[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 351263. OmarEmaraDev added a comment. - Merge branch 'main' into lldb-gui-expand-threads-tree - Implement default selection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev added inline comments. Comment at: lldb/test/API/commands/gui/expand-threads-tree/TestGuiExpandThreadsTree.py:38 +# Exit GUI. +self.child.send(escape_key) +self.expect_prompt() wallace wrote: > create a method self.exit_gui t

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 351547. OmarEmaraDev added a comment. - Handle review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.org/D100243 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb/tes

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds initial support for forms and dialogs for the LLDB

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. An example form: F17429353: 20210616-174753.mp4 class TestFormDelegate : public FormDelegate { public: TestFormDelegate() { m_path_field = AddTextField("Path", 20, Point(4, 2

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. > did you consider implementing each field as a Window? My first implementation was actually done completely with fields as sub windows. However, two things deterred me from taking that approach. - While sub-windows in ncurses are mostly sub-spaces with their own lo

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352761. OmarEmaraDev added a comment. - Remove PutCStringTruncatedWidth, use a character limit instead. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1108 + window.AttributeOn(A_REVERSE); +window.PutChar(m_content ? 'X' : ' '); +if (is_active) clayborg wrote: > We could use ACS_DIAMOND or ACS_BULLET? Check it o

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 352778. OmarEmaraDev added a comment. - Always scroll left on removing a character Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Core/IOHa

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353087. OmarEmaraDev added a comment. - Add form pages. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Core/IOHandlerCurse

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. @clayborg I tried implementing scrolling mechanisms as suggested. My first trial essentially defined a "visible area" rectangle which gets updated with every time the selection changes, then when it comes to drawing, each field checks if it is completely contained

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353783. OmarEmaraDev added a comment. - Remove Field type and use FieldDelegate directly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files: lldb/source/Cor

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Since we are still working on this diff. I will add the other form functionality I have been working on here as well if you don't mind. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1396-1405 + // ___

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 354364. OmarEmaraDev added a comment. - Add Surface type. - Add Pad and SubPad types. - Implement dynamic scrolling. - Implement per-field validation and error messages. - Implement File field. - Implement Directory field. - Implement List field. - Refact

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Not available in this patch yet: - Global error messages. - Contextual scrolling. - Action bar. - Auto completion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 355364. OmarEmaraDev added a comment. This revision is now accepted and ready to land. - Rewrite internal field navigation. - Rewrite form window drawing. Form delegate no longer have drawing routines. - Add global error messages. - Add action bar. Form d

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. - Scrolling was temporarily removed from the patch. It was causing issues with fields that change in size. I will reimplement it as contextual scrolling directly. - Action buttons weren't moved to the window border as d

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 355672. OmarEmaraDev added a comment. This revision is now accepted and ready to land. - Add contextual scrolling support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Full example: F17684763: 20210630-220202.mp4 Example API definition for the above example: class TestFormDelegate : public FormDelegate { public: TestFormDelegate() { m_text_field = AddTextField("Text", "The big br

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a form window to attach a process, either by PID o

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. I initially created two forms for attach by name and attach by PID, because the options were divided between them. Today I tried to reimplement that such that it is a single form with a choices field at the top that determine

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358228. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Use unique pointers for field delegates. - Fix typos in Select methods. - Set the process name to the main executable name by default. - Turn plugin name into a choice

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Currently working on the detach/kill form. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2346 + return; + +if (process->GetShouldDetach()) { clayborg wrote: > We might w

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358268. OmarEmaraDev added a comment. - Add kill/detach form. - Fix forms with no fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D105655 Files: lldb/source/Co

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Updated UI: F17912164: 20210713-170719.png Kill/Detach form. F17912163: 20210713-170734.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1056

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358399. OmarEmaraDev marked 10 inline comments as done. OmarEmaraDev added a comment. - Return raw pointers instead of unique ones. - Add Show Advance Settings option. - Allow detaching and killing at the same time. - Allow detaching while keeping process

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added a comment. Two actions with an option: F17916215: 20210713-214929.png Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1838 + + FieldDelegateUP &GetField(int field_index) { return m_fields[field_index]; } --

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev updated this revision to Diff 358766. OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. - Manually continue if needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D10565

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2425 +return true; + } + clayborg wrote: > Should be easy to verify if it is needed or not. If it is, we will need to > add it back. Looks like it is actually needed. I

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a Create Target form for the LLDB GUI. Additionall

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This doesn't support remote files yet, I am still having trouble testing those. Also, there is also an unrelated clang-format change, not sure if I should revert it or keep it. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a required property to text fields and their deriv

[Lldb-commits] [PATCH] D106459: [LLDB][GUI] Check fields validity in actions

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a virtual method HasError to fields, it can be ove

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I am currently breaking this patch into smaller independent viable patches as suggested. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1309 +FileSpec file_spec(m_content); +FileSystem::Instance().Resolve(file_spec); +return file_

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. Thanks @DavidSpickett! I will look into this and let you know how it goes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 ___ lld

[Lldb-commits] [PATCH] D106467: [LLDB][GUI] Add Process Plugin Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new Process Plugin Field. It is a choices field

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new Platform Plugin Field. It is a choices field

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. > Are you going to land the other smaller diffs first and then update this one > after hey have landed? Yes. There is much dependency between patches, so the smaller ones will have to land first then we will rebase this one on main. Also, notice that the smaller p

[Lldb-commits] [PATCH] D106458: [LLDB][GUI] Add required property to text fields

OmarEmaraDev updated this revision to Diff 360575. OmarEmaraDev added a comment. - Remove default arguments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106458/new/ https://reviews.llvm.org/D106458 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

OmarEmaraDev updated this revision to Diff 360767. OmarEmaraDev added a comment. - Rebase on main and fix conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106483/new/ https://reviews.llvm.org/D106483 Files: lldb/source/Core/IOHandlerCurs

[Lldb-commits] [PATCH] D106459: [LLDB][GUI] Check fields validity in actions

OmarEmaraDev updated this revision to Diff 360778. OmarEmaraDev added a comment. - Merge main and fix conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106459/new/ https://reviews.llvm.org/D106459 Files: lldb/source/Core/IOHandlerCursesGU

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves the paths in the file/directory fields before

[Lldb-commits] [PATCH] D106564: [LLDB][GUI] Add Arch Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds an Arch field that inputs and validates an arch sp

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!"); clayborg wrote: > This is checking for a directory, not a file Not sure what y

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev added a comment. @clayborg Did you check D106564 ? This is the last patch needed to do the rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106553/new/ https://reviews.llvm.org/D106553 _

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362189. OmarEmaraDev added a comment. - Rebase on main. - Add basic remote debugging support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/sourc

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev added a comment. I still can't get remote debugging to work unfortunately, or maybe I don't understand it really. The way I understand it is as follows: - If the remote file is specified, then that means we are creating a target for remote debugging. - If the remote file doesn't ex

[Lldb-commits] [PATCH] D106192: [LLDB][GUI] Add Create Target form

OmarEmaraDev updated this revision to Diff 362450. OmarEmaraDev added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106192/new/ https://reviews.llvm.org/D106192 Files: lldb/source/Core/IOHandlerCursesGUI.cpp

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds an environment variable field. This is usually use

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. Example list of environment fields: F18194751: 20210728-221522.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://review

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev updated this revision to Diff 362755. OmarEmaraDev added a comment. - Generalize the implementation to any Mapping field Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://reviews.llvm.org/D106999 Files: lldb/source/C

[Lldb-commits] [PATCH] D106999: [LLDB][GUI] Add Environment Variable Field

OmarEmaraDev marked an inline comment as done. OmarEmaraDev added a comment. I generalized the implementation as suggested and added a ready to use list version of the field. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106999/new/ https://review

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new method SubSurface to the Surface class. The

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a breakpoints window that lists all breakpoints an

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. I faced a bit of difficulty in this patch, so it is not exactly complete. One issue is that breakpoint descriptions can be very long, I tried to implemented multiline items to workaround this, but that didn't work out and was

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg What do you think? Should we add another tree level with more details or do something else? By the way, it would be nice to have D107182 commited because it is needed by the search form. Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @jasonmolenda `is_pad` is defined by ncurses. According to the man page, it is an extension that is `not supported on Version 7, BSD or System V implementations.`, but that shouldn't be a problem as far as I know. Can you maybe check the ncurses header and see if

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. `is_pad` was added in 2009 in ncurses 5.7 - patch 20090906. So it is sufficiently old to be used, is it not? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107182/new/ https://reviews.llvm.org/D107182

[Lldb-commits] [PATCH] D107182: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @jasonmolenda Okay, I will just reimplement the patch without `is_pad` somehow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107182/new/ https://reviews.llvm.org/D107182 __

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg With you suggestions it currently looks like this. The concern I have is that lines are now 36 characters longer, and some important information are now truncated. The breakpoint and breakpoint locations IDs seems to be just the index of the objects in th

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev updated this revision to Diff 365145. OmarEmaraDev added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llv

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @jingham I see. Thanks! Here is how it looks now: F18450643: 20210809-130123.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 __

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new method SubSurface to the Surface class. The

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This is a reimplementation of D107182 , which was committed and then reverted because the `is_pad` function is not universally supported. The updated patch adds an explicit type member to id

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev updated this revision to Diff 365216. OmarEmaraDev added a comment. - Fix possible crash in SetText Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 Files: lldb/source/Core/IOHandlerCursesGU

[Lldb-commits] [PATCH] D107386: [LLDB][GUI] Add Breakpoints window

OmarEmaraDev added a comment. @clayborg This is unrelated to D107761 , so it should be safe to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107386/new/ https://reviews.llvm.org/D107386 __

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a process launch form. Additionally, a LazyBoolean

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. This is not fully working yet, and I am still debugging it. But I thought I would push it for early feedback regardless. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3237-3240 +} else { + action.Open(STDIN_FILENO, dev_null, true, false); + launch_info.AppendFileAction(action); +} clayborg wrote: > We don't need to do anyt

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added a comment. One thing to note as well is that the target environment seem to include many environment variables like PATH and HOME, I don't think those should be included. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added a comment. @jingham I wasn't arguing that we should remove those environment variables, on the contrary. Greg was suggesting that we populate the environment field with the target environment instead of implicitly adding them to the environment of the launch info. The problem

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev updated this revision to Diff 365825. OmarEmaraDev added a comment. - Address review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 Files: lldb/source/Core/IOHandlerCursesGUI.cpp Index:

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3223 + +const Environment &target_environment = target->GetEnvironment(); +m_enviroment_field->AddEnvironmentVariables(target_environment); clayborg wrote: > Does this

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev added a comment. Adding a boolean for inheriting the environment may not be necessary, we can just add two environment fields, one for inherited and one for user specified. The inherited one will be put in advanced settings with another boolean that show or hide the field. Both wil

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev updated this revision to Diff 365958. OmarEmaraDev added a comment. - Separate environment field into two fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 Files: lldb/include/lldb/Ta

[Lldb-commits] [PATCH] D107761: [LLDB][GUI] Refactor form drawing using subsurfaces

OmarEmaraDev added a comment. @clayborg Perhaps you missed this, it is essential the same as D107182 but without the unsupported function. It would be good to have this committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D107869: [LLDB][GUI] Add Process Launch form

OmarEmaraDev updated this revision to Diff 367171. OmarEmaraDev added a comment. - Address review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107869/new/ https://reviews.llvm.org/D107869 Files: lldb/include/lldb/Target/Target.h lldb/source/C

[Lldb-commits] [PATCH] D108327: [LLDB][GUI] Fix text field incorrect key handling

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The isprint libc function was used to determine if the key code re

[Lldb-commits] [PATCH] D108331: [LLDB][GUI] Handle return key for compound fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch handles the return key for compound fields like lists a

[Lldb-commits] [PATCH] D108385: [LLDB][GUI] Add extra keys to text field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds many new keys to the text field and implements new

[Lldb-commits] [PATCH] D108410: [LLDB][GUI] Add submit form key combination

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new key ALt+Enter key combination to form window

[Lldb-commits] [PATCH] D108414: [LLDB][GUI] Handle extra navigation keys in forms

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch handles the up and down keys if they weren't handled by

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds a new type of reusable UI components. Searcher Win

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. An example searcher window for source files: F18633042: 20210823-141344.mp4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108545/new/ https

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I was planning on getting to field completion later as part of a global "context window" feature. There are reasons why I need this as a full separate window for now. Imminently, I am creating an operator that changes the file in the sources window so tha

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:3592 +m_selected_match(0), m_first_visible_match(0) { +; + } OmarEmaraDev wrote: > clayborg wrote: > > Should we be doing just like any other dialog that we have

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I see a number of issues with using forms directly: - The user will have to bother with form navigation. If we have a text field and a choice field, the user will have to switch between them using Tab and Shift+Tab in order to explore, rectify, and select

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This patch adds a new

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev added a comment. An example typical workflow for navigating to a file and adding a breakpoint. F18748669: 20210830-221617.mp4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108944/new/ https://revie

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev added a comment. @clayborg Did you take a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108944/new/ https://reviews.llvm.org/D108944 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch expands the tree item that corresponds to the selected thread by default in the Threads win

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev updated this revision to Diff 338846. OmarEmaraDev added a comment. - Follow LLVM coding guidelines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new/ https://reviews.llvm.org/D100243 Files: lldb/source/Core/IOHandlerCursesGU

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

OmarEmaraDev marked 2 inline comments as done. OmarEmaraDev added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2211-2213 + if (selected_thread->GetID() == thread->GetID()) { +item[i].Expand(); + } clayborg wro