OmarEmaraDev created this revision.
OmarEmaraDev added a reviewer: clayborg.
Herald added a reviewer: teemperor.
OmarEmaraDev requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch adds a new Platform Plugin Field. It is a choices field that
lists all the available platform plugins and can retrieve the name of the
selected plugin. The default selected plugin is the currently selected
one. This patch also allows for arbitrary scrolling to make scrolling
easier when setting choices.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D106483
Files:
lldb/source/Core/IOHandlerCursesGUI.cpp
Index: lldb/source/Core/IOHandlerCursesGUI.cpp
===================================================================
--- lldb/source/Core/IOHandlerCursesGUI.cpp
+++ lldb/source/Core/IOHandlerCursesGUI.cpp
@@ -1439,6 +1439,8 @@
}
void FieldDelegateDraw(SubPad &surface, bool is_selected) override {
+ UpdateScrolling();
+
surface.TitledBox(m_label.c_str());
Rect content_bounds = surface.GetFrame();
@@ -1458,29 +1460,23 @@
m_choice++;
}
- // If the cursor moved past the first visible choice, scroll up by one
- // choice.
- void ScrollUpIfNeeded() {
- if (m_choice < m_first_visibile_choice)
- m_first_visibile_choice--;
- }
+ void UpdateScrolling() {
+ if (m_choice > GetLastVisibleChoice()) {
+ m_first_visibile_choice = m_choice - (m_number_of_visible_choices - 1);
+ return;
+ }
- // If the cursor moved past the last visible choice, scroll down by one
- // choice.
- void ScrollDownIfNeeded() {
- if (m_choice > GetLastVisibleChoice())
- m_first_visibile_choice++;
+ if (m_choice < m_first_visibile_choice)
+ m_first_visibile_choice = m_choice;
}
HandleCharResult FieldDelegateHandleChar(int key) override {
switch (key) {
case KEY_UP:
SelectPrevious();
- ScrollUpIfNeeded();
return eKeyHandled;
case KEY_DOWN:
SelectNext();
- ScrollDownIfNeeded();
return eKeyHandled;
default:
break;
@@ -1494,6 +1490,15 @@
// Returns the index of the choice.
int GetChoice() { return m_choice; }
+ void SetChoice(const std::string &choice) {
+ for (int i = 0; i < GetNumberOfChoices(); i++) {
+ if (choice == m_choices[i]) {
+ m_choice = i;
+ return;
+ }
+ }
+ }
+
protected:
std::string m_label;
int m_number_of_visible_choices;
@@ -1504,6 +1509,29 @@
int m_first_visibile_choice;
};
+class PlatformPluginFieldDelegate : public ChoicesFieldDelegate {
+public:
+ PlatformPluginFieldDelegate(Debugger &debugger)
+ : ChoicesFieldDelegate("Platform Plugin", 3, GetPossiblePluginNames()) {
+ PlatformSP platform_sp = debugger.GetPlatformList().GetSelectedPlatform();
+ if (platform_sp)
+ SetChoice(platform_sp->GetName().AsCString());
+ }
+
+ std::vector<std::string> GetPossiblePluginNames() {
+ std::vector<std::string> names;
+ size_t i = 0;
+ while (auto name = PluginManager::GetPlatformPluginNameAtIndex(i++))
+ names.push_back(name);
+ return names;
+ }
+
+ std::string GetPluginName() {
+ std::string plugin_name = GetChoiceContent();
+ return plugin_name;
+ }
+};
+
template <class T> class ListFieldDelegate : public FieldDelegate {
public:
ListFieldDelegate(const char *label, T default_field)
@@ -1899,6 +1927,13 @@
return delegate;
}
+ PlatformPluginFieldDelegate *AddPlatformPluginField(Debugger &debugger) {
+ PlatformPluginFieldDelegate *delegate =
+ new PlatformPluginFieldDelegate(debugger);
+ m_fields.push_back(FieldDelegateUP(delegate));
+ return delegate;
+ }
+
template <class T>
ListFieldDelegate<T> *AddListField(const char *label, T default_field) {
ListFieldDelegate<T> *delegate =
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
