[Lldb-commits] [PATCH] D148752: lldb: Fix usage of sve functions on arm64

omjavaid added a comment. In D148752#4283899 , @manojgupta wrote: > I am building on ChromeOS. We only have headers from linux kernel 4.14 > available in our build system (The actual running kernel could be a higher > version). > But given these functi

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This introduced test failures on windows lldb-aarch64-windows buildbot. lldb-api :: functionalities/process_save_core/TestProcessSaveCore.py lldb-api :: python_api/symbol-context/TestSy

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

This revision was automatically updated to reflect the committed changes. Closed by commit rG58e6caaba1cf: Revert "[lldb] Refactor SBFileSpec::GetDirectory" (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D149625?vs=518782&id=522285#toc Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D152519: [lldb][AArch64] Add Scalable Matrix Extension option to QEMU launch script

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152519/new/ https://reviews.llvm.org/D152519 ___

[Lldb-commits] [PATCH] D152516: [lldb][AArch64] Add thread local storage tpidr register

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good to me, just a minor nit above. I have not run the test myself. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid updated this revision to Diff 371380. omjavaid added a comment. This update addresses review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108739/new/ https://reviews.llvm.org/D108739 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp l

[Lldb-commits] [PATCH] D108768: [lldb] DynamicRegisterInfo: fix wrong regnos in Dump()

omjavaid added a comment. This is complicated mainly because we are trying to merge two different register numbering scheme. On LLDB (host) side we try to construct register number from parsing register xml assigning register numbers in the increasing order. But we also have target supplied reg

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8901f8beea3a: AArch64 SVE restore SVE registers after expression (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D108739

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid created this revision. omjavaid added reviewers: labath, mgorny. omjavaid requested review of this revision. This patch allows LLDB to accept register sizes which are not aligned to 8 bits bitsize boundary. This fixes a crash in LLDB when connecting to OpenOCD stub. GDB xml description al

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); @mgorny the assert already exists but then we also want to allow bit s

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); mgorny wrote: > omjavaid wrote: > > @mgorny the assert already exists

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4357 assert(reg_info.byte_size != 0); registers.push_back(reg_info); mgorny wrote: > omjavaid wrote: > > mgorny wrote: > > > omjavaid wrote

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

omjavaid updated this revision to Diff 377470. omjavaid added a comment. This addresses review comments converts printfs to log messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31/new/ https://reviews.llvm.org/D31 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGD

[Lldb-commits] [PATCH] D111131: [LLDB] Round XML register bitsize to byte boundary

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2b9d0fdda5e: Round XML register bitsize to byte boundary (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:203 + +m_register_info_sp = std::make_shared( +*reg_info, m_scripted_process.GetTarget().GetArchitecture()); Hi This fails on arm and aarch64 linux bu

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This look great. Thanks for doing the legit fix. @mgorny This is something you might wanna implement/test on BSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[Lldb-commits] [PATCH] D112471: [LLDB] Fix Cpsr size for WoA64 target

omjavaid created this revision. omjavaid added reviewers: mstorsjo, DavidSpickett. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. CPSR on Arm64 is 4 bytes in size but windows on Arm implementation is trying to read/write 8 bytes against a byte register causi

[Lldb-commits] [PATCH] D113165: [LIT] Add win32 PLATFORM env var to test config

omjavaid created this revision. omjavaid added reviewers: zturner, mstorsjo. Herald added subscribers: pengfei, delcypher, kristof.beyls. omjavaid requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. LIT skips various system environment variable

[Lldb-commits] [PATCH] D113165: [LIT] Add win32 PLATFORM env var to test config

This revision was automatically updated to reflect the committed changes. Closed by commit rGcbd215dfe51d: [LIT] Add win32 PLATFORM env var to test config (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D112471: [LLDB] Fix Cpsr size for WoA64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGb595137fe1c0: [LLDB] Fix Cpsr size for WoA64 target (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11247

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:70 +static llvm::Error make_invalid_range_err(lldb::addr_t addr, + lldb::addr_t end_addr) { I think this fun

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

omjavaid added a comment. Hi @clayborg This breaks LLDB Arm/Linux buildbot. https://lab.llvm.org/buildbot/#/builders/17/builds/14035 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 _

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. MSYS 'uname' on windows returns "MSYS_NT*" instead of windows32 and also MSYS 'pwd' returns non-windows path string. This

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

omjavaid created this revision. Herald added a project: All. omjavaid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch makes build helper script build.py to use platform.uname for machine/architecture detection. Visual studio envi

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

This revision was automatically updated to reflect the committed changes. Closed by commit rG4db78322031f: [LLDB] Make API tests to run using MSYS tools (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133002/new/ https://review

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e6a71e6a3d1: [LLDB] Make build.py use uname to set platform (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133011/new/ https://revie

[Lldb-commits] [PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761 I have reverted the change to make the buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

omjavaid added a comment. This test fails on Arm/AArch64 Linux. I have marked it as an XFAIL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138077/new/ https://reviews.llvm.org/D138077 ___ lldb-commits m

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

omjavaid updated this revision to Diff 347847. omjavaid added a comment. This add skipped linux-aarch64-pac.out file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99944/new/ https://reviews.llvm.org/D99944 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb/source/Plugin

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

omjavaid updated this revision to Diff 347848. omjavaid added a comment. Herald added a project: LLDB. Uploading linux-aarch64-pac.out using arc differential was not uploading binary file properly using arc to do the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. Now that we are stripping away top byte is there any information that may be useful for the remote side and we are removing that on the host side. I am thinking why we should strip top byte on host side rather than making it the responsibility of the remote end? Repo

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. In D102757#2781677 , @DavidSpickett wrote: > In D102757#2781561 , @omjavaid > wrote: > >> Now that we are stripping away top byte is there any information that may be >> useful for the

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid added a comment. @labath @mgorny any comments on this rev? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101361/new/ https://reviews.llvm.org/D101361 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe8f998c0c5ed: AArch64 Linux and elf-core PAC stack unwinder suppor

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Target/Process.cpp:5854 + if (auto abi = GetABI()) { +// TODO: can we always assume data addresses here? +load_addr = abi->FixDataAdd

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. This doesnt build ... you need to include #include "lldb/Target/ABI.h" in lldb/source/Commands/CommandObjectMemory.cpp Comment at: lldb/test/API/linux/aarch64

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid added a comment. @DavidSpickett Do you have any further plans for this and other patches in the series. I was wondering if there is nothing to add we can go ahead and merge this series. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97281/

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. In D97281#2824678 , @DavidSpickett wrote: > @omjavaid As it stands, RemoveNonAddressBits here removes the top byte > unconditionally. > > You aske

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

omjavaid created this revision. omjavaid added a reviewer: JDevlieghere. omjavaid requested review of this revision. This patch fixes a bug in dotest.py where lldb.selected_platform was being set to host platform even after a successful connection to a remote platform via platform url. This patch

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa702358569: [LLDB] dotest.py set selected_platform on remote connection (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLV

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23 +def test_mte_regions(self): +if not self.isAArch64PAut

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. In D102757#2826611 , @DavidSpickett wrote: > Do you think this needs a test with a core file as well? I guess it wont be needed. Included test is fine to check whether we remove non-address bits or not. Rest functionality does

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3477 + + if (raw_type == std::numeric_limits::max() || + // Make sure the cast below would be valid First condition looks redundant give

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

omjavaid added a comment. This rev has caused multiple test failure on LLDB Arm/AArch64 buildbots. https://lab.llvm.org/buildbot/#/builders/17/builds/8504 https://lab.llvm.org/buildbot/#/builders/96/builds/9110 https://lab.llvm.org/buildbot/#/builders/96/builds/9111 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:22 """ Test that qMemTags packets are parsed correctly and/or rejected. """ self.build() Missing isAArch64MTE check here

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid updated this revision to Diff 355735. omjavaid added a comment. This update makes native register context changes restricted to Linux/Arm64. Also tweeks test case a little bit. PS: This test may fail on QEMU. There is QEMU bug that reports wrong watchpoint hit address in case top byte

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) This test is s

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid created this revision. omjavaid added a reviewer: DavidSpickett. Herald added subscribers: danielkiss, kristof.beyls. omjavaid requested review of this revision. This patch adds a helper function to test target architecture is AArch64 or not. This also tightens isAArch64* helpers by addi

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag repeat and unpack to memory tag manager

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good. I just made some cosmetic comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:79 + // + // Set granules to 0 to skip checking the number

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; I was wondering if you can explain reason for hosting this struc

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1517 + + llvm::Expected> repeated_tags_or_err = + details->manager->RepeatTagsForRange(*unpacked_tags_or_err, range); We unpack, repeat and then repack. Can

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

omjavaid added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35 + // alignment/expansion over again. + struct TagManagerWithRange { +const MemoryTagManager *manager; DavidSpickett wrote: > omjavaid wrote: > > I was wondering if yo

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + DavidSpickett wrote: > This can be: > ```

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

omjavaid updated this revision to Diff 357101. omjavaid edited the summary of this revision. omjavaid added a comment. This adds pointer signing before we set watchpoint on the tagged_ptr. LLDB should be able to successfully set a watchpoint on a signed pointer. We can hit the watchpoint on tagg

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

omjavaid added a comment. I think this approach is a lot better given that the process of tagged ranged calculation deserved a separation and may be more explanation too. I guess somewhere in the comments of same function you can explain interaction between memory regions and tagged ranges. It

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e6aabd48e35: Support AArch64/Linux watchpoint on tagged addresses (authored by omjavaid). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

omjavaid created this revision. omjavaid added a reviewer: mib. Herald added a subscriber: kristof.beyls. omjavaid requested review of this revision. This patch fixes ScriptedProcessPythonInterface::GetGenericInteger to avoid compiler warning emitted due to size_t being 32 bit when built on 32 bit

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1296 +"""Returns true if the architecture is AArch64.""" +return self.getArchitecture().lower() in ["aarch64"] + DavidSpickett wrote: > omjavaid wrote: > >

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

omjavaid updated this revision to Diff 357837. omjavaid added a comment. This fixes issue raised in last rev. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105483/new/ https://reviews.llvm.org/D105483 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/functionalit

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. I am trying to run test_qmemtags_packets but the test hangs while waiting for lldb-server to terminate. My test compiler is gcc-linaro-11.0.0-2021.02-x86_64_aarch64-linux-gnu/bin/aarch64-

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rG10f5e08a7124: [LLDB] Testsuite: Add helper to check for AArch64 target (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/mte_tag_faults/main.c:29 + + if (prctl(PR_SET_TAGGED_ADDR_CTRL, prctl_arg2, 0, 0, 0)) +return 1; Can we

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

omjavaid added a comment. Is this final version or you are still doing refactoring. Also can you kindly order its child and parent revs in current tag-write patch series. Comment at: lldb/source/Commands/CommandObjectMemoryTag.cpp:70 Process *process = m_exe_ctx.GetProces

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

omjavaid added a comment. In D105630#2876615 , @DavidSpickett wrote: > All the follow ups are now based on this change. I didn't need to make an > updates to this particular patch after all. This looks good but the test fails on arm 32 bit.

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager

omjavaid added a comment. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105179/new/ https://reviews.llvm.org/D105179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1550 +size_t tags_written = tags_vec.iov_len; +assert(tags_written && (tags_written <= num_tags)); + This assertion suggests something went wrong on ptrac

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) omjavaid wrote

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM after addressing comment above. Comment at: lldb/test/API/linux/aarch64/mte_tag_access/main.c:10 +char *checked_mmap(size_t page_size, int prot) { + char *ptr = m

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) DavidSpickett

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

omjavaid added a comment. In D105788#2897981 , @mib wrote: > Hi @omjavaid , please let me know if you're still seeing the warnings. Thanks. Yes all warnings fixed now. Thanks for taking care of this. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. @DavidSpickett Lets merge this patch series (if it is working on your desk) but we should add information in LLDB wiki or any other appropriate place about how to reliably test mte feature

[Lldb-commits] [PATCH] D105741: [trace] Introduce Hierarchical Trace Representation (HTR) and add `thread trace export ctf` command for Intel PT trace visualization

omjavaid added a comment. In D105741#2910908 , @wallace wrote: > Landed as aad17c55a8116cd3831d4392d909139702019d65 > Temporarily reverted this change as it breaks LLDB build on 32 bi

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

omjavaid added a comment. This change has caused various GUI related tests to fail randomly. https://lab.llvm.org/buildbot/#/builders/96/builds/10100 This also causes random failures of one of the most resource sufficient buildbot here: https://lab.llvm.org/buildbot/#/builders/68/builds/16275 h

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

omjavaid added a comment. I suspect this change as culprit behind failure of various GUI tests randomly on various LLDB buildbots. I have reverted this change to see if its the real culprit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100243/new

[Lldb-commits] [PATCH] D106880: [lldb][AArch64] Mark mismatched tags in tag read output

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. This looks good Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106880/new/ https://reviews.llvm.org/D106880

[Lldb-commits] [PATCH] D100299: Be lazier about loading .dwo files

omjavaid added a comment. Herald added a subscriber: JDevlieghere. This fails on 32 bit Arm https://lab.llvm.org/buildbot/#/builders/17/builds/9595 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100299/new/ https://reviews.llvm.org/D100299 ___

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid created this revision. omjavaid added reviewers: DavidSpickett, rankov. omjavaid added a project: LLDB. Herald added subscribers: ctetreau, JDevlieghere, kristof.beyls, tschuett. omjavaid requested review of this revision. This patch fixes register save/restore on expression call to also

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:451 Status NativeRegisterContextLinux_arm64::ReadAllRegisterValues( lldb::DataBufferSP &data_sp) { DavidSpickett wrote: > Do we need PAC re

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:543 + bool contains_sve_reg_data = + (data_sp->GetByteSize() > (reg_data_min_size + GetSVEHeaderSize())); + omjavaid wrote: > DavidSpickett w

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This breaks LLDB AArch64 Linux buildbot http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/1713 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. I have reverted this change temporarily. Please look at the test failure. I ll also do the same at my end. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. I have tested this not sure why it actually failed on the buildbot. The test seems to pass independently. Lets see if the new version fixes the issue. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

omjavaid added a comment. In D74217#1882539 , @PatriosTheGreat wrote: > Hi Muhammad, > Thank you for review. > Could you or Pavel commit this to master, since I don't have commit access? Hi Patrios, There was some problem with our buildbot and it wen

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf64b31959f6: Add target.xml support for qXfer request. (authored by omjavaid). Changed prior to commit: https://reviews.llvm.org/D74217?vs=245167&id=245686#toc Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

omjavaid added a comment. In D7#1908351 , @aemerson wrote: > @omjavaid can you look over the lldb changes? I don't have the hardware to be > able to actually run this test but I've tried to relax the checks. @aemerson I have moved these test to skip

[Lldb-commits] [PATCH] D75555: [GlobalISel][Localizer] Enable intra-block localization of already-local uses.

omjavaid added a comment. In D7#1909194 , @labath wrote: > Yep, that test really shouldn't be doing that. Historically, lldb has been > avoiding architecture specific artifacts (like assembly) in its tests, but > that didn't really work out here. Tha

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil. Herald added subscribers: danielkiss, kristof.beyls. Herald added a reviewer: rengolin. Native register descriptions in LLDB specify lldb register numbers in value_regs and invalidate_regs lists. These register numbe

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid created this revision. omjavaid added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. AArch64 reigster X and V registers are primary GPR and vector registers respectively. If these registers are modified their corresponding children w regs or s/d regs should be

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid created this revision. omjavaid added reviewers: labath, jankratochvil. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch increases maximum register size to 256 bytes to accommodate AArch64 SVE registers maximum possible size of

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid created this revision. omjavaid added reviewers: labath, clayborg, jankratochvil, jasonmolenda. Herald added subscribers: danielkiss, kristof.beyls, tschuett. Herald added a reviewer: rengolin. This patch adds support for AArch64 SVE register infos description and register access via ptr

[Lldb-commits] [PATCH] D72251: [RFC] Support SVE registers access on AArch64 Linux

omjavaid abandoned this revision. omjavaid added a comment. Herald added a subscriber: danielkiss. Abandoned in favor of following patches and more to come as suggested by labath in separate patches. https://reviews.llvm.org/D77047 https://reviews.llvm.org/D77045 https://reviews.llvm.org/D7704

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid updated this revision to Diff 25. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77043/new/ https://reviews.llvm.org/D77043 Files: lldb/docs/lldb-gdb-remote.txt lldb/include/lldb/Host/common/NativeRegisterContext.h lldb/pac

[Lldb-commits] [PATCH] D77043: Fix process gdb-remote usage of value_regs/invalidate_regs

omjavaid added a comment. In D77043#1954672 , @labath wrote: > I am still thinking this over, but for now I have two comments. First, could > you re-upload the diff with full context (e.g. `git show -U`). That would > make it a lot easier to review t

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid updated this revision to Diff 254454. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77047/new/ https://reviews.llvm.org/D77047 Files: lldb/source/Plugins/Process/Linux/LinuxPTraceDefines_arm64sve.h lldb/source/Plugins/Process/Li

[Lldb-commits] [PATCH] D77047: AArch64 SVE register infos and ptrace support

omjavaid added a comment. In D77047#1954696 , @labath wrote: > > There is no physical hardware currently available to test SVE and we make > > use of QEMU for the purpose of testing this feature. > > Are these registers presented in core files in any way?

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid marked an inline comment as done. omjavaid added a comment. In D77045#1954690 , @labath wrote: > This sounds like it could use a test case. Adding a testcase would be tricky as these register overlap in memory and we store them with overlapping

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid marked 2 inline comments as done. omjavaid added a comment. In D77044#1954685 , @labath wrote: > Sounds fairly noncontroversial. I don't think we have too many of these > objects floating around, but if it turns out we do, we could switch to a >

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

omjavaid updated this revision to Diff 254479. omjavaid added a comment. Posting full diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77044/new/ https://reviews.llvm.org/D77044 Files: lldb/include/lldb/Utility/RegisterValue.h lldb/source/Plugins/Process/gdb-remote/GDBRemoteComm

[Lldb-commits] [PATCH] D77214: [lldb] Add option to retry Fix-Its multiple times to failed expressions

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. This patch fails on lldb-aarch64-linux with following backtrace, apparently failing experession eval. I am marking it xfail for now. Traceback (most recent call last): File "/home/omai

[Lldb-commits] [PATCH] D77045: Add invalidate list to primary regs in arm64 register infos

omjavaid added a comment. In D77045#1963896 , @labath wrote: > In D77045#1956879 , @omjavaid wrote: > > > Adding a testcase would be tricky as these register overlap in memory and > > we store them with overlapping

<    1   2   3   4   5   6   >