omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This looks good to me, just a minor nit above. I have not run the test myself.
================
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:286
src = (uint8_t *)GetMTEControl() + offset;
+ } else if (IsTLS(reg)) {
+ error = ReadTLSTPIDR();
----------------
Do we need to read this register on every stop ? similar to SVE vg? May be
consider moving this else if before SVE which is still optionally available in
most cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152516/new/
https://reviews.llvm.org/D152516
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
