omjavaid added inline comments.
================
Comment at: lldb/include/lldb/Target/MemoryTagManager.h:35
+ // alignment/expansion over again.
+ struct TagManagerWithRange {
+ const MemoryTagManager *manager;
----------------
I was wondering if you can explain reason for hosting this struct. Is there a
association between MemoryTagManager and Tag Range.
I think same tag manager was associated with the whole of process address
space? so why host tag manager pointer along with the range when we already
have a pointer to process. This implies there could be different tag managers
for different ranges? Our initial implementation introduced per architecture
tag manager and for Process AArch64 we can use AArch64 Tag Manager for all our
tag ranges. This appears to have over complicated range expansion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105181/new/
https://reviews.llvm.org/D105181
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
