[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

JDevlieghere created this revision. JDevlieghere added reviewers: wallace, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. The test was expecting `vector> &` while the test returned `vector &`. Since `verify_completions` doesn't support regex matching, side

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

JDevlieghere added a comment. In D158893#4618503 , @wallace wrote: > Awesome!! Thank you for the prompt reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158893/new/ https://reviews.llvm.org/D158893 __

[Lldb-commits] [PATCH] D158893: [lldb] Fix TestVSCode_completions on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7ca1175d0d4: [lldb] Fix & re-enable TestVSCode_completions on Darwin (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5682-5693 + for (uint32_t i = 0; i < m_header.ncmds; ++i) { +const uint32_t cmd_offset = offset; +llvm::MachO::load_command lc = {}; +if (m_data.GetU32(&offset,

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

JDevlieghere added a comment. + @aprantl for impact on the Swift REPL Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158958/new/ https://reviews.llvm.org/D158958 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D159017: [lldb/docs] Silence warnings when generating website

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Overall this LGTM. It's really unfortunate we have to define things like `__hex__` for every class. Is there a way to either (1) silence this warning on (2) have SWIG generate this

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, DavidSpickett, clayborg. Herald added subscribers: jrtc27, sdardis. Herald added a project: All. JDevlieghere requested review of this revision. Add support for syntax highlighting assembly. The current patch uses a d

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere added a comment. Similar to the LLVM patch this depends on, this patch is a WIP to get some early feedback. This definitely needs a test. Most of the patch deals with plumbing the value of `Debugger::GetUseColor` to the `Disassembler`. CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D159234: [llvm-objdump] Enable assembly highlighting in llvm-objdump

JDevlieghere created this revision. JDevlieghere added reviewers: MaskRay, jhenderson. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Enable assembly highlighting in llvm-objdump. https://reviews

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159237/new/ https://reviews.llvm.org/D159237 ___

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 554873. JDevlieghere added a comment. - Fix inconsistencies and use `use_color` everywhere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Core/Disassembler.h lldb/include

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM 🚢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159150/new/ https://reviews.llvm.org/D159150 _

[Lldb-commits] [PATCH] D159234: [llvm-objdump] Enable assembly highlighting in llvm-objdump

JDevlieghere abandoned this revision. JDevlieghere added a comment. Merged with D159224 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159234/new/ https://reviews.llvm.org/D159234 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. In D159164#4632017 , @clayborg wrote: > We shouldn't need to pass in "bool use_color" to the Disassembler creation > functions as the only reason to pass something to the creati

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555268. JDevlieghere added a comment. Address @clayborg's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Core/Disassembler.h lldb/source/Core/Disasse

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555269. JDevlieghere added a comment. Discard whitespace changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Core/Disassembler.h lldb/source/Core/Disassembler.cpp ll

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks great. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 ___ lldb-commits

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555417. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Test `GetMnemonic` and `GetComment`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Cor

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555442. JDevlieghere added a comment. As I was adding another test I realized an issue with the previous approach due to the fact that we cache the result. The solution is to cache both the plain and the marked up result, and have the different accessor

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere added a comment. @clayborg let me know if you're happy with this. To answer your previous question, I'm not planning anymore changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 ___

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 555489. JDevlieghere marked 9 inline comments as done. JDevlieghere added a comment. Use the execution context to enable colors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/l

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Thanks Greg! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGa69f78b080ef: [lldb] Add syntax color highlighting for disassembly (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D159164?vs=555489&id=13

lldb-commits@lists.llvm.org

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM 🚀 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159387/new/ https://reviews.llvm.org/D159387 _

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

JDevlieghere added a comment. Overall this looks good, but instead of consuming all the errors, let's log them with `LLDB_LOG_ERROR`. Note that the API is a bit tricky and still requires you to provide a format string: LLDB_LOG_ERROR(GetLog(LLDBLog::Object), something.takeError(), "context b

[Lldb-commits] [PATCH] D159408: Switch over to using the LLVM archive parser for BSD archives.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159408/new/ https://reviews.llvm.org/D159408 __

[Lldb-commits] [PATCH] D157609: [lldb] Add more ways to find split DWARF files

JDevlieghere added a comment. Looks like this broke the X86 bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/59815/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157609/new/ https://reviews.llvm.org/D157609 _

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I really dislike all the manual memory management that's going on in this file, but I realize that's not the result of this patch, but rather because of the code that was factored

[Lldb-commits] [PATCH] D115017: Fix error reporting for "process load" and add a test for it.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115017/new/ https://reviews.llvm.org/D115017 ___

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We should move this from the wrapper to the header block, similar to what Pavel did for Python: https://reviews.llvm.org/rG9a14adeae00015798843ff5cad987e5fdbdddb34 Repo

[Lldb-commits] [PATCH] D115182: [lldb] Remove some trivial scoped timers

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. These functions seem hot enough that the overhead of the timer outweighs the value it brings. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llvm.org/D114923 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere created this revision. JDevlieghere added reviewers: labath, bulbazord. Herald added subscribers: tstellar, mgorny. JDevlieghere requested review of this revision. Instead of trying to squeeze `GetVersion` into `lldb-private.h`, give it its own header and implementation file in its o

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere added a comment. In D115211#3175581 , @labath wrote: > I am definitely not sad to see lldbBase go away, but I am wondering if we > really need a separate library for this functionality (function). > > The only reason I can think of is that t

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere updated this revision to Diff 392590. JDevlieghere added a comment. Rename Basic -> Version CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115211/new/ https://reviews.llvm.org/D115211 Files: lldb/include/lldb/Version/Version.h lldb/include/lldb/Version/Version.inc.in

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

This revision was automatically updated to reflect the committed changes. Closed by commit rGccf1469a4cdb: [lldb] Make lldbVersion a full fledged library (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D115313: [lldb/Target] Slide source display for artificial locations at function start

JDevlieghere added inline comments. Comment at: lldb/test/API/source-manager/TestSourceManager.py:279 +substrs=['stop reason = breakpoint', '%s:%d' % (src_file,0), + 'Warning: the current PC is an artificial location']) +

[Lldb-commits] [PATCH] D115438: [lldb] Remove unused lldb.cpp

JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115438/new/ https://reviews.llvm.org/D115438 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D115211: [lldb] Make the LLDB version a first class citizen

JDevlieghere added inline comments. Comment at: lldb/source/Version/Version.cpp:18 +#else + return "lldb version " CLANG_VERSION_STRING; +#endif thakis wrote: > thakis wrote: > > does this intentionally use CLANG_VERSION_STRING instead of > > LLDB_VERSION_STRIN

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115652/new/ https://reviews.llvm.org/D115652 ___

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115654/new/ https://reviews.llvm.org/D115654 ___

[Lldb-commits] [PATCH] D115698: [lldb] Check if language is supported before creating a REPL instance

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, teemperor. JDevlieghere requested review of this revision. Currently, we'll try to instantiate a ClangREPL for every known language. The plugin manager already knows what languages are supported, so rely on that to only i

[Lldb-commits] [PATCH] D115736: [lldb] (Semi-automatically) format .swig files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115736/new/ https://reviews.llvm.org/D115736 ___

[Lldb-commits] [PATCH] D115698: [lldb] Check if language is supported before creating a REPL instance

This revision was automatically updated to reflect the committed changes. Closed by commit rG100863ccd8d4: [lldb] Check if language is supported before creating a REPL instance (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

JDevlieghere added a comment. Please reflow your text to fit in the existing 80 col limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115974/new/ https://reviews.llvm.org/D115974 ___ lldb-commits mail

[Lldb-commits] [PATCH] D116012: Fix "settings set -g" so it works again.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116012/new/ https://reviews.llvm.org/D116012 ___

[Lldb-commits] [PATCH] D116028: [lldb] Use GetSupportedArchitectures on darwin platforms

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This was on my todo-list for this week but you beat me to it. Thanks for taking care of this! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D116094: Add support for a version 2 of "main bin spec" Mach-O LC_NOTE in corefiles, handle specifications with a slide value

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. A few small nits but the change itself looks sound to me. LGTM. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:7052 + if (image.load_a

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:584 + + if (!module_sp.get()) { +// Force a an external lookup,

[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Sounds reasonable, with the ifdefs in place I can't think of any reason this would break. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto &subcommand_name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +commands_found.AppendString(std

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, teemperor, labath. JDevlieghere requested review of this revision. Until the introduction of the C++ REPL, there was always a single REPL language. The code relied on this assumption through `repl_languages.GetSingularLan

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere added a comment. No test because this is NFC upstream where there's only one supported REPL language. This is tested downstream in the Swift fork. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116697/new/ https://reviews.llvm.org/D116697 __

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1777 if (auto single_lang = repl_languages.GetSingularLanguage()) { language = *single_lang; aprantl wrote: > As you said in

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG46a28a954e5e: [lldb] Create a property to store the REPL language (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We shouldn't have to manage memory at this granularity. Why isn't `xmlFreeDoc` cleaning this up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116708/new/ https://reviews.llvm.org/D116708 _

[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116682/new/ https://reviews.llvm.org/D116682

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

JDevlieghere accepted this revision. JDevlieghere added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf(

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. Thanks! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116707/new/ https://reviews.llvm.org/D116707 ___ lldb-commit

[Lldb-commits] [PATCH] D116539: [lldb/platform-gdb] Clear cached protocol state upon disconnection

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:84 bool PlatformAndroidRemoteGDBServer::LaunchGDBServer(lldb::pid_t &pi

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

This revision was automatically updated to reflect the committed changes. Closed by commit rG7244e9c2f5f3: [LLDB] libcxx summary formatters for std::string_view (authored by puremourning, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D116912: [lldb] Check for arm64 in TestDisassembleRawData

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116912/new/ https://reviews.llvm.org/D116912 ___

[Lldb-commits] [PATCH] D116901: [lldb] Guard libstdc++ specific 'frame var' test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116901/new/ https://reviews.llvm.org/D116901 ___

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Hey LJC. I'm the person maintaining the LLDB framework build, so please include me in any future patches that change that. I'm also on the majority of the blamelist for t

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

JDevlieghere created this revision. JDevlieghere added reviewers: labath, stella.stamenova, omjavaid. JDevlieghere requested review of this revision. Run `check-lldb` in verbose mode so that the bot shows which tests are unsupported. https://llvm.discourse.group/t/lldb-buildbots-verbosity/5253

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1267506ea54a: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess" (authored by yuanzi, committed by JDevlie

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

JDevlieghere updated this revision to Diff 398837. JDevlieghere marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116972/new/ https://reviews.llvm.org/D116972 Files: zorg/buildbot/builders/LLDBBuilder.py Index: zorg/buildbot/builders/LLDBBuilder.py =

[Lldb-commits] [PATCH] D116982: Fix clang-tidy bugprone-argument-comment that was mixed up

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Good catch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116982/new/ https://reviews.llvm.org/D116982 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D117004: [lldb] Don't print "Command Options Usage:" for an alias with no options

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117004/new/ https://reviews.llvm.org/D117004 ___

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

JDevlieghere updated this revision to Diff 399390. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/new/ https://reviews.llvm.org/D104886 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp lldb/test/API/iohandler/sigint/TestIOHandlerPythonREPLSigint.p

[Lldb-commits] [PATCH] D114722: [LLDB] Fix Python GIL-not-held issues

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h:277-285 + if (_Py_IsFinalizing()) { +// Leak m_py_obj rather than

[Lldb-commits] [PATCH] D117065: [lldb/Plugins] Fix ScriptedInterface object ptr use-after-free

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedThreadPythonInterface.cpp:54 + m_object_instance = static_cast( + new StructuredPythonObject(ret_val)); labath wrote: > labath wrote: > > This doesn't so

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks straightforward. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117068/new/ https://reviews.llvm.org/D117068 ___

[Lldb-commits] [PATCH] D117070: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I was slightly confused by the description, but IIUC this moves the interface into the scripted thread instance. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + If the pointer should be non-null, then should this take a referenc

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

JDevlieghere added a comment. Never thought I'd ask someone to merge two patches, but I think it might make reviewing easier if you merge D117139 into this patch. :-) If I understand the patch correctly, you're getting the underlying `PyObject` out of the `Py

[Lldb-commits] [PATCH] D117165: [lldb] Add long help to `crashlog`

JDevlieghere accepted this revision. JDevlieghere added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117165/new/ https://reviews.llvm.org/D117165 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

JDevlieghere added inline comments. Comment at: lldb/docs/use/python-reference.rst:586 the module is loaded allowing you to add whatever commands you want into the -current debugger. Note that this function will only be run when using the LLDB -command command script import, it

[Lldb-commits] [PATCH] D117237: [lldb] Use __lldb_init_module instead of "if lldb.debugger" idiom

JDevlieghere accepted this revision. JDevlieghere added a comment. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117237/new/ https://reviews.llvm.org/D117237 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

This revision was automatically updated to reflect the committed changes. Closed by commit rG049ae93097c0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D104886?vs=399390&id=399810#toc Reposi

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rZORG38ab06456f73: [lldb] Run the test suite in verbose mode (authored by JDevlieghere). Herald added a reviewer: gkistanova. Repository: rZORG LLVM

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Looks reasonable. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116853/new/ https://reviews.llvm.org/D116853 ___ lldb-co

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:177 lldb::break_id_t break_id; +lldb::break_id_t break_loc_id; data_dict->GetValueForKeyAsInteger("break_id", break_id, This seems unused? Repo

[Lldb-commits] [PATCH] D117340: [lldb] Fix platform selection on Apple Silicon

This revision was automatically updated to reflect the committed changes. Closed by commit rG8faca2ed6ade: [lldb] Fix platform selection on Apple Silicon (authored by JDevlieghere). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117074/new/ https://reviews.llvm.org/D117074 ___

[Lldb-commits] [PATCH] D116853: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON`

This revision was automatically updated to reflect the committed changes. Closed by commit rG62af3eb2599d: [CMake][LLDB] Resolve install conflict when `LLDB_BUILD_FRAMEWORK=ON` (authored by paperchalice, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117374/new/ https://reviews.llvm.org/D117374 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D117550: [lldb] Introduce SBPlatform::SetSDKRoot

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117550/new/ https://reviews.llvm.org/D117550 ___

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. JDevlieghere requested review of this revision. We got a few crash reports that showed LLDB initializing Python on two separate threads. Make `g_initialized` atomic to prevent that from happening. https://reviews.llv

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham. JDevlieghere requested review of this revision. Use libobjc.A.dylib as a sentinel to detect situations where we're reading libraries from memory instead of the shared cache. https://reviews.llvm.org/D117623 Fil

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2377-2378 +stream->Printf( +"warning: libobjc.A.dylib is being read from memory instead of the %s" +"shared cache. This will likel

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere updated this revision to Diff 401034. JDevlieghere added a comment. Unbotch the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117623/new/ https://reviews.llvm.org/D117623 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lld

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere updated this revision to Diff 401036. JDevlieghere added a comment. Update warning message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117623/new/ https://reviews.llvm.org/D117623 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2379 +stream->Printf("warning: libobjc.A.dylib is being read from process " + "memory. This indicates that we could not %s. This

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_

<    3   4   5   6   7   8   9   10   11   12   >