JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at:
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:84
bool PlatformAndroidRemoteGDBServer::LaunchGDBServer(lldb::pid_t &pid,
std::string &connect_url)
{
uint16_t remote_port = 0;
----------------
Should this have `assert(IsConnected());` like
`PlatformRemoteGDBServer::LaunchGDBServer` does?
================
Comment at:
lldb/source/Plugins/Platform/Android/PlatformAndroidRemoteGDBServer.cpp:102
bool PlatformAndroidRemoteGDBServer::KillSpawnedProcess(lldb::pid_t pid) {
DeleteForwardPort(pid);
+ return m_gdb_client_up->KillSpawnedProcess(pid);
----------------
Same here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116539/new/
https://reviews.llvm.org/D116539
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
