JDevlieghere added inline comments.
================ Comment at: lldb/source/Version/Version.cpp:18 +#else + return "lldb version " CLANG_VERSION_STRING; +#endif ---------------- thakis wrote: > thakis wrote: > > does this intentionally use CLANG_VERSION_STRING instead of > > LLDB_VERSION_STRING? > > > > (if not: remove clang/Basic/Version.h include too) > This is still wrong, I think. > > (The include is needed for the clang::getclangRevision() call in > lldb_private::GetVersion() though.) Yes, I think this is a remnant from before we computed `LLDB_VERSION_*` correctly in CMake. I'll put up a patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115211/new/ https://reviews.llvm.org/D115211 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
