[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. SWIG 4 was released in 2019 and has been the de-facto standard for a while now. All bots are at least running SWIG 4. Hans found out that after 66

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere updated this revision to Diff 546093. JDevlieghere added a comment. Remove check for SWIG 3.0.9-3.0.10 in `python.swig`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 Files: lldb/bindings/python/python.swig lldb/cmake/module

[Lldb-commits] [PATCH] D102762: [lldb] Use a time-based timeout instead of a hardcoded instruction count in the IRInterpreter

This revision was automatically updated to reflect the committed changes. Closed by commit rG59237bb52c94: [lldb] Use a time-based timeout in IRInterpreter (authored by JDevlieghere). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, Michael137, teemperor. Herald added a project: All. JDevlieghere requested review of this revision. Check the interrupt flag while interpreting IR expressions and allow the user to interrupt them. https://reviews.llvm.or

[Lldb-commits] [PATCH] D156822: [lldb] Make IR interpretation interruptible

This revision was automatically updated to reflect the committed changes. Closed by commit rG61af957aeaa3: [lldb] Make IR interpretation interruptible (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D156822?vs=546174&id=546600#toc Rep

[Lldb-commits] [PATCH] D156919: [lldb/crashlog] Make register output match lldb ordering in legacy mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156919/new/ https://reviews.llvm.org/D156919 ___

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, DavidSpickett, jingham, bulbazord, Michael137, clayborg, mib, labath, wallace, compnerd, aprantl, zequanwu, emaste, omjavaid. Herald added a subscriber: yaxunl. Herald added a project: All. JDevlieghere requested revi

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere added a comment. Added the bot owners as reviewers for visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 546694. JDevlieghere added a comment. Add Discourse and Discord usernames. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.txt lldb/CodeOwners.rst Index: lldb/CodeOwners.r

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + DavidSpicke

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 546897. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. - Update wording - Remove double newline CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added inline comments. Comment at: lldb/CodeOwners.rst:7-8 +particular part of LLDB are reviewed, either by themself or by someone else. +They are also the gatekeepers for their part of LLDB, with the final word on +what goes in or not. + DavidSpicke

[Lldb-commits] [PATCH] D156997: [LLDB][CMake][NFC] Remove unused LLDB_LINKER_SUPPORTS_GROUPS variable

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156997/new/ https://reviews.llvm.org/D156997 __

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 547099. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Link to developer policy. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.txt lldb/Code

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere updated this revision to Diff 547274. JDevlieghere marked 7 inline comments as done. JDevlieghere added a comment. - Add Pavel's nominations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https://reviews.llvm.org/D156949 Files: lldb/CODE_OWNERS.txt lldb/Code

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere added a comment. Despite their prevalence in LLDB, I still consider `recursive_mutex` as a potential code smell. So +1 on avoiding the need for a recursive mutex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157041/new/ https://revie

[Lldb-commits] [PATCH] D157044: [lldb/crashlog] Fix sticky image parsing logic

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. The `images` list was added in D146765 . Do you remember why we needed it there and why we don't anymore? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157043/new/ https://reviews.llvm.org/D157043 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. If it's straightforward, I think would be nice to have a unit test with two threads modifying the same `OptionValue`. That way a TSan run would catch this issue. If that's mo

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

JDevlieghere added a comment. I didn't expect this to be controversial and I hear no objection so I'm going to go ahead and land this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156804/new/ https://reviews.llvm.org/D156804 ___ lldb-commit

[Lldb-commits] [PATCH] D156804: [lldb] Bump SWIG minimum version to 4

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe0053bc04e6b: [lldb] Bump SWIG minimum version to 4 (authored by JDevlieghere). Herald added a project: LLDB. Changed pri

[Lldb-commits] [PATCH] D157041: [lldb] Protect OptionValue accesses from data races

JDevlieghere added a comment. In D157041#4562033 , @aprantl wrote: >> If it's straightforward, I think would be nice to have a unit test with two >> threads modifying the same OptionValue. That way a TSan run would catch this >> issue. If that's more wo

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, augusto2112. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. Set the `halt_on_error` runtime flag to make TSan errors fatal when running the test suite

[Lldb-commits] [PATCH] D157153: [lldb] Fix ThreadList::Update not locking the rhs's mutex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157153/new/ https://reviews.llvm.org/D157153 ___

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, augusto2112. Herald added a project: All. JDevlieghere requested review of this revision. The Communication class was trying to (ab)use `unique_ptr's` atomic properties to protected it from concurrent access. Replace it wi

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/source/Core/Communication.cpp:43 + std::unique_lock guard(m_shared_mutex); LLDB_LOG(GetLog(LLDBLog::Communication), augusto2112 wrote: > Do you think it's possible that between the call to `Clear` and thi

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5454-5456 +if (log) + log->Printf("LC_NOTE 'k

[Lldb-commits] [PATCH] D157165: [lldb] [darwin kernel debug] When looking for a Darwin kernel symbol file, call GetSharedModules before DownloadObjectAndSymbolFile

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157165/new/ https://reviews.llvm.org/D157165 ___

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:267 /// + /// \param[in] allow_use_memory_image_last_resort + /// If no better binary image can be found, allow reading the binary Nit: seems like either `allow_memo

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere updated this revision to Diff 547639. JDevlieghere added a comment. - Remove `Communication::Clear` method CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157159/new/ https://reviews.llvm.org/D157159 Files: lldb/include/lldb/Core/Communication.h lldb/include/lldb/Core/Th

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/source/Core/ThreadedCommunication.cpp:63-67 -void ThreadedCommunication::Clear() { - SetReadThreadBytesReceivedCallback(nullptr, nullptr); - StopReadThread(nullptr); - Communication::Clear(); -} This wasn't

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

JDevlieghere updated this revision to Diff 547641. JDevlieghere added a comment. Include the unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157152/new/ https://reviews.llvm.org/D157152 Files: lldb/test/API/lit.cfg.py lldb/test/Shell/lit.cfg.py lldb/test/Unit/lit.cfg.py

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

This revision was automatically updated to reflect the committed changes. Closed by commit rG17226c976e04: [lldb] Make TSan errors fatal when running the test suite (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D157168: [lldb] [mach-o corefiles] If we have LC_NOTE metadata and can't find a binary, don't fall back to an exhaustive scan

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Process/mach-core/ProcessMachCore.h:89 void CreateMemoryRegions(); - void LoadBinariesViaMetadata(); + bool LoadBinariesViaMetadata(); void LoadBinariesViaExhaustiveSearch(); bulbazord wr

[Lldb-commits] [PATCH] D157167: [lldb] Add flag to DynamicLoader::LoadBinaryWithUUIDAndAddress to control whether we fall back to reading the binary out of memory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157167/new/ https://reviews.llvm.org/D157167 ___

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, augusto2112. Herald added a subscriber: kristof.beyls. Herald added a project: All. JDevlieghere requested review of this revision. TSan reports the following data race: Write of size 4 at 0x000109e0b160 by thread T2 (

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

JDevlieghere added inline comments. Comment at: lldb/source/Core/DynamicLoader.cpp:241-243 +Stream &s = target.GetDebugger().GetOutputStream(); +s.Printf("Tried DBGShellCommands cmd, got error: %s\n", + error.AsCString()); Shouldn'

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in ConnectionFileDescriptor

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bdbe7bd7f15: [lldb] Fix data race in ConnectionFileDescriptor (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548056. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files: lldb/include/lldb/Host/File.h lldb/source/Host/common/File.cpp Index: lldb/source/Host/common/File.cpp ===

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere abandoned this revision. JDevlieghere added a comment. Abandoning this in favor of D157347 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157159/new/ https://reviews.llvm.org/D157159 ___ lldb-com

[Lldb-commits] [PATCH] D157361: [lldb] FIx data race in ThreadedCommunication

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, augusto2112. Herald added a project: All. JDevlieghere requested review of this revision. TSan reports the following race: Write of size 8 at 0x000107707ee8 by main thread: #0 lldb_private::ThreadedCommunication::S

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

JDevlieghere added a comment. Alright, seems like we have consensus. The only person that hasn't chimed in yet is Greg, but based on a comment in another thread he might be OOO. We can alway address concerns post-commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156949/new/ https:

[Lldb-commits] [PATCH] D156949: [lldb] Update LLDB Code Ownership

This revision was automatically updated to reflect the committed changes. Closed by commit rG013a8fc26ef8: [lldb] Update LLDB Code Ownership (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15694

[Lldb-commits] [PATCH] D157160: Surface error messages from the DebugSymbols DBGShellCommands external agent; add logging for LC_NOTEs in Mach-O corefiles

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/DynamicLoader.cpp:241-242 + error.AsCString("")[0] != '\0') { +Stream &s = target.GetDebugger().GetError

[Lldb-commits] [PATCH] D157450: [lldb][NFCI] Remove unused IOStreamMacros

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Cool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157450/new/ https://reviews.llvm.org/D157450 ___

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548729. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address @bulbazord's code review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files: lldb/include/lld

[Lldb-commits] [PATCH] D157538: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157538/new/ https://reviews.llvm.org/D157538 ___

[Lldb-commits] [PATCH] D157455: [lldb][NFCI] Remove MappedHash.h

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157455/new/ https://reviews.llvm.org/D157455 ___

[Lldb-commits] [PATCH] D157361: [lldb] FIx data race in ThreadedCommunication

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a8d9a7657bb: [lldb] Fix data race in ThreadedCommunication (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere updated this revision to Diff 548849. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Limit scope of `ValueGuard` by avoiding `else if`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 Files: lldb/in

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

JDevlieghere added inline comments. Comment at: lldb/source/Host/common/File.cpp:609 num_bytes = bytes_written; - } else if (StreamIsValid()) { + } else if (ValueGuard stream_guard = StreamIsValid()) { bytes_written = ::fwrite(buf, 1, num_bytes, m_stream); -

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/Event.h:228 void Clear() { m_data_sp.reset(); } + + /// This is used by Broadcasters with Primary Listeners to store the other Nit: trailing whitespace Comment at:

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c135f1478cd: [lldb] Fix data race in NativeFile (authored by JDevlieghere). Changed prior to commit: https://reviews.llvm.org/D157347?vs=548849&id=549116#toc Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, aprantl. Herald added a project: All. JDevlieghere requested review of this revision. On the Swift forums [1][2], people are disabling SIP in order to debug process that are missing the get-task-allow entitlement. Imp

[Lldb-commits] [PATCH] D157636: [lldb][test] Remove tests relying on deprecated std::char_traits specializations

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. If this was important we could put this behind a define, break up the test and conditionally skip it based on the libc++ version. But I personally don't think that's worth it for t

[Lldb-commits] [PATCH] D157648: [lldb] Fix data race in Process

JDevlieghere added a comment. Is the reported race specifically about the shared pointer being accessed concurrently or operations on the `IOHandler`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157648/new/ https://reviews.llvm.org/D157648

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

JDevlieghere added a comment. In D157640#4578198 , @jingham wrote: > In this function we have the path to the binary. We could spawn `codesign -d > -entitlements -` and then we would know whether it had that entitlement. > > Maybe that's more work than

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. Shouldn't we have two murexes, one for the read FD and one for the write FD? The current approach is overly strict: it preventing concurrent reads and writes because `Rea

[Lldb-commits] [PATCH] D157640: [lldb] Improve error message when trying to debug a non-debuggable process

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe237b76da7e: [lldb] Improve error message when trying to debug a non-debuggable process (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D1576

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

JDevlieghere added a comment. In D157654#4581578 , @augusto2112 wrote: > @JDevlieghere I updated this to two shared mutexes because I'm assuming you > can have more than one concurrent read and more than one concurrent write. If > this is wrong I can g

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157654/new/ https://reviews.llvm.org/D157654 __

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

JDevlieghere accepted this revision. JDevlieghere added a comment. The motivation behind this change was that the IRInterpreter wasn't interruptible, which means that if you interpret an infinite loop, you'd be stuck forever. I fixed that in 61af957aeaa3

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157137/new/ https://reviews.llvm.org/D157137 __

[Lldb-commits] [PATCH] D157043: [lldb/crashlog] Make TextCrashLogParser more resilient to new lines

JDevlieghere reopened this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157043/new/ https://reviews.llvm.org/D157043 __

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.h:125-126 - lldb::addr_t GetAddressMask() override; + bool GetAddressMask(lldb::addr_t &lowmem_mask, + lldb::addr_t &highmem_mask) override; --

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:172-174 std::mutex m_write_mutex; ///< Don't let multiple threads write at the same time... + mutable std::shared_mutex m_connection_mutex; Why do we need both? Can'

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

JDevlieghere accepted this revision. JDevlieghere added a comment. In D157759#4581673 , @mib wrote: > LGTM! Although we should make sure no one is still using Python 2 downstream Python 2 has been deprecated for a while and we've removed other stuff that

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: bulbazord, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. These functions have been NO-OPs since 2014 (44d937820b451). Remove them and deprecate the corresponding functions in SBDebugger. ht

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23312cde45b9: [lldb] Remove {Get,Set}CloseInputOnEOF and deprecate SB equivalent (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D158000

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1538-1545 +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this);

[Lldb-commits] [PATCH] D157850: [lldb/crashlog] Fix module loading for crashed thread behaviour

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157850/new/ https://reviews.llvm.org/D157850 ___

[Lldb-commits] [PATCH] D157852: [lldb/crashlog] Skip non-crashed threads in batch mode

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157852/new/ https://reviews.llvm.org/D157852 ___

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision. Print an error message with instructions on how to install sphinx_automodapi. https://reviews.llvm.org/D158022 Files: lldb/docs/conf.py Index

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Feedback I hear regularly is that the LLDB website is hard to navigate. This patch is an attempt to simplify t

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3379-3385 + const char *signal_name = process_sp->GetUnixSignals()->

[Lldb-commits] [PATCH] D158034: [lldb] Fix data race in ThreadList

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158034/new/ https://reviews.llvm.org/D158034 ___

[Lldb-commits] [PATCH] D158035: [lldb] Protect RNBRemote from a data race

JDevlieghere added inline comments. Comment at: lldb/tools/debugserver/source/RNBRemote.cpp:780 PThreadMutex::Locker locker(m_mutex); if (m_rx_packets.empty()) { This is an RAII object, right? Can we just block scope it? Right now it looks like we might

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

JDevlieghere added a comment. In D158022#4590291 , @mib wrote: > We should really add a `requirements.txt` file with all the dependencies. I've long wanted to make this all automated, and have CMake install all the necessary dependencies. But that seems

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158085/new/ https://reviews.llvm.org/D158085 ___

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

This revision was automatically updated to reflect the committed changes. Closed by commit rG5afa519c1ae9: [lldb] Print better error message when sphinx_automodapi is not installed (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

JDevlieghere updated this revision to Diff 550791. JDevlieghere added a comment. - Rename "Extending LLDB" to "Scripting LLDB". - Move "DWARF Extensions" to the developer section. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158023/new/ https://reviews.llvm.org/D158023 Files: lldb/d

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with Alex' comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157851/new/ https://reviews.llvm.org/D157851 ___

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:58-60 +bool AddressableBits::IsValid() { + return m_low_memory_addr_bits != 0 || m_high_memory_addr_bits != 0; +} Please implement `operator bool()` instead. =

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added inline comments. Comment at: lldb/source/Utility/AddressableBits.cpp:62-64 +void AddressableBits::Clear() { + m_low_memory_addr_bits = m_high_memory_addr_bits = 0; +} jasonmolenda wrote: > jasonmolenda wrote: > > JDevlieghere wrote: > > > Wher

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere added a comment. In D158041#4593205 , @jasonmolenda wrote: > Update patch to change the `AddressableBits::IsValid` to > `AddressableBits::HasValue` which is a clearer description. The `IsValid` > methods are used across the lldb_private c

[Lldb-commits] [PATCH] D158041: [lldb] [gdb-remote] Also handle high/low memory addressable bits setting in the stop info packet

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, this LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158041/new/ https://reviews.llvm.org/D158041 _

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e3880e370c8: [lldb] Simplify the LLDB website structure (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D158023?vs=550791&id=551578#toc Repo

[Lldb-commits] [PATCH] D158467: [lldb] Link back to the LLVM Project and Developer Policy from the docs

JDevlieghere created this revision. JDevlieghere added reviewers: LLDB, tonic. Herald added a subscriber: arphaman. Herald added a project: All. JDevlieghere requested review of this revision. Add backlinks to the LLVM Project and the LLVM Developer Policy from the docs. As suggested by Tanya in

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158457/new/ https://reviews.llvm.org/D158457 ___

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Given support for other languages like Rust and D, I think this is reasonable. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

JDevlieghere added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start aprantl wrote: > Feel fr

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

JDevlieghere added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start aprantl wrote: > fdeazev

[Lldb-commits] [PATCH] D158467: [lldb] Link back to the LLVM Project and Developer Policy from the docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG34f84697c37e: [lldb] Link back to the LLVM Project and Developer Policy from the docs (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D157764: [LLDB] Allow expression evaluators to set arbitrary timeouts

JDevlieghere added a comment. In D157764#4608265 , @wallace wrote: > @jasonmolenda , yep. I have already reverted this patch. I'll figure out how > to make that work nicely with these changes. My recommendation would be to change the timeout in the test

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

JDevlieghere added inline comments. Comment at: lldb/docs/conf.py:52-57 try: import sphinx_automodapi.automodapi except ModuleNotFoundError: print( f"install sphinx_automodapi with {sys.executable} -m pip install sphinx_automodapi"

[Lldb-commits] [PATCH] D158323: [lldb/infrastructure] Revamp lldb.llvm.org

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. This patch changes the theme and removes the inline table-of-contents that are always shown on the right. If there are any other changes needed to better support t

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return

JDevlieghere created this revision. JDevlieghere added a reviewer: wallace. Herald added a project: All. JDevlieghere requested review of this revision. Use a switch to avoid else-after-return. https://reviews.llvm.org/D158788 Files: lldb/tools/lldb-vscode/ProgressEvent.cpp Index: lldb/tool

[Lldb-commits] [PATCH] D158788: [lldb-vscode] Use a switch to avoid else-after-return (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG719506769a89: [lldb-vscode] Use a switch to avoid else-after-return (NFC) (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

JDevlieghere created this revision. JDevlieghere added reviewers: clayborg, wallace. Herald added a project: All. JDevlieghere requested review of this revision. Update package.json: - Update license, display name, repository and keywords - Add homepage, issue page - Fix formatting and typos ht

[Lldb-commits] [PATCH] D158801: [lldb-vscode] Update package.json

This revision was automatically updated to reflect the committed changes. Closed by commit rG7bd632895816: [lldb-vscode] Update package.json (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D158801?vs=553320&id=553363#toc Repository:

<    2   3   4   5   6   7   8   9   10   11   >