JDevlieghere created this revision. JDevlieghere added a reviewer: LLDB. Herald added a project: All. JDevlieghere requested review of this revision.
SWIG 4 was released in 2019 and has been the de-facto standard for a while now. All bots are at least running SWIG 4. Hans found out that after 662548c <https://reviews.llvm.org/rG662548c82683bd8657a3179afee693c4965a3dfd> LLDB no longer work with SWIG 3 [1]. I'm not sure if the issue is specific to Windows or a particular SWIG 3 version, but I think it's a good time to bump the minimum requirements to SWIG 4. [1] https://github.com/llvm/llvm-project/issues/64279#issuecomment-1660334441 https://reviews.llvm.org/D156804 Files: lldb/cmake/modules/LLDBConfig.cmake lldb/docs/resources/build.rst Index: lldb/docs/resources/build.rst =================================================================== --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -34,7 +34,7 @@ scripting support. * `Python <http://www.python.org/>`_ -* `SWIG <http://swig.org/>`_ 3 or later. +* `SWIG <http://swig.org/>`_ 4 or later. Optional Dependencies ********************* Index: lldb/cmake/modules/LLDBConfig.cmake =================================================================== --- lldb/cmake/modules/LLDBConfig.cmake +++ lldb/cmake/modules/LLDBConfig.cmake @@ -56,7 +56,7 @@ message(STATUS "${description}: ${${variable}}") endmacro() -add_optional_dependency(LLDB_ENABLE_SWIG "Enable SWIG to generate LLDB bindings" SWIG SWIG_FOUND VERSION 3) +add_optional_dependency(LLDB_ENABLE_SWIG "Enable SWIG to generate LLDB bindings" SWIG SWIG_FOUND VERSION 4) add_optional_dependency(LLDB_ENABLE_LIBEDIT "Enable editline support in LLDB" LibEdit LibEdit_FOUND) add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB" CursesAndPanel CURSESANDPANEL_FOUND) add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in LLDB" LibLZMA LIBLZMA_FOUND)
Index: lldb/docs/resources/build.rst =================================================================== --- lldb/docs/resources/build.rst +++ lldb/docs/resources/build.rst @@ -34,7 +34,7 @@ scripting support. * `Python <http://www.python.org/>`_ -* `SWIG <http://swig.org/>`_ 3 or later. +* `SWIG <http://swig.org/>`_ 4 or later. Optional Dependencies ********************* Index: lldb/cmake/modules/LLDBConfig.cmake =================================================================== --- lldb/cmake/modules/LLDBConfig.cmake +++ lldb/cmake/modules/LLDBConfig.cmake @@ -56,7 +56,7 @@ message(STATUS "${description}: ${${variable}}") endmacro() -add_optional_dependency(LLDB_ENABLE_SWIG "Enable SWIG to generate LLDB bindings" SWIG SWIG_FOUND VERSION 3) +add_optional_dependency(LLDB_ENABLE_SWIG "Enable SWIG to generate LLDB bindings" SWIG SWIG_FOUND VERSION 4) add_optional_dependency(LLDB_ENABLE_LIBEDIT "Enable editline support in LLDB" LibEdit LibEdit_FOUND) add_optional_dependency(LLDB_ENABLE_CURSES "Enable curses support in LLDB" CursesAndPanel CURSESANDPANEL_FOUND) add_optional_dependency(LLDB_ENABLE_LZMA "Enable LZMA compression support in LLDB" LibLZMA LIBLZMA_FOUND)
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
