JDevlieghere added inline comments.
================
Comment at: lldb/source/Core/ThreadedCommunication.cpp:63-67
-void ThreadedCommunication::Clear() {
- SetReadThreadBytesReceivedCallback(nullptr, nullptr);
- StopReadThread(nullptr);
- Communication::Clear();
-}
----------------
This wasn't used: nobody called `Clear` on an instance of
`ThreadedCommunication`.
================
Comment at: lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp:560
StopAsyncThread();
- m_comm.Clear();
----------------
According to the comment on line 541 this is wrong:
``` // We are running and we can't interrupt a running kernel, so we need to
// just close the connection to the kernel and hope for the best```
`m_comm` is an instance of `CommunicationKDP` which didn't override
`Communication::Clear` and hence just called `Disconnected`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157159/new/
https://reviews.llvm.org/D157159
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
