JDevlieghere created this revision.
JDevlieghere added a reviewer: labath.
Herald added a subscriber: mgorny.
JDevlieghere edited the summary of this revision.
This is an attempt to realize Pavel's suggestion from
https://reviews.llvm.org/D48393
In https://reviews.llvm.org/D48393#1139327, @labat
JDevlieghere added a comment.
In https://reviews.llvm.org/D48393#1139327, @labath wrote:
> It's even more complicated than that, in case you really have reference
> cycles, you can have multiple threads starting parsing from different points
> in that cycle, and getting deadlocked waiting for t
JDevlieghere added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:430
const size_t num_ranges =
-die->GetAttributeAddressRanges(dwarf, this, ranges, false);
+die->GetAttributeAddressRanges(dwarf, this, ranges, true);
if (num_r
JDevlieghere added a comment.
Thanks for the information, Greg!
In https://reviews.llvm.org/D48393#1243588, @clayborg wrote:
> A little background might help here: The lldb_private::Module lock is used to
> prevent multiple queries into the DWARF from stomping on each other.
>
> Multi-threaded
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath, friss.
JDevlieghere added a project: LLDB.
Herald added a subscriber: aprantl.
This patch adds locking to all the virtual entry-points in DWARFSymbolFile to
prevent corruption of its data structures as a result of
JDevlieghere added a comment.
In https://reviews.llvm.org/D52543#1246877, @clayborg wrote:
> It is the SymbolVendor's job to do the locking. And in many cases it already
> is. I stopped with inlined comments after a few comments as it would apply to
> this entire patch.
Thanks Greg. Honestly
JDevlieghere added a comment.
My first observations:
- We call `ResolveTypeUID` without going through the symbol vendor (similar to
`GetDeclContextForUID` in the stack trace). This is easy to fix, just add
locking to these functions.
- The module in the symbol vendor is different from the one i
JDevlieghere updated this revision to Diff 167248.
JDevlieghere added a comment.
- Add assertions per Greg's suggestion.
https://reviews.llvm.org/D52543
Files:
include/lldb/Symbol/SymbolFile.h
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
source/Symbol/SymbolFile.cpp
Index: source/
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, jingham, teemperor.
JDevlieghere added a project: LLDB.
For the reproducer feature I need to be able to export and import the current
LLDB configuration. To realize this I've extended the existing functionality to
print
JDevlieghere updated this revision to Diff 167722.
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
- Rebase
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
lit/Settings/TestExport.test
source/Commands/CommandObjectSettings.cpp
JDevlieghere updated this revision to Diff 167889.
JDevlieghere added a comment.
Thanks a lot for the feedback! I clearly overlooked some stuff when inspiring
myself on the other CommandObject code.
I've updated the diff:
- Rename functionality to read and write for consistency with breakpoints
JDevlieghere created this revision.
JDevlieghere added a reviewer: LLDB.
I want to make providing no value to `setting set ` equivalent to
clearing that setting: `settings clear `. The motivation is
https://reviews.llvm.org/D52651 that allows settings to be written to and read
from a file. Not
JDevlieghere updated this revision to Diff 167892.
JDevlieghere marked 2 inline comments as done.
JDevlieghere added a comment.
Split off `settings set` change into separate review:
https://reviews.llvm.org/D52772
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
JDevlieghere added a comment.
In https://reviews.llvm.org/D52772#1252656, @jingham wrote:
> Would it be possible for the exporter to notice empty settings and write
> "settings clear" instead?
I don't think we can if we want to re-use the existing dump infrastructure,
unless there's a way to
JDevlieghere added a comment.
Thanks for working on this Stefan, I'm really excited about this feature!
Regarding the code, I don't have comments that weren't already brought up by
the other reviewers.
https://reviews.llvm.org/D52788
___
lldb-comm
JDevlieghere added a comment.
The code and test look correct, so this LGTM but I'll leave it open for now in
case someone else wants to have a look too.
https://reviews.llvm.org/D53193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
JDevlieghere updated this revision to Diff 170242.
JDevlieghere retitled this revision from "[DWARFSymbolFile] Adds the module
lock to all virtual methods from SymbolFile" to "[DWARFSymbolFile] Add the
module lock where necessary and assert that we own it.".
JDevlieghere edited the summary of thi
JDevlieghere updated this revision to Diff 170252.
JDevlieghere added a comment.
Only clear setting when the force flag is set (as suggested offline by
@jingham).
https://reviews.llvm.org/D52651
Files:
lit/Settings/TestSettingsSet.test
source/Commands/CommandObjectSettings.cpp
Index: sou
JDevlieghere updated this revision to Diff 170257.
JDevlieghere added a comment.
Only clear setting when the force flag is set (as suggested offline by
@jingham).
https://reviews.llvm.org/D52772
Files:
lit/Settings/TestSettingsSet.test
source/Commands/CommandObjectSettings.cpp
Index: sou
JDevlieghere updated this revision to Diff 170258.
JDevlieghere added a comment.
- Back to the right diff.
- Use `-f` as per the other patch.
https://reviews.llvm.org/D52651
Files:
include/lldb/Interpreter/OptionValue.h
lit/Settings/TestExport.test
source/Commands/CommandObjectSettings.cp
JDevlieghere updated this revision to Diff 170465.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
Address Greg's feedback.
https://reviews.llvm.org/D52543
Files:
include/lldb/Symbol/SymbolFile.h
source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
source/Plugi
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB344945: [SymbolFile] Add the module lock where necessary
and assert that we own it. (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52543?vs=170465&id=17
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, clayborg.
JDevlieghere added a project: LLDB.
This patch adds support for virtual file systems by delegating relevant
operations. By default the real file system is used so this should be NFC for
all intents and p
JDevlieghere added a comment.
ping
https://reviews.llvm.org/D52772
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345207: [Settings] Add -force flag to "settings
set" (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52772?vs=17025
JDevlieghere added a comment.
@teemperor Can you have another look?
https://reviews.llvm.org/D52651
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere added a comment.
Thanks Raphael!
With r345207 the empty behavior only works if you explicitly specify `-force`.
I'll address the second issue before landing this.
https://reviews.llvm.org/D52651
___
lldb-commits mailing list
lldb-comm
JDevlieghere added a comment.
Note that there's also a File class which we'll need to patch up separately
together with all other uses that actually open or read a file. For this class
we can do the same as we did for FileSpec: deferring relevant operations to the
FileSystem class.
https://re
JDevlieghere added a comment.
While I don't disagree with the proposed approach, it needs to be highlighted
that extracting all file system operations would be very intrusive.
- Almost all logic in FileSpec deals with the filesystem. You can't even
resolve a path without it. How do you imagine
JDevlieghere added a comment.
Thanks for the feedback! I totally agree it's a good solution and it was one of
the things I considered. It didn't make it to the top of the list because it is
very intrusive and changes the semantics of FileSpec quite a bit (i.e. it
becomes a PathSpec as Zachary n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345346: Add functionality to export settings (authored by
JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52651?vs=170258&id=171
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345346: Add functionality to export settings (authored by
JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52651?vs=170258&id=171231#toc
Repository:
rLLDB LLDB
htt
JDevlieghere updated this revision to Diff 171376.
JDevlieghere retitled this revision from "[FileSpec] Add VFS support to
FileSpec convenience methods." to "[FileSystem] Extend file system and have it
use the VFS.".
JDevlieghere edited the summary of this revision.
JDevlieghere added a comment.
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, jingham, clayborg.
JDevlieghere added a project: LLDB.
This patch moves the EnumerateDirectory functionality and related enums and
typedefs from FileSpec to FileSystem. The long term goal is to remove this
method
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
This patch removes the `GetByteSize` method from FileSpec and updates its uses
with ca
JDevlieghere added a comment.
In https://reviews.llvm.org/D53788#1278036, @zturner wrote:
> I always wondered if we actually even need methods like this in `FileSystem`
> given that they already exist in `llvm::sys::fs`. Is it possible to just
> call the llvm methods directly, or is it still h
JDevlieghere updated this revision to Diff 171529.
JDevlieghere added a comment.
Address Pavel's feedback:
- Change to `Initialize` method which can only be called once.
- Fix accidental change in comment.
https://reviews.llvm.org/D53532
Files:
include/lldb/Host/FileSystem.h
include/lldb/U
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, davide.
JDevlieghere added a project: LLDB.
Herald added subscribers: abidh, emaste.
This patch removes the `GetPermissions` and `GetReadable` methods from FileSpec
and updates its uses with calls to the FileSystem
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, davide.
JDevlieghere added a project: LLDB.
Herald added a subscriber: emaste.
This patch removes the `ResolveExecutableLocation` method from FileSpec and
updates its uses with calls to the FileSystem.
Repository
JDevlieghere created this revision.
JDevlieghere added reviewers: zturner, labath, davide.
JDevlieghere added a project: LLDB.
Herald added a subscriber: emaste.
This patch removes the `Exists` method from FileSpec and updates its uses with
calls to the FileSystem.
Repository:
rLLDB LLDB
htt
JDevlieghere added a comment.
In https://reviews.llvm.org/D53532#1280018, @labath wrote:
> In https://reviews.llvm.org/D53532#1279022, @JDevlieghere wrote:
>
> > Address Pavel's feedback:
> >
> > - Change to `Initialize` method which can only be called once.
>
>
> I suppose this is slightly bette
JDevlieghere added a comment.
In https://reviews.llvm.org/D53532#1280880, @labath wrote:
> Yes, right now it certainly seems to be the case that we parse cmdline late
> in the game. However, it's not clear to me whether that has to be the case.
>
> I can't say I have thought this through to the
JDevlieghere updated this revision to Diff 171845.
JDevlieghere added a comment.
Add static initializers.
https://reviews.llvm.org/D53532
Files:
include/lldb/Host/FileSystem.h
include/lldb/Utility/FileSpec.h
source/Core/Disassembler.cpp
source/Core/Module.cpp
source/Core/ModuleList.cp
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345783: [FileSystem] Extend file system and have it use the
VFS. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345783: [FileSystem] Extend file system and have it use
the VFS. (authored by JDevlieghere, committed by ).
Herald added subscribers: teemperor, abidh.
Changed prior to commit:
https://reviews.llvm.o
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345800: [FileSystem] Move EnumerateDirectory from FileSpec
to FileSystem. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345812: [FileSystem] Remove GetByteSize() from FileSpec
(authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53788?vs=17
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345843: [FileSystem] Remove GetPermissions() and Readable()
from FileSpec (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llv
JDevlieghere updated this revision to Diff 172142.
https://reviews.llvm.org/D53834
Files:
include/lldb/Host/FileSystem.h
include/lldb/Utility/FileSpec.h
source/API/SBFileSpec.cpp
source/Host/common/FileSystem.cpp
source/Host/common/MonitoringProcessLauncher.cpp
source/Host/macosx/objc
JDevlieghere added a comment.
In https://reviews.llvm.org/D53834#1281822, @labath wrote:
> Why did you change the function name? I think it would be nice to keep
> "executable" or something to that effect in the name (e.g. the llvm function
> has "program"), given that the underlying function c
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345853: [FileSystem] Remove ResolveExecutableLocation()
from FileSpec (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53834?vs=172142&id=172157#toc
Repo
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB345854: [FileSystem] Remove Exists() from FileSpec
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53845?vs=171599&id=172158#toc
Repository:
rLLDB LLD
This revision was automatically updated to reflect the committed changes.
Closed by commit rL345854: [FileSystem] Remove Exists() from FileSpec (authored
by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53845?vs=171599&
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, jingham, clayborg.
JDevlieghere added a project: LLDB.
This patch modifies how we open `File` instances in LLDB. Rather than passing a
path or FileSpec to the constructor, we now go through the virtual file system.
JDevlieghere added a comment.
In https://reviews.llvm.org/D54020#1285201, @labath wrote:
> I am not sure what do you mean by "translating paths" in the VFS. If you mean
> something like "return a `FILE *` for `/whatever/my_reproducer/vfs/bin/ls`
> when I ask for `/bin/ls`", then I think that's
JDevlieghere added inline comments.
Comment at: source/Host/common/FileSystem.cpp:253
+static int GetOpenFlags(uint32_t options) {
+ const bool read = options & File::OpenOptions::eOpenOptionRead;
+ const bool write = options & File::OpenOptions::eOpenOptionWrite;
-
JDevlieghere updated this revision to Diff 172382.
JDevlieghere marked 3 inline comments as done.
JDevlieghere added a comment.
Address Pavel's feedback:
- Un-const open functions.
- Remove `::Empty()` again as it was redundant with `operator bool()`.
- Rename `OpenFile` to just `Open`. We might
JDevlieghere added a comment.
In https://reviews.llvm.org/D54020#1285799, @labath wrote:
> Ok, I think we're on the same page here. What I was wondering is that given
> this lack of generality (this operation would only be supported on
> `DiskBackedFilesystem`, and not all other kinds of file s
JDevlieghere added a comment.
Hi Zachary, looks like this broke GreenDragon:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12087/console
Can you have a look please?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54009
___
lldb-comm
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346049: [FileSystem] Open File instances through the
FileSystem. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346049: [FileSystem] Open File instances through the
FileSystem. (authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54020?vs=172382&id=172448#toc
Repositor
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, zturner, labath, tberghammer.
JDevlieghere added a project: LLDB.
Herald added a subscriber: mgorny.
In January Davide sent an e-mail to the mailing list to suggest removing
support for Go and Java. The plan was to have som
JDevlieghere added a comment.
In https://reviews.llvm.org/D54059#1286293, @teemperor wrote:
> Minor detail: The revision title only mentions Java, but this revision
> removes both Go and Java.
Actually, this review is only for removing the Java plugin. There’s a different
review for the Go pl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346159: Remove OCaml debugger plugin (authored by
JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D54060?vs=172464&id=172627#toc
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, davide.
JDevlieghere added a project: LLDB.
Herald added subscribers: teemperor, emaste.
Replace calls to LLVM's is_directory with calls to LLDB's FileSytem class. For
this I introduced a new convenience method that, like t
JDevlieghere added a comment.
In https://reviews.llvm.org/D54135#1288254, @krytarowski wrote:
> Why? We already put a lot of effort into reusing code from LLVM.
This is still using code from LLVM, the `FileSystem` class is just an
abstraction in between:
1. It uses LLVM's virtual file system.
JDevlieghere created this revision.
JDevlieghere added reviewers: jingham, jasonmolenda.
JDevlieghere added a project: LLDB.
Herald added subscribers: teemperor, abidh.
When debugging read-only memory we cannot use software breakpoint. We already
have support for hardware breakpoints and users ca
JDevlieghere updated this revision to Diff 173015.
JDevlieghere added a comment.
Fix bug for `thread until` and add test case.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/Target/Target.h
include/lldb/Target/Thr
JDevlieghere added a comment.
In https://reviews.llvm.org/D54221#1290572, @labath wrote:
> I recall something about linux on arm having a magic unmodifiable (even by
> ptrace) page of memory, so this could be useful there too. However, it's not
> clear to me how a user is going to figure out th
JDevlieghere updated this revision to Diff 173021.
JDevlieghere added a comment.
Remove `ValidatePlan` implementation for `ThreadPlanPython` as I believe it's
bogus.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/T
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346375: [FileSystem] Add convenience method to check for
directories. (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
JDevlieghere updated this revision to Diff 173112.
JDevlieghere marked 18 inline comments as done.
JDevlieghere added a comment.
Feedback from Jim
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
JDevlieghere updated this revision to Diff 173191.
JDevlieghere added a comment.
Update tests to use SB API.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/Target/Target.h
include
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, davide.
JDevlieghere added a project: LLDB.
This moves construction of data buffers into the FileSystem class. Like some of
the previous refactorings we don't translate the path yet because the
functionality hasn'
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346598: Extract construction of DataBufferLLVM into
FileSystem (authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5427
JDevlieghere added a comment.
In https://reviews.llvm.org/D54385#1294534, @teemperor wrote:
> Do we also want to get rid of the `// C Includes` comments that are in some
> files? LLVM isn't using them either and just removing lines doesn't make git
> blame more complicated.
Yup, I'll do that
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Your explanation makes sense, good catch. Thanks for fixing this!
https://reviews.llvm.org/D54417
___
lldb-commits mailing list
lldb-
JDevlieghere added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:101
+option(LLDB_NO_DEBUGSERVER "Delete debugserver after building it, and don't
try to codesign it" OFF)
+option(LLDB_USE_SYSTEM_DEBUGSERVER "Neither build nor codesign debugserver.
Use the
JDevlieghere added inline comments.
Comment at: tools/debugserver/source/CMakeLists.txt:118
+ OUTPUT_VARIABLE xcode_dev_dir)
+string(STRIP ${xcode_dev_dir} xcode_dev_dir)
+
sgraenitz wrote:
> JDevlieghere wrote:
> > Why did you make this variable name lo
JDevlieghere added a comment.
I think we can close this after https://reviews.llvm.org/rL344945?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52543
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
JDevlieghere updated this revision to Diff 174091.
JDevlieghere added a comment.
Feedback Jim: move argument to the end of the list.
https://reviews.llvm.org/D54221
Files:
include/lldb/API/SBBreakpoint.h
include/lldb/API/SBThreadPlan.h
include/lldb/Breakpoint/Breakpoint.h
include/lldb/T
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346920: Add setting to require hardware breakpoints.
(authored by JDevlieghere, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D54221?vs=174091&id=174136#toc
Repository:
rLLDB L
JDevlieghere added a comment.
Personally I don't think we should differentiate between the lit and dotest
suite when it comes to using a custom compiler. The separation between the two
suits is mostly the result of what framework is easier to write your test is
(or which one you're more familia
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D54601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D54602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks for working on this, Stefan. This LGTM.
https://reviews.llvm.org/D54476
___
lldb-commits mailing list
lldb-commits@lists.llvm.
JDevlieghere added a comment.
In https://reviews.llvm.org/D54567#1300459, @zturner wrote:
> I'm not sure how hard it would be.
>
> One problem is that dotest supports not just choosing a compiler, but
> choosing multiple compilers, as well as multiple architectures and it runs
> the test suite
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, shafik, friss, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: abidh, mgorny.
When I landed the initial reproducer framework I knew there were some things
that needed improvement. Rather than bundling
JDevlieghere created this revision.
Herald added a subscriber: mgorny.
JDevlieghere added a subscriber: labath.
This patch is WIP and meant to showcase how the reproducer and VFS will
interact.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54617
Files:
include/lldb/Host/FileSystem.h
JDevlieghere added a comment.
- Initialization of the FS needs to happen in the driver.
- All file access has to go through the new FileSystem.
- Needs tests.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54617
___
lldb-commits mailing list
ll
JDevlieghere updated this revision to Diff 174398.
JDevlieghere marked 4 inline comments as done.
JDevlieghere added a comment.
Address Stefan's review feedback.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebu
JDevlieghere updated this revision to Diff 174399.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Missed a comment; fixed now.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.
JDevlieghere added a comment.
In https://reviews.llvm.org/D54567#1300670, @zturner wrote:
> In https://reviews.llvm.org/D54567#1300641, @JDevlieghere wrote:
>
> > Makes sense. Just to be clear, I'm not advocating running a product for the
> > lit suite, just having one option that controls both
JDevlieghere updated this revision to Diff 174407.
JDevlieghere added a comment.
Simplify code a little, as per Stefan's (offline) suggestion.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
source/API
JDevlieghere updated this revision to Diff 174416.
https://reviews.llvm.org/D54616
Files:
include/lldb/API/SBDebugger.h
include/lldb/Core/Debugger.h
include/lldb/Utility/Reproducer.h
scripts/interface/SBDebugger.i
source/API/SBDebugger.cpp
source/Commands/CommandObjectReproducer.cpp
JDevlieghere added a comment.
Looks like the sed expression is not working on Windows:
http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1418/steps/test/logs/stdio
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54601
___
lldb-com
JDevlieghere added a comment.
In https://reviews.llvm.org/D54617#1302366, @labath wrote:
> I am confused by differing scopes of various objects that are interacting
> here. It seems you are implementing capture/replay as something that can be
> flicked on/off at any point during a debug session
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, labath, zturner, jingham.
JDevlieghere added a project: LLDB.
In order to deal consistently with global state in LLDB, the reproducer feature
affects LLDB's initialization. For example, when replaying, the FileSystem
sin
JDevlieghere added a comment.
In https://reviews.llvm.org/D54682#1302436, @zturner wrote:
> I’ve often thought we should convert LLDB’s command line parsing code over
> to use either cl::opt or lib/Option. This would also solve the problem you
> describe here at the same time.
>
> Do you think
JDevlieghere created this revision.
JDevlieghere added a reviewer: zturner.
JDevlieghere added a project: LLDB.
Herald added subscribers: jfb, mgorny.
Alternative to https://reviews.llvm.org/D54682.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54692
Files:
tools/driver/CMakeLists.txt
1 - 100 of 4304 matches
Mail list logo
