JDevlieghere added a comment. In https://reviews.llvm.org/D53788#1278036, @zturner wrote:
> I always wondered if we actually even need methods like this in `FileSystem` > given that they already exist in `llvm::sys::fs`. Is it possible to just > call the llvm methods directly, or is it still helpful to call the ones in > `FileSystem` so we can more transparently interoperate with the VFS layer > somehow? This particular function uses the VFS so it has to go through the `FileSystem` class. Personally I feel we should do the same for functions that don't, because then it's clear and simple (i.e. everything uses `FileSystem`) and we eliminate potential bugs where someone uses the `llvm::sys::fs` while it should've actually gone through the VFS. Repository: rLLDB LLDB https://reviews.llvm.org/D53788 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
