[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330185. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 02/08: More support for .gnu_debugaltlink

jankratochvil updated this revision to Diff 330322. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96237/new/ https://reviews.llvm.org/D96237 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFC

[Lldb-commits] [PATCH] D96238: [lldb] [nfc] DWZ 03/08: rename TypeUnitSupportFiles -> SharedUnitSupportFiles

jankratochvil updated this revision to Diff 330323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96238/new/ https://reviews.llvm.org/D96238 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/source/Plugins/SymbolFile/DWARF/Sym

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 04/08: DIERef support

jankratochvil updated this revision to Diff 330324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96239/new/ https://reviews.llvm.org/D96239 Files: lldb/source/Plugins/SymbolFile/DWARF/DIERef.cpp lldb/source/Plugins/SymbolFile/DWARF/DIERef.h l

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 05/08: Main functionality

jankratochvil updated this revision to Diff 330325. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96240/new/ https://reviews.llvm.org/D96240 Files: lldb/include/lldb/Utility/ConstString.h lldb/include/lldb/Utility/FileSpec.h lldb/source/Plugin

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 06/08: New testsuite category 'dwz'

jankratochvil updated this revision to Diff 330326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96241/new/ https://reviews.llvm.org/D96241 Files: lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Python/lldbsuite/test/dotes

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 07/08: New testcases

jankratochvil updated this revision to Diff 330327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96242/new/ https://reviews.llvm.org/D96242 Files: lldb/test/Shell/SymbolFile/DWARF/dump-debug-types.cpp lldb/unittests/SymbolFile/CMakeLists.txt

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 08/08: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil updated this revision to Diff 330328. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96243/new/ https://reviews.llvm.org/D96243 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/packages/Python/lldbsuite/test/linux/build

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330473. jankratochvil edited the summary of this revision. jankratochvil added a comment. The testcase assumes checked-in D98589 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. Based on https://reviews.llvm.org/D92643#inline-925368 where the DIE traversal cannot performance-reasonably implement `target variable -r` I am returning here whether the `.debug_names` index could not be rather extended/improved. LLDB would fall back to `ManualD

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 6/9: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. I have filed for dwz tool: Multifile drops DW_TAG_namespace:

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. I think you should remove: `lldb/test/API/.lit_test_times.txt` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92223/new/ https://reviews.llvm.org/D92223 ___ lldb-commits mai

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

jankratochvil added a comment. I think you should remove: `lldb/test/API/.lit_test_times.txt` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 6/9: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil updated this revision to Diff 333692. jankratochvil added a comment. testcase: DWZ is unsupported on OSX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98826/new/ https://reviews.llvm.org/D98826 Files: lldb/source/Plugins/SymbolFil

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 8/9: New testcases

jankratochvil updated this revision to Diff 333693. jankratochvil added a comment. testcases: -fdebug-types-section is unsupported on OSX, Repro was crashing with SymbolFileDWZTests.cpp so it is excluded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

jankratochvil created this revision. jankratochvil added a reviewer: JDevlieghere. jankratochvil added a project: LLDB. jankratochvil requested review of this revision. Failed Tests (1): lldb-shell :: Error/assert.test LLDB on Linux built with symbols is showing this error. I was not bisect

[Lldb-commits] [PATCH] D99462: [lldb] Fix Error/assert.test regression with symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bc1e69de270: [lldb] Fix Error/assert.test regression with symbols (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99462/new/ htt

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: labath, grimar, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Refactor code only for D98289 . Repository

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 334412. jankratochvil retitled this revision from "[lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)" to "[lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)". jankratochvil a

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 334690. jankratochvil added a comment. The patch now requires D99731 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99653/new/ https://reviews.llvm.org/D99653 Files: l

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:498-500 +llvm::Optional DWARFUnit::GetRnglist() { + return m_rnglist_table; +} clayborg wrote: > Return "const llv

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 334692. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:489 const llvm::Optional &DWARFUnit::GetRnglist() { + if (GetVersion() >= 5 && !m_rnglist_table_done) { +m_rnglist_table_done = true; `if (GetVersion() < 5)

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. Thanks for the review. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:489 const llvm::Optional &DWARFUnit::GetRnglist() { + if (GetVersion() >= 5 && !m_rnglist_table_done) { +m_

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 335024. jankratochvil marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:11 +# Failure was the block range 1..2 was not printed plus: +# error: DW_AT_range-DW_FORM_sec_offset.s.tmp {0x00

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added a comment. Sorry for the ping but is there anything left to clarify or fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 __

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. Ping, it would be nice to know if there is some plan/schedule for patch review of this series. I understand it is all voluntary, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. That's sure fine, thanks for the reply. Great there is at least the plan to review it in the future. I understand you are busy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.org/D96236

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. In D96236#2705715 , @dblaikie wrote: > (similar idea) In D96236#2705920 , @clayborg wrote: > > Is there really not way to ask the contained "U" DWARFUnit member for the > main

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

jankratochvil added a comment. It has caused a regression for Fedora buildbot (which is so far a silent one): https://lab.llvm.org/staging/#/builders/16/builds/4936 Failed Tests (2): lldb-api :: tools/lldb-vscode/attach/TestVSCode_attach.py lldb-api :: tools/lldb-vscode/launch/TestVSCod

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

jankratochvil added a comment. The regression was due to the `help process trace` command which surprisingly ends up in `GDBRemoteCommunicationClient::SendTraceSupported` which was crashing on `libipt`-enabled builds. Fixed by: rG18a85276426b9604a9ceca8c528b694964dd8d7c

[Lldb-commits] [PATCH] D91679: [trace][intel-pt] Implement trace start and trace stop

jankratochvil added a comment. Checked in a regression fix: rG18a85276426b9604a9ceca8c528b694964dd8d7c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91679/new/ https://reviews.l

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil planned changes to this revision. jankratochvil added a comment. In D96236#2710376 , @clayborg wrote: > I would be fine with DWARFDie getting bigger to 24B. Great, so I can return back to 2019. > These objects are used temporarily and not u

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil created this revision. jankratochvil added reviewers: dblaikie, labath, clayborg. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. libstc++ 11 started using `[[no_unique_address]]` which crashes LLDB: ec

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:103 + // GCC 11 std::default_delete<...> has existing child with GetByteSize()==1. + if (tuple_sp->GetByteSize() > ptr_obj->GetByteSize()) { +ValueObjectSP de

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. In D101237#2714953 , @dblaikie wrote: > Given that no_unique_address changes the layout of data structures ( > https://clang.llvm.org/docs/AttributeReference.html#no-unique-address ) > adding it to a member that doesn't ac

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil added a comment. In D101237#2714971 , @teemperor wrote: > grep tells me that attribute also influences a bunch of other things in > subtle ways (It seems to potentially influence ABIs and Obj-C encodings?) and > we don't really know what o

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil planned changes to this revision. jankratochvil added a comment. In D101237#2718456 , @shafik wrote: > AFAICT this will change the answer to basic questions such as what size a > `struct` is and this will likely lead to confusion from our u

[Lldb-commits] [PATCH] D92223: [lldb] Add support for looking up static const members

jankratochvil added a comment. The considered .debug_names index update would need to make .debug_names working in the first place - as it does not work now: D99850 So maybe the manual DIE traversal without updating the index and without the regex capability is

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil abandoned this revision. jankratochvil added a comment. IIUC it will get replaced by D101950 . I will just provide some testcase for this case if not already contained therein. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil reclaimed this revision. jankratochvil added a comment. Reopening as D101950 may take some time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101237/new/ https://reviews.llvm.org/D101237 __

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil created this revision. jankratochvil added reviewers: mgorny, labath, JDevlieghere. jankratochvil added a project: LLDB. Herald added subscribers: steven.zhang, shchenz. jankratochvil requested review of this revision. Hardware watchpoints availability differs between hardware (and i

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil planned changes to this revision. jankratochvil added a comment. I forgot it should be also checking it is PowerPC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102140/new/ https://reviews.llvm.org/D102140 __

[Lldb-commits] [PATCH] D102140: [ppc64le] [lldb] [testsuite] Fix false FAILs on ppc64* with no hw watchpoints

jankratochvil updated this revision to Diff 344000. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102140/new/ https://reviews.llvm.org/D102140 Files: lldb/packages/Python/lldbsuite/test/concurrent_base.py lldb/test/API/commands/watchpoints/hello

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. ping#2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1310817194a: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG9dd861a4f539: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using… (authored by jankratoc

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D98289#2764829 , @clayborg wrote: > No objections from me. Anyone else? So I have checked it in, thanks for checking it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289

[Lldb-commits] [PATCH] D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting

jankratochvil created this revision. jankratochvil added a reviewer: dblaikie. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. In D98289#inline-9391

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:32 +# RNGLISTBASE-LABEL: image lookup -v -s lookup_rnglists +# RNGLISTBASE: error: DW_AT_range-DW_FORM_sec_offset.s.t

[Lldb-commits] [PATCH] D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting

jankratochvil updated this revision to Diff 346801. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102851/new/ https://reviews.llvm.org/D102851 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/source/Plugins/SymbolFile/DWA

[Lldb-commits] [PATCH] D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting

jankratochvil requested review of this revision. jankratochvil added a comment. Is the message format OK now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102851/new/ https://reviews.llvm.org/D102851 __

[Lldb-commits] [PATCH] D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting

jankratochvil updated this revision to Diff 346807. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102851/new/ https://reviews.llvm.org/D102851 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp lldb/source/Plugins/SymbolFile/DWA

[Lldb-commits] [PATCH] D102851: [lldb] Improve invalid DWARF DW_AT_ranges error reporting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d19c84cd903: [lldb] Improve invalid DWARF DW_AT_ranges error reporting (authored by jankratochvil). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D81334: 2/2: [lldb] Fix DW_TAG_GNU_call_site-DW_AT_low_pc as produced by GCC

jankratochvil added a comment. In D81334#2189533 , @llunak wrote: > The DWARF in the source file appears to be broken, the test fails for me on > openSUSE 15.2 x86_64, with errors about DIE references outside of its CU. It > fails even if I try to manual

[Lldb-commits] [PATCH] D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies

jankratochvil created this revision. jankratochvil added reviewers: labath, MaskRay. jankratochvil added a project: LLDB. Herald added subscribers: JDevlieghere, aprantl, mgorny. jankratochvil requested review of this revision. D85968 started to use `split-file` a

[Lldb-commits] [PATCH] D86144: [lldb] [testsuite] Add split-file for check-lldb dependencies

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies (authored by jankratochvil). Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

jankratochvil added a comment. It broke the Debian buildbot: http://lab.llvm.org:8011/builders/lldb-x86_64-debian/builds/16095 And also Fedora (although there the commit looks as a different one): http://lab.llvm.org:8014/builders/lldb-x86_64-fedora?numbuilds=1 Repository: rG LLVM Github

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1354 + auto region_it = llvm::find_if(m_mem_region_cache, [](const auto &pair) { +return pair.first.GetExecutable() == MemoryRegionInfo::eYes; + }); Fi

[Lldb-commits] [PATCH] D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Only `SymbolFileDWARF

[Lldb-commits] [PATCH] D89165: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54434dc4dce9: [nfc] [lldb] Simplify calling SymbolFileDWARF::GetDWARFCompileUnit (authored by jankratochvil). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil added a comment. In file included from /home/jkratoch/redhat/llvm-monorepo/lldb/source/Host/common/NativeProcessProtocol.cpp:9: /home/jkratoch/redhat/llvm-monorepo/lldb/include/lldb/Host/common/NativeProcessProtocol.h:20:10: fatal error: 'lldb/Utility/UnimplementedError.h' file not

[Lldb-commits] [PATCH] D89124: [lldb-server][linux] Add ability to allocate memory

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1362 + + NativeThreadLinux &thread = *GetThreadByID(GetID()); + assert(thread.GetStat

[Lldb-commits] [PATCH] D83302: [lldb/DWARF] Don't treat class declarations with children as definitions

jankratochvil added a comment. Fixed stale+unused `DW_AT_object_pointer`+`DW_AT_specification` by rGfa89f641cf9f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83302/new/ https

[Lldb-commits] [PATCH] D89646: [nfc] [lldb] Move `LookupAddress` to `DWARFCompileUnit`

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added projects: Upstreaming LLDB's downstream patches, LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscr

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil added a comment. In D67589#1686150 , @shafik wrote: > @jankratochvil it looks like this PR broke the green dragon build: > http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/1926/ This PR is not yet checked-in. Let's move this discus

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/api/command-return-object/Makefile:1 +MAKE_DSYM := NO + jankratochvil wrote: > labath wrote: > > I'm pretty sure this line is not

[Lldb-commits] [PATCH] D67390: [LLDB][ELF] Load both, .symtab and .dynsym sections

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ELFHeader.cpp:383 + std::hash()(st_name_string.AsCString()), + std::hash()(st_section_name_string.AsCString())); +} llvm::hash_combine already calls std::hash for each o

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

jankratochvil added inline comments. Comment at: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1854 + gdd_objfile_section_list->FindSectionByType( + eSectionTypeELFSymbolTable, true)) { +SectionSP module_section_sp = unified_section_li

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL373775: [lldb] Fix crash on SBCommandReturnObject & assignment (authored by jankratochvil, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [PATCH] D67589: Fix crash on SBCommandReturnObject & assignment

jankratochvil added a comment. Had to disable the testcase on Windows: rL373787 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67589/new/ https://reviews.llvm.org/D67589 ___ lldb-co

[Lldb-commits] [PATCH] D68289: [lldb-server/android] Show more processes by relaxing some checks

jankratochvil added a comment. It has regressed on Linux Fedora 30 x86_64: lldb-Suite :: commands/process/attach/TestProcessAttach.py lldb-Suite :: tools/lldb-vscode/attach/TestVSCode_attach.py F10185566: 1 Repository: rL LLVM CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

jankratochvil added a comment. In D66791#1696340 , @kwk wrote: > lldb-Suite :: commands/process/attach/TestProcessAttach.py > lldb-Suite :: tools/lldb-vscode/attach/TestVSCode_attach.py > These are by: D68289 >

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

jankratochvil added a comment. On Linux OS (Fedora 30 x86_64) with GIT monorepo: After rL374000 : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=c

[Lldb-commits] [PATCH] D68606: [test] Split LLDB tests into filecheck, unittest and dotest.

jankratochvil added a comment. Before this patch I was getting : #rm -rf * cmake ~/redhat/llvm-monorepo2/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_USE_LINKER=gold -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=c

[Lldb-commits] [PATCH] D68188: allow arbitrary python streams to be converted to SBFile

jankratochvil added a comment. Fixed now by rL374322 , there was a regression - Linux Fedora 30 x86_64: == ERROR: test_exceptions (TestFileHandle.FileHandleTestCase) -

[Lldb-commits] [PATCH] D69100: COFF: Create a separate "section" for the file header

jankratochvil added inline comments. Comment at: source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:797 +m_coff_header_opt.header_size, +/*file_offset*/ 0, m_coff_header_opt.header_size, +m_coff_header_opt.sect_alignment, dropped ///*fi

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added a comment. FYI my local buildbot master errors out this way: 2019-10-23 16:10:12+0200 [-] error while parsing config file 2019-10-23 16:10:12+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/buildbot/.local/lib/python2.7/site-packa

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added a comment. 2019-10-23 20:34:53+0200 [-] error while parsing config file 2019-10-23 20:34:53+0200 [-] Unhandled Error Traceback (most recent call last): File "/home/buildbot/.local/lib/python2.7/site-packages/buildbot-latest-py2.7.egg/buildbot/master.py",

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added a comment. I could pack some patched `buildbot-0.8.5` and patched `zorg-git` running on Fedora 30 (and its Python version) so that you can run it yourself. But I am also fine to just testing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69341/new/ https://revie

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added a comment. After the @sivachandra 's fix I get: 2019-10-23 21:28:24+0200 [-] LLVMGitPoller: using workdir '/quad/home/buildbot/zorg-git/buildbot/osuosl/master/gitpoller-workdir' 2019-10-23 21:28:24+0200 [-] LLVMGitPoller: initializing working dir from http://git.lab.llvm

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added a comment. I was using these 3 patches for buildbot-0.8.5 (and one for zorg) to get the master running. But sure there is still some configuration afterwards: https://people.redhat.com/jkratoch/buildbot-0.8.5-fix.patch https://people.redhat.com/jkratoch/buildbot-0.8.5-fix2.pa

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil added inline comments. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"]) sivachandra wrote: > labath wrote: > > sivachandra wrote: > > > sivac

[Lldb-commits] [PATCH] D69341: [zorg] Port LLDB cmake build factory to git

jankratochvil accepted this revision. jankratochvil added inline comments. This revision is now accepted and ready to land. Comment at: zorg/buildbot/builders/LLDBBuilder.py:71 +is_legacy_mode=False, +depends_on_projects=["llvm", "clang", "lldb", "lld"])

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. 2019-10-29 11:38:04+0100 [-] error while parsing config file 2019-10-29 11:38:04+0100 [-] Unhandled Error Traceback (most recent call last): File "

[Lldb-commits] [PATCH] D69555: [zorg] Fix LLDBCmakeBuildFactory

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. It does run now, I did not test it with a slave. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69555/new/ https://reviews.llvm.org/D69555

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

jankratochvil requested changes to this revision. jankratochvil added a comment. This revision now requires changes to proceed. On Fedora 31 x86_64 (that is with `python3-3.7.4-5.fc31.x86_64`) I get: FAIL: LLDB (/quad/home/jkratoch/redhat/llvm-monorepo-clangassertpython3/bin/clang-10-x86_64)

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. I am going to investigate it this week. Feel free to revert it but some such patch is definitely needed for all recent Fedoras, RHEL-8 and CentOS-8 (due to annobin on all those)

[Lldb-commits] [PATCH] D70127: [lldb-vscode] Fix a race in test_extra_launch_commands

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I agree - as there is currently: self.verify_commands('launchCommands', output, launchCommands) # Verify the "stopCommands" here self.continue_to_next_stop() BTW I did not

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid I do not have the regression reproducible, could you provide more info? Having on both hosts trunk `54a9b4c02ff57e9847e0c501578e51db6f73d3be` having applied your D69904 , having reverted your revert (=reapplied) of this m

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. It is still the same (no arm32 regression) with `16bdcc809c72c639a2888b6b859dca88453e3c28` and this patch reapplied. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63540/new/ https://reviews.llvm.org/D63540 ___

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. Getting `ld.lld: error: failed to open ../../../../bin/clang-10: Cannot allocate memory` when trying to build `lldb` natively on arm32 (the same error happens both for `clang` and for `lldb`). Apparently memory is not a problem but the linker runs out of its 32-b

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid In the end I built a native `armv7l-unknown-linux-gnueabihf` lldb using: cmake ../llvm-monorepo/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="lldb;clang;lld" -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_BUILD_LLVM_DYLIB Built it from trunk: `16bdc

[Lldb-commits] [PATCH] D63540: Fix lookup of symbols at the same address with no size vs. size

jankratochvil added a comment. @omjavaid I guess it depends on some system library - what OS vendor/release do you have the regression reproducible on? Still not reproducible for me. Trying `bfbbf0aba81a84da8b53d4d159d080e77ad8ee70` with applied D70155 and app

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added subscribers: kwk, jankratochvil. jankratochvil added a comment. I was glade the `vscode` testcases are gone as they are racy causing many false failures on our Fedora buildbot always hanging until the whole testsuite gets killed: 1910 ?Sl 0:00 | \_ /

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added a comment. In D65123#1597742 , @aadsm wrote: > @jankratochvil interesting, we're also not able to run the lldb-vscode tests > and it was on my todo list to take a look. It is hanging in `vscode.py` function `recv_packet` somehow desp

[Lldb-commits] [PATCH] D65163: Fix occasional hangs of VSCode testcases

jankratochvil created this revision. jankratochvil added reviewers: clayborg, labath, stella.stamenova, gkistanova. jankratochvil added a project: LLDB. Herald added a reviewer: JDevlieghere. Herald added a subscriber: lldb-commits. On slower machines the vscode testcases were sometimes hanging:

[Lldb-commits] [PATCH] D65123: Restore tests for lldb-server and lldb-vscode removed at rL366590

jankratochvil added a comment. In D65123#1597229 , @jankratochvil wrote: > I was glad the `vscode` testcases are gone as they are racy causing many > false failures on our Fedora buildbot always hanging until the whole > testsuite gets killed: That sh

<    1   2   3   4   5   6   7   8   9   >