[Lldb-commits] [lldb] r276065 - s/Cocoa/Foundation/

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 18:58:23 2016 New Revision: 276065 URL: http://llvm.org/viewvc/llvm-project?rev=276065&view=rev Log: s/Cocoa/Foundation/ Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py lldb/t

[Lldb-commits] [lldb] r276220 - Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, even t

2016-07-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 20 19:13:40 2016 New Revision: 276220 URL: http://llvm.org/viewvc/llvm-project?rev=276220&view=rev Log: Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, e

[Lldb-commits] [lldb] r276709 - Print a warning if the directory passed to --test-subdir doesn't end up existing

2016-07-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Jul 25 18:26:24 2016 New Revision: 276709 URL: http://llvm.org/viewvc/llvm-project?rev=276709&view=rev Log: Print a warning if the directory passed to --test-subdir doesn't end up existing Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified: lldb/t

Re: [Lldb-commits] [PATCH] D22863: Improve code of loading plugins that provide cmnds

2016-07-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Everything Greg said makes total sense In general dynamically loadable C++ plugins as a feature is a little rough around the edges. I am glad to see interest in improving it! https://reviews.llvm.org/D22863 ___ lldb

[Lldb-commits] [lldb] r277844 - Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the user

2016-08-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 5 13:09:50 2016 New Revision: 277844 URL: http://llvm.org/viewvc/llvm-project?rev=277844&view=rev Log: Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the

[Lldb-commits] [lldb] r277897 - The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging /bin

2016-08-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 5 19:57:07 2016 New Revision: 277897 URL: http://llvm.org/viewvc/llvm-project?rev=277897&view=rev Log: The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging

[Lldb-commits] [lldb] r278158 - Remove CFData from the xcodeproj as well

2016-08-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 9 15:32:42 2016 New Revision: 278158 URL: http://llvm.org/viewvc/llvm-project?rev=278158&view=rev Log: Remove CFData from the xcodeproj as well Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: lldb/trunk/tools/debugserver/de

[Lldb-commits] [lldb] r278166 - Adjust LLDB's iOS simulator interface for changes in CoreSimulator

2016-08-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 9 16:16:58 2016 New Revision: 278166 URL: http://llvm.org/viewvc/llvm-project?rev=278166&view=rev Log: Adjust LLDB's iOS simulator interface for changes in CoreSimulator rdar://27732333 and rdar://27732377 Modified: lldb/trunk/source/Plugins/Platform/MacOSX/Pla

Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

2016-08-11 Thread Enrico Granata via lldb-commits
> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits > wrote: > > jingham added a comment. > > The patch seems correct to me. > > I don't have a strong opinion about std::vector vrs. SmallVector. These are > temporary objects, so the size of the container doesn't matter, and I doubt

[Lldb-commits] [lldb] r279353 - Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false

2016-08-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 19 19:48:11 2016 New Revision: 279353 URL: http://llvm.org/viewvc/llvm-project?rev=279353&view=rev Log: Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false This

[Lldb-commits] [lldb] r279446 - Add a non-code-running data formatter for __NSCFBoolean

2016-08-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Aug 22 13:07:52 2016 New Revision: 279446 URL: http://llvm.org/viewvc/llvm-project?rev=279446&view=rev Log: Add a non-code-running data formatter for __NSCFBoolean Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp lldb/trunk/source/Plugins/Language/ObjC

[Lldb-commits] [lldb] r279784 - Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types

2016-08-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 25 17:11:01 2016 New Revision: 279784 URL: http://llvm.org/viewvc/llvm-project?rev=279784&view=rev Log: Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types Fixes rda

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

2016-08-29 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Looks good to me https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

2016-08-29 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 15:39:58 2016 New Revision: 280151 URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev Log: Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type This is currently only implemented for the clang-based T

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
g 30, 2016 at 1:48 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Tue Aug 30 15:39:58 2016 > New Revision: 280151 > > URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev > <http://llvm.org/view

[Lldb-commits] [lldb] r280164 - Fix a typo/thinko - this was generating the wrong kind of array

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 16:33:29 2016 New Revision: 280164 URL: http://llvm.org/viewvc/llvm-project?rev=280164&view=rev Log: Fix a typo/thinko - this was generating the wrong kind of array Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/Clan

[Lldb-commits] [lldb] r280166 - Teach ValueObject::ReadPointedString how to read char[] in host memory

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 16:33:47 2016 New Revision: 280166 URL: http://llvm.org/viewvc/llvm-project?rev=280166&view=rev Log: Teach ValueObject::ReadPointedString how to read char[] in host memory Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/Value

[Lldb-commits] [lldb] r280172 - Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 18:00:02 2016 New Revision: 280172 URL: http://llvm.org/viewvc/llvm-project?rev=280172&view=rev Log: Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider This class enables one to easily write a synthetic child provider by writing a class t

[Lldb-commits] [lldb] r280173 - Rename the test class

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 18:00:52 2016 New Revision: 280173 URL: http://llvm.org/viewvc/llvm-project?rev=280173&view=rev Log: Rename the test class Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py Modified

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
;> Is there going to be a test for this? >> >> On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> Author: enrico >> Date: Tue Aug 30 15:39:58 2016 >> New Revision: 280151 >> >&

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19 @@ -18,2 +18,3 @@ mydir = TestBase.compute_mydir(__file__) +N

[Lldb-commits] [lldb] r280294 - Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:21 2016 New Revision: 280294 URL: http://llvm.org/viewvc/llvm-project?rev=280294&view=rev Log: Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type Modified: lldb/trunk/packages/Python/lldbsui

[Lldb-commits] [lldb] r280295 - Add a data formatter for std::function in libcxx

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:37 2016 New Revision: 280295 URL: http://llvm.org/viewvc/llvm-project?rev=280295&view=rev Log: Add a data formatter for std::function in libcxx Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/fun

[Lldb-commits] [lldb] r280328 - There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<>

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 19:32:53 2016 New Revision: 280328 URL: http://llvm.org/viewvc/llvm-project?rev=280328&view=rev Log: There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<> Appease it by being very very very explicit about what I

[Lldb-commits] [lldb] r280389 - Change the formula for tagged NSIndexPath data formatting

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:09:01 2016 New Revision: 280389 URL: http://llvm.org/viewvc/llvm-project?rev=280389&view=rev Log: Change the formula for tagged NSIndexPath data formatting Fixes rdar://25192935 Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatt

Re: [Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

2016-09-01 Thread Enrico Granata via lldb-commits
I am probably being a little dense right now, but I can't seem to find (const char*)0x1000 anywhere in the test case code... > On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Sep 1 04:17:37 2016 > New Revision: 280344 > > URL: http://llvm.org

[Lldb-commits] [lldb] r280395 - When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:31:40 2016 New Revision: 280395 URL: http://llvm.org/viewvc/llvm-project?rev=280395&view=rev Log: When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed Modified: lldb/trunk/source/Core/ValueObjectRegister.cpp Modified:

[Lldb-commits] [lldb] r280513 - Check for null

2016-09-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 2 13:15:48 2016 New Revision: 280513 URL: http://llvm.org/viewvc/llvm-project?rev=280513&view=rev Log: Check for null Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-project/lld

[Lldb-commits] [lldb] r281282 - Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

2016-09-12 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Sep 12 19:22:49 2016 New Revision: 281282 URL: http://llvm.org/viewvc/llvm-project?rev=281282&view=rev Log: Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. granata.enrico added a comment. One piece of concern that I have is the multiplication of things that "testing LLDB" means. We have unit tests, Python tests, and now LIT tests. That means, for each change I want to commit, if I want confidence

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. In https://reviews.llvm.org/D24591#543277, @beanz wrote: > @granata.enrico, we could migrate the existing tests into being executed by > lit even if they aren't using lit's features, so if that direction is desired > we could get everything in lit. That said, you

[Lldb-commits] [lldb] r281993 - Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting

2016-09-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 20 13:26:30 2016 New Revision: 281993 URL: http://llvm.org/viewvc/llvm-project?rev=281993&view=rev Log: Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting Modified: lldb/trunk/source/Plugi

[Lldb-commits] [lldb] r282178 - The host version of lldb always builds for macosx

2016-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 22 12:47:33 2016 New Revision: 282178 URL: http://llvm.org/viewvc/llvm-project?rev=282178&view=rev Log: The host version of lldb always builds for macosx Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild.py URL: http:/

[Lldb-commits] [lldb] r282179 - Actually, do it this way because I will want to know if I am in a host build elsewhere too

2016-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 22 12:59:58 2016 New Revision: 282179 URL: http://llvm.org/viewvc/llvm-project?rev=282179&view=rev Log: Actually, do it this way because I will want to know if I am in a host build elsewhere too Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/tru

[Lldb-commits] [lldb] r282297 - Install only the manpage and only in the proper location

2016-09-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 23 16:24:08 2016 New Revision: 282297 URL: http://llvm.org/viewvc/llvm-project?rev=282297&view=rev Log: Install only the manpage and only in the proper location Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxpr

[Lldb-commits] [lldb] r282310 - Add an accessor to get the value of RC_PLATFORM_NAME at build time

2016-09-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 23 17:30:08 2016 New Revision: 282310 URL: http://llvm.org/viewvc/llvm-project?rev=282310&view=rev Log: Add an accessor to get the value of RC_PLATFORM_NAME at build time Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild

[Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Sep 26 16:36:17 2016 New Revision: 282445 URL: http://llvm.org/viewvc/llvm-project?rev=282445&view=rev Log: Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring Fixes rdar://28480275 Mod

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
ding etc. > oh well There already is a test for this - that's how the breakage was caught to begin with :-) > On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Mon Sep 26 16:36:17 2

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
;> testing command line options similar to what I proposed with unwinding etc. >> oh well > > There already is a test for this - that's how the breakage was caught to > begin with :-) > >> On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits >&

[Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 28 17:53:16 2016 New Revision: 282648 URL: http://llvm.org/viewvc/llvm-project?rev=282648&view=rev Log: Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator Fixes Mod

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote: > > > > On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > > - > + > + static ConstString g___i_("__i_"); > + >// this

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
>> >> On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >> - >> + >> + static ConstString g___i_("__i_"); >> + >>// this must be a ValueObject* because it i

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 29, 2016, at 10:58 AM, Enrico Granata via lldb-commits > wrote: > > >> On Sep 29, 2016, at 10:50 AM, Zachary Turner > <mailto:ztur...@google.com>> wrote: >> >> >> >> On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata > <mai

[Lldb-commits] [lldb] r282754 - Fix an issue where, in i386 mode, the wrong values were being copied into the pair object for a single-entry NSDictionary

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 14:46:48 2016 New Revision: 282754 URL: http://llvm.org/viewvc/llvm-project?rev=282754&view=rev Log: Fix an issue where, in i386 mode, the wrong values were being copied into the pair object for a single-entry NSDictionary Fixes rdar://28502335 Modified: lld

[Lldb-commits] [lldb] r282774 - This test will not work in i386 mode because we don't create interesting types from the ObjC runtime

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 16:20:56 2016 New Revision: 282774 URL: http://llvm.org/viewvc/llvm-project?rev=282774&view=rev Log: This test will not work in i386 mode because we don't create interesting types from the ObjC runtime "Fixes" rdar://28501616 Modified: lldb/trunk/packages/P

[Lldb-commits] [lldb] r282823 - Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:40:04 2016 New Revision: 282823 URL: http://llvm.org/viewvc/llvm-project?rev=282823&view=rev Log: Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r282824 - Prefer skipping over x-failing

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:41:07 2016 New Revision: 282824 URL: http://llvm.org/viewvc/llvm-project?rev=282824&view=rev Log: Prefer skipping over x-failing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py Modified: lldb/trunk/packag

[Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

2016-10-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 3 18:33:00 2016 New Revision: 283160 URL: http://llvm.org/viewvc/llvm-project?rev=283160&view=rev Log: Changes to the std::multimap formatter to make it work against trunk libc++ Fixes rdar://28237486 Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibC

Re: [Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

2016-10-03 Thread Enrico Granata via lldb-commits
Woops... Guess I am just gonna reformat the entire file... Sorry about that! On 10/03/16 04:43 PM, Zachary Turner wrote: > > > Was this clang-formatted? some of these lines look way longer than 80 columns. > > > > On Mon, Oct 3, 2016 at 4:41 PM Enrico Granata via l

[Lldb-commits] [lldb] r283167 - Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap

2016-10-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 3 19:07:42 2016 New Revision: 283167 URL: http://llvm.org/viewvc/llvm-project?rev=283167&view=rev Log: Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap Also, proper formatting.. Modified: lldb/tru

[Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

2015-12-14 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Dec 14 20:20:48 2015 New Revision: 255603 URL: http://llvm.org/viewvc/llvm-project?rev=255603&view=rev Log: Fix a bug where language categories would hold on to their caches even after changes Modified: lldb/trunk/include/lldb/DataFormatters/FormatManager.h lldb

Re: [Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

2015-12-14 Thread Enrico Granata via lldb-commits
like this. > > On Mon, Dec 14, 2015 at 6:23 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Mon Dec 14 20:20:48 2015 > New Revision: 255603 > > URL: http://llvm.org/viewvc/llvm-project?rev=255603&view=rev

Re: [Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

2015-12-14 Thread Enrico Granata via lldb-commits
me as potentially affecting downstream >> tests >> >> I’ll keep this in mind though, if I can come up with a good way to cons a >> test up, I’ll definitely make it happen >> >>> On Dec 14, 2015, at 6:45 PM, Zachary Turner wrote: >>> >>> A uni

[Lldb-commits] [lldb] r255687 - Enable the 'type X list' formatters commands to list formatters in language categories

2015-12-15 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Dec 15 16:20:19 2015 New Revision: 255687 URL: http://llvm.org/viewvc/llvm-project?rev=255687&view=rev Log: Enable the 'type X list' formatters commands to list formatters in language categories Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/da

[Lldb-commits] [lldb] r255696 - Add a few common paths that are not to be tracked to the svnignore property

2015-12-15 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Dec 15 17:01:30 2015 New Revision: 255696 URL: http://llvm.org/viewvc/llvm-project?rev=255696&view=rev Log: Add a few common paths that are not to be tracked to the svnignore property Modified: lldb/trunk/ (props changed) Propchange: lldb/trunk/ --

[Lldb-commits] [lldb] r255741 - Add a symbolic link from the test directory to the actual - elsewhere located - path that contains the test cases - and teach the test suite driver to resolve paths tha

2015-12-15 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Dec 15 19:15:49 2015 New Revision: 255741 URL: http://llvm.org/viewvc/llvm-project?rev=255741&view=rev Log: Add a symbolic link from the test directory to the actual - elsewhere located - path that contains the test cases - and teach the test suite driver to resolve path

[Lldb-commits] [lldb] r256033 - Add API to support retrieving the formatters category for a specific language

2015-12-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Dec 18 15:25:24 2015 New Revision: 256033 URL: http://llvm.org/viewvc/llvm-project?rev=256033&view=rev Log: Add API to support retrieving the formatters category for a specific language Modified: lldb/trunk/include/lldb/API/SBDebugger.h lldb/trunk/packages/Pytho

[Lldb-commits] [lldb] r256034 - Add a test case that validates that my change in r255603 does the right thing

2015-12-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Dec 18 15:35:21 2015 New Revision: 256034 URL: http://llvm.org/viewvc/llvm-project?rev=256034&view=rev Log: Add a test case that validates that my change in r255603 does the right thing Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/

Re: [Lldb-commits] [lldb] r255603 - Fix a bug where language categories would hold on to their caches even after changes

2015-12-18 Thread Enrico Granata via lldb-commits
as potentially affecting downstream >> tests >> >> I’ll keep this in mind though, if I can come up with a good way to cons a >> test up, I’ll definitely make it happen >> >>> On Dec 14, 2015, at 6:45 PM, Zachary Turner >> <mailto:ztur...@google.com&

[Lldb-commits] [lldb] r256042 - Turns out, many people define structs named Point that do not share the same names that this formatter uses for fields; use the {} syntax to make it so that a failure t

2015-12-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Dec 18 16:04:47 2015 New Revision: 256042 URL: http://llvm.org/viewvc/llvm-project?rev=256042&view=rev Log: Turns out, many people define structs named Point that do not share the same names that this formatter uses for fields; use the {} syntax to make it so that a fail

[Lldb-commits] [lldb] r256051 - Add support for seeing through clang::AutoType in ClangASTContext

2015-12-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Dec 18 16:41:25 2015 New Revision: 256051 URL: http://llvm.org/viewvc/llvm-project?rev=256051&view=rev Log: Add support for seeing through clang::AutoType in ClangASTContext This allows LLDB to deal correctly with expression result variables declared via the C++11 'auto'

[Lldb-commits] [lldb] r256053 - __ne__ is the actual Python operator; __neq__ is a typo

2015-12-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Dec 18 16:46:58 2015 New Revision: 256053 URL: http://llvm.org/viewvc/llvm-project?rev=256053&view=rev Log: __ne__ is the actual Python operator; __neq__ is a typo Modified: lldb/trunk/scripts/Python/python-extensions.swig Modified: lldb/trunk/scripts/Python/python-e

[Lldb-commits] [lldb] r256212 - Reduce code duplication

2015-12-21 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Dec 21 17:10:17 2015 New Revision: 256212 URL: http://llvm.org/viewvc/llvm-project?rev=256212&view=rev Log: Reduce code duplication Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-pro

[Lldb-commits] [lldb] r256219 - Remove an empty folder

2015-12-21 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Dec 21 18:00:35 2015 New Revision: 256219 URL: http://llvm.org/viewvc/llvm-project?rev=256219&view=rev Log: Remove an empty folder Removed: lldb/trunk/test/test_runner/ ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] r256223 - No need for a custom function here; just use what C provides

2015-12-21 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Dec 21 18:47:36 2015 New Revision: 256223 URL: http://llvm.org/viewvc/llvm-project?rev=256223&view=rev Log: No need for a custom function here; just use what C provides Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp

[Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jan 13 12:11:45 2016 New Revision: 257644 URL: http://llvm.org/viewvc/llvm-project?rev=257644&view=rev Log: Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Enrico Granata via lldb-commits
> On Jan 13, 2016, at 10:21 AM, Zachary Turner wrote: > > > On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > + > +class CommandScriptImmediateOutputTestCase (PExpectTest): > Does the bug that you

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Enrico Granata via lldb-commits
t; >> On Wed, Jan 13, 2016 at 10:15 AM Enrico Granata via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> + >> +class CommandScriptImmediateOutputTestCase (PExpectTest): >> Does the bug that you were trying to fix occur only when using the >>

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Enrico Granata via lldb-commits
com>> wrote: >> >> >> >> On Wed, Jan 13, 2016 at 10:25 AM Enrico Granata > <mailto:egran...@apple.com>> wrote: >>> On Jan 13, 2016, at 10:21 AM, Zachary Turner >> <mailto:ztur...@google.com>> wrote: >>> >

[Lldb-commits] [lldb] r257656 - Mark these tests on FreeBSD and Linux as non-flakey. We don't know that they are

2016-01-13 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jan 13 13:29:52 2016 New Revision: 257656 URL: http://llvm.org/viewvc/llvm-project?rev=257656&view=rev Log: Mark these tests on FreeBSD and Linux as non-flakey. We don't know that they are Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/command_sc

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-01-13 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Did you mean to delete the tid_t typemap as well? Assuming there truly are identical typemaps and these are just copies, and everything works just as well when they are removed, I have no objection http://reviews.llvm.org/D16149 __

Re: [Lldb-commits] [PATCH] D16149: Delete char const** swig typemaps

2016-01-13 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Ops, sorry, didn't notice the tid_t type map was actually added back later on in the patch. My bad. I'm going to accept this for now, with the caveat that we'll need to work t

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-13 Thread Enrico Granata via lldb-commits
lldb-x86_64-ubuntu-14.04-cmake/builds/10299 > <http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299> > > Thanks, > Ying > > On Wed, Jan 13, 2016 at 11:32 AM, Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wr

Re: [Lldb-commits] [lldb] r257644 - Fix an issue where scripted commands would not actually print any of their output if an immediate output file was set in the result object via a Python file object

2016-01-14 Thread Enrico Granata via lldb-commits
>> offline Ubuntu machines, I don't understand what caused the difference. >> Could you please help to take a look? >> >> http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/10299 >> >> <http://lab.llvm.org:8011/builders/lldb-x86_64-ubu

[Lldb-commits] [lldb] r258367 - Fix a problem where we were not calling fcntl() with the correct arguments for F_DUPFD

2016-01-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jan 20 17:20:10 2016 New Revision: 258367 URL: http://llvm.org/viewvc/llvm-project?rev=258367&view=rev Log: Fix a problem where we were not calling fcntl() with the correct arguments for F_DUPFD On Mac OS X, this was working just fine in debug builds (presumably, because

Re: [Lldb-commits] [PATCH] D15209: Fix script import --allow-reload on Python 3

2016-01-21 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. Yes, I believe so. http://reviews.llvm.org/D15209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r258584 - Add a helper function to ProcessStructReader to allow one to inquire about the offset of a field

2016-01-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Jan 22 17:50:46 2016 New Revision: 258584 URL: http://llvm.org/viewvc/llvm-project?rev=258584&view=rev Log: Add a helper function to ProcessStructReader to allow one to inquire about the offset of a field Modified: lldb/trunk/include/lldb/Utility/ProcessStructReader

[Lldb-commits] [lldb] r258791 - Reverting r258759 as it is breaking the OSX build

2016-01-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Jan 25 22:53:10 2016 New Revision: 258791 URL: http://llvm.org/viewvc/llvm-project?rev=258791&view=rev Log: Reverting r258759 as it is breaking the OSX build Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/cpp/char1632_t/TestChar1632T.py lldb/trunk/pack

Re: [Lldb-commits] [PATCH] D15778: [lldb] Ignore breakpoints by default in SBFrame::EvaluateExpression

2016-01-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. It looks like this code is default constructing a SBExpressionOptions(), which at the end of the day is a fancy wrapper for EvaluateExpressionOptions This last object gets default constructed with m_ignore_breakpoints (false), I wonder whether that is a useful

[Lldb-commits] [lldb] r259078 - Fix an issue where the type list command would not accept a valid argument and instead error out complaining about a malformed regex

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 13:21:38 2016 New Revision: 259078 URL: http://llvm.org/viewvc/llvm-project?rev=259078&view=rev Log: Fix an issue where the type list command would not accept a valid argument and instead error out complaining about a malformed regex rdar://problem/24380025 Add

[Lldb-commits] [lldb] r259131 - Fix a bug where LLDB would not print the name of the function that a scripted summary is bound to

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 18:56:52 2016 New Revision: 259131 URL: http://llvm.org/viewvc/llvm-project?rev=259131&view=rev Log: Fix a bug where LLDB would not print the name of the function that a scripted summary is bound to rdar://24380076 Added: lldb/trunk/packages/Python/lldbsuit

[Lldb-commits] [lldb] r259135 - Fix a bug where type list would ignore the -w argument

2016-01-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jan 28 19:12:13 2016 New Revision: 259135 URL: http://llvm.org/viewvc/llvm-project?rev=259135&view=rev Log: Fix a bug where type list would ignore the -w argument rdar://24379879 Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/ty

Re: [Lldb-commits] [PATCH] D16703: Fix TestDataFormatterScript for Linux.

2016-01-28 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. That seems reasonable, yes. In general, I wish I had done this not via two strings - only one of which gets to be valid in some arbitrary order - but via either two distinct subclasses, or at least via a pair of a string and an enum class specifying the kind. Bu

[Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and then

2016-02-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 5 18:43:07 2016 New Revision: 259964 URL: http://llvm.org/viewvc/llvm-project?rev=259964&view=rev Log: Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Enrico Granata via lldb-commits
> On Feb 5, 2016, at 4:57 PM, Jim Ingham wrote: > > >> On Feb 5, 2016, at 4:43 PM, Enrico Granata via lldb-commits >> wrote: >> >> Modified: lldb/trunk/source/Target/LanguageRuntime.cpp >> URL: >> http://llvm.org/viewvc/llvm-project/lldb/trunk

Re: [Lldb-commits] [lldb] r259964 - Fix an issue where certain CommandObjects (or Options thereof) were being created once, bound to a specific CommandInterpreter (and hence a specific Debugger), and

2016-02-05 Thread Enrico Granata via lldb-commits
o Granata wrote: >> >>> >>> On Feb 5, 2016, at 4:57 PM, Jim Ingham wrote: >>> >>> >>>> On Feb 5, 2016, at 4:43 PM, Enrico Granata via lldb-commits >>>> wrote: >>>> >>>> Modified: lldb/trunk/source/Tar

[Lldb-commits] [lldb] r259972 - Per Jim's suggestion, move checks that we're not mixing and matching Debuggers and Commands deeper in the bowels of LLDB

2016-02-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 5 19:36:07 2016 New Revision: 259972 URL: http://llvm.org/viewvc/llvm-project?rev=259972&view=rev Log: Per Jim's suggestion, move checks that we're not mixing and matching Debuggers and Commands deeper in the bowels of LLDB NFC Modified: lldb/trunk/source/Comm

[Lldb-commits] [lldb] r260199 - Fix an issue where pressing CTRL+C in the interactive script interpreter causes LLDB to crash

2016-02-08 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Feb 8 23:46:47 2016 New Revision: 260199 URL: http://llvm.org/viewvc/llvm-project?rev=260199&view=rev Log: Fix an issue where pressing CTRL+C in the interactive script interpreter causes LLDB to crash This is because PyThreadState_Get() assumes a non-NULL thread state a

[Lldb-commits] [lldb] r260349 - Change lldb.value.__int__() so that it takes into account the signedness of the value being cast to return a Python number with the proper value

2016-02-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Feb 9 20:12:42 2016 New Revision: 260349 URL: http://llvm.org/viewvc/llvm-project?rev=260349&view=rev Log: Change lldb.value.__int__() so that it takes into account the signedness of the value being cast to return a Python number with the proper value The explicit APIs

[Lldb-commits] [lldb] r260436 - No reason for these two letters to be uppercase

2016-02-10 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Feb 10 15:30:20 2016 New Revision: 260436 URL: http://llvm.org/viewvc/llvm-project?rev=260436&view=rev Log: No reason for these two letters to be uppercase Modified: lldb/trunk/source/Commands/CommandObjectBreakpoint.cpp Modified: lldb/trunk/source/Commands/CommandOb

[Lldb-commits] [lldb] r260664 - The data formatters for NSArray, NSDictionary and (only partially) NSSet contain logic to inspect the objects without running code.

2016-02-11 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 12 01:50:15 2016 New Revision: 260664 URL: http://llvm.org/viewvc/llvm-project?rev=260664&view=rev Log: The data formatters for NSArray, NSDictionary and (only partially) NSSet contain logic to inspect the objects without running code. However, they also contain fallb

[Lldb-commits] [lldb] r260752 - Data formatter support for libc++ std::atomic

2016-02-12 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 12 16:18:24 2016 New Revision: 260752 URL: http://llvm.org/viewvc/llvm-project?rev=260752&view=rev Log: Data formatter support for libc++ std::atomic On libc++ std::atomic is a fairly simple data type (layout wise, at least), wrapping actual contents in a member vari

[Lldb-commits] [lldb] r260761 - Remove an unnecessary include

2016-02-12 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Feb 12 17:12:27 2016 New Revision: 260761 URL: http://llvm.org/viewvc/llvm-project?rev=260761&view=rev Log: Remove an unnecessary include Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxAtomic.cpp Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/Li

Re: [Lldb-commits] [PATCH] D17220: [CPlusPlus/LibCxxAtomic.cpp] Fix the path to the header file.

2016-02-12 Thread Enrico Granata via lldb-commits
granata.enrico requested changes to this revision. granata.enrico added a comment. This revision now requires changes to proceed. This include is actually not necessary. I am removing it outright. Thanks! http://reviews.llvm.org/D17220 ___ lldb-com

[Lldb-commits] [lldb] r261165 - Apple simulator platforms don't have a shared cache to load Objective-C class information from

2016-02-17 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Feb 17 16:14:41 2016 New Revision: 261165 URL: http://llvm.org/viewvc/llvm-project?rev=261165&view=rev Log: Apple simulator platforms don't have a shared cache to load Objective-C class information from This code was doing the right thing for the iOS simulator, but not ot

[Lldb-commits] [lldb] r261246 - Fix a typo in FormatCache.cpp such that the cache would potentially return an invalid format in some cases

2016-02-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Feb 18 13:23:52 2016 New Revision: 261246 URL: http://llvm.org/viewvc/llvm-project?rev=261246&view=rev Log: Fix a typo in FormatCache.cpp such that the cache would potentially return an invalid format in some cases Modified: lldb/trunk/source/DataFormatters/FormatCa

Re: [Lldb-commits] [PATCH] D17616: Add a set of new plugins to handle Java debugging

2016-02-25 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. Comment at: source/Plugins/Language/Java/JavaLanguage.cpp:81 @@ +80,3 @@ +HardcodedFormatters::HardcodedSummaryFinder +JavaLanguage::GetHardcodedSummaries() +{ Is there any reason to use hardcoded summaries here?

[Lldb-commits] [lldb] r262254 - Add an LLDB data formatter for single-element NSArray and NSDictionary Cocoa containers

2016-02-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Feb 29 15:06:50 2016 New Revision: 262254 URL: http://llvm.org/viewvc/llvm-project?rev=262254&view=rev Log: Add an LLDB data formatter for single-element NSArray and NSDictionary Cocoa containers Fixes rdar://23715118 Modified: lldb/trunk/include/lldb/Core/ValueObj

[Lldb-commits] [lldb] r262259 - Change the user-visible name for the argument type language to source-language

2016-02-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Feb 29 15:37:01 2016 New Revision: 262259 URL: http://llvm.org/viewvc/llvm-project?rev=262259&view=rev Log: Change the user-visible name for the argument type language to source-language This makes it so that help language provides help on the language command and help s

<    1   2   3   4   5   >