> On Sep 26, 2016, at 2:50 PM, Zachary Turner <ztur...@google.com> wrote: > > Test would be nice, but otoh command line tests are discouraged. Maybe it > will be easier to write this kind of test if we had a tool specifically for > testing command line options similar to what I proposed with unwinding etc. > oh well
There already is a test for this - that's how the breakage was caught to begin with :-) > On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits > <lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Mon Sep 26 16:36:17 2016 > New Revision: 282445 > > URL: http://llvm.org/viewvc/llvm-project?rev=282445&view=rev > <http://llvm.org/viewvc/llvm-project?rev=282445&view=rev> > Log: > Fix an issue where LLDB would not accept the --description-verbosity option > to 'po' without an argument after the StringRef refactoring > > Fixes rdar://28480275 > > > Modified: > lldb/trunk/source/Commands/CommandObjectExpression.cpp > > Modified: lldb/trunk/source/Commands/CommandObjectExpression.cpp > URL: > http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff > > <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Commands/CommandObjectExpression.cpp?rev=282445&r1=282444&r2=282445&view=diff> > ============================================================================== > --- lldb/trunk/source/Commands/CommandObjectExpression.cpp (original) > +++ lldb/trunk/source/Commands/CommandObjectExpression.cpp Mon Sep 26 > 16:36:17 2016 > @@ -142,7 +142,7 @@ Error CommandObjectExpression::CommandOp > } > > case 'v': > - if (!option_arg.empty()) { > + if (option_arg.empty()) { > m_verbosity = eLanguageRuntimeDescriptionDisplayVerbosityFull; > break; > } > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org <mailto:lldb-commits@lists.llvm.org> > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits > <http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits> Thanks, - Enrico 📩 egranata@.com ☎️ 27683
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
