granata.enrico added a comment.

It looks like this code is default constructing a SBExpressionOptions(), which 
at the end of the day is a fancy wrapper for EvaluateExpressionOptions

This last object gets default constructed with

  m_ignore_breakpoints (false),

I wonder whether that is a useful default value to begin with. My personal 
preference would be to change that default to be true and then everyone would 
by default get it "right" for what looks to me like the most common use case.

With that said, if there is a reason for that default to be what it is (and I 
don't know right now and am not in the office to ask), then your patch would 
seem reasonable to me as long as you make the same change in all overloads of 
EvaluateExpression() except the one that explicitly takes an 
SBExpressionOptions.


http://reviews.llvm.org/D15778



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to