Author: dvlahovski
Date: Wed Oct 5 09:35:30 2016
New Revision: 283321
URL: http://llvm.org/viewvc/llvm-project?rev=283321&view=rev
Log:
Fixing new Minidump plugin tests
Added:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/linux-x86_64
(with props)
Author: dvlahovski
Date: Wed Oct 5 10:00:29 2016
New Revision: 283324
URL: http://llvm.org/viewvc/llvm-project?rev=283324&view=rev
Log:
xfailing minidump tests again ... :(
Modified:
lldb/trunk/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
Modifi
t 5, 2016 at 8:09 AM Dimitar Vlahovski via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> Author: dvlahovski
>> Date: Wed Oct 5 10:00:29 2016
>> New Revision: 283324
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=283324&view=rev
Author: dvlahovski
Date: Wed Oct 5 13:11:45 2016
New Revision: 283352
URL: http://llvm.org/viewvc/llvm-project?rev=283352&view=rev
Log:
Removing the new Minidump plugin
Tests are failing and build is failing on windows and darwin.
Will fix and commit it later
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.
Herald added subscribers: modocache, mgorny, beanz.
Now the Minidump parser can parse the:
1. MemoryInfoList - containing region info about memory ranges (readable,
dvlahovski updated this revision to Diff 74551.
dvlahovski added a comment.
Forgot to run clang-format. Also changed a helper function in the tests to make
it simpler.
https://reviews.llvm.org/D25569
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/
dvlahovski updated this revision to Diff 74694.
dvlahovski marked 7 inline comments as done.
dvlahovski added a comment.
Resolved Pavel's remarks.
Also added a unit test for the GetMemory function.
https://reviews.llvm.org/D25569
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
so
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:222
+
+ if (header->size_of_header > sizeof(MinidumpMemoryInfoListHeader)) {
+data = data.drop_front(header->size_of_header -
zturner wrote:
> I don't think you n
dvlahovski updated this revision to Diff 74824.
dvlahovski marked 11 inline comments as done.
dvlahovski added a comment.
Changed std::map with llvm::StringMap
Using containter.empty() instead of containter.size() == 0
Avoiding copy by using for(const auto& ...)
Added bitwise operations to the new
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.
I misunderstood the format of the register context layout.
I thought it was a dynamically changing structure, and that it's size
depended on context_flags.
It turned
dvlahovski updated this revision to Diff 74852.
dvlahovski added a comment.
Adding sanity check for the context's size
https://reviews.llvm.org/D25677
Files:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h
dvlahovski updated this revision to Diff 74856.
dvlahovski added a comment.
Return a nullptr in case of an error
https://reviews.llvm.org/D25677
Files:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h
Index:
dvlahovski updated this revision to Diff 74859.
dvlahovski added a comment.
Make a single array of sse registers instead of separated fields
https://reviews.llvm.org/D25677
Files:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
source/Plugins/Process/minidump/RegisterCont
dvlahovski updated this revision to Diff 74987.
dvlahovski added a comment.
Merge if's checking the same context flag
https://reviews.llvm.org/D25677
Files:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.h
I
Author: dvlahovski
Date: Wed Oct 19 09:14:18 2016
New Revision: 284593
URL: http://llvm.org/viewvc/llvm-project?rev=284593&view=rev
Log:
Minidump plugin: functions parsing memory structures and filtering module list
Summary:
Now the Minidump parser can parse the:
1) MemoryInfoList - containing re
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284593: Minidump plugin: functions parsing memory structures
and filtering module list (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25569?vs=74824&id=75147#toc
Repositor
dvlahovski updated this revision to Diff 75154.
dvlahovski marked an inline comment as done.
dvlahovski added a comment.
Simplified writeRegister function
s/uint128_struct/Uint128/
https://reviews.llvm.org/D25677
Files:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp
sou
Author: dvlahovski
Date: Thu Oct 20 11:01:36 2016
New Revision: 284741
URL: http://llvm.org/viewvc/llvm-project?rev=284741&view=rev
Log:
Minidump plugin: redesign the x86_64 register context
Summary:
I misunderstood the format of the register context layout.
I thought it was a dynamically changin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284741: Minidump plugin: redesign the x86_64 register
context (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25677?vs=75154&id=75309#toc
Repository:
rL LLVM
https://rev
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: lldb-commits, amccarth.
Herald added subscribers: modocache, mgorny, beanz.
This, like the x86_64 case, reads the register values from the minidump
file, and emits a binary buffer that is o
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.
Herald added subscribers: modocache, mgorny, beanz.
This plugin resembles the already existing Windows-only Minidump plugin.
The WinMinidumpPlugin uses the Windows A
dvlahovski updated this revision to Diff 75578.
dvlahovski marked 3 inline comments as done.
dvlahovski added a comment.
Fixes regarding Pavel's comments
https://reviews.llvm.org/D25832
Files:
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/RegisterContextMini
dvlahovski added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:279
// Register stuff
// TODO probably split register stuff tests into different file?
+#define REG_VAL32(x) *(reinterpret_cast(x))
labath wrote:
> If you want to sp
dvlahovski updated this revision to Diff 75617.
dvlahovski marked 6 inline comments as done.
dvlahovski added a comment.
Addressed Pavel's comments.
https://reviews.llvm.org/D25905
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Py
dvlahovski added a comment.
Please ignore the `RegisterContextMinidump_x86_*` changes. Can't seem to make
`arc diff` understand what I want.
https://reviews.llvm.org/D25905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
dvlahovski updated this revision to Diff 75709.
dvlahovski marked 4 inline comments as done.
dvlahovski added a comment.
Formatting correctly the test files source code, and added explanation in their
makefile
ReadModuleList() is called in DoLoadCore()
https://reviews.llvm.org/D25905
Files:
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:67
+ // skip if the Minidump file is Windows generated, because we are still
+ // work-in-progress
+ if (!minidump_parser ||
labath wrote:
> Zach, Adrian: IIUC, t
dvlahovski updated this revision to Diff 76176.
dvlahovski added a comment.
Hopefully removing code that's not for this CL
https://reviews.llvm.org/D25905
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
packages/Python/lldbsuite/test/functi
Author: dvlahovski
Date: Mon Oct 31 10:26:44 2016
New Revision: 285584
URL: http://llvm.org/viewvc/llvm-project?rev=285584&view=rev
Log:
Minidump plugin: Adding x86_32 register context converter
Summary:
This, like the x86_64 case, reads the register values from the minidump
file, and emits a bin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285584: Minidump plugin: Adding x86_32 register context
converter (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25832?vs=75578&id=76414#toc
Repository:
rL LLVM
https:/
Author: dvlahovski
Date: Mon Oct 31 10:35:18 2016
New Revision: 285587
URL: http://llvm.org/viewvc/llvm-project?rev=285587&view=rev
Log:
Minidump plugin: Adding ProcessMinidump, ThreadMinidump and register the plugin
in SystemInitializerFull
Summary:
This plugin resembles the already existing Wi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285587: Minidump plugin: Adding ProcessMinidump,
ThreadMinidump and register the plugin… (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D25905?vs=76176&id=76416#toc
Reposit
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added subscribers: beanz, lldb-commits.
One of the tests was flaky, because similarly to
https://reviews.llvm.org/D18697 (https://reviews.llvm.org/rL265391) - if there
is a process running
which is with the same PID
next build was successful.
> >
> > -Chris
> >
> >> On Oct 31, 2016, at 8:35 AM, Dimitar Vlahovski via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
> >>
> >> Author: dvlahovski
> >> Date: Mon Oct 31 10:35:18 2016
> >&
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285698: Minidump plugin: Fix flaky test (authored by
dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D26193?vs=76560&id=76568#toc
Repository:
rL LLVM
https://reviews.llvm.org/D26193
Author: dvlahovski
Date: Tue Nov 1 10:48:24 2016
New Revision: 285698
URL: http://llvm.org/viewvc/llvm-project?rev=285698&view=rev
Log:
Minidump plugin: Fix flaky test
Summary:
One of the tests was flaky, because similarly to
https://reviews.llvm.org/D18697 (rL265391) - if there is a process run
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
The floating-point and SSE registers could be present in the elf-core
file in the note NT_FPREGSET for 64 bit ones, and in the note
NT_PRXFPREG for 32 bit ones.
The entire note is a
dvlahovski added a comment.
I will generate the core files with the `make-core.sh` script and update the
revision today or tomorrow.
Comment at:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:107
+@skipIf(oslist=['windows'])
+
dvlahovski updated this revision to Diff 77477.
dvlahovski added a comment.
Generated the core files with make-core.sh
https://reviews.llvm.org/D26300
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
packages/Python/lldbsuite/test/functionalitie
dvlahovski updated this revision to Diff 77626.
dvlahovski marked an inline comment as done.
dvlahovski added a comment.
Use unique_ptr instead of shared_ptr
https://reviews.llvm.org/D26300
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
packag
Author: dvlahovski
Date: Sun Nov 20 15:24:49 2016
New Revision: 287506
URL: http://llvm.org/viewvc/llvm-project?rev=287506&view=rev
Log:
ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64
bit elf core files
Summary:
The floating-point and SSE registers could be present
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287506: ELF core: Adding parsing of the floating-point and
SSE registers on x86 32/64… (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D26300?vs=77626&id=78667#toc
Repositor
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
The binary layout of prstatus and prpsinfo was wrong.
Some of the member variables where not aligned properly
and others where with a wrong type (e.g. the time related
stuff in prsta
dvlahovski updated this revision to Diff 64902.
dvlahovski added a comment.
Forgot to add alignas to two members of prstatus
https://reviews.llvm.org/D22628
Files:
source/Plugins/Process/elf-core/ThreadElfCore.cpp
source/Plugins/Process/elf-core/ThreadElfCore.h
Index: source/Plugins/Proces
dvlahovski added a comment.
So, alignas doesn't work with typedef
We can use a #define but that's kind of ugly
https://reviews.llvm.org/D22628
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
dvlahovski created this revision.
dvlahovski added a reviewer: labath.
dvlahovski added a subscriber: lldb-commits.
There were places in the code, assuming(hardcoding) offsets
and types that were only valid for the x86_64 elf core file format.
The NT_PRSTATUS and NT_PRPSINFO structures are with t
dvlahovski updated this revision to Diff 65957.
dvlahovski added a comment.
Checking for null pointer, in case of a corrupt core file
https://reviews.llvm.org/D22917
Files:
packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py
source/Plugins/ObjectFile/ELF/O
Author: dvlahovski
Date: Fri Jul 29 08:18:09 2016
New Revision: 277140
URL: http://llvm.org/viewvc/llvm-project?rev=277140&view=rev
Log:
Add/fix support for i386 elf core files
Summary:
There were places in the code, assuming(hardcoding) offsets
and types that were only valid for the x86_64 elf c
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277140: Add/fix support for i386 elf core files (authored by
dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D22917?vs=65957&id=66114#toc
Repository:
rL LLVM
https://reviews.llvm.org/
dvlahovski created this revision.
dvlahovski added reviewers: labath, amccarth.
dvlahovski added a subscriber: lldb-commits.
Herald added subscribers: dschuff, srhines, danalbert, tberghammer.
This is a work-in-progress minidump parsing code.
There are still some more structures/data streams that
dvlahovski updated this revision to Diff 68177.
dvlahovski added a comment.
Resolving Pavel's remarks
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/
dvlahovski updated this revision to Diff 68180.
dvlahovski added a comment.
Fixing a little bug - should get the byteorder
after calling SignatureMatchAndSetByteOrder
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/
If the only reason is to force little endian,
> just use the types in llvm/Endian.h
> On Tue, Aug 16, 2016 at 8:13 AM Dimitar Vlahovski via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>> dvlahovski updated this revision to Diff 68180.
>> dvlahovski added
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:31-35
@@ +30,7 @@
+// the signature might be byte swapped
+data.SetByteOrder(lldb::eByteOrderBig);
+*offset -= 4;
+signature = data.GetU32(offset);
+if (signature ==
dvlahovski updated this revision to Diff 68557.
dvlahovski added a comment.
Update of the code, regarding the remarks
of zturner and amccarth.
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLi
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:258
@@ +257,3 @@
+llvm::support::ulittle16_t processor_level;
+llvm::support::ulittle16_t processor_revision;
+
The idea of this is to be sure that the compiler d
dvlahovski added a comment.
In https://reviews.llvm.org/D23545#516808, @amccarth wrote:
> Are we putting this code in the right place? I wouldn't expect minidump
> parsing to fall under Plugins/Process.
>
> I assume the eventual intent is to turn the Windows-specific code into a user
> of your
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.h:67
@@ +66,3 @@
+bool m_valid_data;
+llvm::DenseMap m_directory_map;
+};
zturner wrote:
> Can this be `llvm::DenseMap`?
>
> No point erasing the type information
dvlahovski added a comment.
Also FYI I copied the implementation of `consumeObject` to my header.
https://reviews.llvm.org/D23545
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.cpp:21
@@ +20,3 @@
+
+llvm::Optional
+MinidumpHeader::Parse(llvm::ArrayRef &data)
zturner wrote:
> I think these can all just return the pointer instead of `llvm::Optional<
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:260
@@ +259,3 @@
+
+uint8_t number_of_processors;
+uint8_t product_type;
amccarth wrote:
> I'll concede that the static_assert is useful. Given that, showing the
dvlahovski updated this revision to Diff 68670.
dvlahovski added a comment.
Adding sanity checks whether the data buffer
contains the amound of bytes that we want to read.
All of the functions that were returning llvm::Optional
now return just const something *
and indicate for failure with the r
dvlahovski added a comment.
I'm thinking of doing the following approach regarding the plugin
implementation:
Start writing a new plugin "from scratch", which will be inspired strongly by
ProcessWinMiniDump and also borrowing stuff from ProcessElfCore.
Also my plan is to make a single cross-plat
Author: dvlahovski
Date: Fri Aug 19 07:44:53 2016
New Revision: 279234
URL: http://llvm.org/viewvc/llvm-project?rev=279234&view=rev
Log:
Fixing a Darwing test thats failing on windows
The pexpect import should be make after the skip-if-not-darwin part
because pexpect is not available on Windows
dvlahovski updated this revision to Diff 68690.
dvlahovski added a comment.
Move creation of ArrayRef after sanity check
Add a test that checks that the thread list is not present in a
truncated minidump file
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugin
dvlahovski updated this revision to Diff 69254.
dvlahovski added a comment.
Changed the constructing pattern of MinidumpParser
Now there is a static Create method that returns
and llvm::Optional MinidumpParser.
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plug
dvlahovski added a comment.
I changed all of the `llvm::Optional` returning functions to
return only `const type *`
and signalize for 'failure' by returning a `nullptr`. In the cases where I
return objects (e.g. vector of threads)
I'm still using the `llvm::Optional` pattern.
I also think that u
dvlahovski updated this revision to Diff 69340.
dvlahovski added a comment.
Making MinidumpParser constuctor private
https://reviews.llvm.org/D23545
Files:
cmake/LLDBDependencies.cmake
source/Plugins/Process/CMakeLists.txt
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Pr
Author: dvlahovski
Date: Thu Sep 1 06:29:53 2016
New Revision: 280356
URL: http://llvm.org/viewvc/llvm-project?rev=280356&view=rev
Log:
Minidump parsing
Summary:
This is a Minidump parsing code.
There are still some more structures/data streams that need to be added.
The aim ot this is to be use
This revision was automatically updated to reflect the committed changes.
Closed by commit rL280356: Minidump parsing (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D23545?vs=69340&id=69988#toc
Repository:
rL LLVM
https://reviews.llvm.org/D23545
Files:
lldb/tr
dvlahovski added inline comments.
Comment at: lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp:146
@@ +145,3 @@
+break;
+}
+
labath wrote:
> You have a "enumeration not handled in a switch" warning here. Could you do
> something about
Author: dvlahovski
Date: Tue Sep 6 06:00:37 2016
New Revision: 280703
URL: http://llvm.org/viewvc/llvm-project?rev=280703&view=rev
Log:
Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support."
This reverts commit rL280668 because the register tests fail on i386
Linux.
I investigat
Author: dvlahovski
Date: Tue Sep 6 07:48:10 2016
New Revision: 280707
URL: http://llvm.org/viewvc/llvm-project?rev=280707&view=rev
Log:
Fixing an MSVC error from rL280692
MSVC emits an error when one uses a const variable in a lambda without
capturing it.
gcc and clang don't emit an error in th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281030: Fixing a build breakage caused from a change in LLVM
rL281019 (authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24382?vs=70805&id=70806#toc
Repository:
rL LLVM
htt
dvlahovski created this revision.
dvlahovski added a reviewer: ldrumm.
dvlahovski added a subscriber: lldb-commits.
LLVM guys did some clean-up of the Attribute getters/setters
and because of that the build was failing.
https://reviews.llvm.org/D24382
Files:
source/Plugins/LanguageRuntime/Ren
Author: dvlahovski
Date: Fri Sep 9 05:14:11 2016
New Revision: 281030
URL: http://llvm.org/viewvc/llvm-project?rev=281030&view=rev
Log:
Fixing a build breakage caused from a change in LLVM rL281019
Summary:
LLVM guys did some clean-up of the Attribute getters/setters
and because of that the buil
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added a subscriber: lldb-commits.
Herald added a subscriber: beanz.
Added parsing of the MiscInfo data stream.
The main member of it that we care about is the process_id
On Linux generated Minidump (from brea
dvlahovski updated this revision to Diff 70816.
dvlahovski added a comment.
Forgot to run clang-format
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/MinidumpParser.h
source/Plugins/Process/minidump/MinidumpTypes.c
dvlahovski added a comment.
Also added parsing code for Minidump strings - the string in the file are
UTF-16 encoded. I used the code from the WinMiniDump plugin and it can extract
a UTF-16 string and convert it to a UTF-8 one.
https://reviews.llvm.org/D24385
___
dvlahovski updated this revision to Diff 71026.
dvlahovski marked 17 inline comments as done.
dvlahovski added a comment.
Herald added subscribers: mgorny, srhines, danalbert, tberghammer.
Changes regarding all of the comments.
Removed llvm::Optionals where it was unneeded.
Parsing also the OS fr
dvlahovski added inline comments.
Comment at: source/Plugins/Process/minidump/MinidumpParser.cpp:222
@@ -154,1 +221,2 @@
+ return MinidumpExceptionStream::Parse(data);
}
Now that I return an ArrayRef, which is basically a reinterpret
cast of a piece of memory t
dvlahovski updated this revision to Diff 71151.
dvlahovski marked 3 inline comments as done.
dvlahovski added a comment.
Removed consumeString; Fixed comparisons in unittests; out-of-bounds check in
MinidumpString parsing
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump
dvlahovski updated this revision to Diff 71154.
dvlahovski added a comment.
Making the LinuxProcStatus a smarter class
by not parsing the pid each time when GetPid is called
https://reviews.llvm.org/D24385
Files:
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/min
Author: dvlahovski
Date: Tue Sep 13 10:54:38 2016
New Revision: 281348
URL: http://llvm.org/viewvc/llvm-project?rev=281348&view=rev
Log:
MinidumpParsing: pid, modules, exceptions, strings
Summary:
Added parsing of the MiscInfo data stream.
The main member of it that we care about is the process_i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281348: MinidumpParsing: pid, modules, exceptions, strings
(authored by dvlahovski).
Changed prior to commit:
https://reviews.llvm.org/D24385?vs=71154&id=71182#toc
Repository:
rL LLVM
https://review
Author: dvlahovski
Date: Tue Sep 13 11:22:15 2016
New Revision: 281349
URL: http://llvm.org/viewvc/llvm-project?rev=281349&view=rev
Log:
Fix a merge mishap in rL281348
Modified:
lldb/trunk/source/Plugins/Process/minidump/MinidumpParser.cpp
Modified: lldb/trunk/source/Plugins/Process/minidump
Author: dvlahovski
Date: Thu Sep 15 07:58:27 2016
New Revision: 281606
URL: http://llvm.org/viewvc/llvm-project?rev=281606&view=rev
Log:
Reformat x86_64 register infos defines table
Fix the table format of the register defines after clang-format.
Added guards to prevent future reformatting again
dvlahovski created this revision.
dvlahovski added reviewers: labath, zturner.
dvlahovski added subscribers: amccarth, lldb-commits.
Herald added subscribers: mgorny, beanz.
This is a register context converter from Minidump to Linux reg context.
This knows the layout of the register context in th
dvlahovski added a comment.
I tested this on the yet-to-be-submitted plugin code and it works fine on Linux
(should work fine everywhere for that matter). I can do a backtrace, go up/down
the stack frames and, of course, see all of the registers with `register read`
https://reviews.llvm.org/D2
dvlahovski updated this revision to Diff 72509.
dvlahovski marked 4 inline comments as done.
dvlahovski added a comment.
Updating the CL regarding Pavel's comments
https://reviews.llvm.org/D24919
Files:
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/MinidumpP
dvlahovski added a comment.
I will fix the comments that Zachary made in the next revision
https://reviews.llvm.org/D24919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dvlahovski added inline comments.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:47-48
@@ +46,4 @@
+
+ if (*context_flags & uint32_t(MinidumpContext_x86_64_Flags::Control)) {
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
dvlahovski added inline comments.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49
@@ +48,3 @@
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
+ }
+
sizeof(uint16_t), sizeof(uint32_t), etc ?
https://rev
dvlahovski added inline comments.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:47-48
@@ +46,4 @@
+
+ if (*context_flags & uint32_t(MinidumpContext_x86_64_Flags::Control)) {
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
dvlahovski marked 5 inline comments as done.
Comment at:
source/Plugins/Process/minidump/RegisterContextMinidump_x86_64.cpp:49
@@ +48,3 @@
+writeRegister(source_data, result_base, ®_info[lldb_cs_x86_64], 2);
+ }
+
zturner wrote:
> dvlahovski wrote:
> > sizeo
dvlahovski updated this revision to Diff 72659.
dvlahovski added a comment.
Addressing Zachary's and Adrian's comments
https://reviews.llvm.org/D24919
Files:
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minidump/MinidumpParser.cpp
source/Plugins/Process/minidump/M
dvlahovski added a comment.
Thanks for the explanation and examples! :) Will keep this in mind in the
future.
https://reviews.llvm.org/D24919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/l
dvlahovski added inline comments.
Comment at: unittests/Process/minidump/MinidumpParserTest.cpp:177
@@ +176,3 @@
+#define REG_VAL(x) *(reinterpret_cast(x))
+
+TEST_F(MinidumpParserTest, ConvertRegisterContext) {
amccarth wrote:
> `EXPECT_xxx` will check the condit
dvlahovski updated this revision to Diff 72688.
dvlahovski added a comment.
I like the combined approach more. So this is the implementation
https://reviews.llvm.org/D24919
Files:
include/lldb/lldb-private-types.h
source/Plugins/Process/minidump/CMakeLists.txt
source/Plugins/Process/minid
Author: dvlahovski
Date: Tue Sep 27 14:05:55 2016
New Revision: 282529
URL: http://llvm.org/viewvc/llvm-project?rev=282529&view=rev
Log:
Adding a RegisterContextMinidump_x86_64 converter
Summary:
This is a register context converter from Minidump to Linux reg context.
This knows the layout of the
1 - 100 of 121 matches
Mail list logo
