dvlahovski added inline comments.

================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:67
+  // skip if the Minidump file is Windows generated, because we are still
+  // work-in-progress
+  if (!minidump_parser ||
----------------
labath wrote:
> Zach, Adrian: IIUC, the new plugin should generally have feature parity with 
> the windows-only plugin. (Dimitar: could you say exactly what bits are 
> missing?). You should be able to test out this plugin on windows minidumps by 
> removing the windows check below.
> 
> After this goes in, we'll be looking to remove the windows-only plugin.
Yes, I think that now my plugin has full feature parity with the windows-only 
one.


https://reviews.llvm.org/D25905



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to