DhruvSrivastavaX wrote:
> I think we can make some progress here, but I don't think we'll get far
> without ProcessLauncher support. At some point, not too far from now, I'm
> going to start asking questions like "which tests does this fix", and I don't
> think you'll be able to run any of the
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Yes, I did try a few things while rewriting but i was seeing some stray values
which were not actually present in the raw file.
So just want to make sure that I am using it correctly.
https://github.com/llvm/llvm-project/pull/116338
_
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/2] Some base #if _AIX changes
---
.../Host/posix/
@@ -0,0 +1,154 @@
+//===-- HostInfoAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DhruvSrivastavaX wrote:
Okay sure. Done. Please check! 🙂
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/117906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX commented:
Tested with AIX too. Thanks!
https://github.com/llvm/llvm-project/pull/121913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
ConnectionStatus ConnectionFileDescriptor::ConnectFile(
llvm::StringRef s, socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#if LLDB_ENABLE_POSIX && !defin
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
ConnectionStatus ConnectionFileDescriptor::ConnectFile(
llvm::StringRef s, socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#if LLDB_ENABLE_POSIX && !defin
@@ -11,7 +11,9 @@
// C includes
#include
#include
+#ifndef _AIX
#include
DhruvSrivastavaX wrote:
I'll remove sys/mount.h as part of this PR atleast.
https://github.com/llvm/llvm-project/pull/120979
___
lldb-com
DhruvSrivastavaX wrote:
Reference Discussion:
https://github.com/llvm/llvm-project/pull/120979#discussion_r1903934719
Please see if this is okay @DavidSpickett
https://github.com/llvm/llvm-project/pull/121747
___
lldb-commits mailing list
lldb-commi
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/121747
Replaced `bzero` with the standard `memset` so that it is common to all
platforms.
Review Request: @DavidSpickett
>From ced564a1ae7938cddd360684e08077af210654cb Mon Sep 17 00:00:00 2001
From: Dhruv-
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/3] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/4] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/3] Some base #if _AIX changes
---
.../Host/posix/
DhruvSrivastavaX wrote:
Updated the branch
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/4] Introducing PlatformAIX from PlatformLinux
---
DhruvSrivastavaX wrote:
Since the common changes have been moved to HostInfoPosix via this PR:
- https://github.com/llvm/llvm-project/pull/119694
I have updated HostInfoAIX accordingly. Still it is a copy of the remaining
HostInfoLinux, so please let me know your comments.
https://github.com/ll
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/117906
>From d05de47c87362b54760f65c294c30c80b2d5bc9b Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 27 Nov 2024 10:10:32 -0600
Subject: [PATCH 1/2] HostInfoAIX
---
lldb/include/lldb/Host/aix/Hos
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/117906
>From d05de47c87362b54760f65c294c30c80b2d5bc9b Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 27 Nov 2024 10:10:32 -0600
Subject: [PATCH] HostInfoAIX
---
lldb/include/lldb/Host/aix/HostInf
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/121273
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH 1/4] AIX Changes for MainLoop
---
lldb/source/Host/
DhruvSrivastavaX wrote:
> For me personally this would look better as thin syscall wrapper -- a static
> function with all arguments passed explicitly (since the arguments are
> modified, it would have to be MutableArrayRef, and not ArrayRef as I
> originally wrote), rather than a method, but
DhruvSrivastavaX wrote:
Request you to merge this one too. Thanks!
https://github.com/llvm/llvm-project/pull/120978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Request you to merge it as well, if all is good. Thanks!
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120978
>From 40b9ceabdda30e914a1e3ae2938566f13621429c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 11:19:07 -0600
Subject: [PATCH 1/3] clang-format changes
---
lldb/source/Host/posi
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/2] Some base #if _AIX changes
---
.../Host/posix/
DhruvSrivastavaX wrote:
Hi @labath , Please let me know your comments for these changes, I have rebased
this for formatting changes.
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
DhruvSrivastavaX wrote:
Hi @labath , Please let me know your comments for these changes.
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/4] Introducing PlatformAIX from PlatformLinux
---
DhruvSrivastavaX wrote:
Hi @DavidSpickett @labath , Do let me know if this can be merged now
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/5] Introducing PlatformAIX from PlatformLinux
---
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 1/7] Added XCOFF Header Parsing
---
.../ObjectFile/
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -136,13 +169,42 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
return XCOFFHeaderSizeFromMagic(magic) != 0;
}
-bool ObjectFileXCOFF::ParseHeader() { return false; }
+bool ObjectFileXCOFF::ParseHeader() {
+
+ bool retVal = false;
+ ModuleSP module_sp(Ge
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/5] Added base files for NativeProcess for AIX
---
DhruvSrivastavaX wrote:
Addressed your comments in this commit to keep track of the changes.
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
@@ -98,9 +98,20 @@ class ObjectFileXCOFF : public lldb_private::ObjectFile {
const lldb::ProcessSP &process_sp, lldb::addr_t header_addr);
protected:
+ typedef struct llvm::object::XCOFFFileHeader64 xcoff_header_t;
+
+ typedef struct llvm::object::XCOFFAuxi
@@ -136,13 +169,42 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
return XCOFFHeaderSizeFromMagic(magic) != 0;
}
-bool ObjectFileXCOFF::ParseHeader() { return false; }
+bool ObjectFileXCOFF::ParseHeader() {
+
+ bool retVal = false;
+ ModuleSP module_sp(Ge
@@ -0,0 +1,248 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/119694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/119694
This change is related merging some of the APIs in HostInfoLinux into
HostInfoPosix.
Here is the reference PR comment:
https://github.com/llvm/llvm-project/pull/117906#discussion_r1865427495,
https://
@@ -81,9 +79,44 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
DhruvSrivastavaX wrote:
Okay, let me then focus on other areas till we are actually able to build this
PR. Will come back to this once we have some base build-ability on AIX.
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing li
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120459
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
@@ -139,8 +177,53 @@ FileSpec HostInfoPosix::GetDefaultShell() {
return FileSpec("/bin/sh");
}
+FileSpec HostInfoPosix::GetProgramFileSpec() {
+ static FileSpec g_program_filespec;
+
+ if (!g_program_filespec) {
+char exe_path[PATH_MAX];
+ssize_t len = readlink("/p
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/119694
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -226,13 +238,13 @@ MainLoopPosix::~MainLoopPosix() {
#endif
m_read_fds.erase(m_interrupt_pipe.GetReadFileDescriptor());
m_interrupt_pipe.Close();
- assert(m_read_fds.size() == 0);
+ assert(m_read_fds.size() == 0);
assert(m_signals.size() == 0);
}
MainLoopPosix:
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120390
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX deleted
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -47,8 +47,7 @@ static void write_string(int error_fd, const char *str) {
(void)r;
}
-[[noreturn]] static void ExitWithError(int error_fd,
- const char *operation) {
+[[noreturn]] static void ExitWithError(int error_fd, const char *ope
DhruvSrivastavaX wrote:
So, all the tests have passed.
I would request you to merge as I dont have the write access yet.
Thanks!!
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/10] Added XCOFF Header Parsing
---
.../ObjectFil
@@ -81,9 +79,44 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120390
>From 6361863d1533361146677c3bac8ce325ed2721a9 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 03:10:23 -0600
Subject: [PATCH 1/2] Added AIX version of ptrace
---
lldb/source/Ho
@@ -226,13 +238,13 @@ MainLoopPosix::~MainLoopPosix() {
#endif
m_read_fds.erase(m_interrupt_pipe.GetReadFileDescriptor());
m_interrupt_pipe.Close();
- assert(m_read_fds.size() == 0);
+ assert(m_read_fds.size() == 0);
assert(m_signals.size() == 0);
}
MainLoopPosix:
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/120378
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
AIX ptrace (ptrace,ptracex,ptrace64) has a different format, so we would need
an AIX specific case anyway.
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
https://github.com/DhruvSrivastavaX deleted
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
> Please link to the English docs -
> https://www.ibm.com/docs/en/aix/7.3?topic=p-ptrace-ptracex-ptrace64-subroutine
> instead.
Apologies for the blunder, I myself dont speak French by the way. 😀 Corrected
https://github.com/llvm/llvm-project/pull/120390
_
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/116338
>From 0c63800bdcbadcfceed4c9a81305eda7d5a15960 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 15 Nov 2024 02:16:31 -0600
Subject: [PATCH 01/11] Added XCOFF Header Parsing
---
.../ObjectFil
@@ -127,19 +162,31 @@ bool ObjectFileXCOFF::MagicBytesMatch(DataBufferSP
&data_sp,
lldb::addr_t data_length) {
lldb_private::DataExtractor data;
data.SetData(data_sp, data_offset, data_length);
+ // Need to set this as XCOFF is only c
@@ -79,9 +79,45 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
DhruvSrivastavaX wrote:
So, I have handled all the comments. Please merge if everything is alright.
@labath @DavidSpickett
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
DhruvSrivastavaX wrote:
> I am kinda impressed how many languages they have available, but the downside
> is that Google seems to love choosing a non-English one for me.
Pretty much same for me. It will always be either Japanese or Korean. French is
a new addition perhaps. 😄
https://github.c
@@ -21,8 +21,8 @@
#include
#include
-#include
#include
+#include
DhruvSrivastavaX wrote:
Added by clang-format
https://github.com/llvm/llvm-project/pull/120390
___
lldb-commits mailing list
lldb-commits@lists
@@ -47,8 +47,7 @@ static void write_string(int error_fd, const char *str) {
(void)r;
}
-[[noreturn]] static void ExitWithError(int error_fd,
- const char *operation) {
+[[noreturn]] static void ExitWithError(int error_fd, const char *ope
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120378
>From cf6a863b6da6bdaf474d2abc4524960b6436f645 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Wed, 18 Dec 2024 02:17:04 -0600
Subject: [PATCH] AIX Changes for MainLoop
---
lldb/source/Host/posi
DhruvSrivastavaX wrote:
Okay sure. Thats a great suggestion.
Updated my branch for this one.
https://github.com/llvm/llvm-project/pull/120378
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/119694
>From b8807f815956ac46e8b518a88cda79d16a4ec72c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Thu, 12 Dec 2024 06:06:47 -0600
Subject: [PATCH 1/2] Moving APIs from HostInfoLinux to HostInfoPosix
@@ -27,6 +30,31 @@
using namespace lldb_private;
+namespace {
+struct HostInfoPosixFields {
+ llvm::once_flag m_os_version_once_flag;
+ llvm::VersionTuple m_os_version;
+};
+} // namespace
+
+llvm::VersionTuple HostInfoPosix::GetOSVersion() {
+ static HostInfoPosixFields *
@@ -81,9 +79,44 @@ ObjectFile *ObjectFileXCOFF::CreateInstance(const
lldb::ModuleSP &module_sp,
if (!objfile_up)
return nullptr;
+ // Cache xcoff binary.
+ if (!objfile_up->CreateBinary())
+return nullptr;
+
+ if (!objfile_up->ParseHeader())
+return nullptr;
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/116338
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Yes, I was trying to resolve a couple of conflicts in a better way, since the
branch had diverged quite some time back.
Thanks for the squash and merge!
https://github.com/llvm/llvm-project/pull/119892
___
lldb-commits mail
101 - 200 of 308 matches
Mail list logo
