[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

This revision was automatically updated to reflect the committed changes. Closed by commit rG049530129326: [lldb-vscode] Report supportsModulesRequest=true (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115033/new/ https://review

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2461 + bool has_scope = !scope.IsEmpty(); + llvm::StringRef sc(scope.GetStringRef()); + std::string storage; nit: maybe call it `scope_ref`? Co

[Lldb-commits] [PATCH] D115110: [lldb][nfc] clang-format some files as preperation for https://reviews.llvm.org/D114627

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e2eece9aa8: [lldb][NFC] clang-format some files as preparation for https://reviews.llvm. (authored by lassefolger, committed by werat). Changed prior to commit: https://reviews.llvm.org/D115110?vs=39

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Looks good to me, I'm going to land it soon unless there are objections from other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406480. werat added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Call `sys::PrintStackTraceOnErrorSignal()` in `SBDebugger::Initialize()`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406483. werat added a comment. Herald added subscribers: JDevlieghere, mstorsjo. Initialize signal handlers in `PrintStackTraceOnErrorSignal()` only once. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3297591 , @aganea wrote: > I'm not sure it's a good idea to start loading DLLs when we get to this point. > I would rather suggest calling `sys::PrintStackTraceOnErrorSignal({});` in > `SBDebugger::Initialize()`. "argv0"

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406484. werat added a comment. Revert accidental formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406485. werat added a comment. Remove accidental old code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp llvm/lib/

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat updated this revision to Diff 406487. werat added a comment. Restore accidentally removed code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119009/new/ https://reviews.llvm.org/D119009 Files: lldb/source/API/SystemInitializerFull.cpp ll

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3302004 , @labath wrote: > I don't think this is a good idea. I'm very much against libraries randomly > installing signal handlers, and I think that is the reason this function is > called from the main program in lldb

[Lldb-commits] [PATCH] D119009: [Support] Ensure handlers are set up before printing the stacktrace

werat added a comment. In D119009#3302354 , @JDevlieghere wrote: > I believe it's generally considered bad practice to install signal handlers > in a library. This is why the initialization currently happens in the driver. > If you look at other tools

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. @JDevlieghere @shafik friendly ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3305973 , @shafik wrote: > I believe this a program like this > > int main() { > int arr[2]{0}; > > return arr[1]; > } > > and an expression like this `expr arr[0]` will give us the constant > expression

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

This revision was automatically updated to reflect the committed changes. Closed by commit rGafb446e8a61d: [lldb] Constant-resolve operands to `getelementptr` (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://rev

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3308499 , @stella.stamenova wrote: > It looks like the new test is failing on the Windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/15049 Whoops, static lookup seem to be broken on Windows (other tests

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3314729 , @shafik wrote: > I was hoping you would add a positive test as well like the one I came up > with that covered the new code as well. Oh, whoops, sorry, I don’t know how I missed your point :) I will add a test

[Lldb-commits] [PATCH] D119734: [lldb] Add a positive test for `getelementptr` constant args

werat created this revision. werat added a reviewer: shafik. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The IR interpreter supports const operands to the `GetElementPtr` IR instruction, so it should be able to evaluate expression

[Lldb-commits] [PATCH] D119734: [lldb] Add a positive test for `getelementptr` constant args

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e0ef179d883: [lldb] Add a positive test for `getelementptr` constant args (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119734/new/ ht

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 442126. werat added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Rebase on latest HEAD - Address review comments - Add a check for field being integer/enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat marked an inline comment as done. werat added a comment. Reviving the patch and taking over. @jankratochvil @shafik @labath can you please take another look? Thanks! Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:172 + // Find the min/max value

[Lldb-commits] [PATCH] D129327: [lldb] Add support for using integral const static data members in the expression evaluator

werat created this revision. Herald added a subscriber: mgorny. Herald added a reviewer: shafik. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds support for using const static integral data membe

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat marked 6 inline comments as done. werat added a comment. In D81471#3632297 , @labath wrote: > I guess the condition we really want to express here is "does this expression > refer to a constexpr variable (ideally one without a location)"? And the >

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443051. werat marked 2 inline comments as done. werat added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugin

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443052. werat added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp Index

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat updated this revision to Diff 443053. werat added a comment. Fix condition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 Files: lldb/source/Plugins/ExpressionParser/Clang/ASTResultSynthesizer.cpp

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat edited reviewers, added: Michael137; removed: jarin. werat added a comment. In D81471#3641915 , @labath wrote: > So, if noone objects to this, then I think it's fine. I guess nobody objects :) @labath, @Michael137, can you accept/LGTM the revision?

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

This revision was automatically updated to reflect the committed changes. Closed by commit rG486787210df5: [lldb] Add support for using integral const static data members in the… (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8147

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat created this revision. werat added a reviewer: Michael137. Herald added a subscriber: kristof.beyls. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Follow-up fix for https://reviews.llvm.org/D81471.

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat added a comment. I didn't see the test failure on AArch64, so you're both probably right. I've searched the code for other uses of int128 and found a similar place, which disabled the test for both 32-bit and 64-bit -- https://github.com/llvm/llvm-project/blob/30c2406e270cc5dab8da813ce5c5

[Lldb-commits] [PATCH] D129783: [lldb] Skip tests using int128 on ARM

werat abandoned this revision. werat added a comment. I have relanded the patch with the fixed tests here -- https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129783/n

[Lldb-commits] [PATCH] D81471: [lldb] Add support for using integral const static data members in the expression evaluator

werat added a comment. Relanded in https://github.com/llvm/llvm-project/commit/7d297de95117e783bbfaecbba1f72fc55de05a30 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81471/new/ https://reviews.llvm.org/D81471 _

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

werat added a comment. I've tried reproducing the test case with `lldb` built from HEAD on my Linux machine and it seems to work without your patch: ❯ cat ~/src/cpp/const.cc enum class ScopedEnum { scoped_enum_case1 = 1, scoped_enum_case2 = 2, }; struct A { using EnumAlia

[Lldb-commits] [PATCH] D130213: [LLDB][ClangExpression] Fix initialization of static enum alias members

werat added a comment. In D130213#3668450 , @aprantl wrote: > @werat did you build with assertions enabled? Oh, no, I build in `RelWithDebInfo` out of habit. I've tried with assertions and then it fails. However, when ignoring the asserts the result is

[Lldb-commits] [PATCH] D130285: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra

werat created this revision. werat added reviewers: labath, jingham, jasonmolenda. Herald added a project: All. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. DW_OP_skip/DW_OP_bra can move offset to the end of the data, which means t

[Lldb-commits] [PATCH] D130285: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra

This revision was automatically updated to reflect the committed changes. Closed by commit rG5c39c31a9952: [lldb] Handle jumping to the end in DW_OP_skip/DW_OP_bra (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130285/new/ https:

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

werat added a comment. Thanks for improving this! Can you please add a few examples in the commit description like "before -> after", so it's more obvious what is changing here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111715/new/ https://rev

[Lldb-commits] [PATCH] D111934: [NFC] clang format change

This revision was automatically updated to reflect the committed changes. Closed by commit rGee691fbc3de3: [lldb][NFC] clang format change (authored by lassefolger, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111934/new/ https

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

This revision was automatically updated to reflect the committed changes. Closed by commit rG134e1817f62c: [lldb] change name demangling to be consistent between windows and linx (authored by lassefolger, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. This looks reasonable to me. @teemperor any thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112147/new/ https://reviews.llvm.org/D112147

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Scopes can have an optional hint for how to present this scope in the UI: https://microsoft.github.io/debug-adapter-protocol/specification#Types_Scope The I

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat added a comment. In D113400#3117500 , @wallace wrote: > could you share a screenshot of how this looks like? Sure! Here are the screenshots of before/after in Visual Studio 2022. Before everything is in one place (in Locals Window): F20179455: vis

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

werat added a comment. Thanks! I have push permission, will land it myself in a bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews.llvm.org/D113400 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D113400: [lldb-vscode] Add presentation hints for scopes

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8f0035ca99: [lldb-vscode] Add presentation hints for scopes (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113400/new/ https://reviews

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Operands to `getelementptr` can be constants or constant expressions. Check that all operands can be constant-resolved and resolve them during the evaluation

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 385892. werat added a comment. Herald added a subscriber: JDevlieghere. Remove accidental code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files: lldb/source/Expr

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The value type can be a typedef of a reference (e.g. `typedef int& myint`). In this case `GetQualType(type)` will return `clang::Typedef`, which cannot be ca

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

werat updated this revision to Diff 387213. werat added a comment. Update commit message, rename test variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113673/new/ https://reviews.llvm.org/D113673 Files: lldb/source/Plugins/TypeSystem/Clang

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

This revision was automatically updated to reflect the committed changes. Closed by commit rG95102b7dc3c1: [lldb] Unwrap the type when dereferencing the value (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113673/new/ https://rev

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat marked 4 inline comments as done. werat added a comment. In D113498#3124525 , @teemperor wrote: > I really like the solution, but I think by fixing the `CanInterpret` you also > made the test case no longer reach the actual changed interpreting log

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 387236. werat added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files: lldb/source/Expression/IRInterpreter.cpp lldb/test/API

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. Btw, this crash in `llvm::DataLayout::getIndexedOffsetInType` was discovered by lldb-eval fuzzer a while ago -- https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=36738 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 387911. werat added a comment. Make the check more strict, only verify that the indexes are ConstantInt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files: lldb/s

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat marked 2 inline comments as done. werat added a comment. In D113498#3137196 , @teemperor wrote: > Not sure how flexible your fuzzer setup is regarding downstream patches, but > did you try putting some kind of `assert("coverage" && false);` in that

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3139112 , @shafik wrote: > On the other hand this is a well-formed constant expression: > > static const int x =0; > constexpr const int* ip1 = &x + 1; > > Does that get you the test case you need? This expression se

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66b69a3925c: [lldb] Fix lookup for global constants in namespaces (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2464 +const char *qn = die.GetQualifiedName(s); +if (strncmp(sc, qn, strlen(sc))) Can `GetQualifiedName` return `NULL` string? Comment a

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. @shafik ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D115033: [lldb-vscode] Report supportsModulesRequest=true

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The adapter does support `Modules` request, implemented in 39239f9 . Repository: rG

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat added a comment. In D132734#3887018 , @JDevlieghere wrote: > Thanks Will, let me apply this locally and see if that addresses the issue > for which I reverted the original patch. Hy Jonas, sorry for bumping an old thread, but did you manage to ch

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat accepted this revision. werat added reviewers: clayborg, granata.enrico. werat added a comment. This revision is now accepted and ready to land. Nice fix! It would be nice to remove redundant parenthesis, e.g. `(*(ptr)).member -> (*ptr).member`, but I see this is non-trivial with the curre

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

werat accepted this revision. werat added a comment. This revision is now accepted and ready to land. Look good to me, but giving some time for others to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D133689: [lldb] Add SBBreakpointLocation::SetCallback

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f5d109fca23: [lldb] Add SBBreakpointLocation::SetCallback (authored by lauralcg, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133689/n

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

werat added a comment. On a somewhat related note, is it expected that `GetValueAsUnsigned()` performs an overflow as `int32` if the type is smaller that `int64`? ❯ cat overflow.cc #include int main() { int8_t i8 = -1; int32_t i32 = -1; int64_t i64 = -1; return 0; }

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

werat added a comment. In D134493#3811253 , @labath wrote: > lol, I knew about the last two parts (not that I agree with them, but I think > we have about an equal amount of code which relies on it, and that which > tries to work around it), but the fir

[Lldb-commits] [PATCH] D134493: [lldb][TypeSystemClang] Deduce lldb::eEncodingUint for unsigned enum types

werat added a comment. In D134493#3819710 , @shafik wrote: > Note, in both C and C++ converting a `-1` to unsigned will always result in > the max unsigned value e.g.: When you convert to "unsigned" then yeah, but here the API is `uint64_t GetAsUnsig

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG14642dc7405e: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/n

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

werat reopened this revision. werat added a comment. This revision is now accepted and ready to land. In D132734#3827245 , @mib wrote: > Let me know if you need help reproducing and fixing these issues, otherwise > I'll have to revert your patch. Sorry

[Lldb-commits] [PATCH] D132734: [lldb] Fix member access in GetExpressionPath

This revision was automatically updated to reflect the committed changes. Closed by commit rG0205aa4a0257: [lldb] Fix member access in GetExpressionPath (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132734/n

[Lldb-commits] [PATCH] D103454: [lldb][docs] Document SBType

werat added a comment. Is this code used for auto-generated docs? Could be have this documentation in C++ definitions (lldb/API/SBType.h) as well? I usually just read the C++ source code, but I can imagine having the same docs in two places might be not the best idea... Repository: rG LLVM

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat created this revision. werat added a reviewer: teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Children of ValueObject automatically update themselves when they detect the state of the process has changed, which typic

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 356663. werat added a comment. Herald added a subscriber: JDevlieghere. Simplify the test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/Core

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 356677. werat added a comment. Use local variables in test Assert for SetValueFromCString Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/Core/Valu

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat added a reviewer: jingham. werat added a comment. Jim, can you take a look, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 ___ lldb-commits maili

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat added a comment. Thanks for the prompt review! > This change is wrong for ValueObjectConstResult's. The original point of > ValueObjectConstResult's was to store the results of expressions so that, > even if the process is not at the original stop point, you could still check > the value

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 357477. werat added a comment. Add a test for a value created via `SBTarget::CreateValueFromData`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 357478. werat added a comment. Add a test for a value created via `SBTarget::CreateValueFromData`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 357710. werat added a comment. Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105470/new/ https://reviews.llvm.org/D105470 Files: lldb/source/Core/ValueObject.cpp lldb/test/API/python_api/

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat added a comment. Thanks for the explanation! But at this point I feel I'm a bit confused about how it all _supposed_ to work in the current design :) If I understand correctly, there are four "types" of values from the user (API) perspective: 1. `ExpressionResult` -- value returned by `S

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

werat updated this revision to Diff 361649. werat added a comment. [clang-tidy] Always open files using UTF-8 encoding The encoding used for opening files depends on the OS and might be different from UTF-8 (e.g. on Windows it can be CP-1252). The documentation files use UTF-8 and might be incomp

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaafa05e03d62: [lldb] Add minidump save-core functionality to ELF object files (authored by Aj0SK, committed by werat). Changed prior to commit: ht

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeee687a66d76: [lldb] Add minidump save-core functionality to ELF object files (authored by Aj0SK, committed by werat). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat created this revision. werat added a reviewer: jankratochvil. Herald added a reviewer: shafik. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Apply changes from https://reviews.llvm.

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. Herald added a subscriber: JDevlieghere. Hi @jankratochvil, can you take a look at this, please? I can't claim I fully understand what's the difference here, but this aligns with your comment at https://reviews.llvm.org/D92643#inline-900717 :) Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. To be honest, I'm not sure how to reproduce this kind of debug info. I've tried a few examples (e.g. force inline the function from another CU) , but it didn't work. Should be postpone this patch until someone can figure out the test case then? Repository: rG LLVM Git

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat updated this revision to Diff 325415. werat added a comment. Added the test cases provided by jankratochvil@ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://reviews.llvm.org/D96778 Files: lldb/source/Plugins/SymbolFile/DWA

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7ec7876feda4: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

werat added a comment. The test was also executed on `lldb-aarch64-ubuntu` -- https://lab.llvm.org/buildbot/#/changes/13868 But we have `REQUIRES: x86`, shouldn't it exclude ARM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96778/new/ https://rev

[Lldb-commits] [PATCH] D97696: [lldb] Enable cross CU decl file test only for x64 Linux

werat created this revision. werat added reviewers: jankratochvil, teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix tests after https://reviews.llvm.org/D96778 Repository: rG LLVM Github Monorepo https://reviews.llv

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

werat created this revision. werat added reviewers: JDevlieghere, labath, jankratochvil. Herald added a reviewer: shafik. werat requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Apply changes from

[Lldb-commits] [PATCH] D97696: [lldb] Enable cross CU decl file test only for x64 Linux

werat abandoned this revision. werat added a comment. The original commit was reverted, abandon in favor of https://reviews.llvm.org/D97765 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97696/new/ https://reviews.llvm.org/D97696 _

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

werat updated this revision to Diff 327469. werat added a comment. Use `clang_host` instead of `clang` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97765/new/ https://reviews.llvm.org/D97765 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTP

[Lldb-commits] [PATCH] D97765: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b47bd32f9df: [lldb] Fix handling of `DW_AT_decl_file` according to D91014 (attempt #2) (authored by werat). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

werat created this revision. werat added reviewers: teemperor, spyffe. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `memory_read_error` -> `memory_write_error` Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D9817

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

werat added a comment. I was looking into the issue with `SBValue::Persist` (https://discord.com/channels/636084430946959380/636732809708306432/817370459284832297) and the logs and errors eventually led me here to `IRInterpreter`. And the incorrect error message I noticed just by accident :)

[Lldb-commits] [PATCH] D98170: [lldb] Fix error message in IRInterpreter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b7e5d461aee: [lldb] Fix error message in IRInterpreter (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat created this revision. werat added a reviewer: teemperor. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now `SBValue::Persist()` works properly only for values that refere to variables (refer to unit-tests for an exampl

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. Herald added a subscriber: JDevlieghere. Hi @teemperor , here's an attempt to fix `SBValue::Persist` method. I've highlighted a few moments in the patch I'm not so sure about, please let me know what you think. Thanks! Comment at: lldb/source/Expression

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat updated this revision to Diff 330445. werat added a comment. Address review comments: - Don't create expensive `ConstString` objects - Merge `ParseStaticConstMemberDIE` into `ParseVariableDIE` - Add more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

werat marked 4 inline comments as done. werat added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2162 void SymbolFileDWARF::FindGlobalVariables(const RegularExpression ®ex, uint32_t max_matches

  1   2   >