werat added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2461 + bool has_scope = !scope.IsEmpty(); + llvm::StringRef sc(scope.GetStringRef()); + std::string storage; ---------------- nit: maybe call it `scope_ref`? ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2470 + const char *qn = die.GetQualifiedName(storage); + if (qn && !llvm::StringRef(qn).startswith(sc)) + return true; ---------------- `llvm::StringRef(storage)` is slightly more efficient here than `llvm::StringRef(qn)`. The latter uses strlen in the constructor to calculate the length of the source string. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
