[Lldb-commits] [PATCH] D141702: [lldb/crashlog] Make module loading use Scripted Process affordance

bulbazord accepted this revision. bulbazord added a comment. Sorry, this fell off my radar for a while. I re-read through it and it looks fine to me, the lambda vs static methods function thing doesn't really matter much. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141702/new/

[Lldb-commits] [PATCH] D157347: [lldb] Fix data race in NativeFile

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157347/new/ https://reviews.llvm.org/D157347 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D157538: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded

This revision was automatically updated to reflect the committed changes. Closed by commit rGd21ec35dcf3c: [lldb][NFCI] Remove use of ifdef __cpluplus where unneeded (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157538/new/

[Lldb-commits] [PATCH] D157654: [lldb] Fix data race in PipePosix

bulbazord added inline comments. Comment at: lldb/source/Host/posix/PipePosix.cpp:69 PipeBase::operator=(std::move(pipe_posix)); - m_fds[READ] = pipe_posix.ReleaseReadFileDescriptor(); - m_fds[WRITE] = pipe_posix.ReleaseWriteFileDescriptor(); + std::lock_guard guard(m_lock)

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My primary motivation here is actually to change so

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord added a comment. The idea seems fine to me. A few nits and comments, otherwise LGTM. Comment at: lldb/source/API/SBTarget.cpp:1517 + if (Symbols::DownloadObjectAndSymbolFile(*module_spec.m_opaque_up, error, + true)) {

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

bulbazord added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:500-503 + /// /param[out] lowmem_mask + /// Address mask to be used for low memory addresses. + /// + /// /param[out] highmem_mask `/param` -> `\param` C

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord added inline comments. Comment at: lldb/test/API/python_api/target-arch-from-module/TestTargetArchFromModule.py:39 +dwarfdump_cmd_output = subprocess.check_output( +('/usr/bin/dwarfdump --uuid "%s"' % aout_exe), shell=True +).decode("utf-8")

[Lldb-commits] [PATCH] D157659: Have SBTarget::AddModule force a possibly-slow search for the binary, and if the Target has no arch, initialize it with the binary's arch

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157659/new/ https://reviews.llvm.org/D157659 _

[Lldb-commits] [PATCH] D157667: Define qHostInfo and Mach-O LC_NOTE "addrable bits" methods to describe high and low memory addressing bits

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM. You may want to wait for Jonas to take a look before landing though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157667/new/ https

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, kastiglione, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These were useful primarily for the Python 2 t

[Lldb-commits] [PATCH] D157137: [lldb/crashlog] Skip images with empty path and 0 UUID from loading

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157137/new/ https://reviews.llvm.org/D157137 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D157760: [lldb] Properly protect the Communication class with reader/writer lock

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Communication.h:86-89 + lldb_private::Connection *GetConnection() { +std::shared_lock guard(m_connection_mutex); +return m_connection_sp.get(); + } This isn't necessarily introduced by

[Lldb-commits] [PATCH] D157849: [lldb/crashlog] Replace deprecated optparse by argparse (NFC)

bulbazord added a comment. Makes sense to me. `optparse` has been deprecated since Python 3.2 in favor of `argparse`. It's good to get ahead of the curve here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157849/new/ https://reviews.llvm.org/D157

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

bulbazord added a comment. In D157497#4586165 , @MaskRay wrote: > In D157497#4584621 , @Pivnoy wrote: > >> This discussion was the main motivation for this change. >> https://discourse.llvm.org/t/rfc-refactor-trip

[Lldb-commits] [PATCH] D157759: [lldb] Remove use of __future__ in python

This revision was automatically updated to reflect the committed changes. Closed by commit rGe634c2f71493: [lldb] Remove use of __future__ in python (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157759/new/ https://reviews.l

[Lldb-commits] [PATCH] D157122: [lldb] Remove support for SBHostOS threading functionality

bulbazord abandoned this revision. bulbazord added a comment. Landed as 69fdbdc4493aacf4d418a063930b39b02b5e18c5 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157122/new/ https

[Lldb-commits] [PATCH] D157662: [lldb][NFCI] Change parameter type in Process::SetExitStatus

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a25f97e6950: [lldb][NFCI] Change parameter type in Process::SetExitStatus (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157662/new/

[Lldb-commits] [PATCH] D158000: [lldb] Remove {Get, Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

bulbazord added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:1538-1545 +LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.") bool SBDebugger::GetCloseInputOnEOF() const { LLDB_INSTRUMENT_VA(this); - return (m_opaque_sp ? m_opaque_sp->GetCloseIn

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

bulbazord added reviewers: jingham, augusto2112, kastiglione. bulbazord added a comment. Herald added a subscriber: JDevlieghere. Adding a few relevant reviewers :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D157851: [lldb/crashlog] Add support for Last Exception Backtrace

bulbazord added inline comments. Comment at: lldb/examples/python/crashlog.py:800-806 +thread = self.crashlog.Thread( +len(self.crashlog.threads), True, self.crashlog.process_arch +) +thread.queue = "Application Specific Backtrace" +for

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jasonmolenda, jingham, mib. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I'm rewriting this for 2 reasons: 1. Although a 10

[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, kastiglione, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.ll

[Lldb-commits] [PATCH] D158026: [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, kastiglione, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://revie

[Lldb-commits] [PATCH] D158022: [lldb] Print an actionable error message when sphinx_automodapi is not installed

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. From the discussion this sounds like a reasonable thing to do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158022/new/ https://reviews.llvm.org/D158022 __

[Lldb-commits] [PATCH] D158023: [lldb] Simplify the LLDB website structure

bulbazord added a comment. I think the categories you've set are the same ones I would have created. May I suggest renaming `Extending LLDB` to `Scripting LLDB` or something similar? I think "Extending" and "Developing" are close enough in meaning that it may be confusing to end users. CHANGE

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, aprantl. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstStrings are super cheap to copy around. It is often

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

bulbazord accepted this revision. bulbazord added a comment. This is in line with my understanding of cross-compiling LLDB. It could be useful to also document some other interesting cross-compilation options like `CMAKE_TOOLCHAIN_FILE` or mention the use of CMake caches, but if you're unfamili

[Lldb-commits] [PATCH] D157556: Replace the singleton "ShadowListener" with a primary and N secondary listeners

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. Thanks for all the work to clean up some of those interfaces! I know that was not straightforward. :) I left a few more comments about minor things I noticed while re-reading t

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550812. bulbazord added a comment. Addressing @aprantl's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/Module.h lldb/so

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord added inline comments. Comment at: lldb/include/lldb/Core/Module.h:126 Module( - const FileSpec &file_spec, const ArchSpec &arch, - const ConstString *object_name = nullptr, + const FileSpec &file_spec, const ArchSpec &arch, ConstString object_name,

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550822. bulbazord added a comment. Give the parameter a default value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/Module.h lld

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

bulbazord updated this revision to Diff 550824. bulbazord added a comment. Remove `const` from parameter in DebugMapModule Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/new/ https://reviews.llvm.org/D158043 Files: lldb/include/lldb/Core/M

[Lldb-commits] [PATCH] D158024: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f382bfb14e3: [lldb][NFCI] Remove unused method overload of ValueObject::GetChildAtNamePath (authored by bulbazord). Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D158017: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote::MonitorDebugserverProcess

This revision was automatically updated to reflect the committed changes. Closed by commit rG90c5675a3db2: [lldb][NFCI] Rewrite error-handling code in ProcessGDBRemote… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158017/new

[Lldb-commits] [PATCH] D158043: [lldb][NFCI] Module constructor should take ConstString by value

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e6d48ef6085: [lldb][NFCI] Module constructor should take ConstString by value (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158043/

[Lldb-commits] [PATCH] D158026: [lldb][NFCI] Remove unneeded ConstString from ValueObject::GetValueForExpressionPath_Impl

This revision was automatically updated to reflect the committed changes. Closed by commit rG3415798f7993: [lldb][NFCI] Remove unneeded ConstString from ValueObject… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158026/new/

[Lldb-commits] [PATCH] D158209: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jasonmolenda, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is in preparation to remove the uses of ConstS

[Lldb-commits] [PATCH] D158205: [lldb] Fix performance regression after adding GNUstep ObjC runtime

bulbazord accepted this revision. bulbazord added a comment. This looks fine to me. Did you have the chance to verify that it improves performance of non-objc inferiors on Linux? We'll also probably want to make sure this gets back ported into llvm-17. Comment at: lldb/sourc

[Lldb-commits] [PATCH] D158085: [LLDB][Docs] Update cross compilation docs and examples

bulbazord added a comment. In D158085#4598601 , @DavidSpickett wrote: >> It could be useful to also document some other interesting cross-compilation >> options like CMAKE_TOOLCHAIN_FILE > > So this is the way CMake prefers you to do it, but I don't rea

[Lldb-commits] [PATCH] D158209: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef

This revision was automatically updated to reflect the committed changes. Closed by commit rG58fe7b751dc4: [lldb] Change UnixSignals::GetSignalAsCString to GetSignalAsStringRef (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D158452: [lldb/crashlog] Fix python version requirement issue

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Unfortunate but it makes the most sense for now. Thanks for fixing that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158452/new/ https:/

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, DavidSpickett, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason for GetSignalInfo to return the

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, mib, jingham, augusto2112, kastiglione, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Apple maintains a d

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

bulbazord marked 4 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Core/Mangled.cpp:61 + // Swift's older style of mangling used "_T" as a mangling prefix. This can + // lead to false positives with other symbols that just so happen to start

[Lldb-commits] [PATCH] D158470: [lldb] Add support for recognizing swift mangled names

This revision was automatically updated to reflect the committed changes. Closed by commit rGedc64d49de92: [lldb] Add support for recognizing swift mangled names (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158470/new/ http

[Lldb-commits] [PATCH] D158457: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGebff12d675aa: [lldb][NFCI] Change return type of UnixSignals::GetSignalInfo (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158457/new

[Lldb-commits] [PATCH] D157497: feat: Migrate isArch16Bit

bulbazord requested changes to this revision. bulbazord added a comment. In D157497#4592330 , @Pivnoy wrote: > At the moment, the TargetParser architecture is extensible. This complicates > the addition of new architectures, operating systems, and so on.

[Lldb-commits] [PATCH] D158785: [lldb] Add a "thread extrainfo" LC_NOTE for Mach-O corefiles, to store the thread IDs of the threads

bulbazord added a comment. The idea itself looks good to me. It would be nice if we could maintain a schema for this format in documentation or elsewhere so future code spelunkers have an idea of what the parsing and saving code are doing while they read it. Comment at: lldb

[Lldb-commits] [PATCH] D158958: [LLDB][REPL] Change the default tab size

bulbazord added a comment. I have no problem with this conceptually. I'm not sure if there are any caveats or other things that need to be updated though, so please wait for more input before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, fdeazeve, DavidSpickett. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The majority of UnixSignals strings are static in

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord added a comment. Re-organizing the paths seems okay to me, especially since this is going to grow further. I think the header guards are going to need some adjustment though. Comment at: lldb/include/lldb/Interpreter/Interfaces/ScriptedProcessInterface.h:9 -#ifnd

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

bulbazord added a comment. In D159011#4624495 , @fdeazeve wrote: > I am slightly wary of making this a global set without any kind of thread > safe mechanism, as I (naively, not really knowing how this class is used) > would expect us to be able to inst

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

bulbazord added a comment. In D159011#4625915 , @fdeazeve wrote: >> I decided to make it a global object to guarantee its lifetime independent >> of any `PlatformRemoteGDBServer` instance. I don't mind wrapping it in a >> concurrent structure to guarant

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, aprantl, fdeazeve, kastiglione, augusto2112. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a projec

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

bulbazord updated this revision to Diff 554504. bulbazord added a comment. Protect StringSet with a mutex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159011/new/ https://reviews.llvm.org/D159011 Files: lldb/include/lldb/Target/UnixSignals.h

[Lldb-commits] [PATCH] D152870: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads with ConstString

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d49c9ce6588: [lldb][NFCI] Remove StructuredData::Array::GetItemAtIndexAsString overloads… (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The primary goal of this change is to change `if (pair

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

bulbazord added inline comments. Comment at: lldb/source/Core/Section.cpp:153 + case eSectionTypeSwiftModules: +return "swift-modules"; } compnerd wrote: > kastiglione wrote: > > I wonder if this should be "swiftmodules". I have never seen it spelled > >

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString can be implicitly converted into a llvm::St

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

bulbazord added a comment. It seems like there is consensus for actually implementing this functionality but that there were some questions about the actual string. I hope everyone finds my reasoning understandable. If nobody has a strong objection to the actual string, I will land this tomorro

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord added a comment. In D158833#4626023 , @mib wrote: > In D158833#4625775 , @bulbazord > wrote: > >> Re-organizing the paths seems okay to me, especially since this is going to >> grow further. I think th

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158833/new/ https://reviews.llvm.org/D158833 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ed72d4d4d50: [lldb][NFCI] Replace bespoke iterator check with std::next (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14d95b26aee0: [lldb][NFCI] Remove unneeded ConstString conversions (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a subscriber: mgrang. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The remaining use of

[Lldb-commits] [PATCH] D159310: [lldb] Move template python files to separate directory

bulbazord added a comment. This looks fine to me. You'll probably want to wait for @JDevlieghere to take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159310/new/ https://reviews.llvm.org/D159310 ___

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG764287f1ad69: [lldb] Add support for recognizing swift ast sections in object files (authored by bulbazord). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:448 - if (!key.empty()) { -ConstString key_cs(key); -collection::const_iterator iter = m_dict.find(key_cs); fd

[Lldb-commits] [PATCH] D159315: [lldb] Add OperatingSystem base class to the lldb python module

bulbazord accepted this revision. bulbazord added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159315/new/ https://reviews.llvm.org/D159315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

lldb-commits@lists.llvm.org

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D

lldb-commits@lists.llvm.org

This revision was automatically updated to reflect the committed changes. Closed by commit rG5bff905c0de5: [lldb][NFCI] Remove unused method TypeCategoryMap::Get(uint32_t, ValueSP &) (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D159314: [lldb] Introduce OperatingSystem{, Python}Interface and make us it

bulbazord added a comment. This change seems mostly red in that we're removing a lot of things. What are the replacements? I also see you're removing the API lock acquisition in a few places, where does that now occur? Comment at: lldb/bindings/python/python-wrapper.swig:266-

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord updated this revision to Diff 556469. bulbazord marked 7 inline comments as done. bulbazord added a comment. Address feedback from @fdeazeve Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313 Files

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord added inline comments. Comment at: lldb/include/lldb/Utility/StructuredData.h:436 auto array_sp = std::make_shared(); - collection::const_iterator iter; - for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) { + for (auto iter = m_dict.begin()

[Lldb-commits] [PATCH] D159011: [lldb][NFCI] Remove use of ConstString from UnixSignals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2f377c5bd713: [lldb][NFCI] Remove use of ConstString from UnixSignals (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord added inline comments. Comment at: lldb/source/Utility/StructuredData.cpp:249-251 + llvm::sort(sorted_entries, [&](const Entry &lhs, const Entry &rhs) -> bool { +return lhs.first < rhs.first; + }); Oh I can remove this lambda too -- Let me update.

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

bulbazord updated this revision to Diff 556798. bulbazord added a comment. Remove unneeded lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ https://reviews.llvm.org/D159313 Files: lldb/include/lldb/Utility/StructuredData.h lldb

[Lldb-commits] [PATCH] D159313: [lldb][NFCI] Remove use of ConstString in StructuredData

This revision was automatically updated to reflect the committed changes. Closed by commit rGa5a2a5a3eca0: [lldb][NFCI] Remove use of ConstString in StructuredData (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159313/new/ ht

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord added a comment. In D128366#3608051 , @labath wrote: > In D128366#3605484 , @bulbazord > wrote: > >> In D128366#3603943 , @labath wrote: >> >>> Could we move th

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, JDevlieghere, labath. Herald added a subscriber: arphaman. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Context: When setting a breakpoint by name, we invoke `M

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord added a comment. In D129682#3651175 , @labath wrote: > Well.. first of let me say that the performance gain is impressive. I > wouldn't have expected to gain that much with a relatively simple change. Thank you! I am also very surprised, it tu

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 445629. bulbazord edited the summary of this revision. bulbazord added a comment. I have factored out part of `Module::LookupInfo::Prune` into its own method `Module::LookupInfo::NameMatchesLookupInfo` which I re-use in `ProcessFunctionDIE` instead of copy

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord added a comment. Friendly ping :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129682/new/ https://reviews.llvm.org/D129682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:37 +Mangled mangled_name(die.GetMangledName()); +if (!lookup_info.NameMatchesLookupInfo(mangled_name.GetDemangledName(), +

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 448472. bulbazord added a comment. Herald added a reviewer: shafik. - Expanded on NameMatchesLookupInfo to handle different scenarios when names we are comparing are mangled/demangled. - Extracted functionality from DWARFASTParserClang to construct a demang

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked 3 inline comments as done. bulbazord added inline comments. Comment at: lldb/source/Core/Module.cpp:730 +bool Module::LookupInfo::NameMatchesLookupInfo( +ConstString function_name, LanguageType language_type) const { clayborg wrote: > So th

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord marked an inline comment as done. bulbazord added inline comments. Comment at: lldb/source/Core/Module.cpp:740 + bool user_provided_name_is_mangled = + Mangled::GetManglingScheme(m_name.GetStringRef()) != + Mangled::eManglingSchemeNone; labat

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

bulbazord updated this revision to Diff 449350. bulbazord edited the summary of this revision. bulbazord added a comment. Simplify `Module::LookupInfo::NameMatchesLookupInfo`. Perform an initial check to see if the name matches, and if not, do the more expensive demangling operation. CHANGES S

[Lldb-commits] [PATCH] D129682: [lldb] Filter DIEs based on qualified name when possible

This revision was automatically updated to reflect the committed changes. Closed by commit rGbefa77e59a77: [lldb] Filter DIEs based on qualified name where possible (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129682/new/ h

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, clayborg, jingham, labath. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Module::LookupInfo::Prune tries to prune results from lookups that don't match the user-provi

[Lldb-commits] [PATCH] D128366: [lldb] Make Module::LookupInfo::Prune language-agnostic

bulbazord added a comment. In D128366#3603943 , @labath wrote: > How hot is this code? Parsing a demangled name isn't entirely cheap, and the > fact that the objc++ class calls back into the c++ version means that the c++ > name will be parsed twice. N

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

bulbazord added a comment. The idea of the patch seems fine to me. One thing that I thought about is creating a `PlatformSpec` struct that can contain all the needed configuration for `CreateInstance`/`GetOrCreate`. What do you think of this? Comment at: lldb/source/API/SBDeb

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

bulbazord added inline comments. Comment at: lldb/bindings/python/python-wrapper.swig:353-354 + } else { +error_string.assign("wrong number of arguments in __init__, should be 2 " +"(not including self)"); + } I think the error strin

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

bulbazord added inline comments. Comment at: lldb/include/lldb/Interpreter/ScriptedPlatformInterface.h:14 +#include "lldb/Interpreter/ScriptedInterface.h" +#include "lldb/Target/MemoryRegionInfo.h" + What is `MemoryRegionInfo.h` for? Comment at

[Lldb-commits] [PATCH] D139252: [lldb/Plugins] Introduce Scripted Platform Plugin

bulbazord added a comment. There's some overlap in implementation between `ScriptedPlatform::GetProcessInfo` and `ScriptedPlatform::FindProcesses`. If you don't anticipate these diverging dramatically, it might make sense to extract out common functionality into something like `ScriptedPlatfor

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord requested changes to this revision. bulbazord added a comment. This revision now requires changes to proceed. I think that the idea you've laid out in the summary makes sense but the implementation seems off. My understanding of `std::condition_variable` is that combined with `std::mut

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/main.cpp:18 + std::unique_lock lock(mutex); + cv.notify_one(); + n = foo(n); Why do you need this initial notification? Comment at: lldb/test/API/fun

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139249/new/ https://reviews.llvm.org/D139249 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedPlatformPythonInterface.cpp:97 + +#endif nit: This `#endif` should have a ` // L

<    1   2   3   4   5   6   7   8   9   10   >