bulbazord marked an inline comment as done. bulbazord added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:37 + Mangled mangled_name(die.GetMangledName()); + if (!lookup_info.NameMatchesLookupInfo(mangled_name.GetDemangledName(), + lookup_info.GetLanguageType())) ---------------- clayborg wrote: > So this looks like this can be called with an empty named since not all DIEs > have mangled names. Do we not want to try and calculate the demangled name > here if the mangled name is empty? Yes, we probably do want to calculate the demangled name here. The previous version of this patch had a function `GetQualifiedNameWithParams` that tried to calculate the fully qualified demangled name but I think it probably needed a little more work. I can bring that back unless you can think of a different way to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129682/new/ https://reviews.llvm.org/D129682 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
