[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. Let me know how you feel about this abstraction/idea. I think we'll need something like this at some point to remove most of the remaining dependencies (e.g. in Module.cpp) so I'd like to get something good going here. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. In D103210#2784645 , @teemperor wrote: > +1 to not add any language-specific terms to the Language API. > > Looking over the code, it seems what the code is doing its: > > - Going over the symbol names. > - Creating a search ind

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

bulbazord created this revision. bulbazord added reviewers: teemperor, JDevlieghere. Herald added a subscriber: arphaman. bulbazord requested review of this revision. Herald added a project: LLDB. The various maps in Symtab lead to some repetative code. This should improve the situation somewhat.

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord added a comment. In D103210#2795619 , @teemperor wrote: >> We have a method called `Language::GetMethodNameVariants`, that could be >> extended/modified to be more suitable. Unless you had something else in >> mind? Maybe something more specif

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

bulbazord updated this revision to Diff 350404. bulbazord added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103652/new/ https://reviews.llvm.org/D103652 Files: lldb/include/lldb/Symbol/Symtab.h lldb/source/Symbol/

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

bulbazord updated this revision to Diff 350405. bulbazord added a comment. Remove unused line of code that I forgot to remove previously Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103652/new/ https://reviews.llvm.org/D103652 Files: lldb/inclu

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

bulbazord updated this revision to Diff 350685. bulbazord added a comment. Rename function :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103652/new/ https://reviews.llvm.org/D103652 Files: lldb/include/lldb/Symbol/Symtab.h lldb/source/Symbo

[Lldb-commits] [PATCH] D103652: [lldb][NFC] Refactor name to index maps in Symtab

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64576a1be887: [lldb][NFC] Refactor name to index maps in Symtab (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord created this revision. bulbazord added a reviewer: teemperor. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We can extend/modify `GetMethodNameVariants` to suit our purposes here. Wha

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. Herald added a subscriber: JDevlieghere. Note that this is working towards solving the same problem as D103210 but it does so in a different way. Instead of repurposing the old diff, I made a new one so it is a little easier to compa

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord updated this revision to Diff 351696. bulbazord added a comment. Addressing comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 Files: lldb/include/lldb/Target/Language.h lldb/source/Br

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord updated this revision to Diff 353484. bulbazord added a comment. Addressed comments! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 Files: lldb/include/lldb/Target/Language.h lldb/source

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bebc0b177d0: [lldb] Decouple ObjCLanguage from Symtab (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D103210: [lldb] Introduce Language::MethodNameInfo

bulbazord abandoned this revision. bulbazord added a comment. Not going with this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103210/new/ https://reviews.llvm.org/D103210 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord created this revision. bulbazord added reviewers: teemperor, jingham. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The only remaining plugin dependency in Mangled is CPlusPlusLanguage which it uses to extract informat

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. Herald added a subscriber: JDevlieghere. I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may be a bit too specific for a generalized language plugins. I think it may be worth it to make `Mangled` an interface that language plugins can implement

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

bulbazord created this revision. bulbazord added reviewers: wallace, clayborg. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. These two classes, TraceSessionFileParser and ThreadPostMortemTrace, seem to be useful primarily for tracing.

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. In D105215#2850988 , @jingham wrote: > In D105215#2850821 , @bulbazord > wrote: > >> I kind of feel that `Language::GetDemangledFunctionNameWithoutArguments` may >> be a bit too specif

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

bulbazord updated this revision to Diff 360542. bulbazord added a comment. Updating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105649/new/ https://reviews.llvm.org/D105649 Files: lldb/include/lldb/Target/ThreadPostMortemTrace.h lldb/include

[Lldb-commits] [PATCH] D105649: [LLDB] Move Trace-specific classes into separate library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e6b31c3952b: [LLDB] Move Trace-specific classes into separate library (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. ping! @jingham I can change the name to `GetFullyQualifiedBaseName` if needed. Is there anything else here that should be changed or addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105215/new/ https://reviews.l

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added inline comments. Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArguments) { -return GetDemangledNameWithoutArguments(m_mangled, demangled); +if (Language *lang = Language::FindPlugin(GuessLanguage())) { + ret

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

bulbazord added a comment. Thanks for the reviews and comments! It's kind of unfortunate that LLDB is like this right now but I believe this patch is a step in the right direction. :) Comment at: lldb/source/Core/Mangled.cpp:322 if (preference == ePreferDemangledWithoutArgu

[Lldb-commits] [PATCH] D105215: [lldb] Remove CPlusPlusLanguage from Mangled

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG993220a99cce: [lldb] Remove CPlusPlusLanguage from Mangled (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

bulbazord added a comment. I like the idea! Could be a little cleaner imo, but shouldn't be a blocker if others don't think so. Comment at: lldb/include/lldb/Core/Module.h:62 +/// because it must be forward-declared in ModuleList.h. +struct ModuleFunctionOptions { + /// Inclu

[Lldb-commits] [PATCH] D107206: [lldb] Refactor IRExecutionUnit::FindInSymbols (NFC)

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Yeah this is a lot cleaner. Thanks for taking the time to refactor this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107206/new/ https://reviews.llvm.org/D107206

[Lldb-commits] [PATCH] D107295: [lldb] Use a struct to pass function search options to Module::FindFunction

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107295/new/ https://reviews.llvm.org/D107295 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. Module::LookupInfo's constructor currently goes over supported languages trying to figure out the

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord updated this revision to Diff 367244. bulbazord added a comment. Delete now unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108229/new/ https://reviews.llvm.org/D108229 Files: lldb/include/lldb/Core/Module.h lldb/includ

[Lldb-commits] [PATCH] D108335: [lldb] Move UnixSignals subclasses to lldbTarget

bulbazord created this revision. bulbazord added reviewers: LLDB, clayborg, jingham, teemperor, JDevlieghere. Herald added subscribers: atanasyan, jrtc27, mgorny, sdardis, emaste. bulbazord requested review of this revision. Herald added a project: LLDB. I have created this change as a way to soli

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord created this revision. bulbazord added reviewers: clayborg, jingham, teemperor, JDevlieghere. Herald added a subscriber: mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. My goal is to remove lldbExpression's dependence on lldbPluginCPlusPlusLanguage. I

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord added a comment. In D108395#2957194 , @teemperor wrote: > I'm very supportive of the idea that we delete everything that isn't tested > :) (and I'm only partly joking here). I can sympathize, I'm only partly serious with this change! :D > How

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord added a comment. ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108229/new/ https://reviews.llvm.org/D108229 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.or

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:73 + llvm::StringRef basename = method.GetBasename(); + if (basename.empty()) { +if (CPlusPlusLanguage::ExtractContextAndIdentifier( jingham wrote: > T

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2134e42aa7: [lldb] Refactor Module::LookupInfo constructor (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord added a comment. In D108229#2966405 , @aprantl wrote: > FYI (you may have have already noticed) this causes some merge conflicts in > swift-lldb. It would be great if we could work together to figure out how to > best resolve them. Yes, I fig

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord added a comment. Embarassingly I found out my test environment was not working correctly, this does indeed fail some tests. I will upload a patch to actually refactor it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108395/new/ https:

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

bulbazord created this revision. bulbazord added reviewers: jingham, teemperor, JDevlieghere, clayborg, aprantl. bulbazord requested review of this revision. Herald added a project: LLDB. It is easy to accidentally introduce a deadlock by having the callback passed to Language::ForEach also attemp

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

bulbazord added a comment. For further context, I encountered this when debugging the test failures from D108229 . `BreakpointResolverName::AddNameLookup` constructs a `Module::LookupInfo` in a callback that it passes to `Language::ForEach`. Repository: rG

[Lldb-commits] [PATCH] D109013: [lldb] Tighten lock in Language::ForEach

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG862a311301f5: [lldb] Tighten lock in Language::ForEach (authored by bulbazord). Changed prior to commit: https://reviews.llvm.org/D109013?vs=36975

[Lldb-commits] [PATCH] D74245: [lldb/Plugins] Use external functions to (de)initialize plugins

xiaobai accepted this revision. xiaobai added a comment. I like where this is going! Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74245/new/ https://reviews.llvm.org/D74245 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D73016: [lldb/CMake] Make it possible to disable plugins at configuration time

xiaobai added a comment. I like the idea! The one thing that kind of bothers me about this is you can inadvertently break your build without realizing by disabling a plugin that some enabled plugins depend on. Hopefully one day we'll be able to improve the diagnostics around this. CHANGES SIN

[Lldb-commits] [PATCH] D75562: Add an opque payload field to lldb::Type (NFC).

xiaobai added a comment. Thanks for working to make LLDB more language-agnostic! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75562/new/ https://reviews.llvm.org/D75562 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D75680: [lldb] Delete UnwindMacOSXFrameBackchain

xiaobai accepted this revision. xiaobai added a comment. LGTM. If UnwindLLDB is //the// unwinder, that makes things a little easier for plugin separation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75680/new/ https://reviews.llvm.org/D75680

[Lldb-commits] [PATCH] D75848: [lldb] Make UnwindLLDB a non-plugin

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Thanks for doing this. LGTM, might want to wait for Jason's approval like Jonas said though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D758

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

xiaobai added a comment. > we need to build our own and tell LLVM to use it To clarify, this means we'd be building our own llvm-lit and using that just for the LLDB test suite, correct? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76945/new/ https://reviews.llvm.org/D76945 __

[Lldb-commits] [PATCH] D76945: [lldb/CMake] Make check-lldb-* work for the standalone build.

xiaobai added a comment. In D76945#1947034 , @JDevlieghere wrote: > In D76945#1946988 , @xiaobai wrote: > > > > we need to build our own and tell LLVM to use it > > > > To clarify, this means we'd be building our o

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

bulbazord created this revision. bulbazord added reviewers: teemperor, shafik, labath. Herald added subscribers: yaxunl, mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. More decoupling of plugins and non-plugins. Target doesn't need to manage ClangModulesDeclVend

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

bulbazord added a comment. In D79752#2769664 , @teemperor wrote: > Replaced by D102811 and Alex has > apparently a new account, so closing this. Yes, thank you for doing that. Forgot about this one. :) Repository: r

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

bulbazord updated this revision to Diff 346841. bulbazord added a comment. Add helper in ClangASTSource Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102811/new/ https://reviews.llvm.org/D102811 Files: lldb/include/lldb/Target/Target.h lldb/so

[Lldb-commits] [PATCH] D62732: [WIP][RISCV] Initial port of LLDB for RISC-V

xiaobai added subscribers: compnerd, xiaobai. xiaobai added a reviewer: compnerd. xiaobai added a comment. @compnerd You might be interested in this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62732/new/ https://reviews.llvm.org/D62732 __

[Lldb-commits] [PATCH] D68612: [CMake] Track test dependencies with add_lldb_test_dependency

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. Looks good to me. I find it interesting that we had an lldb-test-deps custom target before but most things were depending on `${LLDB_TEST_DEPS}` anyway. Repository: rLLDB LLDB CHANGES SI

[Lldb-commits] [PATCH] D68613: [CMake] Fix building without python on Windows

xiaobai created this revision. xiaobai added reviewers: stella.stamenova, JDevlieghere, labath, mgorny. Herald added a project: LLDB. find_python_libs_windows might set LLDB_DISABLE_PYTHON to ON. Unfortunately we do not re-check this variable before using variables filled in by find_python_libs_wi

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

xiaobai added a reviewer: JDevlieghere. xiaobai added a comment. @JDevlieghere has been touching similar things today. You should coordinate with him on this change. Comment at: lit/CMakeLists.txt:64 ) +if(NOT LLDB_BUILT_STANDALONE) + list(APPEND LLDB_TEST_DEPS llvm-strip)

[Lldb-commits] [PATCH] D68613: [CMake] Fix building without python on Windows

xiaobai closed this revision. xiaobai added a comment. rL374100 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68613/new/ https://reviews.llvm.org/D68613 ___ lldb-com

[Lldb-commits] [PATCH] D68614: [LLDB] Remove standalone build dep on llvm-strip

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68614/new/ https://reviews.llvm.org/D68614 ___ lldb-commi

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

xiaobai added a comment. I thought this option was so that you could specify which compilers to use to build from a cache or command line? I don't think you just want to set `LLDB_TEST_COMPILER` to `clang` since `clang++` is what is used to compile C++ code. Maybe I'm mis-remembering or mistake

[Lldb-commits] [PATCH] D69401: [CMake] Remove unused variable LLDB_TEST_CXX_COMPILER

xiaobai accepted this revision. xiaobai added a comment. In D69401#1720494 , @JDevlieghere wrote: > In D69401#1720432 , @xiaobai wrote: > > > I thought this option was so that you could specify which compilers to u

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath, compnerd. Herald added a project: LLDB. Instead of filling out a std::string and returning a bool to indicate success, returning a std::string directly and testing to see if it's empty seems like a cleaner solution overa

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai added a comment. In D69641#1727787 , @teemperor wrote: > Could this return an `Optional` or `Expected`? It's > not clear from a `std::string` return value that the method can fail and it > will return an empty string on error. That sounds like

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

xiaobai updated this revision to Diff 227188. xiaobai added a comment. Use llvm::Optional Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ https://reviews.llvm.org/D69641 Files: lldb/include/lldb/Symbol/ClangASTContext.h lldb/source/Co

[Lldb-commits] [PATCH] D69641: [Symbol] Change ClangASTContext::GetCXXClassName return type

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb542455dc0f: [Symbol] Change ClangASTContext::GetCXXClassName return type (authored by xiaobai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69641/new/ h

[Lldb-commits] [PATCH] D69820: [Symbol] Add TypeSystem::GetClassName

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, labath, compnerd, teemperor. Herald added a project: LLDB. This will generalize some behavior in ValueObject. Although this code path is still specific to C++, it no longer references ClangASTContext directly. This will allow us

[Lldb-commits] [PATCH] D64844: [Target] Remove Target::GetScratchClangASTContext

xiaobai updated this revision to Diff 229418. xiaobai added a comment. Herald added a project: LLDB. Rebased Moved this change to the monorepo layout Moved `ClangASTContext::GetScratch` to the ClangASTContext header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D64771: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up

This revision was automatically updated to reflect the committed changes. Closed by commit rL366770: [lldb][test_suite] skip tests of `libstdcpp` on Android and clean up (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[Lldb-commits] [PATCH] D64583: [lldb][test_suite] Fix skipIfTargetAndroid decorator

This revision was automatically updated to reflect the committed changes. Closed by commit rL366771: [lldb][test_suite] Fix skipIfTargetAndroid decorator (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D64042: [Symbol] Improve Variable::GetLanguage

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/trunk/source/Symbol/Variable.cpp:61-69 + if (auto *func = m_owner_scope->CalculateSymbolContextFunction()) { +if ((lang = func->GetLanguage()) && lang != lldb::eLanguageTypeUnknown) +

[Lldb-commits] [PATCH] D65155: [lldb] Remove Xcode project legacy

xiaobai added a comment. In D65155#1597710 , @JDevlieghere wrote: > In D65155#1597657 , @lanza wrote: > > > Not directly related, but there's some other legacy cruft I figure are > > valid for removal. e.g. > > >

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai created this revision. xiaobai added a reviewer: labath. Herald added a reviewer: jdoerfert. I messed up the logic for this. Fixing with some improvements suggested by Pavel. https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp

[Lldb-commits] [PATCH] D64767: [lldb][test_suite] Update tests with unexpected pass on Android aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL366858: [lldb][test_suite] Update tests with unexpected pass on Android aarch64 (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai marked 4 inline comments as done. xiaobai added inline comments. Comment at: source/Core/ValueObjectRegister.cpp:261 + if (auto *exe_module = target->GetExecutableModulePointer()) { +if (auto type_system_or_err = +exe_module->GetTypeSystemForL

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

xiaobai updated this revision to Diff 211607. xiaobai added a comment. Implement suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65165/new/ https://reviews.llvm.org/D65165 Files: source/Symbol/Variable.cpp Index: source/Symbol/Variable.cpp =

[Lldb-commits] [PATCH] D65165: [Symbol] Fix some botched logic in Variable::GetLanguage

This revision was automatically updated to reflect the committed changes. Closed by commit rL366950: [Symbol] Fix some botched logic in Variable::GetLanguage (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

[Lldb-commits] [PATCH] D65185: Let tablegen generate property definitions

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I think this is fine. Using `.def` files would be okay too, but I like the sanity checks that Jonas introduced in the LLDBPropertyDefEmitter CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. After going through this and modifying this patch, I can't help but wonder if `llvm::Optional` would be more appropriate. There are plenty of instances where it's not a hard error if you can't get a TypeSystem and the appropriate action is probably just to log and move

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. I'm going to update this diff with what I changed to give y'all a better idea of what has been changed. I shoulda done that to begin with... :P In D65122#1602145 , @labath wrote: > In D65122#1602067

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212031. xiaobai added a comment. Address comments: - Use Expected - Did some formatting - Made error checking more explicit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212210. xiaobai added a comment. Fix incorrect error logging pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h include/lldb/Symb

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added a comment. In D65122#1604352 , @labath wrote: > I have one remark about the consumeError+LLDB_LOG pattern. As for whether > this is better than status quo or not, I still don't have an opinion on that. > :) Thanks for pointing out LLDB_LO

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai added inline comments. Comment at: source/API/SBModule.cpp:525 module_sp->GetTypeSystemForLanguage(eLanguageTypeC); - if (type_system) { -CompilerType compiler_type = type_system->GetBuiltinTypeByName(name); + if (auto err = type_system_or_err

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

xiaobai updated this revision to Diff 212232. xiaobai added a comment. Small logic change in SBModule CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65122/new/ https://reviews.llvm.org/D65122 Files: include/lldb/Core/Module.h include/lldb/Symbol/SymbolFile.h include/lldb/Symbol/Ty

[Lldb-commits] [PATCH] D62213: [ABI] Implement Windows ABI for x86_64

xiaobai added a comment. In D62213#1605521 , @asmith wrote: > I think this change has introduced a dependence on x64. > > I tried building with the 32b Visual Studio compiler and there are a number > of undefined registers in registercontextwindows_x64.cp

[Lldb-commits] [PATCH] D65450: Add llvm-style RTTI to ObjectFile hierarchy

xiaobai accepted this revision. xiaobai added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65450/new/ https://reviews.llvm.org/D65450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [PATCH] D65122: [Symbol] Use llvm::Expected when getting TypeSystems

This revision was automatically updated to reflect the committed changes. Closed by commit rL367360: [Symbol] Use llvm::Expected when getting TypeSystems (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212482. xiaobai added a comment. Update GetScatchTypeSystems to account for changes to TypeSystem usage CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTa

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

xiaobai updated this revision to Diff 212483. xiaobai added a comment. Removed argument to GetScratchTypeSystems from SBTarget CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64964/new/ https://reviews.llvm.org/D64964 Files: include/lldb/Target/Target.h source/API/SBTarget.cpp sour

[Lldb-commits] [PATCH] D64964: [API] Remove use of ClangASTContext from SBTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rL367480: [API] Remove use of ClangASTContext from SBTarget (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[Lldb-commits] [PATCH] D66093: [Symbol] GetTypeBitAlign() should return None in case of failure.

xiaobai accepted this revision. xiaobai added a comment. This revision is now accepted and ready to land. I appreciate you adding more error handling. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66093/new/ https://reviews.llvm.org/D660

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai created this revision. xiaobai added reviewers: compnerd, aprantl, JDevlieghere, davide. Herald added a project: LLDB. xiaobai added a reviewer: labath. Ideally CompilerType would have no knowledge of clang or any individual TypeSystem. Decoupling clang is relatively straightforward. Rep

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

This revision was automatically updated to reflect the committed changes. Closed by commit rL368741: [Symbol] Decouple clang from CompilerType (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[Lldb-commits] [PATCH] D66174: [Utility] Reimplement RegularExpression on top of llvm::Regex

xiaobai added a comment. I like the idea of using something from llvm instead of rolling our own. The code changes look relatively simple and straightforward, so that's good. Comment at: lldb/source/Commands/CommandObjectBreakpoint.cpp:685 RegularExpression regexp(m_o

[Lldb-commits] [PATCH] D65363: [lldb-vscode] add `launchCommands` to handle launch specific commands

This revision was automatically updated to reflect the committed changes. Closed by commit rL369296: [lldb-vscode] add `launchCommands` to handle launch specific commands (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[Lldb-commits] [PATCH] D66448: Include "windows" Instead of "Windows"

xiaobai accepted this revision. xiaobai added a comment. Case-sensitive filesystems lol Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66448/new/ https://reviews.llvm.org/D66448 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, labath. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: LLDB. This introduces a layer between DeclVendor and the currently implemented DeclVendors (ClangM

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

xiaobai marked an inline comment as done. xiaobai added inline comments. Comment at: lldb/include/lldb/Symbol/DeclVendor.h:27 +eAppleObjCDeclVendor, +eLastClangDeclVendor, + }; JDevlieghere wrote: > What's `eLastClangDeclVendor` and where is it used? Fol

[Lldb-commits] [PATCH] D66451: [ClangExpressionParser] Add ClangDeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369424: [ClangExpressionParser] Add ClangDeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[Lldb-commits] [PATCH] D66102: [Symbol] Decouple clang from CompilerType

xiaobai added a comment. I wouldn't mind adding something to reduce boilerplate, but I'm not sure it would actually look too different. A wrapper function or subclass constructor would need to take a ClangASTContext and a clang::QualType so we could avoid calls to `getAsOpaquePtr()` everywhere

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

xiaobai created this revision. xiaobai added reviewers: JDevlieghere, clayborg, jingham, teemperor. Herald added subscribers: kadircet, arphaman, mgorny. Herald added a project: LLDB. This removes DeclVendor's dependency on clang (and ClangASTContext). DeclVendor has no need to know about specific

[Lldb-commits] [PATCH] D66628: [Symbol] Decouple clang from DeclVendor

This revision was automatically updated to reflect the committed changes. Closed by commit rL369735: [Symbol] Decouple clang from DeclVendor (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

<    6   7   8   9   10   11   12   13   14   >