xiaobai added a comment.

In D69641#1727787 <https://reviews.llvm.org/D69641#1727787>, @teemperor wrote:

> Could this return an `Optional<std::string>` or `Expected<std::string>`? It's 
> not clear from a `std::string` return value that the method can fail and it 
> will return an empty string on error.


That sounds like a better idea to me. Will do that instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69641/new/

https://reviews.llvm.org/D69641



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to