[Lldb-commits] [PATCH] D43647: Generate most of the target properties from a central specification.

aprantl abandoned this revision. aprantl added a comment. A Repository: rL LLVM https://reviews.llvm.org/D43647 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added inline comments. Comment at: lldb/source/Target/StackFrameList.cpp:331 +dfs(next_callee); +if (ambiguous) + return; On what path can this happen? Aren't all paths that set `ambiguous=true` returning immediately? =

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:13 +# Set inputs empty, if not passed from the Python script. +CFLAGS ?= +LDFLAGS ?= This is a noop. You can remove it without affecting anything. ==

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:22 +# Everything goes as .o files directly to the linker +C_SOURCES := + dexonsmith wrote: > aprantl wrote: > > same here, just remove it > I haven't read the ful

[Lldb-commits] [PATCH] D52375: [WIP] Support multiple compile units per OSO entry in SymbolFileDWARFDebugMap

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/macosx/debug_map/Makefile:30 +main.o: main.c + $(CC) -c -g $(CFLAGS) $(CFLAGS_MAIN) -o main.o $(SRCDIR)/main.c + sgraenitz wrote: > aprantl wrote: > > ` $(CC) -c $(CFLAGS) $(CFLAGS_M

[Lldb-commits] [PATCH] D52678: DWARFExpression: Resolve file addresses in the linked module

aprantl updated this revision to Diff 167827. aprantl added a comment. Thanks, that was excellent feedback! Updated the patch to set the expression's module instead. https://reviews.llvm.org/D52678 Files: include/lldb/Expression/DWARFExpression.h packages/Python/lldbsuite/test/functionalit

[Lldb-commits] [PATCH] D52678: DWARFExpression: Resolve file addresses in the linked module

aprantl added a comment. I could move it further up in the same function if that is what you mean? Then it would also apply to (hypothetical local variables that refer to a DW_OP_addr). I could imagine that this might be useful in some languages that want to refer to some static type metadata.

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added a comment. This looks pretty good! I have one last question about CallEdge inside. Comment at: lldb/include/lldb/Symbol/Function.h:304 +public: + CallEdge(const char *mangled_name, lldb::addr_t return_pc); + Does this also work for C functions? I

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

aprantl added inline comments. Comment at: source/Interpreter/CommandInterpreter.cpp:2733 + + const char *k_space_characters = "\t\n\v\f\r "; + size_t first_non_space = line.find_first_not_of(k_space_characters); sgraenitz wrote: > sgraenitz wrote: > > shafik w

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/Function.h:304 +public: + CallEdge(const char *mangled_name, lldb::addr_t return_pc); + vsk wrote: > vsk wrote: > > aprantl wrote: > > > Does this also work for C functions? If yes, would `symbo

[Lldb-commits] [PATCH] D50478: Add support for artificial tail call frames

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks! https://reviews.llvm.org/D50478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D52788: Add EchoCommentCommands to CommandInterpreterRunOptions in addition to the existing EchoCommands and expose both as interpreter settings.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. One final inline comment but otherwise I think this is good to go. Thanks! Comment at: lit/Settings/Resources/EchoCommandsAll.out:1 +# CHECK: (lldb) command source -s {{.*\

[Lldb-commits] [PATCH] D53010: Add an alias "var" for "frame var" and "vo" for "frame var -O"

aprantl added a comment. Currently `v` is an alias for `version`. I'd wager that — compared to printing a variable — LLDB user's almost never want to print LLDB's version. Would it make sense to re-purpose the single-letter `v` abbreviation for the much more frequently used `frame variable` act

[Lldb-commits] [PATCH] D53255: Fix: Assertion failed: (!m_first_die || m_first_die == m_die_array.front()), function ExtractDIEsRWLocked

aprantl added a comment. Out of curiosity: why do we allow for both an empty array and an empty children sentinel? Is that distinction useful? Repository: rLLDB LLDB https://reviews.llvm.org/D53255 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl created this revision. aprantl added reviewers: jingham, clayborg. aprantl added a project: LLDB. Herald added a subscriber: JDevlieghere. Clang recently improved its DWARF support for C VLA types. The DWARF now looks like this: 0x0051: DW_TAG_variable [4]

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl updated this revision to Diff 170526. aprantl added a comment. Factor out caching of types as suggested. Thanks! https://reviews.llvm.org/D53530 Files: include/lldb/Symbol/SymbolFile.h include/lldb/Symbol/Variable.h packages/Python/lldbsuite/test/lang/c/vla/Makefile packages/Pyt

[Lldb-commits] [PATCH] D44603: [lldb] Introduce StackFrameRecognizer

aprantl added inline comments. Comment at: include/lldb/Target/StackFrameRecognizer.h:25 + +class RecognizedStackFrame +: std::enable_shared_from_this { Would you mind adding doxygen comments to each of the new classes to explain what they are good for? ht

[Lldb-commits] [PATCH] D53140: [LLDB] - Add support for DW_RLE_base_address and DW_RLE_offset_pair entries (.debug_rnglists)

aprantl added a comment. It looks like this might have broken the bots, could you please take a look? http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/11671/consoleFull#434797663d489585b-5106-414a-ac11-3ff90657619c TEST 'lldb :: Breakpoint/debug_rnglist_rlestartend

[Lldb-commits] [PATCH] D48226: [lldb] Remove enableThreadSanitizer from shared Xcode schemes

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Seems reasonable. https://reviews.llvm.org/D48226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [PATCH] D47889: Use llvm::VersionTuple instead of manual version marshalling

aprantl added a comment. Just FYI, I just came across this patch while debugging strangeness in PlatformDarwin.cpp and unfortunately this patch isn't NFC. `VersionTuple::tryParse()` can deal with an optional third (micro) component, but the parse will fail when there are extra characters after

[Lldb-commits] [PATCH] D53677: Fix a bug PlatformDarwin::SDKSupportsModule

aprantl created this revision. aprantl added reviewers: jingham, clayborg, labath. This fixes a bug PlatformDarwin::SDKSupportsModule introduced by https://reviews.llvm.org/D47889. VersionTuple::tryParse() can deal with an optional third (micro) component, but the parse will fail when there are

[Lldb-commits] [PATCH] D53709: Get rid of C-style cast.

aprantl created this revision. aprantl added a reviewer: shafik. This addresses review feedback from https://reviews.llvm.org/D53677. https://reviews.llvm.org/D53709 Files: source/Plugins/Platform/MacOSX/PlatformDarwin.cpp source/Plugins/Platform/MacOSX/PlatformDarwin.h Index: source/Plug

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. I now spent (way too much :-) time experimenting with alternative implementations of this patch. In https://reviews.llvm.org/D53961 there is a version that changes GetNumChildren() to take an execution context. I don't think that doing it this way is a good solution eit

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. To me a VLA fulfills all properties of a dynamic type so not modeling it as a dynamic type feels backwards to me. But not having to deal with temporary clang types might be worth the trade-off. > The only other thing you would need to change to get the usability back in

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. > I didn't realize that the string int [] is produced by ValueObject itself; I > think this makes this option more palatable to me. I'll give it a try. So, it turns out it isn't. The only way to get the length into the typename is to hack ClangASTContext::GetTypeName to

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl updated this revision to Diff 172388. aprantl added a comment. Herald added subscribers: kbarton, nemanjai. Version that only overrides GetNumChildren to avoid creating dynamic clang types. https://reviews.llvm.org/D53530 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Sy

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. Fair point. So here's a version that only overrides GetNumChildren(). I'll leave the type summary for a follow-up patch. https://reviews.llvm.org/D53530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl updated this revision to Diff 172390. aprantl added a comment. Fix a bug in the testcase. https://reviews.llvm.org/D53530 Files: include/lldb/Symbol/ClangASTContext.h include/lldb/Symbol/CompilerType.h include/lldb/Symbol/GoASTContext.h include/lldb/Symbol/JavaASTContext.h inc

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is great! Why not just call it `--jit`? Repository: rLLDB LLDB https://reviews.llvm.org/D54056 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D54056: Add SetAllowJIT (the SBExpressionOptions equivalent of "expression --allow-jit")

aprantl added a comment. Ah, I didn't realize that the behavior is to always try to interpret first. Repository: rLLDB LLDB https://reviews.llvm.org/D54056 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. Thanks for your patience! Repository: rL LLVM https://reviews.llvm.org/D53530 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53530: Fix (and improve) the support for C99 variable length array types

aprantl added a comment. In https://reviews.llvm.org/D53530#1290664, @stella.stamenova wrote: > TestVla fails on Windows: > http://lab.llvm.org:8014/builders/lldb-x64-windows-ninja/builds/1129/steps/test/logs/stdio > > AssertionError: False is not True : 'frame var vla' returns expected > res

[Lldb-commits] [PATCH] D54333: [CMake] Allow version overrides with -DLLDB_VERSION_MAJOR/MINOR/PATCH/SUFFIX

aprantl added a comment. Seems reasonable! https://reviews.llvm.org/D54333 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D54444: [CMake] Use extended llvm_codesign to pass entitlements for lldb-server

aprantl added a comment. Why does lldb-server need to be signed? I was under the impression that on macOS lldb-server is not used? Or are we building it for testing and need sign it because of that? https://reviews.llvm.org/D5 ___ lldb-commits

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. > Removal of functionality - The lit test suite no longer respects > LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER. This means there is no more > support for gcc, but nobody was using this anyway (note: The functionality is > still there for the dotest suite, just not

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. There is also this bot that does something similar with even more compilers, including gcc: http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/31242 Do you happen to know who maintains it? https://reviews.llvm.org/D54567 ___

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote: > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST_CXX_COMPILER from > the cmake files along with this change, otherwise, people will still expect > them to work. That would not be a good ide

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. In https://reviews.llvm.org/D54567#123, @stella.stamenova wrote: > In https://reviews.llvm.org/D54567#122, @aprantl wrote: > > > In https://reviews.llvm.org/D54567#1299989, @stella.stamenova wrote: > > > > > We should also remove LLDB_TEST_C_COMPILER and LLDB_TEST

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. In https://reviews.llvm.org/D54567#127, @zturner wrote: > It's possible I didn't make this part clear enough. I didn't mean that > nobody is using `LLDB_TEST_C_COMPILER`, I meant that nobody is using it **in > order to compile inferiors with gcc**. There is also a

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. In https://reviews.llvm.org/D54567#130, @zturner wrote: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-clang-5.0.2/ > > What do I need to click on to get the equivalent of this: > http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/312

[Lldb-commits] [PATCH] D54567: Fix LLDB's lit files

aprantl added a comment. In https://reviews.llvm.org/D54567#1300035, @zturner wrote: > In https://reviews.llvm.org/D54567#1300028, @aprantl wrote: > > > In https://reviews.llvm.org/D54567#127, @zturner wrote: > > > > > It's possible I didn't make this part clear enough. I didn't mean that >

[Lldb-commits] [PATCH] D54601: Makefile.rules: Use a shared clang module cache directory.

aprantl created this revision. aprantl added reviewers: JDevlieghere, davide, jingham, vsk. Just to be safe, up until now each test used its own Clang module cache directory. Since the compiler within one testsuite doesn't change it is just as safe to share a clang module directory inside the LLDB

[Lldb-commits] [PATCH] D54602: Use a shared module cache directory for LLDB.

aprantl created this revision. aprantl added reviewers: JDevlieghere, davide, jingham, vsk. aprantl added a dependency: D54601: Makefile.rules: Use a shared clang module cache directory.. This saves about 3 redundant gigabytes from the Objective-C test build directories. Tests that must do unsavo

[Lldb-commits] [PATCH] D54601: Makefile.rules: Use a shared clang module cache directory.

aprantl updated this revision to Diff 174311. aprantl added a comment. Small bugfix + an error message that would have caught it. https://reviews.llvm.org/D54601 Files: lit/lit.cfg.py packages/Python/lldbsuite/test/make/Makefile.rules Index: packages/Python/lldbsuite/test/make/Makefile.ru

[Lldb-commits] [PATCH] D54886: Add support for the Dylan language to ClangASTContext

aprantl added inline comments. Comment at: source/Symbol/ClangASTContext.cpp:123 + language == eLanguageTypeD || + language == eLanguageTypeDylan; } Please add a comment explaining that "The Debug info generated by the Open Dylan compiler's LLVM

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. > Currently lit supports running shell commands through the use of the RUN: > prefix. This patch allows individual test suites to install their own run > handlers that can do thin

[Lldb-commits] [PATCH] D54914: Add a generic build script for building test inferiors

aprantl added a comment. I would like to ask a general question that I (indirectly) also asked in D54731 : Why do we want to implement support for building inferiors in LIT-based tests? IMHO, if we need to support for dealing with specific compilers, we should i

[Lldb-commits] [PATCH] D55114: [CMake] Add LLVM_EXTERNALIZE_DEBUGINFO_OUTPUT_DIR for custom dSYM target directory on Darwin

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks reasonable, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55114/new/ https://reviews.llvm.org/D55114

[Lldb-commits] [PATCH] D55320: [CMake] Move debugserver options to separate debugserverConfig.cmake

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/debugserverConfig.cmake:2 +# Duplicate options from LLDBConfig that are relevant for debugserver Standalone builds. + +option(LLDB_USE_ENTITL

[Lldb-commits] [PATCH] D55317: [CMake] Aggregate options for LLDB in LLDBConfig.cmake

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Looks more organized. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55317/new/ https://reviews.llvm.org/D55317 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D55316: [CMake] Add support for NO_INSTALL_RPATH argument in llvm_add_library()

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: cmake/modules/AddLLVM.cmake:458 + if(NOT ARG_NO_INSTALL_RPATH) +if(ARG_MODULE OR ARG_SHARED) Any kind of comment that we could add h

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

aprantl added inline comments. Comment at: source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOS.cpp:83 + m_break_id(LLDB_INVALID_BREAK_ID), m_mutex() + , m_maybe_image_infos_address(LLDB_INVALID_ADDRESS) {} Why not just write C++11-style `= LLD

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Let's try it. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55399/new/ https://reviews.llvm.org/D55399 ___ l

[Lldb-commits] [PATCH] D55399: If we still have all_image_infos use it in DynamicLoaderMacOSDYLD to detect exec's

aprantl added a comment. If this patch works, then this bot should turn green: http://green.lab.llvm.org/green/view/LLDB/job/lldb-sanitized/ Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55399/new/ https://reviews.llvm.org/D55399 ___

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added inline comments. Comment at: resources/LLDB-Info.plist.in:18 + CFBundleSignature + + CFBundleVersion Just out of curiosity: Why this? Is this expected to be replaced after code signing? CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D55559: Remove the Disassembly benchmarks.

aprantl created this revision. aprantl added reviewers: jingham, jasonmolenda. While I was out hunting for remaining pexpect-based tests, I came across these tests that can't possibly work an any modern system, as they rely on having gdb available in /Developer. This patch simply removes the te

[Lldb-commits] [PATCH] D53677: Fix a bug PlatformDarwin::SDKSupportsModule

aprantl closed this revision. aprantl added a comment. Looks like this landed in r345274 and wasn't properly closed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53677/new/ https://reviews.llvm.org/D53677 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D55574: Remove else statements after returns

aprantl added a comment. I'm mostly on board with making these changes, as it's good LLVM style to do this. I highlighted a couple changes that might warrant a closer look. Comment at: source/API/SBProcess.cpp:1233 error.SetErrorString("process is invalid"); } + --

[Lldb-commits] [PATCH] D55584: Simplify boolean expressions

aprantl added a comment. This one is probably less controversial than D55574 :-) Comment at: include/lldb/Target/ThreadPlanTracer.h:46 TracingStarted(); -else if (old_value == true && value == false) +else if (old_value && !valu

[Lldb-commits] [PATCH] D55574: Remove else statements after returns

aprantl added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:994 return FPURegSet; else if (reg < k_num_registers) return EXCRegSet; This is inconsistent (do you need to re-run it until it reaches a fixpoint

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl created this revision. aprantl added a reviewer: jasonmolenda. Often users have a crash log an d a .dSYM bundle, but not the original application binary. It turns out that for crash symbolication, we can safely fall back to using the binary inside the .dSYM bundle. https://reviews.llvm

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl created this revision. aprantl added reviewers: jasonmolenda, jingham. This is a little dangerous since the crashlog files aren't 100% unambiguous, but the risk is mitigated by using a non-greedy `+?` pattern. rdar://problem/38478511 https://reviews.llvm.org/D55608 Files: examples/p

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 177889. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55608/new/ https://reviews.llvm.org/D55608 Files: examples/python/crashlog.py Index: examples/python/crashlog.py === --- example

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 177890. aprantl added a comment. Be more verbose about what is a valid arch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55608/new/ https://reviews.llvm.org/D55608 Files: examples/python/crashlog.py Index: examples/python/crashlog.py

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/Inputs/stepping.c:8 +// +//===--===// +#include Why does only this file have a header? Comment at: li

[Lldb-commits] [PATCH] D55626: [Reproducers] Add tests for functionality

aprantl added inline comments. Comment at: lit/Reproducer/Functionalities/TestStepping.test:39 +# CHECK: 1 breakpoints disabled. +# CHECK: 1 breakpoints disabled. + aprantl wrote: > perhaps copy the commands in here so it is easier to understand what is being >

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added inline comments. Herald added a subscriber: michaelplatings. Comment at: cmake/modules/LLDBConfig.cmake:275 -if (CMAKE_SOURCE_DIR STREQUAL CMAKE_BINARY_DIR) - message(FATAL_ERROR "In-source builds are not allowed. CMake would overwrite " -"the makefiles distribute

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Let's give this a try. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 ___ lldb-commits maili

[Lldb-commits] [PATCH] D55328: [CMake] Revised LLDB.framework builds

aprantl added a comment. Please be sure to watch all LLDB bots (green dragon and lab.llvm.org:8011) closely when landing this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55328/new/ https://reviews.llvm.org/D55328 ___ lldb-commits

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 178375. aprantl added a comment. Fixed the reported problems with the regexes and added testcases with example lines. I used the funny test setup to avoid burdening the installed crashlog.py script with unit test code that would need to be parsed every time.

[Lldb-commits] [PATCH] D55608: Make crashlog.py work or binaries with spaces in their names

aprantl updated this revision to Diff 178476. aprantl added a comment. Got rid of the no_uuid regex and added even more testcases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55608/new/ https://reviews.llvm.org/D55608 Files: examples/python/crashlog.py lit/Python/crashlog.test I

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Can you confirm that reverting this path actually fixes the issue? I'm asking because the only test that is executing this script has a REQUIRES: system-darwin line in it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Ah.. that's possible. REQUIRES needs to be very high up in the file, but I don't know what the exact threshold is Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://reviews.llvm.org/D55607

[Lldb-commits] [PATCH] D55607: Make crashlog.py work when a .dSYM is present, but a binary is missing

aprantl added a comment. Sorry I forgot to comment: this should be fixed in r349533. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55607/new/ https://reviews.llvm.org/D55607 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

aprantl created this revision. aprantl added a reviewer: JDevlieghere. TestQueues is failing randomly on green dragon and I suspect it is because the enqueued threads haven't executed by the time we expect them. https://reviews.llvm.org/D56208 Files: packages/Python/lldbsuite/test/macosx/que

[Lldb-commits] [PATCH] D56218: Rearrange bitfield to allow for more space in file_idx.

aprantl created this revision. aprantl added reviewers: JDevlieghere, clayborg, jasonmolenda. aprantl added a reviewer: friss. This is an alternate patch for the bug reported in https://bugs.llvm.org/show_bug.cgi?id=39816 ("lldb doesn't show a file of line entry for big project"). This limits th

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

aprantl added a comment. Herald added a reviewer: serge-sans-paille. I implemented a poor man's version of that in r350360. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56208/new/ https://reviews.llvm.org/D56208 ___

[Lldb-commits] [PATCH] D56115: [lldb] Check SafeToCallFunctions before calling functions in GetExceptionObjectForThread

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. A testcase that triggers this situation would be nice, too. Comment at: source/Plugins/LanguageRuntime/CPlusPlus/ItaniumABI/ItaniumABILanguageRuntime.cpp:558 + if (!threa

[Lldb-commits] [PATCH] D55859: noexternal 2/2: symbols.enable-external-lookup=false on all hosts (not just OSX)

aprantl added inline comments. Comment at: source/Core/ModuleList.cpp:72 {}, "Control the use of external tools or libraries to locate symbol files. " + "Directories listed in target.debug-file-search-paths and directory of " jankratochvil wrote:

[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

aprantl added inline comments. Comment at: source/Breakpoint/BreakpointList.cpp:18 +static void NotifyChange(BreakpointSP bp, BreakpointEventType event) { + if (bp->GetTarget().EventTypeHasListeners( + Target::eBroadcastBitBreakpointChanged)) perhaps: -

[Lldb-commits] [PATCH] D56425: [BreakpointList] Simplify/modernize BreakpointList (NFC)

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: source/Breakpoint/BreakpointList.cpp:49 + m_breakpoints.begin(), m_breakpoints.end(), + [&](const BreakpointSP &bp) { return bp->GetID() == break_

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. Can you give an example of what you mean by "specifying the lldb-mi commands up-front"? it's not immediately obvious to me how that would look like. Repository: rL LLVM https://reviews.llvm.org/D46588 ___ lldb-commits ma

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. Got it. We certainly do have dependent checks in our current tests: # Test that -data-info-line works for address self.runCmd("-data-info-line *%#x" % addr) self.expect( "\^done,start=\"0x0*%x\",end=\"0x[0-9a-f]+\",file=\".+?main.cpp\",line=\"%d\"" % (a

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. Actually, the example I posted was not a good one. I'm fairly certain that that was de facto static information or otherwise not particularly important information. Repository: rL LLVM https://reviews.llvm.org/D46588 __

[Lldb-commits] [PATCH] D46669: Retrieve the deployment target when retrieving an object file's triple

aprantl created this revision. aprantl added a reviewer: jasonmolenda. Herald added a subscriber: mgorny. Getting the deployment target can be significant information when rebuilding clang modules since availability information could depend on it. The unittest is cargo-culted from the ELF unit t

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. The code looks good — I think it would be worthwhile to try and convert this test to a LIT test. You can try to model it after `lit/Expr/TestCallUserDefinedFunction.test`. You will also need to modify `lit/lit.cfg` to define a `%lldb-mi` variable, but that should be st

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py:157 +self.runCmd("-break-insert main") +# FIXME function name is unknown on Darwin, fullname should be ??, line is -1 +self.expect(

[Lldb-commits] [PATCH] D46669: Retrieve the deployment target when retrieving an object file's triple

aprantl updated this revision to Diff 146234. aprantl added a comment. Much smaller test thanks to Pavel's suggestion! https://reviews.llvm.org/D46669 Files: lit/Modules/lc_version_min.yaml source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Index: source/Plugins/ObjectFile/Mach-O/ObjectF

[Lldb-commits] [PATCH] D46669: Retrieve the deployment target when retrieving an object file's triple

aprantl updated this revision to Diff 146235. aprantl added a comment. Added a REQUIRES: darwin https://reviews.llvm.org/D46669 Files: lit/Modules/lc_version_min.yaml source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Index: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp ==

[Lldb-commits] [PATCH] D46736: HostInfoMacOSX: Share the clang resource directory with Swift.

aprantl created this revision. aprantl added reviewers: friss, jingham. Herald added a subscriber: mgorny. Inside Xcode and in Xcode toolchains LLDB is always in lockstep with the Swift compiler, so it can reuse its Clang resource directory. This allows LLDB and the Swift compiler to share the sam

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Thanks for converting the test! Comment at: lit/Breakpoint/break-insert.test:2 +# RUN: %cc %p/Inputs/break-insert.c -g +# RUN: %lldb_mi < %p/Inputs/break-insert.input | Fi

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl accepted this revision. aprantl added a comment. Thanks, LGTM. Repository: rL LLVM https://reviews.llvm.org/D46588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. > If we're not able to come up with a command to make lldb-mi wait until the > target stops (maybe there is one already? I know very little about lldb-mi), > we may have to revisit the whole testing strategy... If one doesn't exist then I think it would be reasonable to

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. In https://reviews.llvm.org/D46588#1099566, @clayborg wrote: > In https://reviews.llvm.org/D46588#1099536, @aprantl wrote: > > > > If we're not able to come up with a command to make lldb-mi wait until > > > the target stops (maybe there is one already? I know very littl

[Lldb-commits] [PATCH] D46885: Remove append parameter to FindGlobalVariables

aprantl added a comment. I couldn't find any additional uses of FindGlobalVariables in swift-lldb either. https://reviews.llvm.org/D46885 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:14 +# CHECK-AFTER: ^running +# CHECK-AFTER: *stopped,reason="breakpoint-hit" + CHECK-AFTER is not recognized by FileCheck: https://www.llvm.org/docs/CommandGuide/FileCheck.

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:14 +# CHECK-AFTER: ^running +# CHECK-AFTER: *stopped,reason="breakpoint-hit" + polyakov.alex wrote: > aprantl wrote: > > CHECK-AFTER is not recognized by FileCheck: > > > >

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert.test:14 +# CHECK-AFTER: ^running +# CHECK-AFTER: *stopped,reason="breakpoint-hit" + labath wrote: > aprantl wrote: > > polyakov.alex wrote: > > > aprantl wrote: > > > > CHECK-AFT

[Lldb-commits] [PATCH] D46934: Make ObjectFileMachO work on non-darwin platforms

aprantl added inline comments. Comment at: source/Plugins/Process/Utility/RegisterContextDarwin_arm.cpp:1037 SetError(set, Write, -1); -return KERN_INVALID_ARGUMENT; +return -1; } Could we keep this as a local constant? perhaps with an #ifndef KER

[Lldb-commits] [PATCH] D46588: [LLDB][lldb-mi] Add possibility to set breakpoints without selecting a target.

aprantl added a comment. Alexander, I don't want this discussion to block you progress too much. It's important that we sort out the best way to test lldb-mi early on (and I hope this doesn't take too long), but while we are debating this you could also land the patch with the classic expect-ba

  1   2   3   4   5   6   7   8   9   10   >