aprantl added inline comments.
================
Comment at: source/Core/ModuleList.cpp:72
{},
"Control the use of external tools or libraries to locate symbol files. "
+ "Directories listed in target.debug-file-search-paths and directory of "
----------------
jankratochvil wrote:
> labath wrote:
> > My main issue here was with the "tools or libraries" part of this
> > description -- we're not using any special tools or libraries when looking
> > in /usr/lib/debug.
> >
> > Maybe just say that this is controls whether we use "external sources" when
> > searching for symbols. The rest of the description is fine (though I would
> > just drop the ifdefs and print everything everywhere).
> The Spotlight on OSX was a bit unclear to me what it really does. Doesn't it
> use some those "tools or libraries" to access the dSYM files downloaded from
> internet? But I have put there the "sources" word now as you wish.
> Also rather added `See also symbols.enable-external-lookup.` to
> `target.debug-file-search-paths`.
> I will check it in if there are no more replies in some time. Thanks for the
> approval.
>
The original wording is meant for tools that download debug symbols from
centralized repositories like the dsym download scripts mentioned on
http://lldb.llvm.org/symbols.html + the Spotlight metadata search engine.
The wording "sources" is problematic because it could be confused with source
code. Does "/usr/lib..." count as an external library? Alternatively, what
about "tools and repositories"?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55859/new/
https://reviews.llvm.org/D55859
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
