[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From e948fcf7a890d3ebcde5eb3586577099ba4ee2c0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format of some mach-o files by using vendor info in `getDefaultFormat()` (PR #143633)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format of some mach-o files by using vendor info in `getDefaultFormat()` (PR #143633)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: I've been thinking about this too. I think you're right to distinguish two use cases: 1. Interacting with an existing debug session. For example you've started debugging in VS Code with DAP and you want your AI assistant to interact with the debug session. 2. Starting a n

[Lldb-commits] [lldb] [lldb] Set `ObjectFileMachO` to `MachO` when no version load commands are found (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/144177 **Context**: See previous attempts: #142704, #143633 **Problem**: When `ObjectFileMachO` parses a Mach-O file (including yaml data in lldb unit tests) which doesn't have load commands like `LC_BUILD_VERSION` o

[Lldb-commits] [lldb] [lldb] Set `ObjectFileMachO` to `MachO` when no version load commands are found (PR #144177)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes **Context**: See previous attempts: #142704, #143633 **Problem**: When `ObjectFileMachO` parses a Mach-O file (including yaml data in lldb unit tests) which doesn't have load commands like `LC_BUILD_VERSION` or `LC

[Lldb-commits] [lldb] [lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out (PR #143732)

2025-06-13 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/19295 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb] CommandObjectMemoryFind: Improve expression evaluation error messages (PR #144036)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/144036 We now bubble up the expression evaluation diagnostics to the user and also distinguish between "expression failed to parse/run" versus other ways in which expressions didn't complete (e.g., setup errors, et

[Lldb-commits] [lldb] [lldb] CommandObjectMemoryFind: Improve expression evaluation error messages (PR #144036)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes We now bubble up the expression evaluation diagnostics to the user and also distinguish between "expression failed to parse/run" versus other ways in which expressions didn't complete (e.g., setup errors,

[Lldb-commits] [lldb] 06c7835 - [lldb][test] Disable TestMultipleDebuggers again

2025-06-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-06-13T09:12:01Z New Revision: 06c783567069db169ee2d1545a4bd3ffd0e3fec0 URL: https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0 DIFF: https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0.diff LOG

[Lldb-commits] [lldb] [lldb] CommandObjectMemoryFind: Improve expression evaluation error messages (PR #144036)

2025-06-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/144036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4236423 - [LLDB] Add bit extraction to DIL (#141422)

2025-06-13 Thread via lldb-commits
Author: Ilia Kuklin Date: 2025-06-13T16:31:25+05:00 New Revision: 4236423ee863be5903819db57205fc83a4bd21e1 URL: https://github.com/llvm/llvm-project/commit/4236423ee863be5903819db57205fc83a4bd21e1 DIFF: https://github.com/llvm/llvm-project/commit/4236423ee863be5903819db57205fc83a4bd21e1.diff L

[Lldb-commits] [lldb] [LLDB] Add bit extraction to DIL (PR #141422)

2025-06-13 Thread Ilia Kuklin via lldb-commits
https://github.com/kuilpd closed https://github.com/llvm/llvm-project/pull/141422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 41b37f0 - [lldb] CommandObjectMemoryFind: Improve expression evaluation error messages (#144036)

2025-06-13 Thread via lldb-commits
Author: Michael Buch Date: 2025-06-13T12:43:27+01:00 New Revision: 41b37f05554ae59974675ae219430b5598c6159f URL: https://github.com/llvm/llvm-project/commit/41b37f05554ae59974675ae219430b5598c6159f DIFF: https://github.com/llvm/llvm-project/commit/41b37f05554ae59974675ae219430b5598c6159f.diff

[Lldb-commits] [lldb] [lldb] CommandObjectMemoryFind: Improve expression evaluation error messages (PR #144036)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/144036 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > okay, so would something like this be sufficient to reproduce the issue (you > can put the functions in different files as needed): This should be reproducable but I am not sure if it is the same problem, because it now skips `fn2` line completely regardless if it is complied

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: > It still seems pretty aggressive to log all LLDB_LOG_ERROR messages to the > console, but this is a stop-gap until we want to do something about it. I said as much on the PR, and still think it's too aggressive to send all these errors to the system log. > Looks like this er

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Ebuka Ezike via lldb-commits
@@ -105,6 +105,21 @@ protocol::Source CreateSource(lldb::SBAddress address, lldb::SBTarget &target) { return CreateSource(line_entry.GetFileSpec()); } +protocol::Source CreateSource(lldb::SBFrame frame) { + if (!frame.IsValid()) +return {}; + + const lldb::SBTarget ta

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/143644 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/141577 >From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001 From: DhruvSrivastavaX Date: Tue, 27 May 2025 05:44:55 -0500 Subject: [PATCH 1/7] Added XCOFF ParseSymtab handling --- .../Objec

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Thats true. Created new ones. https://github.com/llvm/llvm-project/pull/141577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/141577 >From a62cd7b510f3cf74ee356a95a26e0f9922f4b39c Mon Sep 17 00:00:00 2001 From: DhruvSrivastavaX Date: Tue, 27 May 2025 05:44:55 -0500 Subject: [PATCH 1/7] Added XCOFF ParseSymtab handling --- .../Objec

[Lldb-commits] [lldb] [lldb][DWARF] Don't try to compute address range information of forward declarations (PR #144059)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This fixes the error reported in https://github.com/llvm/llvm-project/pull/144037. When computing the aranges table of a CU, LLDB would currently visit all `DW_TAG_subprogram` DIEs and check their `DW_AT_l

[Lldb-commits] [lldb] [lldb][DWARF] Don't try to compute address range information of forward declarations (PR #144059)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/144059 This fixes the error reported in https://github.com/llvm/llvm-project/pull/144037. When computing the aranges table of a CU, LLDB would currently visit all `DW_TAG_subprogram` DIEs and check their `DW_AT_low

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: > > It still seems pretty aggressive to log all LLDB_LOG_ERROR messages to the > > console, but this is a stop-gap until we want to do something about it. > > I said as much on the PR, and still think it's too aggressive to send all > these errors to the system log. @JDevlie

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: Yeah, that sounds like a bug. A different one that what you are fixing, but I think it's kind of related, as now the stepping machinery who concludes it has stepped "into" fn2 (and then decides to step out of it). I've filed #144061 to track that. Would it work if we replace the

[Lldb-commits] [lldb] [lldb][DWARF] Don't try to compute address range information of forward declarations (PR #144059)

2025-06-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Looks good. I don't think the test is very useful. Since all it tests is a negative, the test could be easily invalidated (e.g. by changing the error string), and we would never notice. You can keep it if you want, but I'd be fine with this

[Lldb-commits] [lldb] [lldb][DWARF] Don't try to compute address range information of forward declarations (PR #144059)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: Yea that's fair. I'll remove the test and just add a comment in the source https://github.com/llvm/llvm-project/pull/144059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [lldb] [LLDB] Add optional callback function to `TypeMatcher` (PR #143748)

2025-06-13 Thread via lldb-commits
Nerixyz wrote: > I've described a use case a couple times already. If you have a client-server > architecture, it would be really nice to be able to debug both the client and > the server in the same lldb process, because then you can add tooling on top > of lldb to do things like "step in acr

[Lldb-commits] [lldb] [lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out (PR #143732)

2025-06-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Timed out on the very first build :rofl: On second thought this test is better disabled. It's more correct than it was, but it's never going to be truly stable. https://github.com/llvm/llvm-project/commit/06c783567069db169ee2d1545a4bd3ffd0e3fec0 https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/144037 Currently `LLDB_LOG_ERROR` always logs to the "always-on" channel (which prints to the console; this started with https://github.com/llvm/llvm-project/pull/111911). Attaching to LLDB spams the console with

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Currently `LLDB_LOG_ERROR` always logs to the "always-on" channel (which prints to the console; this started with https://github.com/llvm/llvm-project/pull/111911). Attaching to LLDB spams the console wit

[Lldb-commits] [lldb] [LLDB] Add optional callback function to `TypeMatcher` (PR #143748)

2025-06-13 Thread via lldb-commits
Nerixyz wrote: > A low-tech way to support both STL versions would be to do a dispatch inside > the data formatter For summaries this would work, but it Gerts more involved for synthetic children providers, where you'd need to check for the kind in every method. Though now that I think about

[Lldb-commits] [lldb] [lldb] Implement JSON RPC (newline delimited) Transport (PR #143946)

2025-06-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: Even prior to this PR, running HostTests.exe on its own in a terminal causes the terminal to completely close? Always something new to discover on Windows isn't there. https://github.com/llvm/llvm-project/pull/143946 ___ lldb-com

[Lldb-commits] [lldb] addd98f - [lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out (#143732)

2025-06-13 Thread via lldb-commits
Author: David Spickett Date: 2025-06-13T09:31:57+01:00 New Revision: addd98f7a5b964a5a5860d65f327f3fc3b7e0a42 URL: https://github.com/llvm/llvm-project/commit/addd98f7a5b964a5a5860d65f327f3fc3b7e0a42 DIFF: https://github.com/llvm/llvm-project/commit/addd98f7a5b964a5a5860d65f327f3fc3b7e0a42.diff

[Lldb-commits] [lldb] [lldb][test] Don't call SBDebugger::Terminate if TestMultipleDebuggers times out (PR #143732)

2025-06-13 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/143732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/141577 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Pavel Labath via lldb-commits
@@ -29,6 +29,15 @@ # CHECK-NEXT: Type: dwarf-abbrev # CHECK-NEXT: Permissions: r-- +# RUN: %lldb %t -o "image dump symtab" -o exit | FileCheck %s --check-prefix=CHECK-SYMBOL +# CHECK-SYMBOL:Index UserID DSX TypeFile Address/Value Load Address Size

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: This is starting to not be a "basic info" test. I'd suggest moving the new checks to a new test. https://github.com/llvm/llvm-project/pull/141577 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [lldb] [lldb][AIX] Added XCOFF ParseSymtab handling (PR #141577)

2025-06-13 Thread Pavel Labath via lldb-commits
@@ -29,6 +29,16 @@ # CHECK-NEXT: Type: dwarf-abbrev # CHECK-NEXT: Permissions: r-- + +# RUN: %lldb %t -o "image dump symtab" -o exit | FileCheck %s --check-prefix=CHECK-SYMBOL +# CHECK-SYMBOL:Index UserID DSX TypeFile Address/Value Load Address Size

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Pavel Labath via lldb-commits
@@ -581,19 +581,19 @@ llvm::json::Value CreateStackFrame(lldb::SBFrame &frame, EmplaceSafeString(object, "name", frame_name); - auto target = frame.GetThread().GetProcess().GetTarget(); - auto source = CreateSource(frame.GetPCAddress(), target); labath wr

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: Example CU where we fail to get the address range info: ``` builds-lldb/debug/lib/liblldbPluginSymbolFileDWARF.a(DWARFDebugInfoEntry.cpp.o): file format Mach-O arm64 .debug_info contents: 0x000c: DW_TAG_compile_unit DW_AT_producer("Apple clang ver

[Lldb-commits] [lldb] [LLDB] Add optional callback function to `TypeMatcher` (PR #143748)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: > Though now that I think about it, couldn't I inspect the type before creating > the frontend for a synthetic provider and create the appropriate frontend? That is what I was imagining, yes. https://github.com/llvm/llvm-project/pull/143748 ___

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEn

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/144037 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/144037 >From 3a815c2f60cd605fd4c2903f26d4e98f5c73a007 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 13 Jun 2025 10:20:27 +0100 Subject: [PATCH 1/2] [lldb][DWARF] Only log address range error to verbose cha

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: > It is the combination of the first and third. For completeness. > > we do an step-over, which lands us at an instruction, which happens to be the > first instruction of an inlined function. lldb-dap takes the PC value and > resolves it to a function/block on its own. This retur

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: I looked into this a bit further. Looks like the reason this is failing for some functions where we fail to find `DW_AT_ranges` in the CU abbreviation decl (despite the attribute being there according to dwarfdump). Bit confused https://github.com/llvm/llvm-project/pull/14403

[Lldb-commits] [lldb] [LLDB] Add bit extraction to DIL (PR #141422)

2025-06-13 Thread Pavel Labath via lldb-commits
labath wrote: I think it'd be better to do that later, so that the flag-flip is as much of a no-op as possible. (avoiding churn on the test files if it needs to be reverted, etc.) I don't know how many tests we have depending on this (my guess is: not much), but I don't think one extra file y

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: Looks like this error just happens anytime we build the aranges table for a CU. Any `DW_TAG_subprogram` without a `DW_AT_low_pc`/`DW_AT_high_pc` will fail here and log this error. Should we maybe just skip the call to `GetAttributeAddressRanges` here when we're looking at for

[Lldb-commits] [lldb] [lldb][DWARF] Only log address range error to verbose channel (PR #144037)

2025-06-13 Thread Michael Buch via lldb-commits
Michael137 wrote: Another thing that's confusing me is that this error only prints to the console when you attach to LLDB. E.g., ``` $ cat range.cpp struct Foo { void func() {} }; int main() { Foo{}.func(); return 0; } ``` This doesn't print the error: ``` ./build/bin/lldb ~/a.out

[Lldb-commits] [lldb] [lldb] Add MCP support to LLDB (PoC) (PR #143628)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/143628 >From 24e3803fce6d866d0878fe9b1da6203273e58399 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 12 Jun 2025 16:33:55 -0700 Subject: [PATCH] [lldb] Add MCP support to LLDB https://discourse.llvm.

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2025-06-13 Thread Chelsea Cassanova via lldb-commits
@@ -47,6 +48,10 @@ class LLDB_API SBStream { void Print(const char *str); + bool HasColor(); + + void FormatAnsiTerminalCodes(llvm::StringRef format); chelcassanova wrote: Probably not, though does that now mean that I'd just be writing the prefix/suffi

[Lldb-commits] [lldb] [lldb] Add MCP support to LLDB (PoC) (PR #143628)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/143628 >From a3b030f71c68dc85fbb9f972dadfa7d6ffe6acc9 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 12 Jun 2025 16:33:55 -0700 Subject: [PATCH] [lldb] Add MCP support to LLDB https://discourse.llvm.

[Lldb-commits] [clang] [lldb] [Clang][PowerPC] Add __dmr type and DMF integer calculation builtins (PR #142480)

2025-06-13 Thread via lldb-commits
@@ -30,6 +30,7 @@ #endif +PPC_VECTOR_MMA_TYPE(__dmr1024, VectorDmr1024, 1024) RolandF77 wrote: The type names have to match GCC and are negotiated - __dmr1024 is the current choice. https://github.com/llvm/llvm-project/pull/142480 _

[Lldb-commits] [lldb] [lldb-dap] Creating protocol types for setExceptionBreakpoints. (PR #144153)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
@@ -39,6 +41,8 @@ class ExceptionBreakpoint { std::string m_filter; std::string m_label; lldb::LanguageType m_language; + bool m_is_throw; + bool m_is_catch; JDevlieghere wrote: How about an enum value? https://github.com/llvm/llvm-project/pull/14415

[Lldb-commits] [lldb] [lldb] Add MCP support to LLDB (PoC) (PR #143628)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/143628 >From 4156ce234102c67bf664c49bc85982f9691229fb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 12 Jun 2025 16:33:55 -0700 Subject: [PATCH] [lldb] Add MCP support to LLDB https://discourse.llvm.

[Lldb-commits] [lldb] 6751b3a - Revert "[lit] cleanup unused imports" (#144054)

2025-06-13 Thread via lldb-commits
Author: Charles Zablit Date: 2025-06-13T08:16:09-07:00 New Revision: 6751b3a549ebef78a7e75b100d61742c20945592 URL: https://github.com/llvm/llvm-project/commit/6751b3a549ebef78a7e75b100d61742c20945592 DIFF: https://github.com/llvm/llvm-project/commit/6751b3a549ebef78a7e75b100d61742c20945592.diff

[Lldb-commits] [lld] [lldb] [llvm] Revert "[lit] cleanup unused imports" (PR #144054)

2025-06-13 Thread Kirill Stoimenov via lldb-commits
https://github.com/kstoimenov closed https://github.com/llvm/llvm-project/pull/144054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lld] [lldb] [llvm] Revert "[lit] cleanup unused imports" (PR #144054)

2025-06-13 Thread Kirill Stoimenov via lldb-commits
https://github.com/kstoimenov approved this pull request. Original PR broke a bunch of Sanitizers bots: https://lab.llvm.org/buildbot/#/builders/85/builds/9827. I will merge that revert. https://github.com/llvm/llvm-project/pull/144054 ___ lldb-comm

[Lldb-commits] [lldb] [lldb] Implement JSON RPC (newline delimited) Transport (PR #143946)

2025-06-13 Thread David Spickett via lldb-commits
DavidSpickett wrote: https://github.com/llvm/llvm-project/issues/144077 for the terminal closing. It's not related to this change. I had to disable two of the tests that try to read a closed file descriptor. MS CRT validates the fd before it reads it and this leads to a software breakpoint /

[Lldb-commits] [lldb] 82911f1 - [lldb][test] Skip ReadAfterClose JSON Transport tests on Windows

2025-06-13 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2025-06-13T14:26:06Z New Revision: 82911f188be7ce7cb0a04b7fd648ea8b4aad2e59 URL: https://github.com/llvm/llvm-project/commit/82911f188be7ce7cb0a04b7fd648ea8b4aad2e59 DIFF: https://github.com/llvm/llvm-project/commit/82911f188be7ce7cb0a04b7fd648ea8b4aad2e59.diff LOG

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/144119 Today we can run `target modules dump separate-debug-info --json` to get a json blob of all the separate debug info, but it has a few shortcomings when developing some scripting against it. Namely, the caller h

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes Today we can run `target modules dump separate-debug-info --json` to get a json blob of all the separate debug info, but it has a few shortcomings when developing some scripting against it. Namely, the calle

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @jasonmolenda tagged you because I think you're the relevant SME, but feel free to reassign otherwise. https://github.com/llvm/llvm-project/pull/144119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti commented: Looking at this locally, I think this is changing: ``` 0x01234 ff ff ff ff NSLog: pacibsp ... ``` into: ``` 0x01234 ff ff ff ff pacibsp ; NSLog ... ``` When other functions are called, they have the name in the comment, so you'd see ``` 0x01234

[Lldb-commits] [lldb] [lldb] Implement JSON RPC (newline delimited) Transport (PR #143946)

2025-06-13 Thread John Harrison via lldb-commits
ashgti wrote: > If this is a feature you actually rely on, we should check the fd is valid > before we use it. As in: check and if it's invalid early return an error, > instead of getting all the way to reading from it. The start of the `ReadFull` helper is checking `IsValid()`: ``` static Ex

[Lldb-commits] [lldb] [lldb] Implement JSON RPC (newline delimited) Transport (PR #143946)

2025-06-13 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @ashgti AFAIK that only checks if the file descriptor is a valid number (i.e. >= 0) not whether the underlying FD is actually valid. On POSIX we definitely do check that and return an `llvm::Error` but maybe on Windows that's missing. https://github.com/llvm/llvm-project/pu

[Lldb-commits] [lldb] 2704b27 - [lldb] Include unistd.h for _exit in multi-process-driver.cpp

2025-06-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-06-13T10:02:41-07:00 New Revision: 2704b27a0b452f4aaf87ab26d315fdc92857373a URL: https://github.com/llvm/llvm-project/commit/2704b27a0b452f4aaf87ab26d315fdc92857373a DIFF: https://github.com/llvm/llvm-project/commit/2704b27a0b452f4aaf87ab26d315fdc92857373a.d

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/144070 putting the function name is the dissassembly instruction messes up the alignment making it less readable. put it instead with the comment. This also aligns the opcodes and instruction to the left matching th

[Lldb-commits] [lldb] [lldb-dap] show function name in the instruction comment. (PR #144070)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes putting the function name is the dissassembly instruction messes up the alignment making it less readable. put it instead with the comment. This also aligns the opcodes and instruction to the left matching t

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/144072 Take 2. uses the `SendTargetCapabilityes` from #142831 >From c4d909a9bb25983a955254956d3f0dab2ecc284f Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Thu, 12 Jun 2025 12:48:24 +0100 Subject: [PATCH] [lldb-d

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-13 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/144072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use structured types for stepInTargets request (PR #144072)

2025-06-13 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Take 2. uses the `SendTargetCapabilities` from #142831 --- Full diff: https://github.com/llvm/llvm-project/pull/144072.diff 10 Files Affected: - (modified) lldb/packages/Python/lldbsuite/test/tools/lldb-d

[Lldb-commits] [lldb] [llvm] [lldb] Fix object format of some mach-o files by using vendor info in `getDefaultFormat()` (PR #143633)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/143633 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Creating protocol types for setExceptionBreakpoints. (PR #144153)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/144153 >From e54b23052c17efd61297db619c355749d51e34c6 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Fri, 13 Jun 2025 11:58:27 -0700 Subject: [PATCH 1/2] [lldb-dap] Creating protocol types for setExceptionBreakpoin

[Lldb-commits] [lldb] [lldb] Set object format to `MachO` when no version load commands (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set object format to `MachO` when no version load commands are found (3rd) (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set object format to `MachO` when no version load commands are found (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Set object format to `MachO` when no version load commands are found (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when no version load commands (PR #144177)

2025-06-13 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/144177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-13 Thread via lldb-commits
jimingham wrote: >From what I can tell, you have the lldb_private API's you are adding return a >StringMap because it facilitates building a list where each unique >file spec appears only once. Other than that, I can't see you make any use of >the StringMap-ness of the data you return. That

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti commented: Would it be worth it to include a file in lldb/docs/resources about running this? For folks wanting to get started trying this out? Maybe in a follow up PR. https://github.com/llvm/llvm-project/pull/143628 ___ lld

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,72 @@ +//===- Tool.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,131 @@ +//===- Protocol.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,280 @@ +//===- ProtocolServerMCP.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,131 @@ +//===- Protocol.h -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,280 @@ +//===- ProtocolServerMCP.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,280 @@ +//===- ProtocolServerMCP.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
@@ -0,0 +1,13 @@ +add_lldb_library(lldbPluginProtocolServerMCP PLUGIN ashgti wrote: Should this be behind a build flag? I could see some distributions disabling this feature for security reasons. Once an MCP server is running, it can run arbitrary commands in t

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. Just one nit in the less than operator. https://github.com/llvm/llvm-project/pull/136040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-13 Thread Greg Clayton via lldb-commits
@@ -45,9 +49,16 @@ struct Range { friend bool operator==(const Range &lhs, const Range &rhs) { return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref; } + + friend bool operator<(const Range &lhs, const Range &rhs) { +return lhs.start < rhs.start;

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/136040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-13 Thread John Harrison via lldb-commits
ashgti wrote: Reading more about this in the VSCode docs and on the MCP website I think I understand the flow of logic a bit more. I think this is definitely helpful for allowing an agent to help control a debug session. However, I'm still not sure how we should handle the MCP client and debu

[Lldb-commits] [lldb] [lldb] Add support to list/enable/disable remaining plugin types. (PR #143970)

2025-06-13 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/143970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support to list/enable/disable remaining plugin types. (PR #143970)

2025-06-13 Thread Greg Clayton via lldb-commits
@@ -10,10 +10,10 @@ # Test plugin list without an argument will list all plugins. plugin list # CHECK-LABEL: plugin list -# CHECK: system-runtime -# CHECK: [+] systemruntime-macosx System runtime plugin for Mac OS X native libraries # CHECK: instrumentation-runtime

  1   2   >