jimingham wrote: >From what I can tell, you have the lldb_private API's you are adding return a >StringMap<FileSpec> because it facilitates building a list where each unique >file spec appears only once. Other than that, I can't see you make any use of >the StringMap-ness of the data you return.
That's awkward because then none of the consumers actually want that StringMap, whose map nature after all doesn't provide any new information since the keys are also in the values. However, FileSpecList already has an AppendIfUnique method. So you could (with less code than the current implementation) have all the new lldb_private API's return what consumers actually want: an FileSpecList, and then that would be trivially convertible to the SBFileSpecList, which is in the end what you wanted to expose. https://github.com/llvm/llvm-project/pull/144119 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
