[Lldb-commits] [lldb] [lldb/cmake] Remove a no-op statement (PR #141063)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/141063 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f1cf168 - [lldb/cmake] Remove a no-op statement (#141063)

2025-05-23 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-23T09:23:53+02:00 New Revision: f1cf168a6fbfa28eca2bebb4493966dc63c925c5 URL: https://github.com/llvm/llvm-project/commit/f1cf168a6fbfa28eca2bebb4493966dc63c925c5 DIFF: https://github.com/llvm/llvm-project/commit/f1cf168a6fbfa28eca2bebb4493966dc63c925c5.diff

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/141066 >From 498052aef6ae24353bb50771bac773908da51b5d Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 22 May 2025 15:50:01 +0200 Subject: [PATCH] [lldb/cmake] Remove special handling of OBJECT libraries Nothing

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: > One area that I couldn't decide is if the ValueObj should be constructed in > Platform or not. Because Thread calls out to platform I just decided to call > the existing method, but I wanted your feedback on this because it does feel > somewhat split purp

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Pavel Labath via lldb-commits
@@ -480,3 +481,111 @@ CompilerType PlatformLinux::GetSiginfoType(const llvm::Triple &triple) { ast->CompleteTagDeclarationDefinition(siginfo_type); return siginfo_type; } + +static std::string GetDescriptionFromSiginfo(lldb::ValueObjectSP siginfo_sp) { + if (!siginfo_sp)

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/140150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (PR #141159)

2025-05-23 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. https://github.com/llvm/llvm-project/pull/141159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/cmake] Don't call llvm_process_sources (PR #141217)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes It's already called in llvm_add_library. --- Full diff: https://github.com/llvm/llvm-project/pull/141217.diff 1 Files Affected: - (modified) lldb/cmake/modules/AddLLDB.cmake (+2-3) ``diff diff --g

[Lldb-commits] [lldb] [lldb/cmake] Don't call llvm_process_sources (PR #141217)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/141217 It's already called in llvm_add_library. >From 1da42847de2c438ae726b9800843f6449fede41a Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 23 May 2025 11:22:40 +0200 Subject: [PATCH] [lldb/cmake] Don't call

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/141212 https://lab.llvm.org/buildbot/#/builders/141/builds/8927/steps/6/logs/stdio >From 660eeaef30c2d99f0ed571029f4f7d6783a36789 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Fri, 23 May 2025 10:44:09 +0200 Subject

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ely Ronnen (eronnen) Changes https://lab.llvm.org/buildbot/#/builders/141/builds/8927/steps/6/logs/stdio --- Full diff: https://github.com/llvm/llvm-project/pull/141212.diff 1 Files Affected: - (modified) lldb/test/API/python_api/unname

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/141102 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. I think it's fine. the std::vector formatter tests are not running currently on windows, so it's likely that formatter is just broken there. Since this is test for the DIL and not std::vector, we could write our own formatter to test this f

[Lldb-commits] [lldb] [LLDB] Add array subscription and integer parsing to DIL (PR #141102)

2025-05-23 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,119 @@ +""" +Test DIL array subscript. +""" + +import lldb +from lldbsuite.test.lldbtest import * +from lldbsuite.test.decorators import * +from lldbsuite.test import lldbutil + + +class TestFrameVarDILArraySubscript(TestBase): +NO_DEBUG_INFO_TESTCASE = True + +

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Pavel Labath via lldb-commits
labath wrote: > I don't know if this is the source of the problem, but one thing I noticed is > that you're missing some sort of synchronization to make sure the child > process doesn't exit before you're able to observe it. A slightly lame but > probably sufficient method to do that would be

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Pavel Labath via lldb-commits
@@ -480,3 +481,111 @@ CompilerType PlatformLinux::GetSiginfoType(const llvm::Triple &triple) { ast->CompleteTagDeclarationDefinition(siginfo_type); return siginfo_type; } + +static std::string GetDescriptionFromSiginfo(lldb::ValueObjectSP siginfo_sp) { + if (!siginfo_sp)

[Lldb-commits] [lldb] a4380fe - [lldb/cmake] Remove special handling of OBJECT libraries (#141066)

2025-05-23 Thread via lldb-commits
Author: Pavel Labath Date: 2025-05-23T10:22:59+02:00 New Revision: a4380fe5f99978f49c2d119aee412a6bd734e9fd URL: https://github.com/llvm/llvm-project/commit/a4380fe5f99978f49c2d119aee412a6bd734e9fd DIFF: https://github.com/llvm/llvm-project/commit/a4380fe5f99978f49c2d119aee412a6bd734e9fd.diff

[Lldb-commits] [lldb] [lldb/cmake] Remove special handling of OBJECT libraries (PR #141066)

2025-05-23 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/141066 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (PR #141220)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes `parseAndLoadModuleMapFile` returns `true` on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value

[Lldb-commits] [lldb] [lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (PR #141220)

2025-05-23 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/141220 `parseAndLoadModuleMapFile` returns `true` on error. This seems to have always been an issue? This is now preventing me from fixing a different modules related issue. So this patch checks the return value co

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Hemang Gadhavi via lldb-commits
HemangGadhavi wrote: > > I don't know if this is the source of the problem, but one thing I noticed > > is that you're missing some sort of synchronization to make sure the child > > process doesn't exit before you're able to observe it. A slightly lame but > > probably sufficient method to do

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi updated https://github.com/llvm/llvm-project/pull/138687 >From a47e4642e6ebcbe6b5466ff118968bac83ccf1e9 Mon Sep 17 00:00:00 2001 From: HemangGadhavi Date: Tue, 6 May 2025 07:59:45 -0500 Subject: [PATCH 1/3] [lldb][AIX] get host info for AIX (cont..) --- lldb/s

[Lldb-commits] [lldb] 53d7b1d - [LLDB] Add field member operators to DIL (#138093)

2025-05-23 Thread via lldb-commits
Author: cmtice Date: 2025-05-23T07:30:10-07:00 New Revision: 53d7b1d9e00d8cc3189808bbc26e2ee4577766e7 URL: https://github.com/llvm/llvm-project/commit/53d7b1d9e00d8cc3189808bbc26e2ee4577766e7 DIFF: https://github.com/llvm/llvm-project/commit/53d7b1d9e00d8cc3189808bbc26e2ee4577766e7.diff LOG: [

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: @cmtice I'm getting: ``` lldb/include/lldb/ValueObject/DILParser.h:121:8: error: private field 'm_fragile_ivar' is not used [-Werror,-Wunused-private-field] 121 | bool m_fragile_ivar; |^ lldb/include/lldb/ValueObject/DILParser.h:122:8: error: private fiel

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Dhruv Srivastava via lldb-commits
@@ -54,6 +54,12 @@ TEST_F(HostInfoTest, GetHostname) { EXPECT_TRUE(HostInfo::GetHostname(s)); } +TEST_F(HostInfoTest, GetProgramFileSpec) { + // Test GetProgramFileSpec() + FileSpec filespec = HostInfo::GetProgramFileSpec(); + EXPECT_FALSE(filespec.GetFilename().IsEmpty()

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Dhruv Srivastava via lldb-commits
DhruvSrivastavaX wrote: Side-Note: @HemangGadhavi Please verify that these pass on our AIX setup as well. https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] get host info for AIX (cont..) (PR #138687)

2025-05-23 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX edited https://github.com/llvm/llvm-project/pull/138687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/138093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread via lldb-commits
cmtice wrote: > @cmtice I'm getting: > > ``` > lldb/include/lldb/ValueObject/DILParser.h:121:8: error: private field > 'm_fragile_ivar' is not used [-Werror,-Wunused-private-field] > 121 | bool m_fragile_ivar; > |^ > lldb/include/lldb/ValueObject/DILParser.h:122:8: error: priv

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,53 @@ +#!/usr/bin/env python3 +""" +Usage: LLDB_MAJOR_VERSION LLDB_MINOR_VERSION LLDB_PATCH_VERSION + +This script uncomments and populates the versioning information in lldb-defines.h +""" + +import argparse +import os +import re + +LLDB_VERSION_REGEX = re.compile(

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,17 @@ +// Run the convert script on it, then run the framework include fix on it. The framework version fix script +// expects that all lldb references have been renamed to lldb-rpc in order for it to modify the includes +// to go into the framework.

[Lldb-commits] [lldb] 6087854 - [lldb] skip unnamed symbol test on windows (#141212)

2025-05-23 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-23T18:52:42+02:00 New Revision: 6087854472a97e9a1b33933a0694cf4210c90b93 URL: https://github.com/llvm/llvm-project/commit/6087854472a97e9a1b33933a0694cf4210c90b93 DIFF: https://github.com/llvm/llvm-project/commit/6087854472a97e9a1b33933a0694cf4210c90b93.diff LO

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/23051 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/141212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Jacob Lalonde via lldb-commits
@@ -480,3 +481,111 @@ CompilerType PlatformLinux::GetSiginfoType(const llvm::Triple &triple) { ast->CompleteTagDeclarationDefinition(siginfo_type); return siginfo_type; } + +static std::string GetDescriptionFromSiginfo(lldb::ValueObjectSP siginfo_sp) { + if (!siginfo_sp)

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/140150 >From 94d78d5ea7866fe896381319c875d6b9c3d34c90 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 15 May 2025 13:57:11 -0700 Subject: [PATCH 01/12] Update ThreadElfCore --- lldb/include/lldb/Target/UnixSi

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -1042,16 +1042,30 @@ def request_setFunctionBreakpoints(self, names, condition=None, hitCondition=Non return self.send_recv(command_dict) def request_dataBreakpointInfo( -self, variablesReference, name, frameIndex=0, threadId=None +self, +

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb-dap] Minor change to stdio client name. (PR #141266)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Update the stdin <-> stdout client name to `stdio`. I noticed on macOS if I get a crash report from lldb-dap the `/` in the client name causes some thread names to be reported without the full name. For examp

[Lldb-commits] [lldb] 7dc7c15 - [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (#141159)

2025-05-23 Thread via lldb-commits
Author: John Harrison Date: 2025-05-23T08:46:23-07:00 New Revision: 7dc7c155251c0008d5d59b84f0c9056365740f11 URL: https://github.com/llvm/llvm-project/commit/7dc7c155251c0008d5d59b84f0c9056365740f11 DIFF: https://github.com/llvm/llvm-project/commit/7dc7c155251c0008d5d59b84f0c9056365740f11.diff

[Lldb-commits] [lldb] [lldb] Adding a new decorator for CMAKE_BUILD_TYPE. (PR #141159)

2025-05-23 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/141159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] skip unnamed symbol test on windows (PR #141212)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141212 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][RPC] Upstream Python scripts (PR #138028)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138028 >From 01e35b2635b3727be7f7ab6f2389086c6e86b776 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 13:37:15 -0700 Subject: [PATCH] [lldb][RPC] Upstream Python scripts As part of upstre

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread via lldb-commits
https://github.com/cmtice created https://github.com/llvm/llvm-project/pull/141259 None >From 589d44d2924ca149bfbf0b4b4cdb37f7dfe4c99f Mon Sep 17 00:00:00 2001 From: Caroline Tice Date: Fri, 23 May 2025 10:07:59 -0700 Subject: [PATCH] [LLDB] Fix warning about unused private members. --- lldb

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (cmtice) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/141259.diff 1 Files Affected: - (modified) lldb/include/lldb/ValueObject/DILParser.h (+4) ``diff diff --git a/lldb/include/lldb/ValueObject/DILPar

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread via lldb-commits
cmtice wrote: > > @cmtice I'm getting: > > ``` > > lldb/include/lldb/ValueObject/DILParser.h:121:8: error: private field > > 'm_fragile_ivar' is not used [-Werror,-Wunused-private-field] > > 121 | bool m_fragile_ivar; > > |^ > > lldb/include/lldb/ValueObject/DILParser.h:122:8:

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata approved this pull request. LGTM. I've verified that your patch fixes the warning. Thanks! I suppose you're going to use these accessors in the near future !? https://github.com/llvm/llvm-project/pull/141259 ___ ll

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread via lldb-commits
cmtice wrote: > LGTM. I've verified that your patch fixes the warning. Thanks! I suppose > you're going to use these accessors in the near future !? Yes, that is the plan. https://github.com/llvm/llvm-project/pull/141259 ___ lldb-commits mailing list

[Lldb-commits] [lldb] b878e0d - [LLDB] Fix warning about unused private members. (#141259)

2025-05-23 Thread via lldb-commits
Author: cmtice Date: 2025-05-23T10:18:05-07:00 New Revision: b878e0d11874a898bbaa1daf58007dfd232005f2 URL: https://github.com/llvm/llvm-project/commit/b878e0d11874a898bbaa1daf58007dfd232005f2 DIFF: https://github.com/llvm/llvm-project/commit/b878e0d11874a898bbaa1daf58007dfd232005f2.diff LOG: [

[Lldb-commits] [lldb] [LLDB] Add field member operators to DIL (PR #138093)

2025-05-23 Thread Kazu Hirata via lldb-commits
kazutakahirata wrote: > I think this should fix the problem: #141259 . Kazu, could you verify that it > does please? @cmtice Yes, it does. I've LGTMed #141259. Thank you for fixing this quickly! https://github.com/llvm/llvm-project/pull/138093 ___

[Lldb-commits] [lldb] [LLDB] Fix warning about unused private members. (PR #141259)

2025-05-23 Thread via lldb-commits
https://github.com/cmtice closed https://github.com/llvm/llvm-project/pull/141259 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Minor change to stdio client name. (PR #141266)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Minor change to stdio client name. (PR #141266)

2025-05-23 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/141266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -131,9 +133,10 @@ def verify_breakpoint_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT): # So when looking at the description we just want to make sure # the right breakpoint matches and not worry about the actual # locatio

[Lldb-commits] [lldb] [lldb/cmake] Don't call llvm_process_sources (PR #141217)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141217 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (PR #141220)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/141220 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][ELF Core] Support all the Generic (Negative) SI Codes. (PR #140150)

2025-05-23 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > Now for tests. The tests for the UnixSignals part are great, but I'm not sure > if there's a test for the end-to-end flow. It possible this automatically > code is tested by one of the existing core file. Could you check if anything > breaks if you e.g. change GetDescriptionFr

[Lldb-commits] [lldb] b2bb0f9 - [lldb-dap] Minor change to stdio client name. (#141266)

2025-05-23 Thread via lldb-commits
Author: John Harrison Date: 2025-05-23T11:09:19-07:00 New Revision: b2bb0f9764681b15d7813e1dfba3b2877cce1b42 URL: https://github.com/llvm/llvm-project/commit/b2bb0f9764681b15d7813e1dfba3b2877cce1b42 DIFF: https://github.com/llvm/llvm-project/commit/b2bb0f9764681b15d7813e1dfba3b2877cce1b42.diff

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread John Harrison via lldb-commits
@@ -104,7 +104,9 @@ def waitUntil(self, condition_callback): time.sleep(0.5) return False -def verify_breakpoint_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT): +def verify_breakpoint_hit( +self, breakpoint_ids, timeout=DEFAULT_TIMEOUT,

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -16,12 +15,61 @@ namespace lldb_dap { +static llvm::Expected +HandleDataBreakpointBytes(DAP &dap, + const protocol::DataBreakpointInfoArguments &args) { + llvm::StringRef address = args.name; + + unsigned long long load_addr = LLDB_INVALID_ADDRES

[Lldb-commits] [lldb] Support breakpoint info bytes (PR #141122)

2025-05-23 Thread Ebuka Ezike via lldb-commits
@@ -131,9 +133,10 @@ def verify_breakpoint_hit(self, breakpoint_ids, timeout=DEFAULT_TIMEOUT): # So when looking at the description we just want to make sure # the right breakpoint matches and not worry about the actual # locatio

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From b9930c61eff81d3b0c84357d1af86b110ce60ebf Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From fcb4a366d9f4659273480f49c491fc50a179cfff Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th

[Lldb-commits] [lldb] [lldb-dap] Minor change to stdio client name. (PR #141266)

2025-05-23 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/141266 Update the stdin <-> stdout client name to `stdio`. I noticed on macOS if I get a crash report from lldb-dap the `/` in the client name causes some thread names to be reported without the full name. For example

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/141284 Use the if statement with an initializer pattern that's very common in LLVM in SBTarget. Every time someone adds a new method to SBTarget, I want to encourage using this pattern, but I don't because it wou

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use the if statement with an initializer pattern that's very common in LLVM in SBTarget. Every time someone adds a new method to SBTarget, I want to encourage using this pattern, but I don't because

[Lldb-commits] [lldb] [lldb] Use if-with-initializer pattern in SBTarget (NFC) (PR #141284)

2025-05-23 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The diff looks a whole lot less intimidating when ignoring whitespace changes. https://github.com/llvm/llvm-project/pull/141284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-23 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-23 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/141290 When running a process that would exit before LLDB could stop the target, it would try to interpret (and subsequently format) the exit code as a Win32 error. However, processes on Windows won't return Win32 err

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes When running a process that would exit before LLDB could stop the target, it would try to interpret (and subsequently format) the exit code as a Win32 error. However, processes on Windows won't return Win32 errors i

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-23 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/141290 >From aacbcb49354bfd29b21934a26748d58a3b4ae130 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 23 May 2025 21:47:40 +0200 Subject: [PATCH] [LLDB] Show exit code on Windows if process can't launch --- .../Win

[Lldb-commits] [lldb] [LLDB] Show exit code on Windows if process can't launch (PR #141290)

2025-05-23 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,c -- lldb/test/API/windows/launch/missing-dll/dummy_dll.

[Lldb-commits] [lldb] 35c15e4 - [lldb-dap] Fix address comparison in DisassembleRequestHandler (#140975)

2025-05-23 Thread via lldb-commits
Author: Ely Ronnen Date: 2025-05-23T22:17:13+02:00 New Revision: 35c15e41ae9ce0c503efacda592c1aa5eb61e6ec URL: https://github.com/llvm/llvm-project/commit/35c15e41ae9ce0c503efacda592c1aa5eb61e6ec DIFF: https://github.com/llvm/llvm-project/commit/35c15e41ae9ce0c503efacda592c1aa5eb61e6ec.diff LO

[Lldb-commits] [lldb] [lldb-dap] Fix address comparison in DisassembleRequestHandler (PR #140975)

2025-05-23 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen closed https://github.com/llvm/llvm-project/pull/140975 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][headers] Create script to fix up versioning (PR #141116)

2025-05-23 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/141116 >From 975f510e96e0775db29b2f5bcdb9b838a8e4e95f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 22 May 2025 11:00:06 -0700 Subject: [PATCH] [lldb][headers] Create script to fix up versioning Th