Author: Pavel Labath Date: 2025-05-23T09:23:53+02:00 New Revision: f1cf168a6fbfa28eca2bebb4493966dc63c925c5
URL: https://github.com/llvm/llvm-project/commit/f1cf168a6fbfa28eca2bebb4493966dc63c925c5 DIFF: https://github.com/llvm/llvm-project/commit/f1cf168a6fbfa28eca2bebb4493966dc63c925c5.diff LOG: [lldb/cmake] Remove a no-op statement (#141063) Like the comment says, this really is a no-op and has no effect on the generated build commands. Added: Modified: lldb/cmake/modules/AddLLDB.cmake Removed: ################################################################################ diff --git a/lldb/cmake/modules/AddLLDB.cmake b/lldb/cmake/modules/AddLLDB.cmake index 0a81ec5092185..41f9b28a0ab39 100644 --- a/lldb/cmake/modules/AddLLDB.cmake +++ b/lldb/cmake/modules/AddLLDB.cmake @@ -93,13 +93,6 @@ function(add_lldb_library name) set(libkind STATIC) endif() - #PIC not needed on Win - # FIXME: Setting CMAKE_CXX_FLAGS here is a no-op, use target_compile_options - # or omit this logic instead. - if (NOT WIN32) - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fPIC") - endif() - if (PARAM_OBJECT) add_library(${name} ${libkind} ${srcs}) else() _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
