https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/141266
Update the stdin <-> stdout client name to `stdio`. I noticed on macOS if I get
a crash report from lldb-dap the `/` in the client name causes some thread
names to be reported without the full name. For example `Thread 6 Crashed::
*/stdout.event_handler`. Switching to `stdio` I think is still clear and not
truncated in the macOS crash reports.
>From 6a25ac8be9d030d73872a9a1c3b2469425a868ae Mon Sep 17 00:00:00 2001
From: John Harrison <harj...@google.com>
Date: Fri, 23 May 2025 10:56:59 -0700
Subject: [PATCH] [lldb-dap] Minor change to stdio client name.
Update the stdin <-> stdout client name to `stdio`. I noticed on macOS if I get
a crash report from lldb-dap the `/` in the client name causes some thread
names to be reported without the full name. For example `Thread 6 Crashed::
*/stdout.event_handler`. Switching to `stdio` I think is still clear and not
truncated in the macOS crash reports.
---
lldb/tools/lldb-dap/tool/lldb-dap.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lldb/tools/lldb-dap/tool/lldb-dap.cpp
b/lldb/tools/lldb-dap/tool/lldb-dap.cpp
index 7a4cc70902a56..9b9de5e21a742 100644
--- a/lldb/tools/lldb-dap/tool/lldb-dap.cpp
+++ b/lldb/tools/lldb-dap/tool/lldb-dap.cpp
@@ -542,7 +542,7 @@ int main(int argc, char *argv[]) {
lldb::IOObjectSP output = std::make_shared<NativeFile>(
stdout_fd, File::eOpenOptionWriteOnly, NativeFile::Unowned);
- constexpr llvm::StringLiteral client_name = "stdin/stdout";
+ constexpr llvm::StringLiteral client_name = "stdio";
Transport transport(client_name, log.get(), input, output);
DAP dap(log.get(), default_repl_mode, pre_init_commands, transport);
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
