labath wrote:
cool
https://github.com/llvm/llvm-project/pull/135944
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Ebuka Ezike
Date: 2025-04-22T12:21:23+01:00
New Revision: d7d170656404e1cb29a51689fd66a12bc060c630
URL:
https://github.com/llvm/llvm-project/commit/d7d170656404e1cb29a51689fd66a12bc060c630
DIFF:
https://github.com/llvm/llvm-project/commit/d7d170656404e1cb29a51689fd66a12bc060c630.diff
L
https://github.com/da-viper closed
https://github.com/llvm/llvm-project/pull/135626
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-04-22T13:53:16+02:00
New Revision: 84cd0d3c38e40e4cb5e416684ecd84df914e19aa
URL:
https://github.com/llvm/llvm-project/commit/84cd0d3c38e40e4cb5e416684ecd84df914e19aa
DIFF:
https://github.com/llvm/llvm-project/commit/84cd0d3c38e40e4cb5e416684ecd84df914e19aa.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/135333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Don't forget to update the protocol passed to the
GDBRemoteCommunicationServerPlatform constructor.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/123732
>From 68b192e29131d04f38474b7ad44e84aff41a8c21 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Tue, 21 Jan 2025 11:50:31 +0100
Subject: [PATCH] [lldb] Preparation for DWARF indexing speedup
This is part of the
labath wrote:
ping
https://github.com/llvm/llvm-project/pull/123732
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
Agreed
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
IIUC, the `${separator}` thingy could be used in places other than the status
line, so maybe the setting controlling it shouldn't be called
`statusline-separator` ?
https://github.com/llvm/llvm-project/pull/136611
___
lldb-commits maili
https://github.com/hapee updated
https://github.com/llvm/llvm-project/pull/136649
>From 563cbddfe9b7da394c818a03e05924c0f7d39d5f Mon Sep 17 00:00:00 2001
From: hapee <623151...@qq.com>
Date: Tue, 22 Apr 2025 11:34:38 +0800
Subject: [PATCH] [lldb] Fix crash after second run when set a pre
DavidSpickett wrote:
I think I can test this on Arm's Foundation Model, I will do that and get back
to you. I have not checked it before now.
https://github.com/llvm/llvm-project/pull/135563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/hapee closed
https://github.com/llvm/llvm-project/pull/136649
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
labath wrote:
In that case, what would say to filtering this process out inside the AIX
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/hapee created
https://github.com/llvm/llvm-project/pull/136682
This PR fixes a crash in `LLDB` caused by a dangling pointer to a reused
`ValueObjectSP` when re-running the debuggee and setting the same watchpoint
again.
As described by @jasonmolenda, the fix is to reini
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (hapee)
Changes
This PR fixes a crash in `LLDB` caused by a dangling pointer to a reused
`ValueObjectSP` when re-running the debuggee and setting the same watchpoint
again.
As described by @jasonmolenda, the fix is to reinitializ
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/135342
>From 966b50e5a2a8cf7508d2b00f04ff2758d1420c30 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 11 Apr 2025 12:06:15 +0200
Subject: [PATCH] [lldb] Clean up StartDebugserverProcess before I start
refactorin
Author: anjenner
Date: 2025-04-22T09:45:15+01:00
New Revision: c3f815ba82defc84244a9688fd2578da513340fb
URL:
https://github.com/llvm/llvm-project/commit/c3f815ba82defc84244a9688fd2578da513340fb
DIFF:
https://github.com/llvm/llvm-project/commit/c3f815ba82defc84244a9688fd2578da513340fb.diff
LOG:
https://github.com/anjenner closed
https://github.com/llvm/llvm-project/pull/136121
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-04-22T08:53:01Z
New Revision: 382263376fcfed967f5bc17400d9e4542b37801c
URL:
https://github.com/llvm/llvm-project/commit/382263376fcfed967f5bc17400d9e4542b37801c
DIFF:
https://github.com/llvm/llvm-project/commit/382263376fcfed967f5bc17400d9e4542b37801c.diff
LOG
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -15,10 +15,10 @@ set (FILES
XMLTest.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android")
+if (CMAKE_SYSTEM_NAME MATCHES "Linux|Android|AIX")
labath wrote:
```suggestion
if (UNIX)
```
If individual tests fail on some systems. We can disable them there.
@@ -7,17 +7,135 @@
//===--===//
#include "lldb/Host/Host.h"
+#include "lldb/Host/posix/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/ProcessInfo.h"
#inc
@@ -7,21 +7,24 @@
//===--===//
#include "lldb/Host/linux/Support.h"
+#include "lldb/Host/posix/Support.h"
#include "llvm/Support/Threading.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TES
https://github.com/labath commented:
Looks pretty good. Just a couple of details.
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
labath wrote:
Why is that? Does process zero exist on AIX?
https://github.com/llvm/llvm
@@ -7,21 +7,24 @@
//===--===//
#include "lldb/Host/linux/Support.h"
+#include "lldb/Host/posix/Support.h"
#include "llvm/Support/Threading.h"
#include "gtest/gtest.h"
using namespace lldb_private;
TES
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
This process is basically for swapper/scheduling work. And yes its
labath wrote:
> > I can push the button for you if you could just update the patch
> > description to what you'd like the commit message to say (in particular, I
> > think the last paragraph is no longer correct).
> > As for cherry-picking, is this related to the lldb-server platform refactor
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
Make sense.
Thanks for the suggestion let me make the changes.
h
Michael137 wrote:
`clang-format` failure is a false positive. I just copied a bunch of test-cases
from the demangler test-suite and some of those happen to include the string
`UndefValue::get` in them.
https://github.com/llvm/llvm-project/pull/131836
___
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
labath wrote:
I see... Well, that could be a bit tricky (not just for this test, but in
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `openmp-s390x-linux`
running on `systemz-1` while building `lldb,llvm` at step 6 "test-openmp".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/88/builds/10746
Here is the relevant piece of the build l
Author: Pavel Labath
Date: 2025-04-22T11:38:55+02:00
New Revision: adb671ea23af72c0fa1acd42103a5e9ca413d729
URL:
https://github.com/llvm/llvm-project/commit/adb671ea23af72c0fa1acd42103a5e9ca413d729
DIFF:
https://github.com/llvm/llvm-project/commit/adb671ea23af72c0fa1acd42103a5e9ca413d729.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/135342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Yuval Deutscher
Date: 2025-04-22T11:43:23+02:00
New Revision: a86f4ee774e6d2eb9f38502ddda65842179a246a
URL:
https://github.com/llvm/llvm-project/commit/a86f4ee774e6d2eb9f38502ddda65842179a246a
DIFF:
https://github.com/llvm/llvm-project/commit/a86f4ee774e6d2eb9f38502ddda65842179a246a.dif
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/131609
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
@yuvald-sweet-security Congratulations on having your first Pull Request (PR)
merged into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
ProcessInstanceInfo Info;
+#ifndef _AIX
HemangGadhavi wrote:
Yes process zero exist on AIX. That is the reason disabled for AIX
Author: Pavel Labath
Date: 2025-04-22T10:14:03+02:00
New Revision: a22ad659cd0665669d89fae174f9e6a83d1a446d
URL:
https://github.com/llvm/llvm-project/commit/a22ad659cd0665669d89fae174f9e6a83d1a446d
DIFF:
https://github.com/llvm/llvm-project/commit/a22ad659cd0665669d89fae174f9e6a83d1a446d.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/135528
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/135342
>From 932830b169fd28f536382639a2bc46482962866d Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 11 Apr 2025 12:06:15 +0200
Subject: [PATCH] [lldb] Clean up StartDebugserverProcess before I start
refactorin
hapee wrote:
@jasonmolenda Please review this commit.
https://github.com/llvm/llvm-project/pull/136682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Pavel Labath
Date: 2025-04-22T15:35:53+02:00
New Revision: 616e8cc1fa0319819aa6978af0af9a3e4896103a
URL:
https://github.com/llvm/llvm-project/commit/616e8cc1fa0319819aa6978af0af9a3e4896103a
DIFF:
https://github.com/llvm/llvm-project/commit/616e8cc1fa0319819aa6978af0af9a3e4896103a.diff
https://github.com/charles-zablit created
https://github.com/llvm/llvm-project/pull/136693
This patch replaces the use of `UINT32_MAX` as the error return value of
`GetIndexOfChildWithName` with `llvm::Expected`.
>From 143140ca46927e87019dcc818702785ebdb15540 Mon Sep 17 00:00:00 2001
From: Cha
omjavaid wrote:
the reported number of symbols is zero on Windows
"symbolsLoaded": 0,
...
},
...
],
...
"totalSymbolTablesLoaded": 0,
"totalSymbolsLoaded": 0
}
https://github.com/llvm/llvm-project/pull/136226
___
lldb-commits
DavidSpickett wrote:
I think this relates to:
> 2.17 Code Addresses, Ranges and Base Addresses
> <...>
> The base address of the scope for any of the debugging information entries
> listed
> above is given by either the DW_AT_low_pc attribute or the first address in
> the
> first range entry in
DavidSpickett wrote:
> In particular the dynamic loader in the next debian release (trixie) has
> functions like this which means that lldb spews a bunch warning when
> debugging pretty much any binary
If you add this to the PR description, anyone downstream of us seeing this
error will have
@@ -488,10 +488,12 @@
lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::GetChildAtIndex(
return m_pair_sp->GetChildAtIndex(idx);
}
-size_t lldb_private::formatters::LibCxxMapIteratorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibCxxMapIterator
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -173,7 +173,8 @@
lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::Update() {
return ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdProxyArraySyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdProxyArraySyntheti
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -1045,12 +1052,14 @@
lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
}
template
-size_t lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
+llvm::Expected
+lldb_private::formatters::GenericNSDictionaryMSyntheticFrontEnd<
D32, D64>::GetI
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -248,14 +249,17 @@
lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxVectorBoolSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxVectorBoolSynthetic
@@ -319,40 +319,41 @@
ValueObjectSynthetic::GetChildMemberWithName(llvm::StringRef name,
bool can_create) {
UpdateValueIfNeeded();
- uint32_t index = GetIndexOfChildWithName(name);
+ auto index_or_err = GetIndexOfChildWithName(
@@ -612,9 +611,9 @@
lldb_private::formatters::GenericNSArrayISyntheticFrontEnd::
}
template
-size_t
-lldb_private::formatters::GenericNSArrayISyntheticFrontEnd::
- GetIndexOfChildWithName(ConstString name) {
+llvm::Expected
+lldb_private::formatters::GenericNSArrayISyntheti
@@ -130,9 +130,14 @@
lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::GetChildAtIndex(
return nullptr;
}
-size_t lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdAtomicSyntheticFrontEnd::
GetInd
@@ -456,7 +460,7 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
+ StringLayout layout = l->GetIndexOfChildWithName("__data_").get() == 0
Michael137 wrote:
This wo
@@ -152,7 +152,8 @@
lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::
+llvm::Expected
+lldb_private::formatters::LibcxxStdVectorSyntheticFront
@@ -20,9 +20,12 @@ class QueueFrontEnd : public SyntheticChildrenFrontEnd {
Update();
}
- size_t GetIndexOfChildWithName(ConstString name) override {
-return m_container_sp ? m_container_sp->GetIndexOfChildWithName(name)
- : UINT32_MAX;
+ l
@@ -202,8 +202,13 @@ class VariantFrontEnd : public SyntheticChildrenFrontEnd {
Update();
}
- size_t GetIndexOfChildWithName(ConstString name) override {
-return formatters::ExtractIndexFromString(name.GetCString());
+ llvm::Expected GetIndexOfChildWithName(ConstSt
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
labath wrote:
(and yes, `look_me_up` is in the middle of th
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
labath wrote:
It's because the range `[.Lfoo_inl.__part.1,
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/132395
>From 3326940bbae82afa6b19e1ee696447a39ea3723b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 21 Mar 2025 14:04:12 +0100
Subject: [PATCH 1/2] [lldb/DWARF] Remove "range lower than function low_pc"
check
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/132395
>From 3326940bbae82afa6b19e1ee696447a39ea3723b Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Fri, 21 Mar 2025 14:04:12 +0100
Subject: [PATCH 1/2] [lldb/DWARF] Remove "range lower than function low_pc"
check
@@ -218,10 +218,11 @@ bool
ScriptedSyntheticChildren::FrontEnd::MightHaveChildren() {
return m_interpreter->MightHaveChildrenSynthProviderInstance(m_wrapper_sp);
}
-size_t ScriptedSyntheticChildren::FrontEnd::GetIndexOfChildWithName(
-ConstString name) {
+llvm::Expected
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -28,7 +28,7 @@ class GenericBitsetFrontEnd : public
SyntheticChildrenFrontEnd {
GenericBitsetFrontEnd(ValueObject &valobj, StdLib stdlib);
- size_t GetIndexOfChildWithName(ConstString name) override {
+ llvm::Expected GetIndexOfChildWithName(ConstString name) override
Author: Muhammad Omair Javaid
Date: 2025-04-22T18:03:54+05:00
New Revision: 974a8ccb2b9f5b930ce47f65122b5a86481e57fe
URL:
https://github.com/llvm/llvm-project/commit/974a8ccb2b9f5b930ce47f65122b5a86481e57fe
DIFF:
https://github.com/llvm/llvm-project/commit/974a8ccb2b9f5b930ce47f65122b5a86481e57
Author: Pavel Labath
Date: 2025-04-22T14:41:59+02:00
New Revision: 587206a442ebb656f9d72e7e0cc5845ef3a2f7ed
URL:
https://github.com/llvm/llvm-project/commit/587206a442ebb656f9d72e7e0cc5845ef3a2f7ed
DIFF:
https://github.com/llvm/llvm-project/commit/587206a442ebb656f9d72e7e0cc5845ef3a2f7ed.diff
labath wrote:
> I think this relates to:
>
> > 2.17 Code Addresses, Ranges and Base Addresses
> > <...>
> > The base address of the scope for any of the debugging information entries
> > listed
> > above is given by either the DW_AT_low_pc attribute or the first address in
> > the
> > first ra
Jlalond wrote:
@dmpots adding you after our conversation yesterday as an FYI
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/136633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid wrote:
I have tested the using clang and used lld-link as the default linker the
symbols are still zero. For now I have added a bypass commit for this to make
buildbot happy.
https://github.com/llvm/llvm-project/pull/136226
___
lldb-commits
labath wrote:
ping ping :)
https://github.com/llvm/llvm-project/pull/132395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
The priority of this has increased from "it's a niche feature only used by
google" to "it's used by *everyone*" because (as I was made aware of at the dev
meeting), gcc has started producing functions like this on a regular basis. In
particular the dynamic loader in the next debi
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
On first walkthrough
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -13,6 +13,8 @@
#include "lldb/API/SBDefines.h"
#include "lldb/API/SBType.h"
+#include "lldb/Core/Value.h"
Michael137 wrote:
drive-by change?
https://github.com/llvm/llvm-project/pull/136693
___
lldb-commits mail
@@ -172,8 +173,15 @@ bool lldb_private::formatters::BlockPointerSummaryProvider(
static const ConstString s_FuncPtr_name("__FuncPtr");
- lldb::ValueObjectSP child_sp = synthetic_children->GetChildAtIndex(
- synthetic_children->GetIndexOfChildWithName(s_FuncPtr_name));
@@ -704,13 +704,17 @@ SBValue SBValue::GetChildAtIndex(uint32_t idx,
uint32_t SBValue::GetIndexOfChildWithName(const char *name) {
LLDB_INSTRUMENT_VA(this, name);
- uint32_t idx = UINT32_MAX;
ValueLocker locker;
lldb::ValueObjectSP value_sp(GetSP(locker));
if (valu
@@ -199,10 +199,12 @@
lldb_private::formatters::StdlibCoroutineHandleSyntheticFrontEnd::Update() {
return lldb::ChildCacheState::eRefetch;
}
-size_t StdlibCoroutineHandleSyntheticFrontEnd::GetIndexOfChildWithName(
+llvm::Expected
+StdlibCoroutineHandleSyntheticFrontEnd::Get
@@ -489,7 +490,13 @@ llvm::Error Interpret(std::vector
&control,
TYPE_CHECK(Object, String);
auto name = data.Pop();
POP_VALOBJ(valobj);
-data.Push((uint64_t)valobj->GetIndexOfChildWithName(name));
+auto index_or_err = valobj->GetIndexOf
JDevlieghere wrote:
This will need a test. The issue has a fairly simple reproducer that should be
easily converted into a test case.
https://github.com/llvm/llvm-project/pull/136682
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://li
@@ -42,6 +27,21 @@ look_me_up:
.size foo.__part.1, .Lfoo.__part.1_end-foo.__part.1
+bar:
+nop
+.Lbar_end:
+.size bar, .Lbar_end-bar
+
+.type foo,@function
+foo:
DavidSpickett wrote:
Trying to understand the change here.
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/123732
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
LGTM modulo `RunLLDBCommandsVerbatim`.
https://github.com/llvm/llvm-project/pull/135008
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -81,18 +85,23 @@ bool RunLLDBCommands(lldb::SBDebugger &debugger,
llvm::StringRef prefix,
/// If \b false, then command prefixes like \b ! or \b ? are not parsed and
/// each command is executed verbatim.
///
+/// \param[in] echo_commands
+/// If \b true, the co
DavidSpickett wrote:
> which (according to the paragraph you quote) means that the function's entry
> point is 0x1cfb0, which is not the lowest address in the function.
I managed to nitpick the text but then go on to assume the ranges would be
sorted with start address increasing. Bad idea.
B
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/132395
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Charles Zablit (charles-zablit)
Changes
This patch replaces the use of `UINT32_MAX` as the error return value of
`GetIndexOfChildWithName` with `llvm::Expected`.
---
Patch is 66.88 KiB, truncated to 20.00 KiB below, full version:
https:/
omjavaid wrote:
this PR caused lldb windows buildbot to fail
https://lab.llvm.org/buildbot/#/builders/141/builds/8084
https://github.com/llvm/llvm-project/pull/136226
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
DavidSpickett wrote:
Might be another case of us building with clang, producing DWARF, then linking
with link.exe which discards the DWARF. I've skipped a few tests for this
already.
(though I wonder if we should just be using lld anyway)
https://github.com/llvm/llvm-project/pull/136226
_
royitaqi wrote:
@dmpots: See the comments above and the revert of #136236. Both are about the
symbol count being inconsistent under different configurations (os, linker,
debug info plug-in etc; so far it's not clear what is causing the difference).
I propose that for both PR we should remove t
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/135008
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> IIUC, the `${separator}` thingy could be used in places other than the status
> line, so maybe the setting controlling it shouldn't be called
> `statusline-separator` ?
I noticed the discrepancy between the format string (`${separator}`) and the
setting (`statusline-sepa
Author: Jonas Devlieghere
Date: 2025-04-22T22:38:28-07:00
New Revision: 3ccfbc8a002e1e0f64b5408d26bc42282afc194b
URL:
https://github.com/llvm/llvm-project/commit/3ccfbc8a002e1e0f64b5408d26bc42282afc194b
DIFF:
https://github.com/llvm/llvm-project/commit/3ccfbc8a002e1e0f64b5408d26bc42282afc194b.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/136779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 180 matches
Mail list logo
