royitaqi wrote: @dmpots: See the comments above and the revert of #136236. Both are about the symbol count being inconsistent under different configurations (os, linker, debug info plug-in etc; so far it's not clear what is causing the difference).
I propose that for both PR we should remove the verification about the symbol count. Reasons: 1. This PR(#136226)'s goal is to add symbol count to stats dump. The goal isn't to assure that the count is zero or not. 2. In #136236, we should drop the test case in TestStats.py, because there is no guarantee that a different configuration won't cause the symbols to be loaded during target creation. WDYT? https://github.com/llvm/llvm-project/pull/136226 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
