================
@@ -40,8 +40,9 @@ TEST_F(HostTest, GetProcessInfo) {
        triple.getEnvironment() == llvm::Triple::EnvironmentType::Android));
 
   ProcessInstanceInfo Info;
+#ifndef _AIX
----------------
labath wrote:

In that case, what would say to filtering this process out inside the AIX 
implementation? (basically add something like `if (pid == 0) return false;`)

In theory, I suppose that someone may want to get the process information of 
the process zero, but i doubt it's an important use case since we normally call 
this while attaching to a process. And it would ensure that 
`GetProcessInfo(LLDB_INVALID_PROCESS_ID)` behaves the same way everywhere (we 
could also change this test to use the LLDB_INVALID_PROCESS_ID macro to make it 
clear that it's checking for an "invalid" process).

https://github.com/llvm/llvm-project/pull/134354
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to