[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -1692,6 +1692,22 @@ class Target : public std::enable_shared_from_this, } }; +/// The private implementation backing SBLock. +class APILock { +public: + APILock(std::shared_ptr mutex_sp) + : m_mutex(std::move(mutex_sp)), m_lock(*m_mutex) {} + + void Lock() { m_loc

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,59 @@ +//===-- SBMutex.cpp bulbazord wrote: Broken header https://github.com/llvm/llvm-project/pull/133295 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,48 @@ +//===-- SBMutex.h +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

@@ -0,0 +1,59 @@ +//===-- SBMutex.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] 8244f82 - [lldb] Emit progress events in SymbolFileDWARFDebugMap (#133211)

Author: Jonas Devlieghere Date: 2025-03-27T13:09:38-07:00 New Revision: 8244f8210f2e62f68429a0daf104fd483ada45ab URL: https://github.com/llvm/llvm-project/commit/8244f8210f2e62f68429a0daf104fd483ada45ab DIFF: https://github.com/llvm/llvm-project/commit/8244f8210f2e62f68429a0daf104fd483ada45ab.d

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/133211 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

https://github.com/jasonmolenda approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/20] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

jimingham wrote: > Do we want to just do the "command script import" _after_ the target is > created to avoid this? > > Or it would be great to have a way for a python script to add a callback > function to be run after a target is created. So this diff could just do > something like: > > ``

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/133299 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

https://github.com/adrian-prantl approved this pull request. As the person who suggested this change, I think this is a _great_ idea :-) https://github.com/llvm/llvm-project/pull/133315 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jacob Lalonde (Jlalond) Changes In the original SBProgress patch, #123837, I didn't ensure the debugger was broadcasting these events to the CLI. This patch addresses that. [Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jacob Lalonde via lldb-commits

https://github.com/Jlalond created https://github.com/llvm/llvm-project/pull/133309 In the original SBProgress patch, #123837, I didn't ensure the debugger was broadcasting these events to the CLI. This patch addresses that. https://github.com/user-attachments/assets/5eb93a46-1db6-4d46-a6b7-2b

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread via lldb-commits

https://github.com/satyajanga approved this pull request. https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jacob Lalonde via lldb-commits

Jlalond wrote: > I am fine with this being always enabled. I will defer to Jonas to make sure > he is So @JDevlieghere and I agreed on adding this to the default listener which is currently the case. But because we only tested DAP after we added the new broadcast bit, this fell through the cr

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "Reland: [clang] preserve class type sugar when taking pointer to member" (PR #132280)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes Reverts llvm/llvm-project#132234 Needs to be reverted due to dependency. This blocks reverting another PR, see here: https://github.com/llvm/llvm-project/pull/131965#issuecomment-2741619498 --- Patch

[Lldb-commits] [lldb] e60e064 - [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (#132128)

2025-03-27 Thread via lldb-commits

Author: Jason Molenda Date: 2025-03-20T13:31:46-07:00 New Revision: e60e0641583a144703433579b8f241276637fdb0 URL: https://github.com/llvm/llvm-project/commit/e60e0641583a144703433579b8f241276637fdb0 DIFF: https://github.com/llvm/llvm-project/commit/e60e0641583a144703433579b8f241276637fdb0.diff

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 30bb0c4 - [lldb-dap] Adding a DAPError for showing users error messages. (#132255)

2025-03-27 Thread via lldb-commits

Author: John Harrison Date: 2025-03-20T15:33:05-07:00 New Revision: 30bb0c443e163b244d663c88821524b6e747747b URL: https://github.com/llvm/llvm-project/commit/30bb0c443e163b244d663c88821524b6e747747b DIFF: https://github.com/llvm/llvm-project/commit/30bb0c443e163b244d663c88821524b6e747747b.diff

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath created https://github.com/llvm/llvm-project/pull/133240 The x86-specific issue has been fixed with #132122. Watchpoint tests fail on aarch64 with macos<15.0 due to a kernel bug. >From 8f005054261597ddc36f550fcccd050c813cfbf4 Mon Sep 17 00:00:00 2001 From: Pavel Labat

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-27 Thread Pavel Labath via lldb-commits

labath wrote: Thanks for chiming in Jason. It sounds like skipping for macos<15.0 was the right choice then. However, looking at the test decorators, I see they're currently set too broadly. I've created #133240 to tighten them. https://github.com/llvm/llvm-project/pull/128156

[Lldb-commits] [lldb] [lldb] Remove (deprecated) Function::GetAddressRange (PR #132923)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d7cea2b - [lldb] Remove UnwindPlan::Row shared_ptrs (#132370)

2025-03-27 Thread via lldb-commits

Author: Pavel Labath Date: 2025-03-27T11:26:42+01:00 New Revision: d7cea2b18717f0cc31b7da4a03f772d89ee201db URL: https://github.com/llvm/llvm-project/commit/d7cea2b18717f0cc31b7da4a03f772d89ee201db DIFF: https://github.com/llvm/llvm-project/commit/d7cea2b18717f0cc31b7da4a03f772d89ee201db.diff

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits

@@ -38,7 +39,7 @@ enum DWARFProducer { eProducerOther }; -class DWARFUnit : public UserID { +class DWARFUnit : public UserID, public DWARFExpression::Delegate { slydiman wrote: Done. https://github.com/llvm/llvm-project/pull/131645

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-27 Thread Ebuka Ezike via lldb-commits

@@ -0,0 +1,91 @@ +//===-- GoToTargetsRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-27 Thread Ebuka Ezike via lldb-commits

https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach FuncUnwinders about discontinuous functions (PR #133072)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/133072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-03-27 Thread Pavel Labath via lldb-commits

labath wrote: > > @yuvald-sweet-security > > Thanks. This patch means we're still ignoring the arg0 set by `SetArg0`, > right? and just using whatever was in the standard `GetArguments` vector. > Maybe it's worth updating the comment I pointed at ( > > https://github.com/llvm/llvm-project/blo

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath closed https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath updated https://github.com/llvm/llvm-project/pull/133247 >From f4f4d06e485b5d7d28ef2a45ae53d630df5da1c1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 27 Mar 2025 13:53:57 +0100 Subject: [PATCH] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders Thes

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath created https://github.com/llvm/llvm-project/pull/133250 The function had special handling for -1, but that is incompatible with functions whose entry point is not the first address. Use std::nullopt instead. >From b857aa3cb6ced263d0c89d0195ce2f5bcac50d94 Mon Sep 17 0

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The function had special handling for -1, but that is incompatible with functions whose entry point is not the first address. Use std::nullopt instead. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] 39e7efe - [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (#133093)

2025-03-27 Thread via lldb-commits

Author: Pavel Labath Date: 2025-03-27T12:44:56+01:00 New Revision: 39e7efe1e4304544289d8d1b45f4d04d11b4a791 URL: https://github.com/llvm/llvm-project/commit/39e7efe1e4304544289d8d1b45f4d04d11b4a791 DIFF: https://github.com/llvm/llvm-project/commit/39e7efe1e4304544289d8d1b45f4d04d11b4a791.diff

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread Michael Buch via lldb-commits

@@ -936,3 +936,7 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t first_frame, strm.IndentLess(); return num_frames_displayed; } + +void StackFrameList::ClearSelectedFrameIndex() { Michael137 wrote: Hmm we also write to `m_selected_frame_idx` in

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread Michael Buch via lldb-commits

https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/133078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Yuval Deutscher via lldb-commits

https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131519 >From 9519119f3b12854a2198542cfb7f9cff12e910e1 Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Sun, 16 Mar 2025 14:08:57 + Subject: [PATCH] [lldb] Use correct path for lldb-server executab

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Yuval Deutscher via lldb-commits

yuvald-sweet-security wrote: @labath I rebased it https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath approved this pull request. Awesome. Thanks for your patience. https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits

slydiman wrote: > Okay, and what are those conditions? I don't know. Probably code fragmentation within CU or number of references makes the linker to link the entire CU. > someone's compiler/linker Note it is mainline clang/lld. Moving all code used by Module.cpp to a separated module ensur

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Pavel Labath via lldb-commits

https://github.com/labath created https://github.com/llvm/llvm-project/pull/133247 These plans are cached and accessed from multiple threads. Modifying them would be a Bad Idea(tm). >From f4f4d06e485b5d7d28ef2a45ae53d630df5da1c1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 27 Mar 20

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes These plans are cached and accessed from multiple threads. Modifying them would be a Bad Idea(tm). --- Patch is 48.49 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-27 Thread Julius Alexandre via lldb-commits

@@ -436,13 +436,15 @@ Status ABISysV_ppc::SetReturnValueObject(lldb::StackFrameSP &frame_sp, compiler_type.IsPointerType()) { const RegisterInfo *reg_info = reg_ctx->GetRegisterInfoByName("r3", 0); -DataExtractor data; -Status data_error; -size_t num_byt

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits

@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits

@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread via lldb-commits

llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The x86-specific issue has been fixed with #132122. Watchpoint tests fail on aarch64 with macos<15.0 due to a kernel bug. --- Full diff: https://github.com/llvm/llvm-project/pull/133240.diff 2 Files Affected

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-27 Thread Vy Nguyen via lldb-commits

https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/18] [LLDB][Telemetry] Collect telemetry from client when allowed.

<    1   2