labath wrote: > > @yuvald-sweet-security > > Thanks. This patch means we're still ignoring the arg0 set by `SetArg0`, > right? and just using whatever was in the standard `GetArguments` vector. > Maybe it's worth updating the comment I pointed at ( > > https://github.com/llvm/llvm-project/blob/b231f6f86237fc1a15377b4aad6cf9be4808d727/lldb/include/lldb/Utility/ProcessInfo.h#L122-L125 > ) so that this is less confusing?
Yeah, what can I say.. welcome to lldb? The tricky part there is what to say. I believe the comments there are actually match how certain parts of the code use this structure. In particular, I think it matches this code [here](https://github.com/llvm/llvm-project/blob/a9672515ce6b8b1bc6976ed1225f4fb4d53fa381/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp#L2073). It's just that the ProcessLauncher code does something different (but with this patch, at least it does so consistently :/) https://github.com/llvm/llvm-project/pull/133093 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
