[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Pavel Labath (labath)

<details>
<summary>Changes</summary>

The x86-specific issue has been fixed with #<!-- -->132122. Watchpoint tests 
fail on aarch64 with macos&lt;15.0 due to a kernel bug.

---
Full diff: https://github.com/llvm/llvm-project/pull/133240.diff


2 Files Affected:

- (modified) 
lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
 (-8) 
- (modified) 
lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
 (+8-4) 


``````````diff
diff --git 
a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
 
b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
index a159e0f716dbe..0a5f2d88fb917 100644
--- 
a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
+++ 
b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueBreakpoints.py
@@ -10,12 +10,10 @@
 
 class TestReverseContinueBreakpoints(ReverseTestBase):
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue(self):
         self.reverse_continue_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue_async(self):
         self.reverse_continue_internal(async_mode=True)
 
@@ -44,12 +42,10 @@ def reverse_continue_internal(self, async_mode):
         self.assertEqual(process.GetExitStatus(), 0)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue_breakpoint(self):
         self.reverse_continue_breakpoint_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue_breakpoint_async(self):
         self.reverse_continue_breakpoint_internal(async_mode=True)
 
@@ -67,12 +63,10 @@ def reverse_continue_breakpoint_internal(self, async_mode):
         self.assertEqual(threads_now, initial_threads)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue_skip_breakpoint(self):
         self.reverse_continue_skip_breakpoint_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_reverse_continue_skip_breakpoint_async(self):
         self.reverse_continue_skip_breakpoint_internal(async_mode=True)
 
@@ -97,12 +91,10 @@ def reverse_continue_skip_breakpoint_internal(self, 
async_mode):
         )
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_continue_preserves_direction(self):
         self.continue_preserves_direction_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
     def test_continue_preserves_direction_asyhc(self):
         self.continue_preserves_direction_internal(async_mode=True)
 
diff --git 
a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
 
b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
index c942f2a0386e5..a9e1bec5750e7 100644
--- 
a/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
+++ 
b/lldb/test/API/functionalities/reverse-execution/TestReverseContinueWatchpoints.py
@@ -10,12 +10,14 @@
 
 class TestReverseContinueWatchpoints(ReverseTestBase):
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
+    # Watchpoints don't work in single-step mode
+    @skipIf(macos_version=["<", "15.0"], archs=["arm64"])
     def test_reverse_continue_watchpoint(self):
         self.reverse_continue_watchpoint_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
+    # Watchpoints don't work in single-step mode
+    @skipIf(macos_version=["<", "15.0"], archs=["arm64"])
     def test_reverse_continue_watchpoint_async(self):
         self.reverse_continue_watchpoint_internal(async_mode=True)
 
@@ -60,12 +62,14 @@ def reverse_continue_watchpoint_internal(self, async_mode):
         )
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
+    # Watchpoints don't work in single-step mode
+    @skipIf(macos_version=["<", "15.0"], archs=["arm64"])
     def test_reverse_continue_skip_watchpoint(self):
         self.reverse_continue_skip_watchpoint_internal(async_mode=False)
 
     @skipIfRemote
-    @skipIf(macos_version=["<", "15.0"])
+    # Watchpoints don't work in single-step mode
+    @skipIf(macos_version=["<", "15.0"], archs=["arm64"])
     def test_reverse_continue_skip_watchpoint_async(self):
         self.reverse_continue_skip_watchpoint_internal(async_mode=True)
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/133240
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits