[Lldb-commits] [clang] [clang-tools-extra] [lldb] Revert "Reland: [clang] preserve class type sugar when taking pointer to member" (PR #132280)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Matheus Izvekov (mizvekov) Changes Reverts llvm/llvm-project#132234 Needs to be reverted due to dependency. This blocks reverting another PR, see here: https://github.com/llvm/llvm-project/pull/131965#issuecomment-2741619498 --- Patch

[Lldb-commits] [lldb] e60e064 - [lldb][debugserver] Interrupt should reset outstanding SIGSTOP (#132128)

2025-03-27 Thread via lldb-commits
Author: Jason Molenda Date: 2025-03-20T13:31:46-07:00 New Revision: e60e0641583a144703433579b8f241276637fdb0 URL: https://github.com/llvm/llvm-project/commit/e60e0641583a144703433579b8f241276637fdb0 DIFF: https://github.com/llvm/llvm-project/commit/e60e0641583a144703433579b8f241276637fdb0.diff

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 30bb0c4 - [lldb-dap] Adding a DAPError for showing users error messages. (#132255)

2025-03-27 Thread via lldb-commits
Author: John Harrison Date: 2025-03-20T15:33:05-07:00 New Revision: 30bb0c443e163b244d663c88821524b6e747747b URL: https://github.com/llvm/llvm-project/commit/30bb0c443e163b244d663c88821524b6e747747b DIFF: https://github.com/llvm/llvm-project/commit/30bb0c443e163b244d663c88821524b6e747747b.diff

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/133240 The x86-specific issue has been fixed with #132122. Watchpoint tests fail on aarch64 with macos<15.0 due to a kernel bug. >From 8f005054261597ddc36f550fcccd050c813cfbf4 Mon Sep 17 00:00:00 2001 From: Pavel Labat

[Lldb-commits] [lldb] Reapply "[lldb] Implement basic support for reverse-continue (#125242)" (again) (PR #128156)

2025-03-27 Thread Pavel Labath via lldb-commits
labath wrote: Thanks for chiming in Jason. It sounds like skipping for macos<15.0 was the right choice then. However, looking at the test decorators, I see they're currently set too broadly. I've created #133240 to tighten them. https://github.com/llvm/llvm-project/pull/128156

[Lldb-commits] [lldb] [lldb] Remove (deprecated) Function::GetAddressRange (PR #132923)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/132923 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] d7cea2b - [lldb] Remove UnwindPlan::Row shared_ptrs (#132370)

2025-03-27 Thread via lldb-commits
Author: Pavel Labath Date: 2025-03-27T11:26:42+01:00 New Revision: d7cea2b18717f0cc31b7da4a03f772d89ee201db URL: https://github.com/llvm/llvm-project/commit/d7cea2b18717f0cc31b7da4a03f772d89ee201db DIFF: https://github.com/llvm/llvm-project/commit/d7cea2b18717f0cc31b7da4a03f772d89ee201db.diff

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits
@@ -38,7 +39,7 @@ enum DWARFProducer { eProducerOther }; -class DWARFUnit : public UserID { +class DWARFUnit : public UserID, public DWARFExpression::Delegate { slydiman wrote: Done. https://github.com/llvm/llvm-project/pull/131645

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-27 Thread Ebuka Ezike via lldb-commits
@@ -0,0 +1,91 @@ +//===-- GoToTargetsRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [llvm] [lldb][lldb-dap] Implement jump to cursor (PR #130503)

2025-03-27 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper edited https://github.com/llvm/llvm-project/pull/130503 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Teach FuncUnwinders about discontinuous functions (PR #133072)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/133072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-03-27 Thread Pavel Labath via lldb-commits
labath wrote: > > @yuvald-sweet-security > > Thanks. This patch means we're still ignoring the arg0 set by `SetArg0`, > right? and just using whatever was in the standard `GetArguments` vector. > Maybe it's worth updating the comment I pointed at ( > > https://github.com/llvm/llvm-project/blo

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/133093 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/133247 >From f4f4d06e485b5d7d28ef2a45ae53d630df5da1c1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 27 Mar 2025 13:53:57 +0100 Subject: [PATCH] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders Thes

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/133250 The function had special handling for -1, but that is incompatible with functions whose entry point is not the first address. Use std::nullopt instead. >From b857aa3cb6ced263d0c89d0195ce2f5bcac50d94 Mon Sep 17 0

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The function had special handling for -1, but that is incompatible with functions whose entry point is not the first address. Use std::nullopt instead. --- Full diff: https://github.com/llvm/llvm-project/pull/

[Lldb-commits] [lldb] 39e7efe - [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (#133093)

2025-03-27 Thread via lldb-commits
Author: Pavel Labath Date: 2025-03-27T12:44:56+01:00 New Revision: 39e7efe1e4304544289d8d1b45f4d04d11b4a791 URL: https://github.com/llvm/llvm-project/commit/39e7efe1e4304544289d8d1b45f4d04d11b4a791 DIFF: https://github.com/llvm/llvm-project/commit/39e7efe1e4304544289d8d1b45f4d04d11b4a791.diff

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread Michael Buch via lldb-commits
@@ -936,3 +936,7 @@ size_t StackFrameList::GetStatus(Stream &strm, uint32_t first_frame, strm.IndentLess(); return num_frames_displayed; } + +void StackFrameList::ClearSelectedFrameIndex() { Michael137 wrote: Hmm we also write to `m_selected_frame_idx` in

[Lldb-commits] [lldb] [lldb][Target] Clear selected frame index after a StopInfo::PerformAction (PR #133078)

2025-03-27 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/133078 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Yuval Deutscher via lldb-commits
https://github.com/yuvald-sweet-security updated https://github.com/llvm/llvm-project/pull/131519 >From 9519119f3b12854a2198542cfb7f9cff12e910e1 Mon Sep 17 00:00:00 2001 From: Yuval Deutscher Date: Sun, 16 Mar 2025 14:08:57 + Subject: [PATCH] [lldb] Use correct path for lldb-server executab

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: @labath I rebased it https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. Awesome. Thanks for your patience. https://github.com/llvm/llvm-project/pull/131519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > Okay, and what are those conditions? I don't know. Probably code fragmentation within CU or number of references makes the linker to link the entire CU. > someone's compiler/linker Note it is mainline clang/lld. Moving all code used by Module.cpp to a separated module ensur

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/133247 These plans are cached and accessed from multiple threads. Modifying them would be a Bad Idea(tm). >From f4f4d06e485b5d7d28ef2a45ae53d630df5da1c1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 27 Mar 20

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes These plans are cached and accessed from multiple threads. Modifying them would be a Bad Idea(tm). --- Patch is 48.49 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pul

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-27 Thread Julius Alexandre via lldb-commits
@@ -436,13 +436,15 @@ Status ABISysV_ppc::SetReturnValueObject(lldb::StackFrameSP &frame_sp, compiler_type.IsPointerType()) { const RegisterInfo *reg_info = reg_ctx->GetRegisterInfoByName("r3", 0); -DataExtractor data; -Status data_error; -size_t num_byt

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Adrian Vogelsgesang via lldb-commits
@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The x86-specific issue has been fixed with #132122. Watchpoint tests fail on aarch64 with macos<15.0 due to a kernel bug. --- Full diff: https://github.com/llvm/llvm-project/pull/133240.diff 2 Files Affected

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-27 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/129728 >From 21103adacdf9c08cee4065f8a6b90ff812fefbb3 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 4 Mar 2025 11:01:46 -0500 Subject: [PATCH 01/18] [LLDB][Telemetry] Collect telemetry from client when allowed.

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff fbf0276b6a7a7a4508c373cf87fc349569652659 d5840447a35992530963ae910615b1908e2880d2 --e

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/133309 >From d55d7e328300134c723cbc7d0f67ac8c1309ebbb Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Thu, 27 Mar 2025 13:15:46 -0700 Subject: [PATCH] Configure sbprogress events to be emitted for the CLI --- lldb

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond edited https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 0d4f12e - [lldb-dap] Allow providing debug adapter arguments in the extension (#129262)

2025-03-27 Thread via lldb-commits
Author: Matthew Bastien Date: 2025-03-27T14:09:09-07:00 New Revision: 0d4f12ee0046b83d28dbf3a8aca07a0f27b77786 URL: https://github.com/llvm/llvm-project/commit/0d4f12ee0046b83d28dbf3a8aca07a0f27b77786 DIFF: https://github.com/llvm/llvm-project/commit/0d4f12ee0046b83d28dbf3a8aca07a0f27b77786.dif

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread Alex Langford via lldb-commits
@@ -0,0 +1,48 @@ +//===-- SBMutex.h +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] 2a96bec - [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (#133309)

2025-03-27 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-03-27T14:20:43-07:00 New Revision: 2a96beca9b502776d5e2a3be2da3f886135b056e URL: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e DIFF: https://github.com/llvm/llvm-project/commit/2a96beca9b502776d5e2a3be2da3f886135b056e.diff

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks, I'm happy with this! https://github.com/llvm/llvm-project/pull/133007 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [lldb] [SBProgress][CLI] Configure sbprogress events to be emitted for the CLI (PR #133309)

2025-03-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: I am fine with this being always enabled. I will defer to Jonas to make sure he is https://github.com/llvm/llvm-project/pull/133309 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Use the reverse video [1] font effect (`${ansi.negative}`) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared t

[Lldb-commits] [lldb] [lldb] Improve default statusline colors to work with more color schemes (PR #133315)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133315 Use the reverse video [1] font effect (`${ansi.negative}`) as the default for the statusline. Inverting the foreground and background color has a better change as looking reasonably good, compared to picki

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,238 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,131 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,104 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-27 Thread via lldb-commits
@@ -0,0 +1,276 @@ +//===-- DILParser.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
@@ -54,6 +54,79 @@ bool fromJSON(const llvm::json::Value &, DisconnectArguments &, /// body field is required. using DisconnectResponse = VoidResponse; +/// Arguments for `initialize` request. +struct InitializeRequestArguments { + /// The ID of the debug adapter. + std::st

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-27 Thread David Spickett via lldb-commits
DavidSpickett wrote: @JDevlieghere if I start lldb with no arguments: ``` david.spickett@tcwg-jade-03-dev:~/build-llvm-aarch64$ ./bin/lldb << cursor is here at the start of the line, but no (lldb) was printed < the status bar> ``` Does not happen if I have a program file, but this is also strange

[Lldb-commits] [lldb] [lldb] add --platform-available-ports option to the dotest.py (PR #112555)

2025-03-27 Thread via lldb-commits
dlav-sc wrote: > I don't know what else it was going to do :) Yeah, me too, so I've decided to retain the old behavior if `--platform-available-ports` isn’t specified. > Do you need a CMake variable for this too? I wonder how you are getting the > argument to dotest. I don't think I really n

[Lldb-commits] [lldb] [LLDB][Telemetry] Collect telemetry from client when allowed. (PR #129728)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
@@ -965,6 +965,22 @@ SBTarget SBDebugger::GetDummyTarget() { return sb_target; } +void SBDebugger::DispatchClientTelemetry(const lldb::SBStructuredData &entry) { + LLDB_INSTRUMENT_VA(this); + // Disable client-telemetry for SWIG. + // This prevent arbitrary python client

[Lldb-commits] [lldb] Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (PR #133299)

2025-03-27 Thread Jordan Rupprecht via lldb-commits
https://github.com/rupprecht closed https://github.com/llvm/llvm-project/pull/133299 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Jordan Rupprecht via lldb-commits
rupprecht wrote: Saw the same thing running tests internally; reverted. https://github.com/llvm/llvm-project/pull/132370 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 48864a5 - Revert "[lldb] Remove UnwindPlan::Row shared_ptrs (#132370)" (#133299)

2025-03-27 Thread via lldb-commits
Author: Jordan Rupprecht Date: 2025-03-27T14:20:07-05:00 New Revision: 48864a52ef547ac0477271127b510dd9e9798219 URL: https://github.com/llvm/llvm-project/commit/48864a52ef547ac0477271127b510dd9e9798219 DIFF: https://github.com/llvm/llvm-project/commit/48864a52ef547ac0477271127b510dd9e9798219.di

[Lldb-commits] [lldb] [lldb] Expose the Target API lock through the SB API (PR #131404)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The pre-merge bot is using SWIG 4.0.2 which seems to have trouble with the move-only type. I'm going to build that SWIG and see if I can reproduce this. https://github.com/llvm/llvm-project/pull/131404 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Use correct path for lldb-server executable (PR #131519)

2025-03-27 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > I think this #63468 is the same sort of issue. Not sure if it's the same > though. > > As you can tell from me saying "I will get back to this" 2 years ago, the > knowledge of any of that has left my head by now, but thank you for looking > into this. I know it'

[Lldb-commits] [lldb] [lldb-dap] Adding a DAPError for showing users error messages. (PR #132255)

2025-03-27 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/132255 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use correct path for debugserver (PR #131609)

2025-03-27 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: Solves https://github.com/llvm/llvm-project/issues/63468 https://github.com/llvm/llvm-project/pull/131609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [lldb] [lldb] Respect LaunchInfo::SetExecutable in ProcessLauncherPosixFork (PR #133093)

2025-03-27 Thread Yuval Deutscher via lldb-commits
yuvald-sweet-security wrote: > @yuvald-sweet-security Thanks. This patch means we're still ignoring the arg0 set by `SetArg0`, right? and just using whatever was in the standard `GetArguments` vector. Maybe it's worth updating the comment I pointed at (https://github.com/llvm/llvm-project/blo

[Lldb-commits] [lldb] [lldb-dap] Migrating DAP 'initialize' to new typed RequestHandler. (PR #133007)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
@@ -1144,31 +1145,45 @@ lldb::SBValue Variables::FindVariable(uint64_t variablesReference, return variable; } -llvm::StringMap DAP::GetCapabilities() { - llvm::StringMap capabilities; +bool DAP::isSupported(ClientFeature feature) { + return clientFeatures.find(feature) !=

[Lldb-commits] [lldb] 618e8b9 - [lldb] Avoid unnecessary statusline redraw in HandleProgressEvent

2025-03-27 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-03-26T23:35:36-07:00 New Revision: 618e8b9a708ed037ec90c495890344046d78e5bf URL: https://github.com/llvm/llvm-project/commit/618e8b9a708ed037ec90c495890344046d78e5bf DIFF: https://github.com/llvm/llvm-project/commit/618e8b9a708ed037ec90c495890344046d78e5bf.d

[Lldb-commits] [lldb] 71d54cd - [lldb] Remove (deprecated) Function::GetAddressRange (#132923)

2025-03-27 Thread via lldb-commits
Author: Pavel Labath Date: 2025-03-27T11:27:56+01:00 New Revision: 71d54cd4f1cc5233437f25479166e4659fbe2e53 URL: https://github.com/llvm/llvm-project/commit/71d54cd4f1cc5233437f25479166e4659fbe2e53 DIFF: https://github.com/llvm/llvm-project/commit/71d54cd4f1cc5233437f25479166e4659fbe2e53.diff

[Lldb-commits] [compiler-rt] [libcxx] [libcxxabi] [libunwind] [lldb] [llvm] [compiler-rt] Disable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON on AIX. (PR #131200)

2025-03-27 Thread Daniel Chen via lldb-commits
@@ -223,6 +223,13 @@ endif() # This can be used to detect whether we're in the runtimes build. set(LLVM_RUNTIMES_BUILD ON) +if (LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX") + # Set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF as AIX doesn't s

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Adrian Prantl via lldb-commits
@@ -924,59 +947,63 @@ void SymbolFileDWARFDebugMap::FindGlobalVariables( std::lock_guard guard(GetModuleMutex()); uint32_t total_matches = 0; - ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) { -const uint32_t old_size = variables.GetSize(); -oso_dwarf->FindGlob

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Adrian Prantl via lldb-commits
@@ -924,59 +947,63 @@ void SymbolFileDWARFDebugMap::FindGlobalVariables( std::lock_guard guard(GetModuleMutex()); uint32_t total_matches = 0; - ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) { -const uint32_t old_size = variables.GetSize(); -oso_dwarf->FindGlob

[Lldb-commits] [lldb] [lldb] Emit progress events in SymbolFileDWARFDebugMap (PR #133211)

2025-03-27 Thread Adrian Prantl via lldb-commits
@@ -1148,16 +1175,16 @@ SymbolFileDWARFDebugMap::ParseCallEdgesInFunction( DWARFDIE SymbolFileDWARFDebugMap::FindDefinitionDIE(const DWARFDIE &die) { DWARFDIE result; - ForEachSymbolFile([&](SymbolFileDWARF *oso_dwarf) { -result = oso_dwarf->FindDefinitionDIE(die); -

[Lldb-commits] [lldb] [LLDB][NFC] Added the interface DWARFExpression::Delegate to break dependencies and reduce lldb-server size (PR #131645)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: I actually very much like this result. It'd be nice to (try) get rid of the `GetAddressByteSize` method, as I outlined before, but that's better done separately. Just a couple of small changes/improvements inline. https://github.com/llvm/llvm-project/pull/1

[Lldb-commits] [lldb] [lldb] Adjust skips on reverse continue tests (PR #133240)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM, we discussed this yesterday with @rocallahan https://github.com/llvm/llvm-project/pull/133240 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [lldb] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders (PR #133247)

2025-03-27 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/133247 >From f4f4d06e485b5d7d28ef2a45ae53d630df5da1c1 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 27 Mar 2025 13:53:57 +0100 Subject: [PATCH 1/2] [lldb] Return *const* UnwindPlan pointers from FuncUnwinders

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/133290 So the dSYM can be told what target it has been loaded into. When lldb is loading modules, while creating a target, it will run "command script import" on any Python modules in Resources/Python in the dSYM.

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs (PR #132370)

2025-03-27 Thread Michael Buch via lldb-commits
Michael137 wrote: Still double checking but i think this may have broken a couple of macOS x86_64 tests: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/10909/ ``` TestTsanMultiple.test_dsym/a.out") runCmd: env TSAN_OPTIONS=abort_on_error=0 output: runCmd: run warning: li

[Lldb-commits] [lldb] [lldb] Make GetRowForFunctionOffset compatible with discontinuous functions (PR #133250)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/133250 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Move CPlusPlusLanguage methods used in Core/Module.cpp to a separated module to break lldb-server dependencies (PR #132274)

2025-03-27 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: @labath The repro above shows that CPlusPlusLanguage::GetHardcodedSummaries() causes to link TypeSystemClang and other dependencies. But --print-gc-sections and `llvm-objdump --all-headers --demangle lldb-server` shows that GetHardcodedSummaries is missing in the final binary

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Alright, let's go with the copy. Unless you think the `enabled` property might change while we're iterating over the plugins, we should be able to store it in the PluginInstance. AFAIK, the instance itself is never stored away. https://github.com/llvm/llvm-project/pull/132

[Lldb-commits] [lldb] [lldb] Remove raw access to PluginInstances vector (PR #132884)

2025-03-27 Thread David Peixotto via lldb-commits
dmpots wrote: > Alright, let's go with the copy. Unless you think the `enabled` property > might change while we're iterating over the plugins, we should be able to > store it in the PluginInstance. AFAIK, the instance itself is never stored > away. Sounds good. That seems to be the simplest

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Santhosh Kumar Ellendula via lldb-commits
@@ -112,3 +112,48 @@ def test_readMemory(self): # Reads at offset 0x0 fail mem = self.dap_server.request_readMemory("0x0", 0, 6) self.assertEqual(mem["success"], False) + +def test_writeMemory(self): +""" +Tests the 'writeMemory' requ

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes So the dSYM can be told what target it has been loaded into. When lldb is loading modules, while creating a target, it will run "command script import" on any Python modules in Resources/Python in the dSYM. Howeve

[Lldb-commits] [lldb] [lldb] Show target.debug-file-search-paths setting from python SBDebugger (PR #131683)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/131683 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 960615954e4cb3150ae4a479fa7f9d0d17035eea effad9525461611ed47598b53a77ee5aabb0e4cf --e

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 960615954e4cb3150ae4a479fa7f9d0d17035eea...effad9525461611ed47598b53a77ee5aabb0e4cf lldb/

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/131820 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/133295 Expose u target API mutex through the SB API. This is motivated by lldb-dap, which is built on top of the SB API and needs a way to execute a series of SB API calls in an atomic manner (see #131242). We c

[Lldb-commits] [lldb] Add a new affordance that the Python module in a dSYM (PR #133290)

2025-03-27 Thread via lldb-commits
https://github.com/jimingham updated https://github.com/llvm/llvm-project/pull/133290 >From effad9525461611ed47598b53a77ee5aabb0e4cf Mon Sep 17 00:00:00 2001 From: Jim Ingham Date: Thu, 27 Mar 2025 11:04:26 -0700 Subject: [PATCH 1/2] Add a new affordance that the Python module in a dSYM can be

[Lldb-commits] [lldb] [lldb] Expose the Target API mutex through the SB API (PR #133295)

2025-03-27 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/133295 >From 79241d2f5701ab789f7fdbb5bd881c4494cb67eb Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Thu, 27 Mar 2025 11:24:50 -0700 Subject: [PATCH 1/2] [lldb] Expose the Target API mutex through the SB A

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][lldb-dap] Added support for "WriteMemory" request. (PR #131820)

2025-03-27 Thread Greg Clayton via lldb-commits
@@ -0,0 +1,175 @@ +//===-- WriteMemoryRequestHandler.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

  1   2   >