llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) <details> <summary>Changes</summary> Since lldb 20, these have had no effect: https://releases.llvm.org/20.1.0/docs/ReleaseNotes.html#changes-to-lldb > lldb-server now listens to a single port for gdbserver connections and > provides that port to the connection handler processes. This means that > only 2 ports need to be opened in the firewall (one for the lldb-server > platform, one for gdbserver connections). In addition, due to this work, lldb-server now works on Windows in the server mode. Remove them. --- Full diff: https://github.com/llvm/llvm-project/pull/133275.diff 2 Files Affected: - (modified) lldb/tools/lldb-server/lldb-platform.cpp (-2) - (modified) llvm/docs/ReleaseNotes.md (+3) ``````````diff diff --git a/lldb/tools/lldb-server/lldb-platform.cpp b/lldb/tools/lldb-server/lldb-platform.cpp index 880b45b989b9c..24a2ea12ae3f1 100644 --- a/lldb/tools/lldb-server/lldb-platform.cpp +++ b/lldb/tools/lldb-server/lldb-platform.cpp @@ -66,8 +66,6 @@ static struct option g_long_options[] = { {"log-channels", required_argument, nullptr, 'c'}, {"listen", required_argument, nullptr, 'L'}, {"gdbserver-port", required_argument, nullptr, 'P'}, - {"min-gdbserver-port", required_argument, nullptr, 'm'}, - {"max-gdbserver-port", required_argument, nullptr, 'M'}, {"socket-file", required_argument, nullptr, 'f'}, {"server", no_argument, &g_server, 1}, {"child-platform-fd", required_argument, nullptr, 2}, diff --git a/llvm/docs/ReleaseNotes.md b/llvm/docs/ReleaseNotes.md index bb75aec44ef8e..c633d9ca9bd52 100644 --- a/llvm/docs/ReleaseNotes.md +++ b/llvm/docs/ReleaseNotes.md @@ -214,6 +214,9 @@ Changes to LLDB Windows 11 on the Microsoft SQ2 and Snapdragon Elite X platforms. * LLDB now steps through C++ thunks. This fixes an issue where previously, it wouldn't step into multiple inheritance virtual functions. +* The `min-gdbserver-port` and `max-gdbserver-port` options have been removed + from `lldb-server`'s platform mode. Since the changes to `lldb-server`'s port + handling in LLDB 20, these options have had no effect. ### Changes to lldb-dap `````````` </details> https://github.com/llvm/llvm-project/pull/133275 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
