chrisPyr wrote:
Ok, to make it clear, I’ll split it up by projects.
And I will leave function local variables as-is.
Is that fair enough?
On Sat, Feb 8, 2025 at 04:45 Vitaly Buka ***@***.***> wrote:
> All these changes are independent and quite straight forward.
>
> I'd suggest to split in some
https://github.com/SixWeining approved this pull request.
https://github.com/llvm/llvm-project/pull/126204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Tiezhu Yang
Date: 2025-02-08T10:31:48+08:00
New Revision: ff79d83caeeea8457f69406f38801fe8893bbfd8
URL:
https://github.com/llvm/llvm-project/commit/ff79d83caeeea8457f69406f38801fe8893bbfd8
DIFF:
https://github.com/llvm/llvm-project/commit/ff79d83caeeea8457f69406f38801fe8893bbfd8.diff
L
https://github.com/SixWeining closed
https://github.com/llvm/llvm-project/pull/126204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/116392
>From 88a8522f1b29b2ff392974322acdb722b7e00b70 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Tue, 28 Jan 2025 12:39:38 -0800
Subject: [PATCH 1/5] [lldb-dap] Refactoring lldb-dap port listening mode to
allow
https://github.com/mizvekov milestoned
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/mizvekov milestoned
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Augusto Noronha (augusto2112)
Changes
GetLocalBuffer() makes more sense as an API.
---
Full diff: https://github.com/llvm/llvm-project/pull/126333.diff
4 Files Affected:
- (modified) lldb/include/lldb/ValueObject/ValueObject.h (+9-8)
-
@@ -20,7 +20,7 @@ using namespace mlir::lsp;
LogicalResult mlir::MlirLspServerMain(int argc, char **argv,
DialectRegistry ®istry) {
- llvm::cl::opt inputStyle{
+ static llvm::cl::opt inputStyle{
jurahul wrote:
These are
https://github.com/danobi closed
https://github.com/llvm/llvm-project/pull/105757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
danobi wrote:
Hi @labath, sorry for late reply, I must've missed a notification :(
That makes sense to me - perhaps LLDB is not the right dependency for us to
take.
https://github.com/llvm/llvm-project/pull/105757
___
lldb-commits mailing list
lldb-c
dwblaikie wrote:
> I don't quite follow the motivation for this, can you expand on this in the
> description please? Right now this seems unnecessary for the changes I can
> see in MLIR for example.
The linked bug seems to explain it, I think? It seems to be the usual "if
something isn't/does
@@ -119,24 +119,24 @@ int main(int argc, char **argv) {
// options as static variables.. some of which overlap with our options.
llvm::cl::ResetCommandLineParser();
- llvm::cl::opt inputFilename(
+ static llvm::cl::opt inputFilename(
jurahul wrote:
Thes
dwblaikie wrote:
> > > I don't quite follow the motivation for this, can you expand on this in
> > > the description please? Right now this seems unnecessary for the changes
> > > I can see in MLIR for example.
> >
> >
> > The linked bug seems to explain it, I think? It seems to be the usual
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/121860
>From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 17 Jan 2025 17:10:36 -0800
Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB
MIME-Version:
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/121860
>From 19f5185ac5b19a656e0109d8aa011c49b36c5934 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 17 Jan 2025 17:10:36 -0800
Subject: [PATCH] [lldb] Implement a statusline in LLDB
MIME-Version: 1.0
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
51759ffc4408e9eb5c2d40c9489ce3b98de233d5...19f5185ac5b19a656e0109d8aa011c49b36c5934
lldb/
@@ -427,14 +452,27 @@ void ProgressEventThreadFunction(DAP &dap) {
done = true;
}
} else {
-uint64_t progress_id = 0;
-uint64_t completed = 0;
-uint64_t total = 0;
-bool is_debugger_specific = false;
-const char *m
@@ -427,14 +452,27 @@ void ProgressEventThreadFunction(DAP &dap) {
done = true;
}
} else {
-uint64_t progress_id = 0;
-uint64_t completed = 0;
-uint64_t total = 0;
-bool is_debugger_specific = false;
-const char *m
@@ -411,6 +412,30 @@ void SendStdOutStdErr(DAP &dap, lldb::SBProcess &process) {
dap.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
}
+static std::string GetStringFromStructuredData(lldb::SBStructuredData &data,
+
joker-eph wrote:
I don't quite follow the motivation for this, can you expand on this in the
description please? Right now this seems unnecessary for the changes I can see
in MLIR for example.
https://github.com/llvm/llvm-project/pull/126243
___
lldb
jurahul wrote:
> > I don't quite follow the motivation for this, can you expand on this in the
> > description please? Right now this seems unnecessary for the changes I can
> > see in MLIR for example.
>
> The linked bug seems to explain it, I think? It seems to be the usual "if
> something
bulbazord wrote:
> Rebased & fixed the existing tests.
Looks like
`lldb/test/API/functionalities/progress_reporting/TestTrimmedProgressReporting.py`
was deleted entirely. Was this intentional?
https://github.com/llvm/llvm-project/pull/121860
___
lld
https://github.com/adrian-prantl approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/126221
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
Thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
Rebased & fixed the existing tests.
https://github.com/llvm/llvm-project/pull/121860
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jurahul wrote:
Also, the commit description should be something like: "[NFC] Make file-local
cl::opt global variables static" or something like that
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits mailing list
lldb-commits@lists.llvm
vitalybuka wrote:
All these changes are independent and quite straight forward.
I'd suggest to split in some way, so it's easier to review, land, and revert if
we miss and break something.
Maybe by component.
also globals vs function local etc.
https://github.com/llvm/llvm-project/pull/12624
https://github.com/jasonmolenda created
https://github.com/llvm/llvm-project/pull/126335
Recognize the visionOS Triple::OSType::XROS os type. Some of these have already
been landed on main, but I reviewed the downstream sources and there were a few
that still needed to be landed upstream.
>Fr
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jason Molenda (jasonmolenda)
Changes
Recognize the visionOS Triple::OSType::XROS os type. Some of these have already
been landed on main, but I reviewed the downstream sources and there were a few
that still needed to be landed upstream.
Author: Augusto Noronha
Date: 2025-02-07T19:12:35-08:00
New Revision: 9d5edc9a0dd35049017aad2a9d3f4a4a2746fec9
URL:
https://github.com/llvm/llvm-project/commit/9d5edc9a0dd35049017aad2a9d3f4a4a2746fec9
DIFF:
https://github.com/llvm/llvm-project/commit/9d5edc9a0dd35049017aad2a9d3f4a4a2746fec9.dif
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/126333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/asb created https://github.com/llvm/llvm-project/pull/126352
By far the most important part of this patch is updating GettingInvolved.rst to
include the invite link, but I've grepped for any other discord.com links.
I'm no Discord expert, but from my experience (confirmed via
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Alex Bradbury (asb)
Changes
By far the most important part of this patch is updating GettingInvolved.rst to
include the invite link, but I've grepped for any other discord.com links.
I'm no Discord expert, but from my experience (confirm
https://github.com/asb edited https://github.com/llvm/llvm-project/pull/126352
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-libc
Author: Alex Bradbury (asb)
Changes
By far the most important part of this patch is updating GettingInvolved.rst to
include the invite link, but I've grepped for any other discord.com links.
I'm no Discord expert, but from my experience (confirmed
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/121860
>From ed0cf2866638162ff7314d31ee8325dc492060dd Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Fri, 17 Jan 2025 17:10:36 -0800
Subject: [PATCH] [lldb] Implement a statusline in LLDB
MIME-Version: 1.0
https://github.com/seehearfeel created
https://github.com/llvm/llvm-project/pull/126204
The maximum number of load/store watchpoints and fetch instruction
watchpoints is 14 each according to LoongArch Reference Manual [1],
so extend the maximum number of watchpoints from 8 to 14 for ptrace.
A n
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tiezhu Yang (seehearfeel)
Changes
The maximum number of load/store watchpoints and fetch instruction
watchpoints is 14 each according to LoongArch Reference Manual [1],
so extend the maximum number of watchpoints from 8 to 14 for ptrace.
A
https://github.com/seehearfeel updated
https://github.com/llvm/llvm-project/pull/126204
>From 7f23aaea0abeafd408fbdd06f1b1a5393860af3a Mon Sep 17 00:00:00 2001
From: Tiezhu Yang
Date: Fri, 7 Feb 2025 12:09:30 +0800
Subject: [PATCH] [LLDB][LoongArch] Extend the maximum number of watchpoints
The
https://github.com/seehearfeel edited
https://github.com/llvm/llvm-project/pull/126204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Please fix ASAP
https://lab.llvm.org/buildbot/#/builders/197/builds/1717
```
llvm-project/lldb/unittests/ValueObject/DynamicValueObjectLocalBuffer.cpp(221):
error C2065: 'u_int8_t': undeclared identifier
```
https://github.com/llvm/llvm-project/pull/125143
__
@@ -0,0 +1,92 @@
+//===-- Telemetry.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,100 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
Author: Michael Buch
Date: 2025-02-07T09:27:04Z
New Revision: 1608fe8d56015719d5bf7abca608adad8a866f43
URL:
https://github.com/llvm/llvm-project/commit/1608fe8d56015719d5bf7abca608adad8a866f43
DIFF:
https://github.com/llvm/llvm-project/commit/1608fe8d56015719d5bf7abca608adad8a866f43.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-02-07T09:30:27Z
New Revision: 7aeae7379d430404499f2929ffeea9416575a091
URL:
https://github.com/llvm/llvm-project/commit/7aeae7379d430404499f2929ffeea9416575a091
DIFF:
https://github.com/llvm/llvm-project/commit/7aeae7379d430404499f2929ffeea9416575a091.diff
LOG:
DavidSpickett wrote:
Thanks for the clear explanation. Part of my confusion before was that I
mistakenly thought that the v2 struct added a padding field but this is not
correct. The only thing that has changed is the number of debug regs.
We send one `user_watch_state` to the kernel, but in v
@@ -50,6 +50,19 @@
#define REG_CONTEXT_SIZE
\
(GetGPRSize() + GetFPRSize() + sizeof(m_lsx) + sizeof(m_lasx))
+// In order to avoid undefined or redefined error, just add a new struct
+// loongarch_user_watch_state in LLD
kper wrote:
Thank you for detailed explanations and sorry for the delay.
I needed almost a week to fix the cross compiling for the lldb-server. FYI, it
wanted to link the X86's libxml2 with RISCV which didn't work. Also the CMake
flag for disabling libxml2 didn't work for me.
I deinstalled the
DavidSpickett wrote:
LGTM, but @SixWeining for the final approval as the arch expert.
https://github.com/llvm/llvm-project/pull/126204
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -50,6 +50,19 @@
#define REG_CONTEXT_SIZE
\
(GetGPRSize() + GetFPRSize() + sizeof(m_lsx) + sizeof(m_lasx))
+// In order to avoid undefined or redefined error, just add a new struct
+// loongarch_user_watch_state in LLD
https://github.com/seehearfeel updated
https://github.com/llvm/llvm-project/pull/126204
>From d813d794f15b66f9f2036692cc99c241a365046d Mon Sep 17 00:00:00 2001
From: Tiezhu Yang
Date: Fri, 7 Feb 2025 12:09:30 +0800
Subject: [PATCH] [LLDB][LoongArch] Extend the maximum number of watchpoints
The
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin`
running on `doug-worker-5` while building `clang,lldb` at step 6
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/190/builds/14274
Here
Author: Pavel Labath
Date: 2025-02-07T12:52:21+01:00
New Revision: 83ba3740bf51347307494d013099e392c310e32b
URL:
https://github.com/llvm/llvm-project/commit/83ba3740bf51347307494d013099e392c310e32b
DIFF:
https://github.com/llvm/llvm-project/commit/83ba3740bf51347307494d013099e392c310e32b.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/125839
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-02-07T11:10:09Z
New Revision: c269182b13abddc459820e57a4d2065f364b23dc
URL:
https://github.com/llvm/llvm-project/commit/c269182b13abddc459820e57a4d2065f364b23dc
DIFF:
https://github.com/llvm/llvm-project/commit/c269182b13abddc459820e57a4d2065f364b23dc.diff
LOG:
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
Author: Michael Buch (Michael137)
Changes
This addresses the MSAN failure reported
in https://github.com/llvm/llvm-project/pull/125791#issuecomment-2639183154:
```
==5633==WARNING: MemorySanitizer: use-of-uninitialized-val
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
DavidSpickett wrote:
> FYI, it wanted to link the X86's libxml2 with RISCV which didn't work.
This is known, from the cross building doc:
```
If you find that CMake is finding a version of an optional dependency that for
whatever reason doesn’t work, consider simply disabling it if you don’t kn
https://github.com/hokein approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd
https://github.com/llvm/llvm-project/pull/125143
___
lldb-com
@@ -3494,6 +3506,7 @@ class CommandObjectTargetModulesShowUnwind : public
CommandObjectParsed {
// parsing options
std::string m_str; // Holds name lookup
lldb::addr_t m_addr = LLDB_INVALID_ADDRESS; // Holds the address to lookup
+
rocallahan wrote:
@adrian-prantl can we have that help please?
Also, is that link supposed to be accessible to the public? Because it's 404
for me.
https://github.com/llvm/llvm-project/pull/123945
___
lldb-commits mailing list
lldb-commits@lists.llvm.
https://github.com/mizvekov approved this pull request.
https://github.com/llvm/llvm-project/pull/126215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
Author: David Spickett
Date: 2025-02-07T10:29:35Z
New Revision: 52db30ec4154b0ef21db546ed9b5a9bfe47859cd
URL:
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd
DIFF:
https://github.com/llvm/llvm-project/commit/52db30ec4154b0ef21db546ed9b5a9bfe47859cd.diff
LOG
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This patch consumes the `DW_AT_APPLE_enum_kind` attribute added in
https://github.com/llvm/llvm-project/pull/124752 and turns it into a Clang
attribute in the AST. This will currently be used by the Swift
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126221
This patch consumes the `DW_AT_APPLE_enum_kind` attribute added in
https://github.com/llvm/llvm-project/pull/124752 and turns it into a Clang
attribute in the AST. This will currently be used by the Swift la
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/125839
>From 82e0ee5bf53dd6b886327021f5b145c942b43ff6 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Wed, 5 Feb 2025 11:28:48 +0100
Subject: [PATCH 1/2] [lldb] Clear cached unwind plans when adding symbols
PR #86603
Michael137 wrote:
Put up https://github.com/llvm/llvm-project/pull/126215
Should address the failure @hokein observed
https://github.com/llvm/llvm-project/pull/125791
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
DavidSpickett wrote:
I will push something shortly for this.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2025-02-07T10:03:23Z
New Revision: 9d83790d170cc0a06179514e2ab739f7ecafb78c
URL:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c
DIFF:
https://github.com/llvm/llvm-project/commit/9d83790d170cc0a06179514e2ab739f7ecafb78c.diff
LOG
@@ -3471,6 +3471,17 @@ class CommandObjectTargetModulesShowUnwind : public
CommandObjectParsed {
m_type = eLookupTypeFunctionOrSymbol;
break;
+ case 'c':
+bool value, success;
+value = OptionArgParser::ToBoolean(option_arg, false, &success
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/126215
This addresses the MSAN failure reported
in https://github.com/llvm/llvm-project/pull/125791#issuecomment-2639183154:
```
==5633==WARNING: MemorySanitizer: use-of-uninitialized-value
#0 in
clang::ASTNodeI
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: None (chrisPyr)
Changes
#125983
---
Patch is 216.27 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/126243.diff
128 Files Affected:
- (modified) bolt/lib/Core/BinaryContext.cpp (+4-
llvmbot wrote:
@llvm/pr-subscribers-bolt
@llvm/pr-subscribers-clang
Author: None (chrisPyr)
Changes
#125983
---
Patch is 216.27 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/126243.diff
128 Files Affected:
- (modified) bolt/lib/Core/Binar
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
jurahul wrote:
I understand this is mostly mechanical changes, but wondering if review wise it
will help if its split up into 4-5 PRs. For example, bolt, clang, flag, llvm,
mlir etc.
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits m
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/119716
>From b7216d7c3edd5974d84612586fbabdef19037387 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 26 Dec 2024 20:50:40 -0500
Subject: [PATCH 01/15] Implement LLDB Telemetry (Part 1)
This contains only the conc
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
jhuber6 wrote:
> So I should do like open 5 branches and make a PR for each?
>
> As for the cases mentioned, when I tried compile all projects (compile with
> -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and
> I've fixed them all. Now all projects can be successfully
chrisPyr wrote:
So I should do like open 5 branches and make a PR for each?
As for the cases mentioned, when I tried compile all projects (compile with
-DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and I've
fixed them all.
Now all projects can be successfully built, s
chrisPyr wrote:
OK, I'll do it.
Except for checking it on CI, is there any other method I can test locally?
E.g. what options should I add
I've tried compile with all project enabled, I thought by that way all changes
were already being tested.
However, the CI failed, so it seems what I thought
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,100 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/jhuber6 commented:
This should definitely be split up. Also some options are referenced in
multiple places, i.e.
```
// foo.h
extern cl::opt <...>
// foo.cpp
cl::opt <...>
use opt
//bar.cpp
use opt.
```
https://github.com/llvm/llvm-project/pull/126243
__
jurahul wrote:
Yeah, that’s why the description said most but not all. We should get link
failures if one of these is made static.
On Fri, Feb 7, 2025 at 7:17 AM Joseph Huber ***@***.***>
wrote:
> ***@***. commented on this pull request.
>
> This should definitely be split up. Also some opt
jurahul wrote:
@arsenm did you intent to approve it without splitting? Is this trivial enough
to not need splitting as long as CI checks pass?
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
arsenm wrote:
I don't care about splitting or not; either way
https://github.com/llvm/llvm-project/pull/126243
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jurahul wrote:
You can check the CI logs for the exact command line it uses and replicate
it locally.
On Fri, Feb 7, 2025 at 7:46 AM chrisPyr ***@***.***> wrote:
> OK, I'll do it.
> Except for checking it on CI, is there any other method I can test
> locally? E.g. what options should I add
> I'
@@ -0,0 +1,93 @@
+//===-- Telemetry.h --*- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
DavidSpickett wrote:
> You can check the CI logs for the exact command line it uses and replicate it
> locally.
Should be towards the start of the log, search for `cmake ` to find the command.
https://github.com/llvm/llvm-project/pull/126243
___
lldb
DavidSpickett wrote:
> As for the cases mentioned, when I tried compile all projects (compile with
> -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and
> I've fixed them all.
> Now all projects can be successfully built, so I think it should be fine?
Just to explain why
98 matches
Mail list logo
