jurahul wrote: > > I don't quite follow the motivation for this, can you expand on this in the > > description please? Right now this seems unnecessary for the changes I can > > see in MLIR for example. > > The linked bug seems to explain it, I think? It seems to be the usual "if > something isn't/doesn't need to be declared in a header, then it should be > file-local static, so as to not conflict with other local names in other > files"?
Right, though I think @joker-eph comment is that for lot of the MLIR changes, these option variables are function local and they need not be changed to static. https://github.com/llvm/llvm-project/pull/126243 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
