jurahul wrote: Yeah, that’s why the description said most but not all. We should get link failures if one of these is made static.
On Fri, Feb 7, 2025 at 7:17 AM Joseph Huber ***@***.***> wrote: > ***@***.**** commented on this pull request. > > This should definitely be split up. Also some options are referenced in > multiple places, i.e. > > // foo.h > extern cl::opt <...> > > // foo.cpp > cl::opt <...> > use opt > > //bar.cpp > use opt. > > — > Reply to this email directly, view it on GitHub > <https://github.com/llvm/llvm-project/pull/126243#pullrequestreview-2602020282>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/APRMUB4MPX36QSQ4DEVAIED2OTFB5AVCNFSM6AAAAABWV6M2CWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMBSGAZDAMRYGI> > . > You are receiving this because you commented.Message ID: > ***@***.***> > https://github.com/llvm/llvm-project/pull/126243 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
