https://github.com/omjavaid approved this pull request.
I agree this is as good as we can get for now with failure handling during
expression.
https://github.com/llvm/llvm-project/pull/123918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/123918
>From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 20 Aug 2024 16:06:34 +0100
Subject: [PATCH 1/4] [lldb][AArch64] Fix expression evaluation with Guarde
Author: David Spickett
Date: 2025-01-27T13:06:33Z
New Revision: b31e9747d0866ff97a1cd4a608b7eade31c0aa0b
URL:
https://github.com/llvm/llvm-project/commit/b31e9747d0866ff97a1cd4a608b7eade31c0aa0b
DIFF:
https://github.com/llvm/llvm-project/commit/b31e9747d0866ff97a1cd4a608b7eade31c0aa0b.diff
LOG
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/123918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124279
>From 23c7f4a3e067739a050964b3f1c2140787b0c31f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 13:33:07 +
Subject: [PATCH 1/6] [lldb][TypeSystem] Ensure that ParmVarDecls have the
corr
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/123918
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -408,9 +412,13 @@ BasicBlock::getFirstNonPHIOrDbgOrLifetime(bool
SkipPseudoOp) const {
if (SkipPseudoOp && isa(I))
continue;
-return &I;
+BasicBlock::const_iterator It = I.getIterator();
+// Signal that this comes after any debug records.
+It.setH
@@ -1656,7 +1656,8 @@ static Value
*emitSetAndGetSwiftErrorValueAround(Instruction *Call,
Builder.SetInsertPoint(Call->getNextNode());
} else {
auto Invoke = cast(Call);
-Builder.SetInsertPoint(Invoke->getNormalDest()->getFirstNonPHIOrDbg());
+BasicBlock::ite
https://github.com/OCHyams edited
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/OCHyams approved this pull request.
LGTM + nits
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -383,20 +383,24 @@ BasicBlock::const_iterator BasicBlock::getFirstNonPHIIt()
const {
return It;
}
-const Instruction *BasicBlock::getFirstNonPHIOrDbg(bool SkipPseudoOp) const {
+BasicBlock::const_iterator
+BasicBlock::getFirstNonPHIOrDbg(bool SkipPseudoOp) const {
for
@@ -448,6 +455,9 @@ BasicBlock::const_iterator
BasicBlock::getFirstNonPHIOrDbgOrAlloca() const {
++InsertPt;
}
}
+
+ // Signal that this comes after any debug records.
+ InsertPt.setHeadBit(false);
OCHyams wrote:
And again
https://github.com/ll
@@ -29,6 +29,10 @@
#include
#include
+#ifdef __ANDROID__
+#include
enh-google wrote:
what's the build failure you're seeing? this _should_ be included "for free" by
all of the #includes above (via , which they should all drag in).
of course, if you're ai
https://github.com/enh-google approved this pull request.
https://github.com/llvm/llvm-project/pull/124383
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -26,10 +26,14 @@
#include
#endif
+#ifdef __ANDROID__
+#include
+#endif
+
#if defined(__linux__) || defined(__FreeBSD__) ||
\
defined(__FreeBSD_kernel__) || defined(__APPLE__) ||
\
defined(__NetBSD__) || defin
https://github.com/enh-google approved this pull request.
https://github.com/llvm/llvm-project/pull/124453
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-01-27T14:56:47Z
New Revision: 081723b9db84e78d7dd240b46af2aeb3b51b00be
URL:
https://github.com/llvm/llvm-project/commit/081723b9db84e78d7dd240b46af2aeb3b51b00be
DIFF:
https://github.com/llvm/llvm-project/commit/081723b9db84e78d7dd240b46af2aeb3b51b00be.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/124279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -575,6 +575,10 @@ Changes to LLDB
24 int main() {
Likely cause: f->b->d accessed 0x4
```
+* LLDB now supports hardware watchpoints for AArch64 Windows targets. Windows
+ does not provide API to query the number of supported hardware watchpoints.
+ Therefore curr
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
DavidSpickett wrote:
W = something related to WOW64 here right, not W for watchpoint?
And we get this even on a
@@ -110,8 +110,8 @@
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
NativeRegisterContextWindows_x86_64::NativeRegisterContextWindows_x86_64(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread)
-: NativeRegisterContextWindows(native
Author: David Spickett
Date: 2025-01-27T13:27:31Z
New Revision: e9e06bea8661ddd474557a0db2cdc8770a55b66f
URL:
https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f
DIFF:
https://github.com/llvm/llvm-project/commit/e9e06bea8661ddd474557a0db2cdc8770a55b66f.diff
LOG
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124293
>From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 11:45:52 +0100
Subject: [PATCH] [lldb][AArch64] Add Guarded Control Stack support for Lin
labath wrote:
If I **was** holding a vector as a `vector**`, then I would would to see its
summary/size as well. And maybe even the children too. But the thing I
questioning is how often does one hold a C++ container as a double pointer. Is
there like some common programming pattern that produ
DavidSpickett wrote:
Rebased, PR is just new code now.
https://github.com/llvm/llvm-project/pull/124293
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please update the PR description to reflect what the current code does, or if
you want to leave the notes there, move them into an obvious section that you
can cut out if/when this gets merged.
https://github.com/llvm/llvm-project/pull/108072
__
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/124279
>From 23c7f4a3e067739a050964b3f1c2140787b0c31f Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 24 Jan 2025 13:33:07 +
Subject: [PATCH 1/5] [lldb][TypeSystem] Ensure that ParmVarDecls have the
corr
@@ -492,23 +492,40 @@ NativeProcessWindows::OnDebugException(bool first_chance,
}
case DWORD(STATUS_BREAKPOINT):
case STATUS_WX86_BREAKPOINT:
-if (FindSoftwareBreakpoint(record.GetExceptionAddress())) {
- LLDB_LOG(log, "Hit non-loader breakpoint at address {0:x}.
@@ -0,0 +1,158 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,218 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,218 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
@@ -0,0 +1,189 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,158 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,158 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,158 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,189 @@
+//===-- DILLexer.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,158 @@
+//===-- DILLexer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/labath commented:
There are some simplifications (and one rewrite :P) that I'd like to talk
about, but I think we're not far.
The main thing that's bothering me is this identifier vs. keyword issue (and
for this part, I'd like to loop in @jimingham (at least)).
Your implem
@@ -0,0 +1,218 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
Author: Pavel Labath
Date: 2025-01-27T13:41:18+01:00
New Revision: 6087c3049656bbaef51fffb48e2404e86f7e0d3f
URL:
https://github.com/llvm/llvm-project/commit/6087c3049656bbaef51fffb48e2404e86f7e0d3f
DIFF:
https://github.com/llvm/llvm-project/commit/6087c3049656bbaef51fffb48e2404e86f7e0d3f.diff
https://github.com/labath closed
https://github.com/llvm/llvm-project/pull/124522
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/124279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -3157,7 +3158,8 @@ bool DWARFASTParserClang::ParseChildMembers(
void DWARFASTParserClang::ParseChildParameters(
clang::DeclContext *containing_decl_ctx, const DWARFDIE &parent_die,
bool &is_variadic, bool &has_template_params,
-std::vector &function_param_types)
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/123521
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/123918
>From c89a16ab405d4aad7bf0a59afb433dd5ecd1a402 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 20 Aug 2024 16:06:34 +0100
Subject: [PATCH 1/3] [lldb][AArch64] Fix expression evaluation with Guarde
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
b7286dbef9dc1986860d29e390b092599e1d7db5...3436294db831d78dddacb186c93007ec05c0cfee
lldb/
@@ -0,0 +1,218 @@
+//===-- DILLexerTests.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2
DavidSpickett wrote:
1st commit(s) is https://github.com/llvm/llvm-project/pull/124293, last commit
is the new code.
https://github.com/llvm/llvm-project/pull/124295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/124295
>From d2c221b9b8cfeb8d9d902947db38c716e7a09804 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 27 Aug 2024 11:45:52 +0100
Subject: [PATCH 1/2] [lldb][AArch64] Add Guarded Control Stack support for
@@ -29,6 +29,10 @@
#include
#include
+#ifdef __ANDROID__
+#include
labath wrote:
It sounds like it's mainly for "style", but given what you've said, maybe that
shouldn't be the style we should use (is it possible those includes were
necessary 10 years ag
labath wrote:
> > > that's especially weird because execve() doesn't use $PATH ... it's the
> > > members of the exec family that have a 'p' in the name that do.
> >
> >
> > It's been a long time, but I'm pretty sure this was due to a test which ran
> > something with an empty environment (so
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/124279
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1414,11 +1412,15 @@ DWARFASTParserClang::ParseSubroutine(const DWARFDIE
&die,
LinkDeclContextToDIE(function_decl, die);
- if (!function_param_decls.empty()) {
-m_ast.SetFunctionParameters(function_decl, function_param_decls);
+ con
https://github.com/labath commented:
Losing it would not be the end of the world, but the extra detail in the
diagnostic seems nice, even if it was only working for free functions. How
hard would it be to plumb the names in?
https://github.com/llvm/llvm-project/pull/124279
___
https://github.com/labath approved this pull request.
Correct. (The alternative is to make this a "proper" cmake build-time check)
https://github.com/llvm/llvm-project/pull/124383
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
Michael137 wrote:
> Losing it would not be the end of the world, but the extra detail in the
> diagnostic seems nice, even if it was only working for free functions. How
> hard would it be to plumb the names in?
Yea shouldn't be tooo bad. We could add a `llvm::SmallVector` (or
similar) parame
https://github.com/DavidSpickett approved this pull request.
I suppose there might be some platform out there we don't know about that this
breaks, but what better way to find out than changing it :)
LGTM.
https://github.com/llvm/llvm-project/pull/124522
___
DavidSpickett wrote:
> which doesn't send the alternate name information
I don't think we do either. Unless it's in the register info structs maybe it
is.
The way to find out is to write the tests and if they pass without any changes
to LLDB - somehow it does work.
> (in particular, there a
svs-quic wrote:
> A test for this would be finding the tests that check basic reads of
> registers, and adding reads with the new names. There should be one for core
> files and one for live processes.
Basic support was added in
https://github.com/llvm/llvm-project/commit/847de9c332775d1841fe
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The long list of defines is just a very elaborate way to say "not windows".
---
Full diff: https://github.com/llvm/llvm-project/pull/124522.diff
1 Files Affected:
- (modified) lldb/source/Host/common/Host.cp
https://github.com/labath approved this pull request.
(The messy include above this has prompted me to create #124522. You'll need to
rebase if I merge this before you do. :) )
https://github.com/llvm/llvm-project/pull/124452
___
lldb-commits mailing
https://github.com/labath approved this pull request.
Yeah, I have no idea what was that about.
https://github.com/llvm/llvm-project/pull/124453
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/124522
The long list of defines is just a very elaborate way to say "not windows".
>From 528535210c76c5700246069321be47a8cf3dc6e1 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 27 Jan 2025 10:07:33 +0100
Subjec
labath wrote:
> Some of that looks questionable and I question if most of the remaining
> headers are actually necessary. I'd like to trim this down to only what is
> necessary.
This is probably the consequence of some refactoring (right now, most of the
actual work is done in the individual
DavidSpickett wrote:
A test for this would be finding the tests that check basic reads of registers,
and adding reads with the new names. There should be one for core files and one
for live processes.
https://github.com/llvm/llvm-project/pull/124475
labath wrote:
I haven't checked, but it's possible that this already works for core files.
The original bug was specifically about talking to qemu, which doesn't send the
alternate name information (and maybe not information about subregisters as
well). If that's the case then a more suitable
Michael137 wrote:
> > Losing it would not be the end of the world, but the extra detail in the
> > diagnostic seems nice, even if it was only working for free functions. How
> > hard would it be to plumb the names in?
>
> Yea shouldn't be tooo bad. We could add a `llvm::SmallVector`
> (or sim
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/6] [lldb] Analyze enum promotion type during parsing
---
clang/in
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/kuilpd edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/7] [lldb] Analyze enum promotion type during parsing
---
clang/in
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
AaronBallman wrote:
Thank you for working on cleaning up these APIs! They are definitely a source
of confusion in practice, so paying down this tech debt is great!
> The names for the first two are rather verbose; I’m open to suggestions as to
> better names for these functions since that was
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl {
void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED,
TemplateSpecializationKind TSK);
+public:
Michael137 wrote:
Don't need this change anymore
https://gi
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 commented:
Looks much better
Left some more clarification comments
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
https://github.com/OCHyams approved this pull request.
Thanks, still LGTM
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kuilpd wrote:
@Michael137
Reused the code I merged in #120965 to get the best promotion type.
https://github.com/llvm/llvm-project/pull/115005
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/jmorse updated
https://github.com/llvm/llvm-project/pull/124287
>From 3d2aa2734d6cb49c43565e3ac8584ba8130fe302 Mon Sep 17 00:00:00 2001
From: Jeremy Morse
Date: Thu, 23 Jan 2025 12:24:14 +
Subject: [PATCH 1/2] [NFC][DebugInfo] Make some block-start-position methods
retur
https://github.com/jmorse edited
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1656,7 +1656,8 @@ static Value
*emitSetAndGetSwiftErrorValueAround(Instruction *Call,
Builder.SetInsertPoint(Call->getNextNode());
} else {
auto Invoke = cast(Call);
-Builder.SetInsertPoint(Invoke->getNormalDest()->getFirstNonPHIOrDbg());
+BasicBlock::ite
https://github.com/jmorse commented:
Adjusted two call sites, see comments on the others. I've also added an extra
unwrap to CoroSplit.cpp due to it not compiling -- this is going to be reworked
in #124288 anyway.
https://github.com/llvm/llvm-project/pull/124287
___
@@ -448,6 +455,9 @@ BasicBlock::const_iterator
BasicBlock::getFirstNonPHIOrDbgOrAlloca() const {
++InsertPt;
}
}
+
+ // Signal that this comes after any debug records.
+ InsertPt.setHeadBit(false);
jmorse wrote:
The other two call-sites always g
@@ -2367,11 +2369,38 @@ size_t DWARFASTParserClang::ParseChildEnumerators(
}
if (name && name[0] && got_value) {
- m_ast.AddEnumerationValueToEnumerationType(
+ auto ECD = m_ast.AddEnumerationValueToEnumerationType(
clang_type, decl, name, enum_val
jimingham wrote:
> On Jan 27, 2025, at 5:30 AM, Pavel Labath ***@***.***> wrote:
>
>
> If I was holding a vector as a vector**, then I would would to see its
> summary/size as well. And maybe even the children too. But the thing I
> questioning is how often does one hold a C++ container as a
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `llvm-x86_64-debian-dylib`
running on `gribozavr4` while building `lldb` at step 5 "build-unified-tree".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/60/builds/18062
Here is the relevant piece of th
https://github.com/jmorse updated
https://github.com/llvm/llvm-project/pull/124287
>From 3d2aa2734d6cb49c43565e3ac8584ba8130fe302 Mon Sep 17 00:00:00 2001
From: Jeremy Morse
Date: Thu, 23 Jan 2025 12:24:14 +
Subject: [PATCH 1/3] [NFC][DebugInfo] Make some block-start-position methods
retur
Author: Michael Buch
Date: 2025-01-27T16:15:30Z
New Revision: 5f5cdf40382f06a8c417c42ec591f97aa76eeb67
URL:
https://github.com/llvm/llvm-project/commit/5f5cdf40382f06a8c417c42ec591f97aa76eeb67
DIFF:
https://github.com/llvm/llvm-project/commit/5f5cdf40382f06a8c417c42ec591f97aa76eeb67.diff
LOG:
Author: Jeremy Morse
Date: 2025-01-27T16:27:54Z
New Revision: 81d18ad86419fc612c7071e888d11aa923eaeb8a
URL:
https://github.com/llvm/llvm-project/commit/81d18ad86419fc612c7071e888d11aa923eaeb8a
DIFF:
https://github.com/llvm/llvm-project/commit/81d18ad86419fc612c7071e888d11aa923eaeb8a.diff
LOG:
https://github.com/jmorse closed
https://github.com/llvm/llvm-project/pull/124287
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuilpd updated
https://github.com/llvm/llvm-project/pull/115005
>From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001
From: Ilia Kuklin
Date: Mon, 4 Nov 2024 14:33:45 +0500
Subject: [PATCH 1/8] [lldb] Analyze enum promotion type during parsing
---
clang/in
Sirraide wrote:
Aaron and I just talked about this a bit, and I agree it would be cleaner to
just make a single function that can be used everywhere and whose behaviour is
customised with an enum. I’ll experiment with that approach and see how it
goes. Also, my plan was to try and remove `isPo
Sirraide wrote:
ping
https://github.com/llvm/llvm-project/pull/122938
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
enh-google wrote:
> It's quite possible that didn't run as a part of the CTS from the start. If
> you say it didn't, then I'll take your word for it.
sorry, i didn't mean to imply that these tests didn't immediately go into CTS
when they went into bionic: they will have automatically been incl
@@ -29,6 +29,10 @@
#include
#include
+#ifdef __ANDROID__
+#include
enh-google wrote:
> is it possible those includes were necessary 10 years ago?
yeah, one reason i'm so confidently asserting that you shouldn't need this now
is because i know we had a bi
1 - 100 of 117 matches
Mail list logo
