Michael137 wrote: > > Losing it would not be the end of the world, but the extra detail in the > > diagnostic seems nice, even if it was only working for free functions. How > > hard would it be to plumb the names in? > > Yea shouldn't be tooo bad. We could add a `llvm::SmallVector<std::string>` > (or similar) parameter to `ParseChildParameters` and populate it via > `DW_AT_name`s. Then just pass it to `CreateParameterDeclarations`. Happy to > do that too.
Also tempted to just create a `struct FunctionInfo` that holds all of the output parameters we currently pass to `ParseChildParameters`. And return it by value. But that could be done separately if we wanted to https://github.com/llvm/llvm-project/pull/124279 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits