[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-14 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-14 Thread Pavel Labath via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] 95f7c2f - [lldb] Reduce duplication in two of DWARFDIE context functions (#122712)

2025-01-14 Thread via lldb-commits
Author: Pavel Labath Date: 2025-01-14T09:26:02+01:00 New Revision: 95f7c2f88dc5b2fd851c3181b03300538151133e URL: https://github.com/llvm/llvm-project/commit/95f7c2f88dc5b2fd851c3181b03300538151133e DIFF: https://github.com/llvm/llvm-project/commit/95f7c2f88dc5b2fd851c3181b03300538151133e.diff

[Lldb-commits] [lldb] [lldb] Reduce duplication in two of DWARFDIE context functions (PR #122712)

2025-01-14 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/122712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e87f94a - [llvm-project] Fix typos mutli and mutliple. NFC. (#122880)

2025-01-14 Thread via lldb-commits
Author: Jay Foad Date: 2025-01-14T11:59:41Z New Revision: e87f94a6a806a941242506680f88573d6a87a828 URL: https://github.com/llvm/llvm-project/commit/e87f94a6a806a941242506680f88573d6a87a828 DIFF: https://github.com/llvm/llvm-project/commit/e87f94a6a806a941242506680f88573d6a87a828.diff LOG: [llv

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread Jay Foad via lldb-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/122880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 created https://github.com/llvm/llvm-project/pull/122887 Close https://github.com/llvm/llvm-project/issues/90154 This patch is also an optimization to the lookup process to utilize the information provided by `export` keyword. Previously, in the lookup process, t

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Chuanqi Xu (ChuanqiXu9) Changes Close https://github.com/llvm/llvm-project/issues/90154 This patch is also an optimization to the lookup process to utilize the information provided by `export` keyword. Previously, in the lookup p

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/122887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy @llvm/pr-subscribers-lldb @llvm/pr-subscribers-clang Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122880.diff 17 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseAutoChe

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122880.diff 17 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp (+2-2) - (modified) clang/lib/Basic/SourceMa

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Jay Foad (jayfoad) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/122880.diff 17 Files Affected: - (modified) clang-tools-extra/clang-tidy/modernize/UseAutoCheck.cpp (+2-2) - (modified) clang/lib/Basic/SourceMana

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread Jay Foad via lldb-commits
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/122880 None >From d9a92edae5d021eed39acbdb22fa195dff78315d Mon Sep 17 00:00:00 2001 From: Jay Foad Date: Tue, 14 Jan 2025 10:00:41 + Subject: [PATCH] [llvm-project] Fix typos mutli and mutliple. NFC. --- .../cla

[Lldb-commits] [lldb] [lldb] Removed gdbserver ports map from lldb-server (PR #104238)

2025-01-14 Thread David Spickett via lldb-commits
DavidSpickett wrote: Thanks! - https://github.com/llvm/llvm-project/commit/cfd7e024c6a97b0083f2e25a9d03d7dd516a0452#diff-9a29352a0c8c114f51b142b44cb1d5d6688787df1f78f3785ada73e1355a7379R463 https://github.com/llvm/llvm-project/pull/104238 ___ lldb-com

[Lldb-commits] [clang] [clang-tools-extra] [flang] [libc] [lldb] [llvm] [mlir] [llvm-project] Fix typos mutli and mutliple. NFC. (PR #122880)

2025-01-14 Thread via lldb-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/122880 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
@@ -2711,6 +2715,12 @@ class DeclContext { bool Deserialize = false) const; private: + /// Lookup all external visible declarations and the external declarations + /// within the same module specified by \param NamedModule. We can't Michae

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 commented: LLDB API adjustments look fine. Just left some minor comments re. documentation https://github.com/llvm/llvm-project/pull/122887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/122887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
@@ -145,12 +146,17 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. + /// \param Na

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 58708151ecaab8786c58b20eefc548dbdb23c8cc 0555df5f2bd726904e1ac21f44c9623aa057f831 --e

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-14 Thread Pavel Labath via lldb-commits
@@ -10,22 +10,46 @@ class DAPTestCaseBase(TestBase): # set timeout based on whether ASAN was enabled or not. Increase # timeout by a factor of 10 if ASAN is enabled. -timeoutval = 10 * (10 if ('ASAN_OPTIONS' in os.environ) else 1) +timeoutval = 10 * (10 if ("ASA

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-14 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: Were you able to reproduce the windows failure (and confirm the problem was indeed in the pipe code), or is this an attempt at speculation? https://github.com/llvm/llvm-project/pull/122783 ___ lldb-commits mailing

[Lldb-commits] [lldb] [lldb-dap] Ensure the IO forwarding threads are managed by the DAP object lifecycle. (PR #122783)

2025-01-14 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/122783 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
@@ -145,12 +146,17 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. + /// \param Na

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
@@ -2711,6 +2715,12 @@ class DeclContext { bool Deserialize = false) const; private: + /// Lookup all external visible declarations and the external declarations + /// within the same module specified by \param NamedModule. We can't Chuanq

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/122887 >From 3586c686980c3307856642c056caf572eb7ffe82 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Dec 2024 16:00:51 +0800 Subject: [PATCH] [C++20] [Modules] Support module level lookup Close https://git

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-14 Thread Omair Javaid via lldb-commits
https://github.com/omjavaid approved this pull request. https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b1751fa - [lldb][Linux] Mark memory regions used for shadow stacks (#117861)

2025-01-14 Thread via lldb-commits
Author: David Spickett Date: 2025-01-14T15:19:22Z New Revision: b1751faada35e3456b2a3f6b6c9559b5d74d559b URL: https://github.com/llvm/llvm-project/commit/b1751faada35e3456b2a3f6b6c9559b5d74d559b DIFF: https://github.com/llvm/llvm-project/commit/b1751faada35e3456b2a3f6b6c9559b5d74d559b.diff LOG

[Lldb-commits] [lldb] [lldb][Linux] Mark memory regions used for shadow stacks (PR #117861)

2025-01-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/117861 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Linux] Add Control Protection Fault signal (PR #122917)

2025-01-14 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/122917 This will be sent by Arm's Guarded Control Stack extension when an invalid return is executed. The signal does have an address we could show, but it's the PC at which the fault occured. The debugger has

[Lldb-commits] [lldb] [lldb][Linux] Add Control Protection Fault signal (PR #122917)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes This will be sent by Arm's Guarded Control Stack extension when an invalid return is executed. The signal does have an address we could show, but it's the PC at which the fault occured. The debugger

[Lldb-commits] [lldb] [lldb][Linux] Add Control Protection Fault signal (PR #122917)

2025-01-14 Thread David Spickett via lldb-commits
@@ -50,5 +63,7 @@ int main() { } // By now we should have one memory region where the GCS is stored. - return 0; // Set break point at this line. + gcs_signal(); // Set break point at this line. DavidSpickett wrote: The previously added `test_gcs_region

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: > LLDB, please ping us if you encounter problems after we merge this patch. https://lab.llvm.org/buildbot/#/builders/195/builds/3458 https://lab.llvm.org/buildbot/#/builders/197/builds/627 https://github.com/llvm/llvm-project/pull/115380

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/122817 >From b42dc01256c8a433629d3594d54e942417705f83 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Wed, 18 Dec 2024 14:47:08 -0800 Subject: [PATCH 1/3] [lldb] Remove unfiltered stop reason pro

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
@@ -145,12 +146,17 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. + /// \param Na

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
@@ -145,12 +146,18 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. - /// \return \

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Michael Buch via lldb-commits
@@ -145,12 +146,18 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. - /// \return \

[Lldb-commits] [lldb] [lldb] Implement (SB)Function::GetInstructions for discontinuous functions (PR #122933)

2025-01-14 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/122933 The main change is to permit the disassembler class to process/store multiple (discontinuous) ranges of addresses. The result is not ambiguous because each instruction knows its size (in addition to its address)

[Lldb-commits] [lldb] [lldb] Implement (SB)Function::GetInstructions for discontinuous functions (PR #122933)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes The main change is to permit the disassembler class to process/store multiple (discontinuous) ranges of addresses. The result is not ambiguous because each instruction knows its size (in addition to its addres

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clangd Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `getPointee

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `getPointeeO

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: None (Sirraide) Changes ## Changes tl;dr: The names are inaccurate and continue to cause confusion. This pr currently makes the following changes: - Rename `isAnyPointerType()` to `isPointerOrObjCObjectPointerType()`. - Rename `ge

[Lldb-commits] [lldb] 428c876 - [libc++] Stop copying headers to the build directory (#115380)

2025-01-14 Thread via lldb-commits
Author: Alexander Richardson Date: 2025-01-14T08:40:04-05:00 New Revision: 428c8767ae997b0f726c0b40160ea8172551babf URL: https://github.com/llvm/llvm-project/commit/428c8767ae997b0f726c0b40160ea8172551babf DIFF: https://github.com/llvm/llvm-project/commit/428c8767ae997b0f726c0b40160ea8172551bab

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Louis Dionne via lldb-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/115380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Louis Dionne via lldb-commits
ldionne wrote: A bunch of CI jobs were triggered because of my faulty rebase, but the necessary jobs seems to have passed. What's still pending are some release jobs which normally don't run on PRs, and the documentation job which fails for an unrelated reason (`clang-tools-extra`). Merging.

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Louis Dionne via lldb-commits
ldionne wrote: LLDB, please ping us if you encounter problems after we merge this patch. https://github.com/llvm/llvm-project/pull/115380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux` running on `sanitizer-buildbot8` while building `libcxx,libcxxabi,lldb` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/9056 Here is the relev

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/122887 >From 0555df5f2bd726904e1ac21f44c9623aa057f831 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Dec 2024 16:00:51 +0800 Subject: [PATCH] [C++20] [Modules] Support module level lookup Close https://git

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-14 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM. Adding an OS plugin is a user gesture, and changes the view of the threads in the process as its primary action. So I agree it's reasonable that the user who adds the OS plugin would know they have to reset their thread specific

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
cor3ntin wrote: Thanks for working on this. A few comment: `getPointerLikeOrArrayElementType` is not used, and I'm rather concerned by what it does. Removing pointiness in some cases seem dangerous, and not super useful... Renaming `getPointeeOrArrayElementType` to `getPointerOrArrayElementTy

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
Sirraide wrote: > That’s fair, I don’t think it’s crucial to add that or anything. If anything the pr in question can either add that or put that somewhere else; I’ll remove that function from this pr. https://github.com/llvm/llvm-project/pull/122938 ___

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
Sirraide wrote: > Not confused. renaming `getPointeeFoo` to `getPointerBar` does not seem > correct, especially as `getPointeeOrArrayElementType` does indeed return a > pointee. Ah, I see, in that case the only other name I could think of would be something like `getPointerOrObjCPointerPointe

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
Sirraide wrote: (just removed the last two commits that only added that function) https://github.com/llvm/llvm-project/pull/122938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
cor3ntin wrote: > Ah, I think you’re confusing two functions there: > `getPointeeOrArrayElementType()` is being renamed to > `getPointerOrObjCPointerOrArrayElementType()`, not > `getPointerOrArrayElementType()`. Not confused. renaming `getPointeeFoo` to `getPointerBar` does not seem correct,

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Alexander Richardson via lldb-commits
arichardson wrote: I realize there are some issues with this and while it's a nice cleanup, I don't have the time right now to deal with the potential fallout (build directory can't be used as a cross-compiler out of the box). https://github.com/llvm/llvm-project/pull/115380 __

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-14 Thread via lldb-commits
@@ -511,22 +513,58 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + if (use_DIL)

[Lldb-commits] [lldb] 576b538 - Revert "[libc++] Stop copying headers to the build directory (#115380)"

2025-01-14 Thread Kirill Stoimenov via lldb-commits
Author: Kirill Stoimenov Date: 2025-01-14T18:23:07Z New Revision: 576b53801fc3d721602ae0d8377af9950f356000 URL: https://github.com/llvm/llvm-project/commit/576b53801fc3d721602ae0d8377af9950f356000 DIFF: https://github.com/llvm/llvm-project/commit/576b53801fc3d721602ae0d8377af9950f356000.diff L

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Kirill Stoimenov via lldb-commits
kstoimenov wrote: @arichardson this was reverted due to sanitizer build failures: https://lab.llvm.org/buildbot/#/builders/51/builds/9056 https://github.com/llvm/llvm-project/pull/115380 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread via lldb-commits
Prabhuk wrote: We are seeing a failures in our Fuchsia toolchain builders and I suspect this CL is the root cause. Overview: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8725760447541892625/overview Logs: https://logs.chromium.org/logs/fuchsia/buildbucket

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/122887 >From a259ccafe9b6f7efc740cd7203d44fd4170a25dc Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Dec 2024 16:00:51 +0800 Subject: [PATCH] [C++20] [Modules] Support module level lookup Close https://git

[Lldb-commits] [lldb] [lldb][test] Fix some 'import-std-module' tests (PR #122358)

2025-01-14 Thread via lldb-commits
Prabhuk wrote: Hi @dzhidzhoev! I am seeing failures in our lldb builders and from the list of commits that went into the build this PR seems to be the likely cause though I am not completely sure. This is the builder link: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/lldb

[Lldb-commits] [clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-14 Thread via lldb-commits
Sirraide wrote: > A few comment: `getPointerLikeOrArrayElementType` is not used, and I'm rather > concerned by what it does. > Removing pointiness in only some cases seem dangerous, and not super useful... That’s fair, I don’t think it’s crucial to add that or anything. > Renaming `getPointeeO

[Lldb-commits] [lldb] [lldb] Add APIs enabling OperatingSystem plugins to update ThreadPlanStack (PR #122966)

2025-01-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/122966 At the end of Process::UpdateThreadListIfNeeded, we see this comment: ``` // Now update the plan stack map. // If we do have an OS plugin, any absent real threads in the // m_thread_list

[Lldb-commits] [lldb] [lldb] Add APIs enabling OperatingSystem plugins to update ThreadPlanStack (PR #122966)

2025-01-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/122966 >From c8e7e22ada455c1097e7a3499c3cc152a6bef0fa Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Mon, 13 Jan 2025 09:17:07 -0800 Subject: [PATCH] [lldb] Add APIs enabling OperatingSystem plu

[Lldb-commits] [lldb] [lldb] Add APIs enabling OperatingSystem plugins to update ThreadPlanStack (PR #122966)

2025-01-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/122966 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Louis Dionne via lldb-commits
ldionne wrote: @kstoimenov @vitalybuka Could you folks show us how the sanitizer builds you run are different from the ones we already run in our CI pipeline? It would be important to align both since we often run into issues with your post-commit CI jobs failing but our pre-commit CI not catc

[Lldb-commits] [libcxx] [libcxxabi] [lldb] [libc++] Stop copying headers to the build directory (PR #115380)

2025-01-14 Thread Vitaly Buka via lldb-commits
vitalybuka wrote: > @kstoimenov @vitalybuka Could you folks show us how the sanitizer builds you > run are different from the ones we already run in our CI pipeline? It would > be important to align both since we often run into issues with your > post-commit CI jobs failing but our pre-commit

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-14 Thread via lldb-commits
cmtice wrote: (Also, I will split the Lexer into a separate PR) https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-01-14 Thread via lldb-commits
cmtice wrote: I've addressed a lot of the review comments, but I'm still working on some. https://github.com/llvm/llvm-project/pull/120971 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
@@ -145,12 +146,18 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. - /// \return \

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 updated https://github.com/llvm/llvm-project/pull/122887 >From 0e49792900783f442da68b89fc3b4b3e013d18d3 Mon Sep 17 00:00:00 2001 From: Chuanqi Xu Date: Thu, 26 Dec 2024 16:00:51 +0800 Subject: [PATCH] [C++20] [Modules] Support module level lookup Close https://git

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
@@ -145,12 +146,18 @@ class ExternalASTSource : public RefCountedBase { /// Find all declarations with the given name in the given context, /// and add them to the context by calling SetExternalVisibleDeclsForName /// or SetNoExternalVisibleDeclsForName. - /// \return \

[Lldb-commits] [lldb] 7201cae - [C++20] [Modules] Support module level lookup (#122887)

2025-01-14 Thread via lldb-commits
Author: Chuanqi Xu Date: 2025-01-15T15:15:35+08:00 New Revision: 7201cae106260aeb3e97d5291ff30f05076a URL: https://github.com/llvm/llvm-project/commit/7201cae106260aeb3e97d5291ff30f05076a DIFF: https://github.com/llvm/llvm-project/commit/7201cae106260aeb3e97d5291ff30f05076a.diff LO

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/122887 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20] [Modules] Support module level lookup (PR #122887)

2025-01-14 Thread Chuanqi Xu via lldb-commits
ChuanqiXu9 wrote: Now CI passes. I want to land this in 20.x and give it some baking times so that we can find issues in it if any. Post commit review comments are welcomed as always. https://github.com/llvm/llvm-project/pull/122887 ___ lldb-commits

[Lldb-commits] [lldb] 5dcf5cc - [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (#122817)

2025-01-14 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-01-14T11:25:58-08:00 New Revision: 5dcf5cc0e0b462be99d1ae3d993ec11b039097b8 URL: https://github.com/llvm/llvm-project/commit/5dcf5cc0e0b462be99d1ae3d993ec11b039097b8 DIFF: https://github.com/llvm/llvm-project/commit/5dcf5cc0e0b462be99d1ae3d993ec11b0

[Lldb-commits] [lldb] [lldb] Remove unfiltered stop reason propagation from StopInfoMachException (PR #122817)

2025-01-14 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/122817 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-14 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/122541 >From 5a756db04b1e5124b99fa44c162439fbf8385aee Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Fri, 10 Jan 2025 14:26:10 -0800 Subject: [PATCH 1/7] Make the thread list for SBSaveCoreOptions iterable --- ll

[Lldb-commits] [lldb] [LLDB] Make the thread list for SBSaveCoreOptions iterable (PR #122541)

2025-01-14 Thread Jacob Lalonde via lldb-commits
@@ -115,8 +115,21 @@ const MemoryRanges &SaveCoreOptions::GetCoreFileMemoryRanges() const { return m_regions_to_save; } -Status SaveCoreOptions::EnsureValidConfiguration( -lldb::ProcessSP process_sp) const { +lldb::ThreadCollectionSP SaveCoreOptions::GetThreadsToSave()

[Lldb-commits] [lldb] [lldb] Add OpenBSD signals (PR #123005)

2025-01-14 Thread Brad Smith via lldb-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/123005 >From 25e59d64f085df535c62676ae8ec00a778def8f9 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Tue, 14 Jan 2025 22:25:00 -0500 Subject: [PATCH] [lldb] Add OpenBSD signals Signals 1-32 are matching the default UNI

[Lldb-commits] [lldb] [lldb] Add OpenBSD signals (PR #123005)

2025-01-14 Thread Brad Smith via lldb-commits
https://github.com/brad0 edited https://github.com/llvm/llvm-project/pull/123005 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c4fb718 - [lldb][NFC] Make the target's SectionLoadList private. (#113278)

2025-01-14 Thread via lldb-commits
Author: Greg Clayton Date: 2025-01-14T20:12:46-08:00 New Revision: c4fb7180cbbe977f1ab1ce945a691550f8fdd1fb URL: https://github.com/llvm/llvm-project/commit/c4fb7180cbbe977f1ab1ce945a691550f8fdd1fb DIFF: https://github.com/llvm/llvm-project/commit/c4fb7180cbbe977f1ab1ce945a691550f8fdd1fb.diff

[Lldb-commits] [lldb] [lldb][NFC] Make the target's SectionLoadList private. (PR #113278)

2025-01-14 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/113278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits