Author: Jonas Devlieghere
Date: 2024-11-06T15:16:20-08:00
New Revision: bd3a3959dc5b72ccbc83334132dece3f38957666
URL:
https://github.com/llvm/llvm-project/commit/bd3a3959dc5b72ccbc83334132dece3f38957666
DIFF:
https://github.com/llvm/llvm-project/commit/bd3a3959dc5b72ccbc83334132dece3f38957666.d
@@ -9,21 +9,27 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
JDevlieghere wrote:
This should follow LLVM's [
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 87f0b7326e5d05e5d61d2596a1bfbc63aa7d6935 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
referen
@@ -264,34 +288,35 @@ PathMappingList::FindFile(const FileSpec &orig_spec)
const {
bool PathMappingList::Replace(llvm::StringRef path, llvm::StringRef new_path,
bool notify) {
- std::lock_guard lock(m_mutex);
- uint32_t idx = FindIndexForPath(p
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/115208
Refactoring breakpoints to not use the `g_dap` reference.
Instead, when a breakpoint is constructed it will be passed a DAP reference
that it should use for its lifetime.
This is part of a larger refactor to re
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: John Harrison (ashgti)
Changes
Refactoring breakpoints to not use the `g_dap` reference.
Instead, when a breakpoint is constructed it will be passed a DAP reference
that it should use for its lifetime.
This is part of a larger refactor to
https://github.com/ashgti ready_for_review
https://github.com/llvm/llvm-project/pull/115208
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff bcb64e13172c9b894be03ccefcf967e99949b32a
87f0b7326e5d05e5d61d2596a1bfbc63aa7d6935 --e
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 586720cbf52aff41370368e9e1036f60200c1a83 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
referen
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 125c8976906ff25da6e212dff21d1b129575bd28 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
referen
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -155,7 +181,9 @@ Status MainLoopPosix::RunImpl::Poll() {
void *sigset_ptr;
size_t sigset_len;
} extra_data = {&kernel_sigset, sizeof(kernel_sigset)};
- if (syscall(__NR_pselect6, nfds, &read_fd_set, nullptr, nullptr, nullptr,
+ if (syscall(__NR_pselect6, nfds, &r
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
@@ -38,6 +40,9 @@ class MainLoopBase {
class ReadHandle;
public:
+ using TimePoint = std::chrono::time_pointhttps://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath commented:
Thanks for the feedback. I did not forget about this PR, I just wasn't able to
find the time to get back to it before now.
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 125c8976906ff25da6e212dff21d1b129575bd28 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH 1/2] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
ref
@@ -9,21 +9,27 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
ashgti wrote:
Updated all the files I touched i
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -95,6 +100,8 @@ class DWARFBaseDIE {
const char *GetName() const;
+ const char *getShortName() const { return GetName(); }
Michael137 wrote:
Nit: How do people feel about grouping all the new APIs that are required for
LLVM compatbility together and c
@@ -1403,26 +1403,6 @@ static TemplateParameterList
*CreateTemplateParameterList(
return template_param_list;
}
-std::string TypeSystemClang::PrintTemplateParams(
-const TemplateParameterInfos &template_param_infos) {
- llvm::SmallVector ignore;
- clang::TemplateParam
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
https://github.com/Michael137 commented:
Overall LGTM, just left some nits
I think separating out the "DWARFDIE compatbility" changes from the "use
DWARFTypePrinter for type lookup" would make it easier to review, but I don't
mind too much
https://github.com/llvm/llvm-project/pull/112811
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/115177
Following up from https://github.com/llvm/llvm-project/pull/112928, we can
reuse the [approach from Clang
Sema](https://github.com/llvm/llvm-project/blob/release/19.x/clang/lib/Sema/SemaType.cpp#L9039)
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Stefan Gränitz (weliveindetail)
Changes
Following up from https://github.com/llvm/llvm-project/pull/112928, we can
reuse the [approach from Clang
Sema](https://github.com/llvm/llvm-project/blob/release/19.x/clang/lib/Sema/SemaType.cpp#L903
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/112811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -369,9 +369,12 @@ def FeatureSVE2 : ExtensionWithMArch<"sve2", "SVE2",
"FEAT_SVE2",
"Enable Scalable Vector Extension 2 (SVE2) instructions",
[FeatureSVE, FeatureUseScalarIncVL]>;
-def FeatureSVE2AES : ExtensionWithMArch<"sve2-aes", "SVE2AES",
+def FeatureSVEAES : Exte
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/115245
None
>From f8087e96f8d8d242a4da2e74a3259161a3bfc179 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 5 Nov 2024 00:22:07 +
Subject: [PATCH] Init
---
clang/include/clang/Basic/Attr.td
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
@@ -95,6 +100,8 @@ class DWARFBaseDIE {
const char *GetName() const;
+ const char *getShortName() const { return GetName(); }
ZequanWu wrote:
Grouped those new APIs for each lldb class and added a comment for it.
https://github.com/llvm/llvm-project/pull
@@ -0,0 +1,31 @@
+// Test lldb is able to compute the fully qualified names on templates with
+// -gsimple-template-names and -fdebug-types-section.
+
+// REQUIRES: lld
+
+// Test against logging to see if we print the fully qualified names correctly.
+// RUN: %clangxx --target=x8
@@ -46,6 +48,7 @@ class DWARFBaseDIE {
explicit operator bool() const { return IsValid(); }
bool IsValid() const { return m_cu && m_die; }
+ bool isValid() const { return IsValid(); }
ZequanWu wrote:
Removed both `IsValid()` and `IsValid()` and switched
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/115208
>From 125c8976906ff25da6e212dff21d1b129575bd28 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 6 Nov 2024 09:36:48 -0800
Subject: [PATCH 1/3] [lldb-dap] Refactoring breakpoints to not use the `g_dap`
ref
@@ -9,21 +9,27 @@
#ifndef LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
#define LLDB_TOOLS_LLDB_DAP_BREAKPOINTBASE_H
-#include "llvm/Support/JSON.h"
#include
+#include "llvm/Support/JSON.h"
+
+#include "DAPForward.h"
ashgti wrote:
I ran `include-what-you-use`[^1]
jimingham wrote:
Thanks for figuring that out!
https://github.com/llvm/llvm-project/pull/114896
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti closed
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/3] [lldb] Infer MSInheritanceAttr for
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 9b
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
Change the signal handler to use a pipe to notify about incoming signals. This
has two benefits:
- the signal no longer has to happen on the MainLoop thread. With the previous
implementation, this had to be th
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/115197
Change the signal handler to use a pipe to notify about incoming signals. This
has two benefits:
- the signal no longer has to happen on the MainLoop thread. With the previous
implementation, this had to be the
@@ -2,23 +2,58 @@
// Itanium ABI:
// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s
-// RUN: %lldb -f %t_linux.o -b -o "target variable mp" | FileCheck %s
+// RUN: %lldb -f %t_linux.o -b -o "target variable s1 s2 m1 m2 v1 v2 v3 v4" |
FileCheck --check-prefix
ashgti wrote:
I will work on splitting this up into smaller pieces
https://github.com/llvm/llvm-project/pull/114881
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2024-11-06T09:59:35-08:00
New Revision: 4d4024e1edf354113e8d0d11661d466ae5b0bee7
URL:
https://github.com/llvm/llvm-project/commit/4d4024e1edf354113e8d0d11661d466ae5b0bee7
DIFF:
https://github.com/llvm/llvm-project/commit/4d4024e1edf354113e8d0d11661d466ae5b0bee7.d
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/5] [lldb] Infer MSInheritanceAttr for
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond approved this pull request.
Appreciate the explanation to your concerns. I'll try to get to your syscall
replacement PR today or tomorrow.
https://github.com/llvm/llvm-project/pull/112895
___
lldb-commits mailing list
lldb-c
@@ -7,27 +7,43 @@
//===--===//
#include "lldb/Host/MainLoopBase.h"
+#include
using namespace lldb;
using namespace lldb_private;
-void MainLoopBase::AddPendingCallback(const Callback &callback) {
+void
https://github.com/ZequanWu updated
https://github.com/llvm/llvm-project/pull/112811
>From 3fc0675398547617731d0501e3d4b98e2ffc480e Mon Sep 17 00:00:00 2001
From: Zequan Wu
Date: Wed, 9 Oct 2024 22:35:46 -0700
Subject: [PATCH 1/2] [lldb][dwarf] Compute fully qualified names on simplified
templ
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/115245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
52 matches
Mail list logo
