[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Stefan Gränitz via lldb-commits
@@ -0,0 +1,46 @@ +// Itanium ABI: +// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s +// RUN: %lldb -f %t_linux.o -b -o "target variable mp1 mp2 mp3 mp4 mp5 mp6 mp7 mp8 mp9" | FileCheck %s +// +// CHECK: (char SI2::*) mp9 = 0x + +// Microsoft ABI

[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail updated https://github.com/llvm/llvm-project/pull/112928 From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Fri, 18 Oct 2024 17:44:26 +0200 Subject: [PATCH 1/6] [lldb] Fix crash due to missing MS

[Lldb-commits] [lldb] [lldb][NFC] Make the target's SectionLoadList private. (PR #113278)

2024-10-23 Thread Greg Clayton via lldb-commits
https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/113278 >From 851ee7a3fd4f1ae294f3e0baaf0944caeadb7d05 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Tue, 22 Oct 2024 01:16:40 -0700 Subject: [PATCH 1/2] Make the target's SectionLoadList private. Lots of code aro

[Lldb-commits] [lldb] [lldb][NFC] Make the target's SectionLoadList private. (PR #113278)

2024-10-23 Thread Greg Clayton via lldb-commits
clayborg wrote: Ok, all comments were addressed. https://github.com/llvm/llvm-project/pull/113278 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail updated https://github.com/llvm/llvm-project/pull/112928 From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?= Date: Fri, 18 Oct 2024 17:44:26 +0200 Subject: [PATCH 1/7] [lldb] Fix crash due to missing MS

[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Stefan Gränitz via lldb-commits
https://github.com/weliveindetail closed https://github.com/llvm/llvm-project/pull/112928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 699ce16 - [lldb] Fix crash missing MSInheritanceAttr with DWARF on Windows (#112928)

2024-10-23 Thread via lldb-commits
Author: Stefan Gränitz Date: 2024-10-23T13:21:22+02:00 New Revision: 699ce16b6284377e0cd9969b9f95e7367632a622 URL: https://github.com/llvm/llvm-project/commit/699ce16b6284377e0cd9969b9f95e7367632a622 DIFF: https://github.com/llvm/llvm-project/commit/699ce16b6284377e0cd9969b9f95e7367632a622.diff

[Lldb-commits] [lldb] ba19e98 - [lldb][CMake] If make isn't found, print a warning but don't error out (#111531)

2024-10-23 Thread Stefan Gränitz via lldb-commits
Author: Stefan Gränitz Date: 2024-10-23T14:32:58+02:00 New Revision: ba19e98ca5e4fbc05429edd96e09b5c75df57e3c URL: https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c DIFF: https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c.diff

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #106799)

2024-10-23 Thread Walter Erquinigo via lldb-commits
@@ -578,6 +583,7 @@ bool DWARFFormValue::IsBlockForm(const dw_form_t form) { case DW_FORM_block1: case DW_FORM_block2: case DW_FORM_block4: + case DW_FORM_data16: walter-erquinigo wrote: I think that the block form will be the most convenient way to acc

[Lldb-commits] [lldb] [lldb] Move ValueObject into its own library (NFC) (PR #113393)

2024-10-23 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/113393 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move ValueObject into its own library (NFC) (PR #113393)

2024-10-23 Thread Pavel Labath via lldb-commits
https://github.com/labath commented: It looks like the CMakeLists.txt for Breakpoint and Command libraries is missing a dependency on the ValueObject lib (and the do appear to depend on it). I can run this on linux to see if we need to increase our cirular dep counter. :P My main question is:

[Lldb-commits] [lldb] [lldb] Add early CMake check for 'make' tool (PR #111531)

2024-10-23 Thread Stefan Gränitz via lldb-commits
weliveindetail wrote: Yes, for devs it might be too much of a burden and eventually bot maintainers should be aware. If we want the error behavior back, we could make it conditional on `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`. For now I didn't want to make it more complicated than necessary. h

[Lldb-commits] [lldb] 3309061 - [lldb] Cover all of SVE_TYPE in encoding switch

2024-10-23 Thread Spencer Abson via lldb-commits
Author: Spencer Abson Date: 2024-10-23T17:05:28Z New Revision: 3309061b2dd8a5cacacf05d956a872617808a974 URL: https://github.com/llvm/llvm-project/commit/3309061b2dd8a5cacacf05d956a872617808a974 DIFF: https://github.com/llvm/llvm-project/commit/3309061b2dd8a5cacacf05d956a872617808a974.diff LOG:

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-10-23 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/113508 This FORM already has support within LLDB to be parsed as a 16-byte BLOCK, and all that is left to properly support it in the DWARFParser is to add it to some enums. With this, I can debug programs th

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #106799)

2024-10-23 Thread Walter Erquinigo via lldb-commits
walter-erquinigo wrote: Cancelled in favor of https://github.com/llvm/llvm-project/pull/113508 which adds tests https://github.com/llvm/llvm-project/pull/106799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #106799)

2024-10-23 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/106799 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Finish implementing support for DW_FORM_data16 (PR #113508)

2024-10-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Walter Erquinigo (walter-erquinigo) Changes This FORM already has support within LLDB to be parsed as a 16-byte BLOCK, and all that is left to properly support it in the DWARFParser is to add it to some enums. With this, I can debug progr

[Lldb-commits] [lldb] [lldb] Extend FindTypes to optionally search by mangled type name (PR #113007)

2024-10-23 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Typenames don't often get put into the acclerator tables as mangled names for C/C++/ObjC. Functions do, but not typenames. Is there a case where the debug info contains a mangled name for a type? I know swift does use mangled names for types though as th

[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Shubham Sandeep Rastogi via lldb-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: rastogishubham wrote: I reverted this change with https://github.co

[Lldb-commits] [lldb] Revert "[lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows" (PR #113498)

2024-10-23 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shubham Sandeep Rastogi (rastogishubham) Changes Reverts llvm/llvm-project#112928 This is because it broke greendragon: SymbolFile/DWARF/x86/member-pointers.cpp --- Full diff: https://github.com/llvm/llvm-project/pull/113498.diff 2 Files

[Lldb-commits] [lldb] Revert "[lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows" (PR #113498)

2024-10-23 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham closed https://github.com/llvm/llvm-project/pull/113498 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c919970 - Revert "[lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows" (#113498)

2024-10-23 Thread via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2024-10-23T14:31:15-07:00 New Revision: c9199700b8fdde50a920857207e4387cfe69da45 URL: https://github.com/llvm/llvm-project/commit/c9199700b8fdde50a920857207e4387cfe69da45 DIFF: https://github.com/llvm/llvm-project/commit/c9199700b8fdde50a920857207e4387cfe69

[Lldb-commits] [lldb] Revert "[lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows" (PR #113498)

2024-10-23 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham created https://github.com/llvm/llvm-project/pull/113498 Reverts llvm/llvm-project#112928 This is because it broke greendragon: SymbolFile/DWARF/x86/member-pointers.cpp >From 565b370162888c91e82bd5c9a8787bbc4942219c Mon Sep 17 00:00:00 2001 From: Shubham Sande

[Lldb-commits] [lldb] Push down cpython module to the submodule (PR #113066)

2024-10-23 Thread via lldb-commits
@@ -145,7 +145,7 @@ add_lldb_library(liblldb SHARED ${option_framework} ${option_install_prefix} ) -# lib/pythonX.Y/dist-packages/lldb/_lldb.so is a symlink to lib/liblldb.so, +# lib/pythonX.Y/site-packages/lldb/_lldb.so is a symlink to lib/liblldb.so, dingx

[Lldb-commits] [lldb] [lldb] Fix crash missing MSInheritanceAttr on CXXRecordDecl with DWARF on Windows (PR #112928)

2024-10-23 Thread Shubham Sandeep Rastogi via lldb-commits
Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= , Stefan =?utf-8?q?Gr=C3=A4nitz?= Message-ID: In-Reply-To: rastogishubham wrote: Hi, this patch broke green dragon: https://gr

[Lldb-commits] [lldb] [LLDB] Add a target.launch-working-dir setting (PR #113521)

2024-10-23 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/113521 Internally we use bazel in a way in which it can drop you in a LLDB session with the target launched in a particular cwd, which is needed for things to work. We've been making this automation work via

[Lldb-commits] [lldb] [lldb] Move ValueObject into its own library (NFC) (PR #113393)

2024-10-23 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Given that most of these files start with 1st ValueObject` I felt like that was the better name for the library, rather than DIL which doesn't exist yet. I'm fine with putting the DIL implementation in the new ValueObject library (potentially in a DIL subdirectory) or keep