https://github.com/labath commented:

It looks like the CMakeLists.txt for Breakpoint and Command libraries is 
missing a dependency on the ValueObject lib (and the do appear to depend on it).

I can run this on linux to see if we need to increase our cirular dep counter. 
:P

My main question is: given that this is motivated by making room for the DIL 
implementation, isn't the name a bit overly specific? Like would you (all) be 
fine with putting something called DILParser into a directory called 
"ValueObject"?

(Note that I personally never had a problem with keeping the DIL in the Core 
library, and with the eviction of ValueObject, the core library gets noticably 
smaller, so for me, a completely acceptable colution would be to put/keep the 
DIL in the Core library, and leave the ValueObject library strictly for the 
ValueObject classes.)

https://github.com/llvm/llvm-project/pull/113393
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to